From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F32C021B8 for ; Wed, 26 Feb 2025 15:57:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0EF228000B; Wed, 26 Feb 2025 10:57:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A97EA280001; Wed, 26 Feb 2025 10:57:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89CE228000B; Wed, 26 Feb 2025 10:57:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6B75A280001 for ; Wed, 26 Feb 2025 10:57:40 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1785D121712 for ; Wed, 26 Feb 2025 15:57:40 +0000 (UTC) X-FDA: 83162551080.23.E2FDBFC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 834B1180013 for ; Wed, 26 Feb 2025 15:57:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KneBbtex; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740585457; a=rsa-sha256; cv=none; b=6sTM8FgmMKC8HW0yaHh/QjN6Yck4jTkWu/NPZ4yl1X/nlCSmxRbyshoe9j//dC5RkvHd6l WsIKfyCgWWKOBoL3lB2gr0qcMIw5YZxSSG0HRZ4hBDFQeopOh3YHIzYpVQS7l7gchynFlq U2TPobF2NL377YjyiDvevqVqrRrL3P8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KneBbtex; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740585457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/gq6gNGWkSkCuf0aaqirM/qyqInPsmM3eYzvtJfjuZg=; b=mF74/LRy6utkb1mPQgQLxzYvXplJ8P7iy37M0TObg4MJ85aPsP5RaUk2upHDSfMGIMMLXB mLbgewcMUxpv4RCJGByDBsC6vqurki+oK2lnslMT0GX9KJC8WQ0VZxvVuIUhWqueeW1z4u C6kjGkOVuao8o5JcI4zBomDxEun4+h4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740585456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/gq6gNGWkSkCuf0aaqirM/qyqInPsmM3eYzvtJfjuZg=; b=KneBbtexJ8D39Ku8/YWtSMBZq37OpFaURw/xL9QAotjDVc+5aun8t+S97ECn+22P3cer6y 1cIgktIyayJO0AuxY43OHNI/0iTzOIhE4lXDiBEFJ5CEYPxbaM6uqMqw8AVKtF3xSpTu3w LatKa8MdU0sUYiOtMYIAIJyj2sVsJUU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-ApVtvj1lOb2f9zgtApwEOA-1; Wed, 26 Feb 2025 10:57:34 -0500 X-MC-Unique: ApVtvj1lOb2f9zgtApwEOA-1 X-Mimecast-MFC-AGG-ID: ApVtvj1lOb2f9zgtApwEOA_1740585452 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f2ef5f0dbso2688134f8f.2 for ; Wed, 26 Feb 2025 07:57:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740585452; x=1741190252; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/gq6gNGWkSkCuf0aaqirM/qyqInPsmM3eYzvtJfjuZg=; b=Vnwd56I4fhKHmnkUUDHedqpr4xPwghOVaVQ/Ft9xIVGYb/AewJxT3+aX1ydLQScUae YOUq6rdxIHncPmwl57ZA8dTYff4zqyoVkicgSlURJNJIRRsuC7FJKdM4VwjIMxJFb7MM 8cphK73fKdqHgjg5rxnmiNOXHRaubeG+yp9ZamUXwhb24JUg6cz4sTZArtbNZsP3Ob+a V+JnCwfeu6h7OC50Ry3e3/4g8iQcAPA/ZcMUtmsZrBb1/tevvga44LWluEFpaMLnQvQR +nilxZi0QlQzarMJr59Eu7YbWnNpmYoVu3inVg9Cy4p/oG4wnXVSI3Ds2SMrqW/ZpFre QfQQ== X-Gm-Message-State: AOJu0YxzcK3+rZ6HkVhQLo9RvGxDsF4lz8BNuMpySUiM602m8NjwSk7G 9SYMzcU32HIVe3DcKpe/Yf6zjZqkpnMmqALydPWD5zY28Yh0vG0o84vWkzpG+5grAVxra8AYFk2 SRrxl/1P1/nMPbmydcEss0k9z+uLsZ6OOY0TbA3Nimndo2rDd X-Gm-Gg: ASbGnctZIcPoEXzU6TQ4g9tP8c7U+oB4MU5l+7HPtiuRmVh2FRF5YVnflYuGhVMoxvv zj+Xywkkzd5+GNlfGnxbhs8d7vkm2L0MNabQM1YNDqMWrpHtMFzsecvIdOHqgjEj3Ji4jRB5A22 RqEMGrnxhQF+KBQ7K7O5IX/oZHODlJBqa0uD7qSbP6w4TjoLjpcyrZeoRkNHc7+9ZyEgZuP0xao d8p6/MKqLyWF4F3PXgjuPjiflmVyGEFkSyz0/FnRvGNCghL9i+VCmVKO3tOUdqltvuJuOXtQnWQ aFuBfCcKOih0VtqgkOdelTdwyB5kaSnDKffGEcfFKuIryTToLtBcNT9+mwIO7ZO5iM4eqAaExrF K6nOgsmor5GtQ1iPBthJyEp4+p7dX1430aQ1JpV8Xs8I= X-Received: by 2002:a05:6000:1fad:b0:390:dfbb:640 with SMTP id ffacd0b85a97d-390dfbb06dbmr829325f8f.45.1740585452481; Wed, 26 Feb 2025 07:57:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHgeTrk23LWoYFqMBZobf5EF+4eNuWqpgDWdjsRd0s/NHyAZ6fmsSguRypqLy+fE4BP6A3Mhg== X-Received: by 2002:a05:6000:1fad:b0:390:dfbb:640 with SMTP id ffacd0b85a97d-390dfbb06dbmr829299f8f.45.1740585452144; Wed, 26 Feb 2025 07:57:32 -0800 (PST) Received: from ?IPV6:2003:cb:c747:ff00:9d85:4afb:a7df:6c45? (p200300cbc747ff009d854afba7df6c45.dip0.t-ipconnect.de. [2003:cb:c747:ff00:9d85:4afb:a7df:6c45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd882bf7sm6151867f8f.52.2025.02.26.07.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 07:57:31 -0800 (PST) Message-ID: Date: Wed, 26 Feb 2025 16:57:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages To: Jinjiang Tu , muchun.song@linux.dev, akpm@linux-foundation.org, mel@csn.ul.ie, lee.schermerhorn@hp.com, andi@firstfloor.org Cc: linux-mm@kvack.org References: <20250225141933.3852667-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250225141933.3852667-1-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TE4hY43TZWOzKpoU7-sDRdG6CRSQBwaNNSXD4ILj1mw_1740585452 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: eyixgpug5p888ar7d6w6opju4ud5zdyy X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 834B1180013 X-Rspam-User: X-HE-Tag: 1740585457-516794 X-HE-Meta: U2FsdGVkX1/cLxwcWqAiElVKTERx2MDJzPQBXWElztXOHzfitlfUlAiIvjaPr0Vw0hIy5AClf5UPvqz3EQYKdK5BvzrMPjf1ZsjzuCVM9hw/hw23jE9Sb1S5Hnkypc/3Xm/7P/wWfOTJOKLEpUKmqVcbt8Lh1v99SK1WpRp5nZgCrAWTwIoLCgr9QnVSxQgic9N2d2ByPI4538dd8pOgjFGjfaDqmpI1oZyaq5geFpZYRFp4SOB6LwNIah5ZBUzjhrPHNJpwl0rSi7cMXdEyiSbxwDHfbN9msfzu6w7aMUwhfLdZkNqjRzRyE2lcY7tiUL3VKoXR/kv3CvwINdHTyQgHy+Nv12cAMMdl8uvIRXxCI77FY2tC23hH+XOD2nBhItlBO9IqfWi7ya+JioV8VDQUEs25rQXRGKsG75Egz3c57Armsu2XUwoT8DoegFM3Tnsqjg2rgp/SnFR4y/UKWiJnhjCwt/ZKXebV1HmWJ/PSUyTN3qu/YPGj3Zraz1BDEwV1/dB3JpO8OfUsma0OGl41Shkq0ZVCX7XZPVG/z++rwlWvkMBOv3TVivtD8rsJNSqMcN7hYdQEI4NAU4upYi6ti48YaTYEk9O3wU3bhyp72BbcKlPcsUoVLq7CgMOsSd6b5Q6fDA2ffGhPTk+vzd59yDLSDKEYpEbJnrGxbUGIwla5d+AUILUu8zmSFKGwR6AyCNPk54+gtZbFa8LvbtzS5WTvRTrglFo5lw2FpbEp6wHgCaGsxx3sKf9KJnG2SMUjgmN0pT+5zmyzxENjkNactrfa745q8Q+LXV63ovoPGKxjk47UURFTF9EjCQyL5Myo0+7H6bJhf/8oEpwenG6pRf4P1PqhEMaLz/SBdi8kNAZXdvb60T2MRdxkJvMv3s+6J8Qwd3y8o56QZXiGgG9AxWzBZJRsemiYD6HvX6/UPWJ9zoxgssLLiA+BVqUSagQ5X5yQmhnbtoGtKDw a0DnMXzu RFFlMyuclnq3NjvQbU4sG1gtDmEF5+qIhc2CYurE2hftdRUFvpzeCBbOacaLSYpW8OVdiopFBBvPpZvlhnaY3xglHsh3NAoXe4mXqOAnaqObBotTNzqa1CLe1CdYRwpghJoafFxfi151BrPCtuyDWnUsi5OAswmGrA8IPQ6MkhouRLW1WhQIiFrAhg8PDuLJevB4leKRB7dspC9x0gHXjSIImktk/lJuK8sGdxKL/g/WVLE6pxyAzojG7LZADv+ALmDUtfYQO0XmRczGEuTB6gOF4RXl86Ach2zv0c5H5M3+GWl8b7PS+q+JcNNxdxE44avsq5B+z6gHUpRs/rHrOrId7I2OUcmLyLv/d/XRSSDJFEdSXCMNLXTPy2yl89rw8iiUWxubjbMSYS8GGGb1gvl2of0lrPgaw7vFSm6v6ZvODVoRz/6UqobF1NZidqJDagvcCKC+qpFzTSazjgKuzRi4fF2+wn4e7aW9ZzKLaHoDk36EyUa+XunQcfNB863GFIRMC2Pylh5p49M6+UW4x0A8yMwURY2de7J6hnySSrUdbDsm+roQkdMD0jJqZiRdYN9fyWqTKxbUUe+Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.02.25 15:19, Jinjiang Tu wrote: > In set_max_huge_pages(), min_count should mean the acquired persistent > huge pages, but it contains surplus huge pages. It will leads to failing s/leads/lead/ > to freeing free huge pages for a Node. > > Steps to reproduce: > 1) create 5 huge pages in Node 0 > 2) run a program to use all the huge pages > 3) create 5 huge pages in Node 1 > 4) echo 0 > nr_hugepages for Node 1 to free the huge pages > > The result: > Node 0 Node 1 > Total 5 5 > Free 0 5 > Surp 5 5 Can you also share the results after your change? > > Fixes: 9a30523066cd ("hugetlb: add per node hstate attributes") > Signed-off-by: Jinjiang Tu > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 163190e89ea1..783faec7360b 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3758,7 +3758,7 @@ static int set_max_huge_pages(struct hstate *h, unsigned long count, int nid, > * and won't grow the pool anywhere else. Not until one of the > * sysctls are changed, or the surplus pages go out of use. > */ > - min_count = h->resv_huge_pages + h->nr_huge_pages - h->free_huge_pages; > + min_count = h->resv_huge_pages + persistent_huge_pages(h) - h->free_huge_pages; > min_count = max(count, min_count); > try_to_free_low(h, min_count, nodes_allowed); > -- Cheers, David / dhildenb