From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D49C43334 for ; Tue, 28 Jun 2022 03:20:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F77D8E0002; Mon, 27 Jun 2022 23:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A7538E0001; Mon, 27 Jun 2022 23:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895EC8E0002; Mon, 27 Jun 2022 23:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 79E5C8E0001 for ; Mon, 27 Jun 2022 23:20:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 5423A81039 for ; Tue, 28 Jun 2022 03:20:55 +0000 (UTC) X-FDA: 79626192870.29.88BF169 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf04.hostedemail.com (Postfix) with ESMTP id 7652440032 for ; Tue, 28 Jun 2022 03:20:53 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LX8sX5NpyzTgC7; Tue, 28 Jun 2022 11:17:20 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 28 Jun 2022 11:20:49 +0800 Subject: Re: [PATCH] filemap: minor cleanup for filemap_write_and_wait_range To: Matthew Wilcox CC: , , , References: <20220627132351.55680-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 28 Jun 2022 11:20:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656386455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HlFXxa3HBDM8j82kCvFf1cXkSEp7WHVlzvgLbY38lZU=; b=4wfDqdk+etvFon1bMOokDY/Vb9ibMPzmQ/3V/OqQ7z6gIn8fVZRZdmNJf/0CubB1cOh86z U529yknGvEw4PwMrUIF7Y7SLNhfVIY9le3rqVGTIKqoR28/Ta6abQWXKW/1890glaSZ/AA VUoydhMVCS1a/7mW1RgHKoLZxJOIug8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656386455; a=rsa-sha256; cv=none; b=CPSa/z/DCKRGuV/TN1Bh+PtPOWU3AcXoYg9NEh75ro7UyXnkUZhCN58FUng6qxxWxN6Gzy LayUz8iuN/BUuTtJLdCctw7NQFLf7RUzVhfI7/gitXpl7mPbXk7S7+GeHe7cOFuiudtwoI A4lzBbO1y8F6f3GBCLX71ejysHj0IFk= X-Stat-Signature: o65hdri844go57s44rwpgz48zx619j31 X-Rspamd-Queue-Id: 7652440032 Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1656386453-447204 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/28 11:03, Matthew Wilcox wrote: > On Mon, Jun 27, 2022 at 09:23:51PM +0800, Miaohe Lin wrote: >> Restructure the logic in filemap_write_and_wait_range to simplify the code >> and make it more consistent with file_write_and_wait_range. No functional >> change intended. >> >> Signed-off-by: Miaohe Lin > > Looks OK to me at a quick glance. I'll look at it more closely next > week when I'm back from holiday. Thanks for your time. Enjoy your holiday. ;) > > . >