From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CD0C02183 for ; Mon, 13 Jan 2025 10:07:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 875C16B0096; Mon, 13 Jan 2025 05:07:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8271A6B0098; Mon, 13 Jan 2025 05:07:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69F566B0099; Mon, 13 Jan 2025 05:07:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4A34F6B0096 for ; Mon, 13 Jan 2025 05:07:18 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08351B0FD0 for ; Mon, 13 Jan 2025 10:07:18 +0000 (UTC) X-FDA: 83002000956.21.73D0CC3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id ACD06140011 for ; Mon, 13 Jan 2025 10:07:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gceqeccg; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736762835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6RoMHKqn+OEQUYxBDfwfMpacXoRqdmw+E8HI3RxVKFo=; b=7F1mQ+qItbxx3lpSOdbAiusCVbW0G+w3koNgMvG7JH1nDyfua4lcr9GdR6Fs8VDBK7DE3z 03OtI0BicuJEbxocmhsEtjG1XM6VwlizZxw/aGn2Hqetq3LBtj0IlqWSxxq5p/dF42pMVc DCPoCtlWQFntufds/fgJQniSlQbhsr0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gceqeccg; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736762835; a=rsa-sha256; cv=none; b=bI18VwZran7afYWmcbviExdR7gWSStFaoZXifkLBVV9zqEhIUewG+xpmlmbEpUG15MeCcD zrjCVIONgIiT6jbQGym3UhN1xlufv5SWib/L6Ej7MkSU7b1T6G6cHuH4LkKe/1kE6khZfB Ts9ONEY4Oc1J4s3X4ehk9nurYBtNbe0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736762835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6RoMHKqn+OEQUYxBDfwfMpacXoRqdmw+E8HI3RxVKFo=; b=gceqeccgtp0cbD8J9VA8UDvkMzPSJv73xrraSBNExXzWDMe0oi83JfBeBsXzBsyW50ZbxK ssmhan2WQRHUIgApJSCqMbTsHAjb+EVEtIHt6DiHqx64WeMgitOTd5uP7X3LjsuFseauhH HRMaeo1pTLfaISBk4LpJ3PPjAvNQv7M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-aZH_T2wYPXqzrNmh_jPdxA-1; Mon, 13 Jan 2025 05:07:11 -0500 X-MC-Unique: aZH_T2wYPXqzrNmh_jPdxA-1 X-Mimecast-MFC-AGG-ID: aZH_T2wYPXqzrNmh_jPdxA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-386321c8f4bso2594911f8f.0 for ; Mon, 13 Jan 2025 02:07:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736762830; x=1737367630; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6RoMHKqn+OEQUYxBDfwfMpacXoRqdmw+E8HI3RxVKFo=; b=Vtegr0jITW26gYwIPJtgDr5m5czP4OU4yhea6TCCUcqL2pungt8uqdDlnZQpkMIUtF 3fG/m3XpSsWUmdpZDL/dK8crA+LIZxUb5BFVYNAPnqSQjK2tFWsXtjrQbvCGnbdbxNj2 W41oQru60GeTYeRHB1Jy8nXnFzsOl0Mt0kfFoU1ktdL7W46xS6BYMOhbtD06EiI3Kqu5 1sDdbwNPMsncqydqCoQDa7xmyQ7Vmovgbf5FrGwnxbKLC4fmCOPPPUOncXLC5vZmUIsr VhqhA+Va+BsmLhLGRcv9F0W1c5tqjWlf/ZGtUYc20JpPRd0iLZcEdF771+y8WEWr/Chx gTSg== X-Forwarded-Encrypted: i=1; AJvYcCXWe2ptgYd/mfgwvDHIBjm/vwjO3mkx8Hs5Mj82UUqBQ4bNpAA4Qnh91agE6DjUzleykldUSJ0uoA==@kvack.org X-Gm-Message-State: AOJu0YyqVtTCYVXmZomBwrjS3M4o2ls9RxWrDR0osCj/+tGU4NADTf2k TXDSwzwU4HbQ9r6ODT2kVwX91XylLYJS4ZALhbg/v9fBnG12qO0nXsnpsENhpbNupligAvq7r87 0HWHMvcleb3TCsAvaE7pUg3bMbwLEpjkjUAuTxmaC1/W237ef X-Gm-Gg: ASbGncuQhVAQWVo/r/9zOh7SZ4s3KS9lYTqR3LdlquFQV3Mkyo0P5d2RqlX3TiQ1VAK xQ2yCoPiVgKp6JykN3sbZbsWemUO45YbQ3E3NsEg8UhRjQURAUYxkK7YxfQEVsEhxkXsVUwu6TK 8MV3P9y4pm5TuLdHSh9XjU5YVw80b2cDe8mXWkOOXp0RBA3P+AxR10duwDT5uZIGt/0V+jRC/tW q4EIFkw1wLkY9mz2bjmU1uxXaKs/vObIAk5CuglIOmkJ6y9zOcpPkk5ByghiXbS5HnGx64EYZ6v 0hg/bQLfqg6PHn0= X-Received: by 2002:a05:6000:1a8a:b0:386:1cd3:8a07 with SMTP id ffacd0b85a97d-38a872fc363mr16123000f8f.7.1736762830521; Mon, 13 Jan 2025 02:07:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEE1u3AbP8k0hrWiLnmAaC1HOmF7dCy3Vq3DJZiBdWZ8I2mC3mR+CAZnCUncnjCDV69fFYbQ== X-Received: by 2002:a05:6000:1a8a:b0:386:1cd3:8a07 with SMTP id ffacd0b85a97d-38a872fc363mr16122940f8f.7.1736762830154; Mon, 13 Jan 2025 02:07:10 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9d8fb99sm140017115e9.3.2025.01.13.02.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 02:07:09 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 11:07:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] mm/swap: Use PG_dropbehind instead of PG_reclaim To: "Kirill A. Shutemov" , Andrew Morton , "Matthew Wilcox (Oracle)" , Jens Axboe Cc: "Jason A. Donenfeld" , Andi Shyti , Chengming Zhou , Christian Brauner , Christophe Leroy , Dan Carpenter , David Airlie , Hao Ge , Jani Nikula , Johannes Weiner , Joonas Lahtinen , Josef Bacik , Masami Hiramatsu , Mathieu Desnoyers , Miklos Szeredi , Nhat Pham , Oscar Salvador , Ran Xiaokai , Rodrigo Vivi , Simona Vetter , Steven Rostedt , Tvrtko Ursulin , Vlastimil Babka , Yosry Ahmed , Yu Zhao , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-5-kirill.shutemov@linux.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250113093453.1932083-5-kirill.shutemov@linux.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: onsta6XEXN-x_EjVhCzioP347GTtSphXjiHjS-2wW9E_1736762830 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ACD06140011 X-Stat-Signature: c8hfx8g8x17ebn49sao5cwxxa6dy95uy X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736762835-281267 X-HE-Meta: U2FsdGVkX18dJvlsbwzWa2szNgYVYUcliCVq//Z2Ztbdbb3isoqK+cEEgPwYcNJt3u+JPdjYoKwzxCaRgPWFqROifNLu2arxfwP6ihzJiocR5oPvWJU8X9k61lDhWqxIEiuxFuJ7rn+0BfCYIPipxxY9oz1Reot6VsiyZmpuAnC1P3c/VTzBrLyXtbDedBnl2vO+MDnJNdE7uNzz9nuM/lSM/lqE2vOCIbGl/w9CVlLNFKHDnNtJ6UhG+rY0DaF7Z6bx7IEuyeOBWc3PXpEpx8oHDn5x9r6jF1XlOeRYrKpY2XSgFPbpRZ6Ezl0VudKy4dLwuZ3OMCnuBc8ioAAm8XwY3GlEceStrzcS/Zyi+erhmqO+BjsP2VdWnBK72JY4Me0Yop9QT58b7QXB5aGaY6IuR+9/6myAAsvfFdmWi3RZH60O7oUyPQoKctByhePtT8/tZE9TQX8Qic0yfbJQ8ruNeMcbhH3FKLwYhUyIXMTgerZWpsDfY6sqgIx811yqwQRoxkAJHHAvHJQ7bo2FHm5yzQ7IJflv8fBiTZYhBk0fG+no0Ih3u9ayxVsVtMC7xQujoaf2fsfI1oMjc71wiq6HiToQlPXomDphWJNwxRFsafn7Zrr3/Bsl5SQrxktDOGsgqGrpFxkK9qbFH3UmsKB0Uqw+gWO6qNX8qzNTw8lGjDJolC6X4W9sPU5sDsXFRt3nqzZNkdyZIpJvkuL3iDy2hFEVV/cANQi5NzOTCVQK+THKVoCAq4+AYZTqiZ9ojoR5NKViwA405CkxVcKtsMGNqk5nND8gzI8ax5io8but4ibqeT9JsvtowsAOIpPS8/jq9AFCiWpcMbe4oRXKmtAayjiCxKniH9Zxmez5xr4GbRd27I4Rq53/N4iZ9dZSAsrWCu6mFiw98hCuJahSR1zwSyBmG/eVeKG7vpTTR8hl0BnA6h9UYrFmu3sYNd3JzdCZSrfyGo6We/QRZG1 ztVtytgp /LFs+tAkRd/CxQBGdHyXyIygdiysdp11Iq+IclvUusc7Yi/FenVWjGgLfgFmrmayZWwaMcIk9JQKlOhprF7AZP5puim6G2v5NqyvJnWenckxwhC/UbzBCSCiyVRI/qk8pYNEZY6IlfkiIGop1KQvfZ8XJ+l9z+l1uFCi+7Xv37x9gSoj0elwkLDhD15qTuK8NUPJxOyISalyfn/Cx+/H6xM7yiNtKSdRzQ0g8CkL2uc3X5dK7blZkxEGnxu/iyZvsaRDbCBs9yma/RPpy6Vf502DgJUBLlADfUz1lZLwIPZvD1Ll19D+xdE+HrvQ4eB+8pl4yAFlDrSbWJB40PHWtojR6uREgnV7iHU42Rv3UBDewBlagihvX5t8nNLIGQnd6MWFT+nA42tddWbTi/+Yn6Y5hrDf5O1sJJhY0A5FyctvoM0R73V5OQFoWLxPhNHmvXq9eb7nrbwyttDzJu53yrwN434U0X+jQYhHey9J9v1lZN+PrVs9gE3b0iZr0Cs0Ivasvbw3Cde6k/ao= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.01.25 10:34, Kirill A. Shutemov wrote: > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use folio_set_dropbehind() in > lru_deactivate_file(). > > Signed-off-by: Kirill A. Shutemov > --- > mm/swap.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index fc8281ef4241..4eb33b4804a8 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -562,14 +562,8 @@ static void lru_deactivate_file(struct lruvec *lruvec, struct folio *folio) > folio_clear_referenced(folio); > > if (folio_test_writeback(folio) || folio_test_dirty(folio)) { > - /* > - * Setting the reclaim flag could race with > - * folio_end_writeback() and confuse readahead. But the > - * race window is _really_ small and it's not a critical > - * problem. > - */ > lruvec_add_folio(lruvec, folio); > - folio_set_reclaim(folio); > + folio_set_dropbehind(folio); > } else { > /* > * The folio's writeback ended while it was in the batch. Acked-by: David Hildenbrand -- Cheers, David / dhildenb