From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED03EB64DA for ; Fri, 16 Jun 2023 06:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 476FE8E0001; Fri, 16 Jun 2023 02:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 401846B0075; Fri, 16 Jun 2023 02:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EEBE8E0001; Fri, 16 Jun 2023 02:11:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D9166B0074 for ; Fri, 16 Jun 2023 02:11:09 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD22C140A20 for ; Fri, 16 Jun 2023 06:11:08 +0000 (UTC) X-FDA: 80907588216.09.C770A86 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf02.hostedemail.com (Postfix) with ESMTP id 6E7DA80007 for ; Fri, 16 Jun 2023 06:11:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686895867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5PdFheA3XpcExv0qwVdQstShnWn4lsFA9u6zQexx1to=; b=rQiGiDO+HnOZCCg3iiqSMPzWOeDQMOACzLJohX6g5JB9tKtgytiQVte//uvoD+r7DfWA2c GR1ZYhGYP1nbIg/kbPGPTKyqUfSo4IpoT8dET6Jeh5WYC5SY+s/Ab4uesQoYOAVj3z1exg glM/8XphAQD8eyFNlvT9UZaoGr0ENXc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf02.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686895867; a=rsa-sha256; cv=none; b=EPKfRCkRgGdK/Q5qgLIMTm+Wy5iUx1wQqhnkr+ddrGlWw5K8NtR5Lkpl74PUyc0QPQ76cv GOWJftdcs0aZDa9fcL3Mya1dO41F9oozg91zFpJpFmqozG0fR7X2QRDZukeb4zOTwp00BS 7VFfR/OOopBsfXiehPOhd6PORkTe0zQ= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qj7xK4lwhzGpkt; Fri, 16 Jun 2023 14:07:49 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 14:10:54 +0800 Message-ID: Date: Fri, 16 Jun 2023 14:10:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] mm/memcg: remove return value of mem_cgroup_scan_tasks() To: kernel test robot , , CC: , , , , , , , , , References: <20230616021955.872413-1-zhangpeng362@huawei.com> <202306161306.9YKbncNT-lkp@intel.com> Content-Language: en-US From: "zhangpeng (AS)" In-Reply-To: <202306161306.9YKbncNT-lkp@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6E7DA80007 X-Stat-Signature: y1owpxs8u7gmho6mic7rxe5c8hgka5if X-Rspam-User: X-HE-Tag: 1686895863-800826 X-HE-Meta: U2FsdGVkX18SE2pYCcmsIEdshX1dtRxF3LNJqfQsFaGvNTWVT03rCIBMoaojiYlP31jSvTQOOB95LJQ4vCEGTWTL4sWZWLSEzjEoC6EcIgOvoLZCKbfIQKlg/ly3PszbEC1lEOBIkMj9rqgpl6SA9tquc1JyZDtoYN9qZ/8VYBIHtq2BJheZ74+iZQudRf/yLDltFpEoC83XbnIubTwykNQS358vqyhWPaOy0Rp9hucjoA0yysflhfYAkmWrqym+97q+cYNWdFYzDqYtEUyhnfgBQLR4v4nisO1P1vahukRmHooKCT3XSqMjLKNc5YgIFZ+v/n9Y0dnetcYZtp0ygPQljLvETOBuaX3v8baFE2YORpTcScYxubjgCrpT59MOo2c9tCJtOXRJsKDUvDnygKj37Oni7nEdNem4cif+SufWkNVOq1NDd3EIyGDMFJQ8D6H/1uCLj86lt0CEOCs/nT8//Tn/X3x/rT3GcZ2bSzM7Ktmwefuu5XeWu5cz0XpzjoWBRNizFjhpGfO+6GXHLhW/wktnLtnVG8a96ZgaXdfX9a1ROqJRPhaEkMF6N+d5UdYs/ZPKyIEUkSsCqykWm+O8e/Zjewd3ZaS/ZfNiq2FANCoEOFcx3ITP8DLhK02M2C8QV4l4kd0xG93nYBRcOTlMuNsNQMivCy1G8R8ZTeENSZmq289CmhhzrnxblhV+iQX72WqxCWJx2lKxr3bUQtK5JCAjHsnMn8vEUAYDaK6ANQVD84+3Qe8Sr6WeymQaNhjeWU91y+vN8wi0TokX17H99qN97EkLPLBw3pS5ANirjz1cmCSxIqmKlXx8LUmCmqbv5t8ogHiJWTSgeor/9Ty+SymzhZf7yJYZvOIL0/Yiwff1thQCcVj4xTa/GA3B4fGEvb8HX3sVAuGoSLonVSt81gLysm5XrqjvjVFiPWmoOYPU6ghqwNobsgo38d/mLw4ob6oOVDSf9Ciby2u 4y0vlJM6 HTvmby/V6ukIg41XbpMQ/66mDAXfc/O7z6KakzeCCYZl7lULxSa+GxuREZBp/FoVngtdI1/dosYvgiBvFnbqyszj79NsFIcOzAy7NOY62ABwFUB+ASAlDdTnWDJDrKNlzmg3MNwDQDSS+nj5AQ2B0HHPaFmh2vWFKWdlj70xAG90vEMAXOU9Ad337XiniZDoTkJbHFkSFVY9ZDwbxFMMEqzOZeLAygFPS8PQiWZUaVBwE2O2LSU3/IX0pQvp0obtFm++Nad2axOs1+eayHdtlveqRNgXmL9sJ4B0ochbxtnO+pD0dYGq1vubLU8YNiShP11ftd7dR7Ll6isq5/AQnlib5IL27MQoLZV+VWZ4gemFgRpbFKG6btoooYpcjyiauGMoZoL8R91AjDYg+HGPmPv+0Ib2/llYNE1Y/41xUGEnCv+Ub1GNlItlTuw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/16 13:13, kernel test robot wrote: > Hi Peng, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Peng-Zhang/mm-memcg-remove-return-value-of-mem_cgroup_scan_tasks/20230616-102145 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20230616021955.872413-1-zhangpeng362%40huawei.com > patch subject: [PATCH] mm/memcg: remove return value of mem_cgroup_scan_tasks() > config: x86_64-randconfig-r005-20230616 (https://download.01.org/0day-ci/archive/20230616/202306161306.9YKbncNT-lkp@intel.com/config) > compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) > reproduce (this is a W=1 build): > mkdir -p ~/bin > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > git fetch akpm-mm mm-everything > git checkout akpm-mm/mm-everything > b4 shazam https://lore.kernel.org/r/20230616021955.872413-1-zhangpeng362@huawei.com > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 prepare > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202306161306.9YKbncNT-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from arch/x86/kernel/asm-offsets.c:14: > In file included from include/linux/suspend.h:5: > In file included from include/linux/swap.h:9: >>> include/linux/memcontrol.h:1370:2: error: void function 'mem_cgroup_scan_tasks' should not return a value [-Wreturn-type] > return 0; Thanks for reporting. I'll drop this line. > ^ ~ > 1 error generated. > make[2]: *** [scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1 shuffle=3878817758 > make[2]: Target 'prepare' not remade because of errors. > make[1]: *** [Makefile:1287: prepare0] Error 2 shuffle=3878817758 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:226: __sub-make] Error 2 shuffle=3878817758 > make: Target 'prepare' not remade because of errors. > > > vim +/mem_cgroup_scan_tasks +1370 include/linux/memcontrol.h > > 5660048ccac873 Johannes Weiner 2012-01-12 1366 > 5044a2e0ddbf82 ZhangPeng 2023-06-16 1367 static inline void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, > 7c5f64f84483bd Vladimir Davydov 2016-10-07 1368 int (*fn)(struct task_struct *, void *), void *arg) > 7c5f64f84483bd Vladimir Davydov 2016-10-07 1369 { > 7c5f64f84483bd Vladimir Davydov 2016-10-07 @1370 return 0; > 7c5f64f84483bd Vladimir Davydov 2016-10-07 1371 } > 7c5f64f84483bd Vladimir Davydov 2016-10-07 1372 >