From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B89C54E58 for ; Wed, 20 Mar 2024 16:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8472C6B0083; Wed, 20 Mar 2024 12:02:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CF8A6B0089; Wed, 20 Mar 2024 12:02:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 697176B008A; Wed, 20 Mar 2024 12:02:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5B0856B0083 for ; Wed, 20 Mar 2024 12:02:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D7FFA1C1504 for ; Wed, 20 Mar 2024 16:02:30 +0000 (UTC) X-FDA: 81917884860.30.294AE6E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 789DB180058 for ; Wed, 20 Mar 2024 16:02:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=fGBL4m1W; dkim=pass header.d=suse.com header.s=susede1 header.b=fGBL4m1W; spf=pass (imf16.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710950542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zkFAIj4insiWgehfaGHK9ZeiQ+/idmOfPpkDEXOgMxM=; b=G+2FsNmzwgOKnFxpxNklmRWFHXpQBTXaVGDbKuBCE3cKOzY+Ko2xfeFvIgfiP7c7PUCzQ0 vq2Ab1AqT1ZL/5sRNtpDELw9c4eVrd0cxW3MuYz9WesSsS8FHrmSb7VMsFtbJ6mNeZe+E8 XKVy+rLiimVG30gq0I7URgKq5iBn8gU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710950542; a=rsa-sha256; cv=none; b=8LrL9NSvgEHx5PXzvQpjjlmpiDVkc6z+wwn696m4ZsSZYxaiAKNBTGx5PBoBvnk1PpAlHY Sh1AjuKXC0My9yQwYtNJ5HIxmaStJ7a3eS3hR7sH8YKMvWmg2LgHC58RMGXK254v6YDi61 00OdTF/vbhyq34o2EEM8rkrOeoewkRE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=fGBL4m1W; dkim=pass header.d=suse.com header.s=susede1 header.b=fGBL4m1W; spf=pass (imf16.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from blackpad (unknown [10.100.12.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 428473476E; Wed, 20 Mar 2024 16:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1710950540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkFAIj4insiWgehfaGHK9ZeiQ+/idmOfPpkDEXOgMxM=; b=fGBL4m1WbxDBjH8NasgS4YdOf8fr3mnzpBS04ti2AwiT7tNwL9venFB8qP4kSiQJDS5RbN 8Zkj9kYlgwPy5LZCDxI8VjP/ekk75/sWjE7iMC400EG8WEHnyW1b8mwlDGngSgcEbS0jsd IzY8unF2Bv/natcgNpHYikrWSBWsSro= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1710950540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zkFAIj4insiWgehfaGHK9ZeiQ+/idmOfPpkDEXOgMxM=; b=fGBL4m1WbxDBjH8NasgS4YdOf8fr3mnzpBS04ti2AwiT7tNwL9venFB8qP4kSiQJDS5RbN 8Zkj9kYlgwPy5LZCDxI8VjP/ekk75/sWjE7iMC400EG8WEHnyW1b8mwlDGngSgcEbS0jsd IzY8unF2Bv/natcgNpHYikrWSBWsSro= Date: Wed, 20 Mar 2024 17:02:19 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: "Jan Kratochvil (Azul)" Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Waiman Long Subject: Re: [PATCH v4] cgroup2: New memory.max.effective like cgroup1 hierarchical_memory_limit Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="obcvqv52hinoclhy" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 789DB180058 X-Rspam-User: X-Stat-Signature: 6d5dmnizf17bzjbfs6r3yz8dei17zxnh X-Rspamd-Server: rspam03 X-HE-Tag: 1710950542-229277 X-HE-Meta: U2FsdGVkX19y/sKhxbE55fs9U9VcSYEQcvORlR2UyWqTHiOUt8xjiOr4+SlwhNEi5RlvHBIYSofzDbnrh3neyz3mHlRIscXJjBHVAx/z8fdR5osG2fk6MPbex3Hn1AQ/RZacpkh8i9P2lFHxYP/Vhpq6v+mEY1k6TUj62LKWONGDw0W3vq0oQwACLDYlKm55fi6qQYzjFm37DvEqcqWeMgChBD1mWTR/LM0qRPg9Noy5i63XFALP9kUwbE+8lx37MQmgCjE+6dQSY+3ciAjx0nB4WCQF786fU249dHz+eoVLGOPRaQ3CnjjOT6yAhai0xTS/u1vuUvcy96NVVh75JgL0A6EAcnm7PQoS2dwHtDWku76e+j1IVo7N9eKJV+6whWYZefNK+MIbaLcjfq5KFzeTIWU7N6rn0XNpL0lzljdIVDdTF4r5NBSJ+OMjfCcNKwwcwJMFwgqpPRYqA2iaZbCDd9gVf1SgdK6jqhogFP49WtesL1gZdlu3g4Lt78yhyk323ysyGtJb+Lr29wqijH9fLkKkqFIYkkPNoydJauivbC9zuarK8lmxsuqaNQt1vjOB0qlq/C53xhfcF1Q7CKNLuT9DKwaHz+RdC6wpfdQrU3+syNafye0tA2bHdupVzyvoe/LDRjiw+mb9K/9i05r6ptRs15njIUYTTkjQ287DFvWGvFh6tM1gK9oQywkhcndBi/rzlhHfVXq1ZurEo6jTxgIqnldsC8FBfu4kosJy9wNKZhp9JA7ro8Z8NYzJE2wFmVlWeFoiuer+/53seyzRPHEwVUiHSr+x4wcBjOBcZoaeEaVoCwzho0R2nLH3cziRFs9J6+GUxpWn0CmOZehiBvmz4SqjJb++qPIdqHPp2S2ebQlyKM4edz2VCMaGLlY7nvHYiXkDa0FkL2Sd+nfaVdvhZKj6XogewEDjxarbKKVu6j2npXT8nd/nLTpHFNYlXfuVp0g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --obcvqv52hinoclhy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. I have some advise about patch desription and only nitpick about implementation. On Wed, Feb 14, 2024 at 05:56:20AM +0800, "Jan Kratochvil (Azul)" wrote: > which are useful for userland to easily and performance-wise find out the > effective cgroup limits being applied. I think this is a weak reasoning for in-kernel implementation. It may be faster but how often do you need to read that limit? > Otherwise userland has to Userland is at loss when running inside cgroupns with limited ancestors out of the cgroupns. Thus I think this is the reason why kernel can provide such an effective value. (And be subject line of the commit, I think bringing up cgroup1 is misleading.) > For cgroup1 it was implemented by: > memcg: show real limit under hierarchy mode > https://github.com/torvalds/linux/commit/fee7b548e6f2bd4bfd03a1a45d3afd5= 93de7d5e9 > Date: Wed Jan 7 18:08:26 2009 -0800 FTR, commits are usually referenced more concisely like fee7b548e6f2 ("memcg: show real limit under hierarchy mode")=20 (the document Waiman linked previously has some tips how to get this =66rom git). > +static int memory_max_effective_show(struct seq_file *m, void *v) > +{ > + unsigned long memory; > + struct mem_cgroup *mi; > + > + /* Hierarchical information */ > + memory =3D PAGE_COUNTER_MAX; > + for (mi =3D mem_cgroup_from_seq(m); mi; mi =3D parent_mem_cgroup(mi)) > + memory =3D min(memory, READ_ONCE(mi->memory.max)); root_mem_cgroup is never charged (thus limited), so you can terminate the iteration on !mem_cgroup_is_root(mi), one level earlier > +static int swap_max_effective_show(struct seq_file *m, void *v) > +{ > + unsigned long swap; > + struct mem_cgroup *mi; > + > + /* Hierarchical information */ > + swap =3D PAGE_COUNTER_MAX; > + for (mi =3D mem_cgroup_from_seq(m); mi; mi =3D parent_mem_cgroup(mi)) > + swap =3D min(swap, READ_ONCE(mi->swap.max)); ditto HTH, Michal --obcvqv52hinoclhy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZfsIiAAKCRAGvrMr/1gc jjPaAP0UpgJnAoQuiyGpfv2ygAkpZ8Tv5wAS6zlt3p6Kti91cAEAw4Wb0RH30luT hhBwGAntr1Pz6mUyND/ds2Ff8CoOGwY= =Zh6c -----END PGP SIGNATURE----- --obcvqv52hinoclhy--