From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C94EC369BB for ; Wed, 25 Sep 2024 09:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E8306B008A; Wed, 25 Sep 2024 05:53:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 198FC6B008C; Wed, 25 Sep 2024 05:53:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F9B6B0092; Wed, 25 Sep 2024 05:53:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD8386B008A for ; Wed, 25 Sep 2024 05:53:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 425EB1409A2 for ; Wed, 25 Sep 2024 09:53:40 +0000 (UTC) X-FDA: 82602798600.22.A193C13 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf24.hostedemail.com (Postfix) with ESMTP id 0A3E4180010 for ; Wed, 25 Sep 2024 09:53:36 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727257982; a=rsa-sha256; cv=none; b=wuhRsUHWoKl075HdBhdFRGtKwJqXi21T4EFqJDgb+IbwjINn4zfSEM4gxsclGkj+w2DIzl p1s+pAzs73zb1PWKNSo/hMSobN8pedwpUruyvY7PywAeK0s/Q8+RMJPiVcqQLNzvOKN0Cs jIGKG0tIWbbkKNpdJ9i61M+0RkEQVXM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727257982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YFyUaEkAWVfA5f5MrsR+A79v1SnJw/KpPdPKzNIUffw=; b=lc2IMjRoccc+0niBzeici+6NQv5l5v0jvgcRcjZCAPN04WtEqfChVQQnOZSXIOkHYyUQJY rtKzldYALhj9RuxSPZkQzrXqs1ZN8fZSTNAUN0h1NWpd6hnEKKaO+bryFO6iqF0ULj6VO+ nGRs8+RMceJSbXCSW2Ow1NFTWaL2bxg= X-UUID: 033194067b2411efa216b1d71e6e1362-20240925 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:762292cf-c5a4-4c29-a9bf-8e4f5ca46732,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:82c5f88,CLOUDID:dc23199cd3ea9806256a2ebe4be2ba54,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0|-5,EDM:-3,IP:nil,UR L:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,S PR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 033194067b2411efa216b1d71e6e1362-20240925 Received: from node2.com.cn [(10.44.16.197)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 1024422858; Wed, 25 Sep 2024 17:53:27 +0800 Received: from node2.com.cn (localhost [127.0.0.1]) by node2.com.cn (NSMail) with SMTP id 45207B80758A; Wed, 25 Sep 2024 17:53:27 +0800 (CST) X-ns-mid: postfix-66F3DD97-234119772 Received: from [172.30.70.73] (unknown [172.30.70.73]) by node2.com.cn (NSMail) with ESMTPA id A5A74B80758A; Wed, 25 Sep 2024 09:53:26 +0000 (UTC) Subject: Re: [PATCH] mm/vmscan: Fix hard LOCKUP in function isolate_lru_folios To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240814091825.27262-1-liuye@kylinos.cn> <20240924172205.5068e86430873b09b75f8538@linux-foundation.org> <565bae19-889e-57df-42ff-70728cfb818c@kylinos.cn> <20240925022914.7c4033c9bb1206ad149ba69e@linux-foundation.org> From: liuye Message-ID: Date: Wed, 25 Sep 2024 17:53:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20240925022914.7c4033c9bb1206ad149ba69e@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 0A3E4180010 X-Rspamd-Server: rspam01 X-Stat-Signature: nsrkcew3uh1bs8a5yai9rxr3npggxzyf X-HE-Tag: 1727258016-950469 X-HE-Meta: U2FsdGVkX181MWAQHYSLXm6kurTIAAXv66UVNniYnuX3Dtr1hglqSJLkz4f2EREhAa+nT2dDS+DyjorAZRIPQeqFX3TUIlnYIsaF+BudBvVADDFGMsGNLtbIWEzy8sRFKjehV1ySnULSrQN55RZo95kFkxo3mmvO1tw3kXxsP6isEYgaRHAlfqklT0hn9XV9jjhtXu6Wf6ENZ62PLg/3hjruroLBF4Ol/OCjfGQz5K6k3oVHrKOl5ZTmQNYnbl3ueXuQS75YfAk7uqxnHeovDc1iQCU1wbmGJABfzaO4ml8lpF+NANl68hmbiZC4GFYb4jodiYX+Tj4hRiJqUYhPlsiLeHWCcPpQ4Mr7C9wbG3p6ffK+teCsbJW7OVw953DAU3avfbvj6Rt9df6XVVEKZW+9fFDkhzeph9e3ZRE/75FbXYYTypemJYrB+KqSH47+l4fQ8r3I03y1dbxBiI/rWNf4t5HEX/dazaSG4wpCbr3IrJATH01xRW7vSTWjP2rYXZl72wcLGYvXNQ4WefC4X7faaY+69qyqUmLogRcDT794D92Cv7EeG4T7Q1wfsZIV6irPvEQ1+Xj83OiPwEbSkrz4KbRnw+v8jKTz0a6cetqIL/JEMEnqO1sfQPq1dyOsccR0u9C7CVfuKvBJwrX/e4tE/NRVZ3f4pN6LqbpmIeB4oPr58SYHtHXH31AQoAVINk4aHZ7+G/dqt/eamTTBc6RNIDGlX9+8/BmzGbJoHWrAJR47yu6ZloE2tajJEgrfAgqyHH7ER9OIOB28FNNLqFBViPVFuai5jAB8dc8mvJ0esVffW18sswWXxUEfeCGcMgtenAamMjIRxWxD7iQOSZ7xXgF3H/1JNSJGJ9ipUYIh/SXvpzm21alV80rGAYIuYwiFVx0/XoSz+2z5RpI3iQdUvpbDs1d43xKlqwox1re1lo8b14MxPIMv5d2e2xaoutdVlJ3+RiWGyE4y3ZW b4rVPyHm jneUhQB8H3cDziKYhRnBz4kc5foyCUGtZMrgNi+zKaD2FTku/m3tbSXpb/B7W0/yejbTzJCDR3XnSDVT3PyAsKqNM6LtwaaxvYaSHb77VUN70+ZIAaHC3SMG8RwTdwAVV0DRrq1/TfF9p6SM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/25 =E4=B8=8B=E5=8D=885:29, Andrew Morton wrote: > On Wed, 25 Sep 2024 16:37:14 +0800 liuye wrote: >=20 >> >> >> On 2024/9/25 =E4=B8=8A=E5=8D=888:22, Andrew Morton wrote: >>> On Wed, 14 Aug 2024 17:18:25 +0800 liuye wrote: >>> >>>> @@ -1669,10 +1670,12 @@ static unsigned long isolate_lru_folios(unsi= gned long nr_to_scan, >>>> nr_pages =3D folio_nr_pages(folio); >>>> total_scan +=3D nr_pages; >>>> =20 >>>> - if (folio_zonenum(folio) > sc->reclaim_idx || >>>> - skip_cma(folio, sc)) { >>>> + /* Using max_nr_skipped to prevent hard LOCKUP*/ >>>> + if ((max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED) && >>>> + (folio_zonenum(folio) > sc->reclaim_idx || skip_cma(folio, sc)))= { >>>> nr_skipped[folio_zonenum(folio)] +=3D nr_pages; >>>> move_to =3D &folios_skipped; >>>> + max_nr_skipped++; >>>> goto move; >>> >>> This hunk is not applicable to current mainline. >>> >> >> Please see the PATCH v2 in link [1], and the related discussion in lin= k [2]. >> Then please explain why it is not applicable,thank you. >=20 > What I mean is that the patch doesn't apply. >=20 > Current mainline has >=20 > if (folio_zonenum(folio) > sc->reclaim_idx) { > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; > move_to =3D &folios_skipped; > goto move; > } >=20 PATCH v2 base on current mainline. @@ -1650,9 +1651,12 @@ static unsigned long isolate_lru_folios(unsigned l= ong nr_to_scan, nr_pages =3D folio_nr_pages(folio); total_scan +=3D nr_pages; =20 - if (folio_zonenum(folio) > sc->reclaim_idx) { + /* Using max_nr_skipped to prevent hard LOCKUP*/ + if (max_nr_skipped < SWAP_CLUSTER_MAX_SKIPPED && + (folio_zonenum(folio) > sc->reclaim_idx)) { nr_skipped[folio_zonenum(folio)] +=3D nr_pages; move_to =3D &folios_skipped; + max_nr_skipped++; goto move; }