From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760ACC2BBCA for ; Fri, 28 Jun 2024 03:19:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 051776B00A1; Thu, 27 Jun 2024 23:19:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0014D6B00A3; Thu, 27 Jun 2024 23:19:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0AE66B00C3; Thu, 27 Jun 2024 23:19:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C2BDA6B00A1 for ; Thu, 27 Jun 2024 23:19:45 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6D435121334 for ; Fri, 28 Jun 2024 03:19:45 +0000 (UTC) X-FDA: 82278842730.29.AA7777F Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 72B77A0013 for ; Fri, 28 Jun 2024 03:19:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=b8QCBXiZ; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719544774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WFokgB4wZasxHxgxoe2aHiUXolXTIQhXISskpwyHqEg=; b=LwlGYXejlgLgn8HxCUpbinW8oH6zqcjbw+bD19IjXcK1sO7RGTR4+UWLPY9pLBqz95gf8s 8YDrqhGYnkNd/6gixX5VWO7A+lOPRqLMQ9+W59tg5Vz0bsT1MhLhWCE0qM48qJ/IVAH1zg WODXqQll5Yhn87EqAIDckTTyHc9LmxQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=b8QCBXiZ; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719544774; a=rsa-sha256; cv=none; b=c4qZmfG4V12FsXT2EL6Qp8J0ZV4YISllizxZvD3htZ8womETb4aEQjsB4W/M3zWiEUEX1e 3DMyFjfYCXE51WX+NeIqX5E9J/b91+bPpcwh5LFCQ4R2NRRbtHc0/u5NjDu+yKk41raF+P 5YG/sOudClTZuNx8nepuavHI+smRUmQ= X-Envelope-To: senozhatsky@chromium.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719544780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFokgB4wZasxHxgxoe2aHiUXolXTIQhXISskpwyHqEg=; b=b8QCBXiZhu9TQf55ouEt1PA6vWNA0vmYkYrNcOguhWhLDhE/L58Qpd96nn+zo14nbefzzY aYLXsCthxCtf/CKOTcO636ar98s23s2ARck34XJ+M2pgOSgXmzuL+hLFVBCyZcXLBhDoon /HDNZT9ix/oLz1pldat6XRKOIRnWzoY= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: minchan@kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: Date: Fri, 28 Jun 2024 11:19:32 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts To: Sergey Senozhatsky , akpm@linux-foundation.org Cc: minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240627075959.611783-1-chengming.zhou@linux.dev> <20240628005523.GC15925@google.com> <20240628010812.GD15925@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240628010812.GD15925@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 72B77A0013 X-Stat-Signature: 7whfxax1buwpmzioa5atxyg8jmp3bxw9 X-HE-Tag: 1719544782-186038 X-HE-Meta: U2FsdGVkX19IntmjL6yGOKE6hWKMZPw2lz5aFkdZvvk1LAj4hcP1SMXDy32xfjLZp1Nu1/RFqW7O1PG1+1O+mQXftFj5WHJunvgLszuU+BqKQqzlW0cVZlh1u2Xf3FdxTCGRGQXPuou5Xc/rRafwCIy30qkGCeIvW0FemIKrye+x539eK3Fi23aNGK/G7xItgcMTaEDt13qKqaVjkQcORqr/HunYoaBspSfb2yelYmdF9OG7aXSvRfpwF+ioTj8wf6HCH7ab72T6prufi7vst0lrT2t2cvbmPkbTi1pAyhhGCkyU6bu9d5cnkVj9EBrTcPLJOtlcfnOC1TVZvwYdHADXK7HkcOOeHLqV8BLipvssOSbIZy0m2ztDO6p5qcNptMOrc9WSdacJICUwnIga4pYHnLAxOTAQmO+R3Yv6X3j8hBJAp8iI1qiCB4vkfJ7QkQC1wLtl3nX1DmJPuGK83zmSC9wTK7PrbrEkBvZE8BdwgPI2K1LvnP5SZnF5hkk+Zs44dENdPXKs6P0Oo9euVFRS/v2XeYJCMkrtyJsVO1JIw8Tx7J+t8inRUImxbd48ZqRC94PA9Q/csCm7fg9U0aLUjPnsfXr0FNy2lpgn77XsyuzngZ4VjnZL4SuL1JNHPOQceOTakBAWQFGgTdnVYDGqlnvUPD2wGH84Pz0Cl7Ak52mKkqD7rEqoOaopywduC0GEWrMSGYCYTnHSglbQavGin5g4rnbSHfuAvhAn70Yx4wCmuWaqPwMOFLGdCaG6tfYiLDKWXcXXFjmbfKCYfr4/JXohJabIPwT15gUkAyIqsd+QMZj77vVTjIyCb4lQGGTrqkenwj6ndhSdZRd7c8+fU9de5CNHEd069Fz6JtXQ0M6OZOC4tqLX1gPxRrzgSMPTixE2ePMmEDmGyqeaB26Gl7l/ZCT9tBGhjEih5L1xKIONBpxpw2+W+S9mnCyLiDy9MXNxcabIby3SOql XdT/tZtc EFSLUDiN0PLdUF1bJ+JCDxnuP9SCMRCUheJH+WDooR/N++693knhDifIVp6MyON3TM6HiuqZ2VWXcyyjhwy5B9ybG6YFYP7nrxin5hknnWN2SjTFCbCHmxV+7cA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/28 09:08, Sergey Senozhatsky wrote: > On (24/06/28 09:55), Sergey Senozhatsky wrote: >> We can land this patch, if you insist/prefer, but it's some sort of >> a NOOP, essentially (in a sense that it has no visible effects). > > Forgot to mention, sorry. If we land this then I'll ask for a different > commit message. "Fix" sounds alarming. It would be better to say something > like "keep that stat counter accurate, but RATIO_O is never used anywhere". You're right, "fix" sounds alarming although it's a fix, but it has no any virtual effect. I just found it when I last time changed to the per-class locking but forgot to send it. Andrew, could you please help to change the subject as Sergey asked? Sorry, I should have noted these details in the changelog when I wrote this subject. Thanks.