From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A1C7C3DA49 for ; Tue, 23 Jul 2024 17:17:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBB876B0082; Tue, 23 Jul 2024 13:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B456B6B0083; Tue, 23 Jul 2024 13:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9475E6B0089; Tue, 23 Jul 2024 13:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C0A36B0082 for ; Tue, 23 Jul 2024 13:17:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 13735802B1 for ; Tue, 23 Jul 2024 17:17:02 +0000 (UTC) X-FDA: 82371672684.25.440ACAE Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 737F54001C for ; Tue, 23 Jul 2024 17:16:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HMZndeIV; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=IvzcaPFx; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1721754980; a=rsa-sha256; cv=pass; b=d9lhJhCT1dvXUrh1H6qFE2pSYi+ZMnTC1C4fTJzix+AE21qHRrZs6UeRh+Evco9hh4L+p4 nkVGg9TKBv7gGmXu0+QJ/jmjDtuyf0vsiZtqfOy8vGXMsFT0Gx5LnxqL0qvqZlwgYvdmvD Qm3oPuDspX5fQWLhqsGno7h1D2Ud7o4= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HMZndeIV; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=IvzcaPFx; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721754980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PB8BYpcdslViKF79XJ2YzlN1Vk5ClgDRth1iFgE5pWU=; b=8AeGUD3c1JOMm2cG1y1VOgwJgkmqJhe+poY6RHyoXqD2dksU/sypg29g+2tExKRNduajNf I6o9TegtKmTc9qZuRQMgOrPwQxg+U5GCu5A/qlpTeCPdlw+o5x9s39+gFZRDpmI3cFvvaG 1/9MuLG94G4u64SDc7ET8IB3KX0P5Vc= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46NGQWND026263; Tue, 23 Jul 2024 17:15:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :content-transfer-encoding:in-reply-to:mime-version; s= corp-2023-11-20; bh=PB8BYpcdslViKF79XJ2YzlN1Vk5ClgDRth1iFgE5pWU=; b= HMZndeIVKXe/vaQQWQxNIwb27dj5IgVOmWj4gYtGcAhfFEvy+AZ210bjQoUlE0W+ L0AVPo1IE7hNtAH9c95x3cuR/sA4LtQk+mH/31PLw84aBZvt1KzSTroQw2bBQPFG ugrynGvrU7SbmK7eqLTClH5rI9tuV3UwqpC0XX85iE0Kt+db3ICMHBmQc9IU+MrE 4CAszbU5XwDdEyFZcoTAHPdUL1z4vR4OpXeMpl6OKFORra23Y8/LJ+Vkh5AZc9Q1 cbsqhLCL3AJQaFwvARA4aJXBJkg2Rze5f+qckdK+RBRjG77IIgG+YBp/lT4SpeC3 ysR+Y1GJO7YSF3kdSGspBQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40hgkt75ps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jul 2024 17:15:50 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46NGG80i040109; Tue, 23 Jul 2024 17:15:49 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2047.outbound.protection.outlook.com [104.47.70.47]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40h26mrcka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jul 2024 17:15:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qJLiw6QcZLQi37iSyGO7o0yWPTvKJdl34vrehXOl0Iv+OSGLvCoPbysPkXdGHheLuDEbfqhUY0jr1Yf7DqI3/FLZW7uekevgNTK4SXPYBLnqMhd37HBjRdUysNzpqswg0RCTVxp0sbqpFanAcIxyn3RIZeLruZHBBnekJ3f1cRO+RISIcOikVnqWD78LwWApzJu7/tPic/TcwwxDjxQQVFAjyqy+DMR7qktGgrqdU2r8tntAorJMlJst3DW1uHEhwULxjzYAmSM6TV3E8S2nCVaK/7hVERfhT/dd8cCVo//rtWQ1M30syUFP/1kgzRMWtPeJJZFOVev57ed4zVFk3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PB8BYpcdslViKF79XJ2YzlN1Vk5ClgDRth1iFgE5pWU=; b=xdlVB9eTuqi61x+++tbv8vxZa8ASCflBavD26O3+0des7BfLPtx2ulNz1DjY/6B8Z2fIRPqReDNF4JyxhEeG4qzWn9BueHWbcYNtGpoQJ17sH3TaEyz8c7eU8lCOwxCgmkGS0rkQ5aLFfrG/6rj7DPBmexm40u4Yp3NzbfR2zZdG9q4nqe7tYKT9XtBc6b2sNtlgqmW2rc9JTA1UJq5ryWIZFSGcyFDApfwP0p4JVKgVPxUu3/NdEFXsqrHk0xZKPcI5GiXiUzzVKxQGQ5x91gOMVdYNUPhjFfaRfrs4p1Qp28h0bo39KzN4zBTCpqArFnNoK6X9TRWB7f5ZAITCDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PB8BYpcdslViKF79XJ2YzlN1Vk5ClgDRth1iFgE5pWU=; b=IvzcaPFxq02bWI7yQr7UPKrlyeD+h928F5Z3Y/t8nQ1RzcpVyQBAGxOgFG95qmStrJRMpvtvghZ8PNzluHOVU2KbbKqJm/O8TG+HZ97KC9JlTZ7j6V/REgLEIxiShB7JvBxBbE9ErjHWt90lh0PBzxk8jfOcLv5Bbx1lyX/wP6k= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by DM3PR10MB7948.namprd10.prod.outlook.com (2603:10b6:8:1af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Tue, 23 Jul 2024 17:15:41 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%6]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 17:15:41 +0000 Date: Tue, 23 Jul 2024 18:15:36 +0100 From: Lorenzo Stoakes To: SeongJae Park Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Liam R . Howlett" , Vlastimil Babka , Matthew Wilcox , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Suren Baghdasaryan , Shuah Khan , Brendan Higgins , David Gow , Rae Moar Subject: Re: [PATCH v3 4/7] mm: move internal core VMA manipulation functions to own file Message-ID: References: <36667fcc4fcf9e6341239a4eb0e15f6143cdc5c2.1721648367.git.lorenzo.stoakes@oracle.com> <20240723165825.196416-1-sj@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240723165825.196416-1-sj@kernel.org> X-ClientProxiedBy: LO3P265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::19) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|DM3PR10MB7948:EE_ X-MS-Office365-Filtering-Correlation-Id: df4235ad-c34f-4584-9dfe-08dcab3b1489 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UGVReXJnTUtRT0QyL2RxZ2tmL1d0NVVjNURMd2VMYmxRbkRaRldhMmtVOExK?= =?utf-8?B?TGN2eUlUcnhIdzI0U1pDWlV0WXJ3Z3Q5SFZENHlsZ3IzSWVRajRPUERJUTRu?= =?utf-8?B?QmpnbGtxY3B0aFUyMnhWVVRTWTIyVDM5NFA3aFcxR0k5L3dwU1NRMDc0Wm5n?= =?utf-8?B?eWlORXdmVGhBVVJTd0I5bnUwUlV3TGRFRmxJV1ZsT2VGOGhWRVVtMHp5Y1B4?= =?utf-8?B?MEdwYmlkNlZ0SDdoUEVwV0h0UXFoLzdBYkFqUWR6bHM5ZWZHYmU1U0dXeWl2?= =?utf-8?B?T0Jua3RnV2JobFJUNGRGNE0zMlFVZXV4TTRualBsMWthbmN4eWs4ZVRtR1Qw?= =?utf-8?B?Q1REb1RHUWZobXk2cS9LRHJCYjNhNVhXNEUva011Ni84a2x0ak9neWRyQitS?= =?utf-8?B?M3FKbWN2djFJd2JJbVd2S0FkZ2pLaE5RbFV4Y0VLQ3p5YksyVEJsZWRQNzZj?= =?utf-8?B?MHBwUlB3dHF1Mk5MTmdRM0RGanBCdFZsd0d0bkkxK3o0YTg0MU1WaCtDRitK?= =?utf-8?B?OGo0dGJyUDN0VWVPV2V1WEU4L2NLaFdNbXNCeFVscXNPcDRzaVZMTTNyc2J1?= =?utf-8?B?enZWS2RIaFhucmpaQUVXN1p5WHhrb2k5NlJVYUxpZDRTcUJhNzZNZ0s4UVVh?= =?utf-8?B?SXBGeVpiSFdvL0Z6UkFrMG5ZOWxMT2dNdkpCLzI4dnFmdGlvcVNEODViUUpE?= =?utf-8?B?b3FZZmt0NGozaHR0Um5YWURnM0ZwWHRkdFdoNW9pbmlkYXdYR01RVHdKUGpK?= =?utf-8?B?dzBteGN2UEtJNFRvL1cwakxmVFBMZFZ0T2tFMDRvM0NjcGhLYXM4NkI4eXV3?= =?utf-8?B?NmljaW9xU21QM3NGaUF3SDVIWC9XTXQ0bDMwbU16WVk3dGNEL2VwR3NaWG5R?= =?utf-8?B?UVhHY1gzWHVRcUlneEpFa1VWWFUyY0paTHJrb3lMU2o5OGlVeFpQQkhjbkk4?= =?utf-8?B?eFZEbVdZc29TZURMOHlkL0lGQ2ZUbTNsTGNyMXlHTnJURzZrUjJLZUpIUWZZ?= =?utf-8?B?T1BqaU1oUFFoNStkRGlreUpJR0Nid0lUNWlETCszUlh4dENjR3BjdmxaalJx?= =?utf-8?B?SW5oTDB5aUtaNmZFTFZQVFJJbGdPTVdWVjI3NlB6NVNldFo4UTNTRktQY3FG?= =?utf-8?B?UExnb1FMWlo5cHJ6U1lNOVpJUjhZalhaWjlScFJRQ05NL2krUVFHWmd6RzUw?= =?utf-8?B?SzFXRXpVaDUySnpveDl0RnZnaUsvOWY4OTRCSExjcytpc0JxYXdYWXU2d2t1?= =?utf-8?B?R2VzWlVVNTk0dVpZV0ZPc1JnVWU4VzBWSkFOd1c4M01vU1luendDb3VrZ2xr?= =?utf-8?B?amJSYWlhMWdMaCtZYXNUcnJoWjk5ZkJRaVpPNVBkOTlZS2gyaUJVbWZpM2ds?= =?utf-8?B?TTY1ZlQ5Ly9tb3JzK1Rva0dDdXZIOGpacmt6KzF4cjRoOUsxdStHdjVqSlVZ?= =?utf-8?B?SUNuazNIWEkwTTd5VmhBYWVuakdDYWZIVGcwSXlLdWdvdHVySFBSU1hlbXBu?= =?utf-8?B?eEVQOW1Zd2trMndqd2lPTm1KeXpoekhMNFQ5UWlkeGdPd2pFMHF3Y2txQzQx?= =?utf-8?B?bFhMbEVaNktUZVpwc3ZtQmI4NHMxUjNJTUU5amtHelFRbnl3djRxZWdRNG1K?= =?utf-8?B?WXU2ZDZRNkJlY2VTU3AvcDhjVGk1M2FnYVZRMzZTTHcvYXNoYmc4UUhEZmFn?= =?utf-8?B?RGRIQUlmVmRRK1JzVFdXL3N6WTYwUzFqS1ZNVzd2Nkd6NmhHQ2cxVDJxVTQx?= =?utf-8?B?R0E3MExiQU1YT0w5b3BLKzEyTERidmF2cUswOFB3ZnZIb04reXI0anVoOFp3?= =?utf-8?B?SWlZcTU1Z3krMEc0OUtRdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0tmWnFHalZvSlczRVVrSzFpVGg5VnVFN3pMNGVmcUZNUFFBbUcrY1E1d0ha?= =?utf-8?B?MmNjTmhFSE5yTTJXMzMzWlVlbHZDY05uVHMzSm82bUxxd1hnTW5veXlUcEVu?= =?utf-8?B?ZUdLN0NETUV2SWNGdEFMV1ZWOFE1Wm40NFRxWElvNWhEQUlEbTVkUEJoNTRV?= =?utf-8?B?ekI0dVF0NGdDaWMwNEZ5b0s0Qmd2K3BuOERDNHhaQlM1RitqRkIvc2xMMEcw?= =?utf-8?B?cmQrQlhjb0xFM3FPL2tFZnZKZ3QveEduYUtuMExrSjVhRE1rZGRiazhPTEU0?= =?utf-8?B?cjFnWXNlaWd5R2FDeE9UU1RZZFlocjFyTW1jbURNdDRFdkxyNm9wUGRwSmU1?= =?utf-8?B?R0loOXZKWHVHOVJMVG5CME5xTFpWUEdhMHV3STFuNURHSDlqTjNSMEh1ekd0?= =?utf-8?B?M2t3a012M0E1VGFmN3lPeGUwYlROb1hLTzFMU3RiZ09COHVLeFZNVU5Vald4?= =?utf-8?B?N1JYVndtWVBoZUduc2JRWlhwK0F4OGhMMlNJcGRYYm9rZ3lVZ3F2VTlibXQx?= =?utf-8?B?aDdjZ0FGeGJyaDdUcitwVGUrUm5YNDdRSmNCSDJIZ2hvVUNYS2ZQMC83cnhx?= =?utf-8?B?YUlFV01Fakt1c3F5V3F0SkRkQWo3ajJLSjBBT3VaVlJKM2F2N29jUzl1d1h1?= =?utf-8?B?c3hKNVBvR3pzR3hzRXBCMjdqNUxMbndsUDNhUWxpNzVYdjg1ckpoTXVGTHA1?= =?utf-8?B?eTAwK21hL2U4clZSa3JTZjVOaElUUXJ4VmRFTFhDK2ZHZnFvN3pFb3pyeE8r?= =?utf-8?B?Q3BwbnovcWJvWHJVYzRXUzdKY2Vta2RQR1ZuQkorK21TUWlpV3hkMXdZSU9K?= =?utf-8?B?bTVGb0l5d3JxUzFVOExhZDBJNy9CY0h3Y1pHQzc4ZHJCZ01Qc2ltQUV5bWFR?= =?utf-8?B?dHpQQkZ5bWF6RG5sWGRCN1lpWDJVUHl4dWdhZUtLWjRBZDN4aFFYQjQvNWM5?= =?utf-8?B?NSsySWRYN1AveVNpNmJFdHJwZWVkaHB2QUl2VlV0OFY5dGs2UXRXdGt1YVFZ?= =?utf-8?B?OTZ3NGIrckpWc0Y0YTFaNU85eExFalBSYWJiSWdHK1YvNWZuSHVhQVRtT3lk?= =?utf-8?B?M0svNEUzakZ1TFR3Q3cvcGJ2bXQvd0d1NDJiYnc3dmVoMHJKWHhNK1JZalho?= =?utf-8?B?dHlCMmtNUWJKZnRONG1CR3pVTG81SEpXdE9nZk9LVVpaa0pDZERaeVJkSEF3?= =?utf-8?B?MUN3Qi9HL2tpUWMybE9zbGhqRWN2ZEs5dTBaVllrWjZJWG14TVFlTWhObVhN?= =?utf-8?B?T083bEtITllXNUkvR3JrY0ZKVE45T2tuaTd2NjlpSnhvMHUrTVFudkNsYXli?= =?utf-8?B?S1RGTVFHWlNrdXZWS0diL20zN0tzaFpkbjdNRm0ydXBVQmI0OGUrblR0dDE4?= =?utf-8?B?eUY0ODJXdjJRKzNDK2Y2QTF4RE11WTBTZENQUjN3NU1TUmtHRzVYVC9IaG5E?= =?utf-8?B?WnJ0OGs0UkFrUGMyVUp6U2xJdTFrcFhtTnJRQzlnNXFjVThPWXBrZUtGOTBH?= =?utf-8?B?YWYwTk5sWm5kempJTlowMVYxQjd3U0lXOUdmaWJzMXV5cVlMVDJXVUdGVkZn?= =?utf-8?B?S00xVTB5VnR6Y3Q0NHJPNlo5N2hkTHZ4OG0vWW5EYVRiemRBNmFxSFFWZ2xB?= =?utf-8?B?bWoxSHJWdUNua2p1SW8xdjQxdHdVMTI3NGdJVnpFcjNPdTlacjdwbDRxYi9O?= =?utf-8?B?RFg4eFp5RWhOUmlYOEorMjdwNG42aWdZeXR6MzJrZDBWZ2g2d2w0bFhSN0ZK?= =?utf-8?B?SUxEdWdwdEp1NDZFRCt4bURpUWhsUGFpWk9vUHgwcXo5ejFGL0wrREh4Y1pn?= =?utf-8?B?aVZ6RlBycFErUHcrVHhHdDBsOVNkNTlrV1dVeVZGMnZpQThvR0RiTUw1Ritu?= =?utf-8?B?TFZhU0kwS1A1dG02LzNadWwvRzFHRVA4U0F1WDJZMktGOXpsSlhyTXR3cjJN?= =?utf-8?B?anI5WG1uaDQzKzk5SW95d3dMQnl0QVNrRldGWWEvRU8rOFZTTHJQaTRkc2ZE?= =?utf-8?B?K0Z4U21kcTl0RnlLcDk4YzdaZE9hV3NhZ05mR25vWFB2aXp6ZCt0amp5dDJp?= =?utf-8?B?UXJkY2RxbnI5VjRaOWw0ZmNPdU5IZEJ5ZWJwVXFBME9HNEtNVzhpV0prMTZ5?= =?utf-8?B?RXJrcWdWVjM2Wk9nVGZWVzJSQ1VhU2NMcks2NUdPRUVadkFXS3lWZHBlQ0ZZ?= =?utf-8?B?MGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xkHpGjk4fGG6fYuKDz879FVJMOwSczD9br2RrwVZ6tPgBHmYaRDUiwr0qS6YAAb13IMyz4SjUEGaDX9wOK6E0Dfh7emidAYSHiyyb8tsmhc5fyp9uHN5+df+P+gyspoo3Ew6hWEX34Ryc+7UvU0uz59pEbnFEuRPaOVpm4K/eLa+pBnled8AaCD7w5a4a3t2YaiIrYiEjQ3jhhWWL8nqHiXrei2Tu0hokd3vQizJCeUv9Nd2DKK2Mx7p1aaCET0GQV+POX04px8B48yh3ECGa53mjFSBVGkAk33eHSK+a79gHcvKRA0yH1gvOM3JwhbiHamWxWTISj11UP5VjETFVX0EJ9C6lUXQbxCHKCq1LT+GOBN4xMH37fSVTQSa8gWvgGbSUidedf4Emk6mfpLPqmeAGGqpPfN/rcL4wEQqIfqgnI0OHq7djc8zZ3xRXeikF5JGl7jUDkG0R4POqG9p7jbKNuxaLGJLxwX/e+KiwqEr+966IyRssbV2cHpng0jdwkhVGiSU4kMxJi41qwqkXJC+YH+9Ewmhvmw+2Wph1aMt1aVSTlYg8e8H94DnQfQ9P0GtA1SIKvRfoE9UN8K+exbO1gOUJO10fcqWMjdP4NY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: df4235ad-c34f-4584-9dfe-08dcab3b1489 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 17:15:41.6603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bCQGJcLp+rzcqzCh/k9SpWjuYjqXZkEL9Cv8Z4qOh+02jsWxpUee1VSvXXst9MoksDwNMdnjARgwDuFq2IY8hqcTHl4bxAco+I88tR3UfwE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR10MB7948 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-23_07,2024-07-23_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2407230118 X-Proofpoint-GUID: sQRDH8D7xpcNekWqk5-ye0QxRMtXXj6z X-Proofpoint-ORIG-GUID: sQRDH8D7xpcNekWqk5-ye0QxRMtXXj6z X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 737F54001C X-Stat-Signature: td3cwb8hbm64ri3wb768bpd19md5dxun X-Rspam-User: X-HE-Tag: 1721755018-876238 X-HE-Meta: U2FsdGVkX18rKAtMTTYKNJp3kx5XrgvAM/QwHPdkPIl7YZ4x3Aa8r/WtyeCV07tbcfUPc8oL/0CsLxaleYYuOkRCCy2/V/ojktt1/97w0wvUhEM6B1AeD+/C8CbhNlkLQpa9Eyb3F9ZldPxidoboSU1pGh40VcsM78squtaZoW6cXvWxpbR4hIEgYgZ8ur7zORHZC7xlkXhZYezeTlpmtb5Lbn/mA2ZpAU0hukeQyW25rBEKTmGsWKG6eyPr/sAia/Z47xTYbaa6dWqjZugS/3KAdKsGLu7hOer0hKOFKOYk8VlIJnaK3bz3VXRF29YXruQdsO7IuWNwtlnaOK4RgUM72Ph0U2ZzMBq2AygnJGKxorErhWZiMhhEqO/VvNZWDd6Q64ThJkK0wBUNQK8K5+WPP8rJLP7tFUoeRyXccEJeTfvqpN9Zsc0YcTl4tKessTHnI0t4XjzajGZVRk0n0cws5kjy8jJ83C57R48+rlQj7Ydee/GtX1NHK9hOOBfRCl8oKOC/NBPM8aox5m6OzD0FMx6iOzRaSY9RCelp2Y772d6RKmazrAlVWDuB7M2HMzZbjT0iKOmpwYiWCRfO0v9+XG4kpfXH9irSoNfLhfOB1qDvPnw3n40WpKi+jIwBEwOfeVahTpclVWPEhsvSj0KYklWNxTbX2tW6aFJxCGahcQyNEQaRZt2CHQvaRX7hb11C1qaU674xWN2WXNBEVRvoCP/T8O0WcMpSFj4uWRz/gFXFaYPXlA919ZHaKZL4I3XdCysAwxR0hUcjUR44OrND/F/PMBLgI3AKdqJd23qgTZ4yiFDOOJx4oXqSokvmbwV6HfuaY8JvpYSm5s7iNu23T3/amOW+JwkrYXeojsgqPnTJuzYSiJYXaFuY4G4/kblMS7S9MUvVp8PdRQ4lVbGOWUD9tIImB6Jxd7pfLVqLlNR9D6VGlv1So6/zjqDUK1Zztfa/9BrsJdubcME itit1mYE EXFz4YIPVnSPX6yvIioUQuuf0pplFFC9FtCneTYQ6DnPVDs93IU5AklUTSIrfZpUzpkCctBx2gJsbv7vUtxtG+L9DWgrJF90Mf+pSX2BFthsng1J0tB89MakWCTtnu4uD2DCnPosOrU0DBBCM0s4UQ2d+hDZh/1diSCkZ7b9m6N8jtCLSekGT2By32XLLC1vNxvW2J1dbCc/yoJKdY9ROG5lFn8jZQDPr6WXPQSMlYzMktaGDlEAiNd8hWex7NK5+PwLNRnjCWivMGdZGM49mGKE0WoOImk2udd2zKqehcXwehxMoSWutZpS5Ahm8+QdlDC3p7G8uyZlvgEGXtXzofTjms2TL37P+bou6OoliYhrxKVX5z6gkLzkqVZfyv9t3hF0Cbyurb0qOd1RJfhmX5eCjk4jG2RNplcDjMyGzbPyVdeBJbHYHGllwi5+6CCCwF7NLY3uNA6dN6/eKE7ymcQKxFoaS0P+Zi8MeFSU1jZcgPEwcj45Yaw2qWuryxqUMX1Y/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 23, 2024 at 09:58:25AM GMT, SeongJae Park wrote: > Hi Lorenzo, > > On Mon, 22 Jul 2024 12:50:22 +0100 Lorenzo Stoakes wrote: > > > This patch introduces vma.c and moves internal core VMA manipulation > > functions to this file from mmap.c. > > > > This allows us to isolate VMA functionality in a single place such that we > > can create userspace testing code that invokes this functionality in an > > environment where we can implement simple unit tests of core functionality. > > > > This patch ensures that core VMA functionality is explicitly marked as such > > by its presence in mm/vma.h. > > > > It also places the header includes required by vma.c in vma_internal.h, > > which is simply imported by vma.c. This makes the VMA functionality > > testable, as userland testing code can simply stub out functionality > > as required. > > > > Reviewed-by: Vlastimil Babka > > Reviewed-by: Liam R. Howlett > > Signed-off-by: Lorenzo Stoakes > > --- > > include/linux/mm.h | 35 - > > mm/Makefile | 2 +- > > mm/internal.h | 236 +----- > > mm/mmap.c | 1980 +++----------------------------------------- > > mm/mmu_notifier.c | 2 + > > mm/vma.c | 1766 +++++++++++++++++++++++++++++++++++++++ > > mm/vma.h | 364 ++++++++ > > mm/vma_internal.h | 52 ++ > > 8 files changed, 2294 insertions(+), 2143 deletions(-) > > create mode 100644 mm/vma.c > > create mode 100644 mm/vma.h > > create mode 100644 mm/vma_internal.h > > > [...] > > diff --git a/mm/vma_internal.h b/mm/vma_internal.h > > new file mode 100644 > > index 000000000000..e13e5950df78 > > --- /dev/null > > +++ b/mm/vma_internal.h > > @@ -0,0 +1,52 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > +/* > > + * vma_internal.h > > + * > > + * Headers required by vma.c, which can be substituted accordingly when testing > > + * VMA functionality. > > + */ > > + > > +#ifndef __MM_VMA_INTERNAL_H > > +#define __MM_VMA_INTERNAL_H > > + > [...] > > +#include > > +#include > > +#include > > I found the latest mm-unstable fails build for arm64 and kunit (tenically > speaking, UM) with errors including below. And 'git bisect' points this patch. > > From arm64 build: > CC mm/vma.o > In file included from /mm/vma.c:7: > /mm/vma_internal.h:46:10: fatal error: asm/page_types.h: No such file or directory > 46 | #include > | ^~~~~~~~~~~~~~~~~~ > compilation terminated. > > From kunit build: > > $ ./tools/testing/kunit/kunit.py build > [...] > $ make ARCH=um O=.kunit --jobs=36 > ERROR:root:../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes] > 156 | u64 ioread64_lo_hi(const void __iomem *addr) > | ^~~~~~~~~~~~~~ > ../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes] > 163 | u64 ioread64_hi_lo(const void __iomem *addr) > | ^~~~~~~~~~~~~~ > ../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes] > 170 | u64 ioread64be_lo_hi(const void __iomem *addr) > | ^~~~~~~~~~~~~~~~ > ../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes] > 178 | u64 ioread64be_hi_lo(const void __iomem *addr) > | ^~~~~~~~~~~~~~~~ > ../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes] > 264 | void iowrite64_lo_hi(u64 val, void __iomem *addr) > | ^~~~~~~~~~~~~~~ > ../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes] > 272 | void iowrite64_hi_lo(u64 val, void __iomem *addr) > | ^~~~~~~~~~~~~~~ > ../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes] > 280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr) > | ^~~~~~~~~~~~~~~~~ > ../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes] > 288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr) > | ^~~~~~~~~~~~~~~~~ > In file included from ../mm/vma_internal.h:46, > from ../mm/vma.c:7: > > Maybe the above two #include need to be removed or protected for some configs? > I confirmed simply removing the two lines as below makes at least kunit, arm64, > and my x86_64 builds happy, but would like to hear your thoughts. Thanks, good spot! Yeah they can just be dropped, this is pedantry from wanting to absolutely nail down the sources of declarations, something I pared down in the final release, but obviously these were unfortunately arch-specific. You're right that they're just not needed. I will send a -fix patch in a second. > > """ > diff --git a/mm/vma_internal.h b/mm/vma_internal.h > index e13e5950df78..14c24d5cb582 100644 > --- a/mm/vma_internal.h > +++ b/mm/vma_internal.h > @@ -43,8 +43,6 @@ > #include > > #include > -#include > -#include > #include > > #include "internal.h" > """ > > > Thanks, > SJ > > [...]