From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4432CC433F5 for ; Fri, 11 Mar 2022 09:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC75B8D0002; Fri, 11 Mar 2022 04:55:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C76DF8D0001; Fri, 11 Mar 2022 04:55:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8DAA8D0002; Fri, 11 Mar 2022 04:55:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id ACC8C8D0001 for ; Fri, 11 Mar 2022 04:55:19 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5F38E8249980 for ; Fri, 11 Mar 2022 09:55:19 +0000 (UTC) X-FDA: 79231647558.23.86331FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D6E7014001A for ; Fri, 11 Mar 2022 09:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646992518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ylmH23lNYpJ5L3ifT6u21HFSeJ1A7vGW+YoFCvEO9M0=; b=BS+EOAtcWUZn4dZ+R9C+4E9dAxsplpEHKXTDG2pj37ZbMl+Lxn+eogxLR+Pi3UyKzriF+V 8SXZs5aJcWVKyqR76UDyQzhoS4g/s8Y9cjh2dRocsyWoSZFBXVONjRjryQT7p0EB/hHotY YBGouwKX2blnkLvBHGF0Rb+CfsrkKFc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-284-ulE6TiV0MWqiP8SPI_Ti9g-1; Fri, 11 Mar 2022 04:55:17 -0500 X-MC-Unique: ulE6TiV0MWqiP8SPI_Ti9g-1 Received: by mail-wm1-f69.google.com with SMTP id l2-20020a1ced02000000b0038482a47e7eso5298728wmh.5 for ; Fri, 11 Mar 2022 01:55:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=ylmH23lNYpJ5L3ifT6u21HFSeJ1A7vGW+YoFCvEO9M0=; b=DfEici+R95dfQBrQjuGgy+M/xz40JW6dJNMOK2/QcPhonvxwoPy2F21K8+gGDOG+au T5JIW0AJRvSvLzNs378/wSkmJBeU1aXP8KDolAcbi6mH60ALbJOCJde9mIOIna+eFcjO fhlVbv/I4WNV/qZhIoKR4KlChbNXBxAu3zfIeok/9QJpTckZIQNM/k1un3QlwjAf0h1z PnwUB9VFOovOCa2ZqL90FczUIcX7BcTRfHRLCJ7oF0y5AMnT7C6pEDLCXFY5LMP9TI/n LWLHnZ6L6FBa5ZN9pHdo/Zqq2f9quM53Hk08DNsSkWGf7t/zI+idB7oWAJb1S3LRFv19 BX2w== X-Gm-Message-State: AOAM5308WcO04brSrVWVJIUkmCO/CHkGxVQyyLCO2LxdwdWmv21iP1oP xq4c8IcEOhpB4iu4zBSUI7vkylikMV5imP+RIgqtvXKrR+9YngPTJf8AICTWDxawHEeIxhzeTI1 tfBYo9gp9xg4= X-Received: by 2002:a5d:64e5:0:b0:1f1:fa31:e7d3 with SMTP id g5-20020a5d64e5000000b001f1fa31e7d3mr6940755wri.573.1646992515899; Fri, 11 Mar 2022 01:55:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLC643/T4UbINF7UgQYXhn1FtkQIwPzi08Sb5vJL6N19y2iFpM7UaA6J5H7uueEZlzOIGkoQ== X-Received: by 2002:a5d:64e5:0:b0:1f1:fa31:e7d3 with SMTP id g5-20020a5d64e5000000b001f1fa31e7d3mr6940740wri.573.1646992515653; Fri, 11 Mar 2022 01:55:15 -0800 (PST) Received: from ?IPV6:2003:cb:c707:8200:163d:7a08:6e61:87a5? (p200300cbc7078200163d7a086e6187a5.dip0.t-ipconnect.de. [2003:cb:c707:8200:163d:7a08:6e61:87a5]) by smtp.gmail.com with ESMTPSA id i11-20020a05600c354b00b00389f440512esm591995wmq.32.2022.03.11.01.55.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 01:55:15 -0800 (PST) Message-ID: Date: Fri, 11 Mar 2022 10:55:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/khugepaged: sched to numa node when collapse huge page To: maobibo , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220311090119.2412738-1-maobibo@loongson.cn> <52412f08-829a-6c29-60c6-a24c866e6253@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BS+EOAtc; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D6E7014001A X-Stat-Signature: h7qku8rbufjjp3ygbtensag7n71jb6hj X-HE-Tag: 1646992518-590199 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.03.22 10:51, maobibo wrote: > > > On 03/11/2022 05:20 PM, David Hildenbrand wrote: >> On 11.03.22 10:01, Bibo Mao wrote: >>> collapse huge page is slow, specially when khugepaged daemon runs >>> on different numa node with that of huge page. It suffers from >>> huge page copying across nodes, also cache is not used for target >>> node. With this patch, khugepaged daemon switches to the same numa >>> node with huge page. It saves copying time and makes use of local >>> cache better. >> >> Hi, >> >> just the usual question, do you have any performance numbers to back >> your claims (e.g., "is slow, specially when") and proof that this patch >> does the trick? > With specint 2006 on loongarch 3C5000L 32core numa system, it improves > about 6%. The page size is 16K and pmd page size is 32M, memory performance > across numa node is obvious different. However I do not test it on x86 box. > Thanks, can you add these details to the patch description? -- Thanks, David / dhildenb