From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B18ECE582 for ; Tue, 10 Sep 2024 09:08:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7813E8D0037; Tue, 10 Sep 2024 05:08:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 730C68D0002; Tue, 10 Sep 2024 05:08:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61F5E8D0037; Tue, 10 Sep 2024 05:08:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 451048D0002 for ; Tue, 10 Sep 2024 05:08:16 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC428120A6F for ; Tue, 10 Sep 2024 09:08:15 +0000 (UTC) X-FDA: 82548252150.12.79EDDEA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 0984AC0009 for ; Tue, 10 Sep 2024 09:08:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725959192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNu+8w1zn2W7ETkPtZwkn4N43SPeqrDEWHo+RlKyDQs=; b=vS5RBNeLnrEpyuQ3KTsFr8K2/2YYamPyAQIsUfzIN31vK/7V6+Y9r8kMUNJx7JpsF9eHlO /NpCcNFxLOsErX6zRXvZzArZFqsNo8ho2/xo4ouLWIyT9+riFlf+cA6DR6xrFillU5WhdF vWN8n5l59CXxh1+NE4NsPAoLroEf+Q8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725959192; a=rsa-sha256; cv=none; b=CXU8uPD0qtAhdZDCn+NW7h72cCeu/J0Z3lKqDjWUuF06SvAketRQrfz4+Oo5Pxr+lGsjLW tSPxc4QIRV6EB1W5EJK8Vh3cH7E5ApY/W1oU1cvb1ZB2ILftj1Osrv1x9fp/TjOLv8xO7Z 81RdyVW2W/c/+xqpHnkC+skg+2xVMG0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31B2A113E; Tue, 10 Sep 2024 02:08:42 -0700 (PDT) Received: from [10.1.35.188] (XHFQ2J9959.cambridge.arm.com [10.1.35.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DC613F66E; Tue, 10 Sep 2024 02:08:12 -0700 (PDT) Message-ID: Date: Tue, 10 Sep 2024 10:08:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Drop unused set_pte_safe() Content-Language: en-GB To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , "Mike Rapoport (IBM)" , linux-kernel@vger.kernel.org References: <20240910090409.374424-1-anshuman.khandual@arm.com> From: Ryan Roberts In-Reply-To: <20240910090409.374424-1-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0984AC0009 X-Stat-Signature: ta66gt4fopdw369iynepd9d3ft36yuhx X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725959293-186379 X-HE-Meta: U2FsdGVkX1+g2j538iYfROONiABz4leRRma8OWRTfQpQpoBUScSiEO9iV5HxlzkFpnmI9j6BWF6HeTENg795lyoGZuNRL8fo22v1qHCfUazaj3q3btTE3v1jPJry24jdeAsotCG+ncAnOZieL09YYIDxRIfxeJk7jOiSLiOSm7dGKnuZxK5iqVC1NJsYb75q9dhqPfKctlKzB9MVK/ztDtOIe0sJJxP8WmneiGkHxejlKdZQnj9jVeTVDTEjAdtriytVzk8NYn54l4/kuS0dFYGkay18XuIqsdx6IwHaIvEQW/IFxpd55LWnB1fPK9qEqtlm9waTv4NzZuXHhmCoKSEnVPz7Ah9/SKL2ZPbeIkcHhZP2AfFoh6UfkRKtZwJyXY8pqT80pGUs7IuUBs4OpSP+5eARL/op4N6slidOW/nHkEEFs2zEzRU83/JS6ur7rqTrCi+C6btCzzbObkbHWf3usyNskqkeR8weW9Gg0J4+VG+n06EAIVfbDhtngpOus4kZRYW9rHSR41vYHEN4/LB+2XQKLJujxILS5BAh3juHKutkxFj/NcNfvoBtd1lCJHAJUqOTNmn/u5NBjnP0TM7oFP2wBr4THjStF1tXC8Z+lZBXGeMmh8axxqPxqtzhNufFMTxIa5g40mqBLMpNlOiV4KMSpVxiu9xHEPwPkUGfZ0gq991AVwhh11XKKobt/NWz1vVKRjvZTzY6ECNITHdYs0oJcDJZPU9jtONl/Xl1CyMNHTtc3mBYgM2kWzP4DH+5NrrtcHfkm0LfwKzymIO0QfKRygJQHVbX9FbJKOu40W6+qsCJxmxPPbcFF/x51zJdqB0VXgZZH8cjUO+gIqQwWCPaIuOxB4XWhJ4RMxV7I/xcQsRQWzbrI3SkgqEUsP2sRRdUvwRs/Xh509zPM888YfhAEh7ykVZUxD7QwRupKOP2CvtxugdmxP3ZvB+Gcg33+kvNinxZvAvgp8E QqPzaeLw ACK4PWOTpdxCrpPFnnnvCOj9JV7IWU9WOVcE9LUX19FykiTHdnD+gIny1GbQh/JgsU6WyCMBotLT/oHyZcnrtQvHFd7JX4F9oY6Iz/zgzQ1amqky0oC01tEPnNVLu3zyYRg8Ly25TWC1+HBkPCqZW7lYvxHdCSl0jHlAhe/OSYzAPGghigfX37Eo0h7A5J91HolmfphQeWydPfQc2nThN2oxt/MtEOKA7PKGYX5gEBtqLI+qW4cYJlUWtOCZKmxkGXuDA1uZw6xX9Mgid7ubohLkoQf0Rf+yEWKD2nPC8Kp/7GSCO/zmIMBAgIPWZLUJE4Urew7+BvYj//mUAsLy3n4YQ7Ipy/3JVKORfMRuDLs4NwSXZDQBZXQIS1afe1glIDoFl4gFXWCSV9W2od/hD6PuoxXtswmhFPSjzEaqOACwwuTRrVwfy9llWE2csW67KryIY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/09/2024 10:04, Anshuman Khandual wrote: > All set_pte_safe() usage have been dropped after the commit eccd906484d1 > ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page") > This just drops now unused helper set_pte_safe(). It would be good to add some comment here to mention that the macro was buggy due to doing direct dereferencing of the pte, and that if it were to be kept, it should have been updated to use a single call to ptep_get(). With that: Reviewed-by: Ryan Roberts Thanks, Ryan > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Ryan Roberts > Cc: "Mike Rapoport (IBM)" > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > include/linux/pgtable.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 2a6a3cccfc36..aeabbf0db7c8 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1058,12 +1058,6 @@ static inline int pgd_same(pgd_t pgd_a, pgd_t pgd_b) > * same value. Otherwise, use the typical "set" helpers and flush the > * TLB. > */ > -#define set_pte_safe(ptep, pte) \ > -({ \ > - WARN_ON_ONCE(pte_present(*ptep) && !pte_same(*ptep, pte)); \ > - set_pte(ptep, pte); \ > -}) > - > #define set_pmd_safe(pmdp, pmd) \ > ({ \ > WARN_ON_ONCE(pmd_present(*pmdp) && !pmd_same(*pmdp, pmd)); \