From: Jiri Slaby <jirislaby@kernel.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, akpm@linux-foundation.org,
rientjes@google.com, pjt@google.com, weixugc@google.com,
gthelen@google.com, mingo@redhat.com, corbet@lwn.net,
will@kernel.org, rppt@kernel.org, keescook@chromium.org,
tglx@linutronix.de, peterz@infradead.org, masahiroy@kernel.org,
samitolvanen@google.com, dave.hansen@linux.intel.com,
x86@kernel.org, frederic@kernel.org, hpa@zytor.com,
aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH 3/3] x86: mm: add x86_64 support for page table check
Date: Wed, 1 Dec 2021 09:44:44 +0100 [thread overview]
Message-ID: <cadf2582-3004-92b9-ab5a-cb39259fa36c@kernel.org> (raw)
In-Reply-To: <f81a6434-9f38-947e-02a8-9a9191285e52@kernel.org>
On 01. 12. 21, 9:00, Jiri Slaby wrote:
> On 23. 11. 21, 22:48, Pasha Tatashin wrote:
>> Add page table check hooks into routines that modify user page tables.
>
> Hi,
>
> I bisected to this as this causes crashes during modules load:
And it's not enough to unset CONFIG_PAGE_TABLE_CHECK_ENFORCED. I had to
unset CONFIG_PAGE_TABLE_CHECK completely to get rid of this.
> #PF: supervisor write access in kernel mode
> #PF: error_code(0x0003) - permissions violation
> PGD 6d615067 P4D 6d615067 PUD 6d616063 PMD 800000006d2001e1
> Oops: 0003 [#1] PREEMPT SMP PTI
> CPU: 0 PID: 6189 Comm: modprobe Kdump: loaded Tainted: G I E
> 5.16.0-rc2-next-20211129-vanilla #3
> 83846a405f0e3937f5c8dfbc7d449622b8f46369
> Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./To be
> filled by O.E.M., BIOS SDBLI944.86P 05/08/2007
> RIP: 0010:jump_label_module_notify (kernel/jump_label.c:370
> kernel/jump_label.c:670 kernel/jump_label.c:748)
> Code: 00 48 8b 43 08 a8 02 0f 85 e9 00 00 00 48 83 e0 fc 48 c7 02 00 00
> 00 00 48 89 42 08 48 8b 43 08 83 e0 03 48 09 c2 48 83 ca 02 <48> 89 53
> 08 4d 89 66 10 49 89 6e 08 48 8b 43 08 a8 02 0f 84 98 00
> All code
> ========
> 0: 00 48 8b add %cl,-0x75(%rax)
> 3: 43 08 a8 02 0f 85 e9 rex.XB or %bpl,-0x167af0fe(%r8)
> a: 00 00 add %al,(%rax)
> c: 00 48 83 add %cl,-0x7d(%rax)
> f: e0 fc loopne 0xd
> 11: 48 c7 02 00 00 00 00 movq $0x0,(%rdx)
> 18: 48 89 42 08 mov %rax,0x8(%rdx)
> 1c: 48 8b 43 08 mov 0x8(%rbx),%rax
> 20: 83 e0 03 and $0x3,%eax
> 23: 48 09 c2 or %rax,%rdx
> 26: 48 83 ca 02 or $0x2,%rdx
> 2a:* 48 89 53 08 mov %rdx,0x8(%rbx) <--
> trapping instruction
> 2e: 4d 89 66 10 mov %r12,0x10(%r14)
> 32: 49 89 6e 08 mov %rbp,0x8(%r14)
> 36: 48 8b 43 08 mov 0x8(%rbx),%rax
> 3a: a8 02 test $0x2,%al
> 3c: 0f .byte 0xf
> 3d: 84 .byte 0x84
> 3e: 98 cwtl
> ...
>
> Code starting with the faulting instruction
> ===========================================
> 0: 48 89 53 08 mov %rdx,0x8(%rbx)
> 4: 4d 89 66 10 mov %r12,0x10(%r14)
> 8: 49 89 6e 08 mov %rbp,0x8(%r14)
> c: 48 8b 43 08 mov 0x8(%rbx),%rax
> 10: a8 02 test $0x2,%al
> 12: 0f .byte 0xf
> 13: 84 .byte 0x84
> 14: 98 cwtl
> ...
> RSP: 0018:ffffaf4dc051fbe8 EFLAGS: 00010282
> RAX: 0000000000000001 RBX: ffffffff931ee760 RCX: 0000000000000001
> RDX: ffff9d1aa7d43883 RSI: ffffffff91c50aa0 RDI: ffffffff931ee760
> RBP: ffffffffc0782000 R08: 0000000000000020 R09: 0000000000000000
> R10: ffff9d1aa7d43880 R11: 0000000000000000 R12: ffffffffc079a980
> R13: ffffffffc0784080 R14: ffff9d1aa7d43ca0 R15: ffffffffc0782008
> FS: 00007f87104b8740(0000) GS:ffff9d1b45c00000(0000)
> knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: ffffffff931ee768 CR3: 000000010fdce000 CR4: 00000000000006f0
> Call Trace:
> <TASK>
> blocking_notifier_call_chain_robust (kernel/notifier.c:83
> kernel/notifier.c:118 kernel/notifier.c:283 kernel/notifier.c:271)
> load_module (./include/linux/notifier.h:198 kernel/module.c:3923
> kernel/module.c:4100)
> __do_sys_finit_module (kernel/module.c:4224)
> do_syscall_64 (arch/x86/entry/common.c:50 arch/x86/entry/common.c:80)
> entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:113)
>
>> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
>> ---
>> arch/x86/Kconfig | 1 +
>> arch/x86/include/asm/pgtable.h | 29 +++++++++++++++++++++++++++--
>> 2 files changed, 28 insertions(+), 2 deletions(-)
>>
>
> regards,
--
js
suse labs
next prev parent reply other threads:[~2021-12-01 8:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 21:48 [PATCH 0/3] " Pasha Tatashin
2021-11-23 21:48 ` [PATCH 1/3] mm: ptep_clear() page table helper Pasha Tatashin
2021-11-23 21:48 ` [PATCH 2/3] mm: page table check Pasha Tatashin
2021-11-27 8:10 ` Fusion Future
2021-11-27 8:14 ` Fushan Wen
2021-11-27 8:41 ` Fusion Future
2021-11-27 19:48 ` Pasha Tatashin
2021-11-28 8:13 ` Fusion Future
2021-11-28 9:37 ` Fusion
2021-11-28 16:54 ` Fusion Future
2021-11-28 16:57 ` Pasha Tatashin
2021-11-29 2:55 ` Fusion Future
2021-11-30 19:25 ` Pasha Tatashin
2021-12-01 8:38 ` Jiri Slaby
2021-11-23 21:48 ` [PATCH 3/3] x86: mm: add x86_64 support for " Pasha Tatashin
2021-12-01 8:00 ` Jiri Slaby
2021-12-01 8:44 ` Jiri Slaby [this message]
2021-12-01 13:55 ` Pasha Tatashin
2021-12-02 9:59 ` Jiri Slaby
2021-12-02 10:05 ` Jiri Slaby
2021-12-02 10:30 ` Muchun Song
2021-12-02 15:01 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cadf2582-3004-92b9-ab5a-cb39259fa36c@kernel.org \
--to=jirislaby@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=frederic@kernel.org \
--cc=gthelen@google.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=weixugc@google.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox