From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D4AC7EE25 for ; Thu, 18 May 2023 17:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B887A900006; Thu, 18 May 2023 13:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B38C1900003; Thu, 18 May 2023 13:29:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0138900006; Thu, 18 May 2023 13:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 870A6900003 for ; Thu, 18 May 2023 13:29:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5ED9AA0904 for ; Thu, 18 May 2023 17:29:04 +0000 (UTC) X-FDA: 80804061408.04.A231326 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf02.hostedemail.com (Postfix) with ESMTP id 131478000C for ; Thu, 18 May 2023 17:29:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BXXde7bF; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684430942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cjWXhGAltEGivXANI2bw4yXAkLkrpX6pA09xKLvggSk=; b=s4ho358IE7gHHjkR2EjgDgh+KMov0Rxar2+R+AF6pdfxumH2e692qiOX8HTCRFBUafXtcn lltr5fDc7bzGRMmm9pmqQcMM42MWcC1er4hZSIBpxLHKJ6/o4RNYP/jDyekOEp+iOKCBR1 4Xjh3sN1kDtW9+fvmsyCv9q4OHfop30= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BXXde7bF; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684430942; a=rsa-sha256; cv=none; b=5iaKVKImh9ka85TvmNMxgQIHLoePv8ETQW3bEmFB7a7iunMAS9fPXrBEeWuoCsKmJeaWS9 ODvIRfQdW9Z5TrK9gjt8NVCyPs0uhW6zUr4El9e1og8NhGSrSYFtkrHeVWIvHkjJgPoh0A QF8wPUbevBrw7tI9slEDpDzSqFNZAxY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684430941; x=1715966941; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=YbB0ITNWC6W+DKq+pyGIH80h6yd4xEjccS7jew/3CTQ=; b=BXXde7bFASDIrGRMtq9oKotSdub338hTK5ReO13/vFnWFtKFKozy5VzE bxD7JVBQFwvUANwscWBgtdGbhtldeSAkBWOc107nZ7Ywjv4tDrhy9NfoZ 6Q5Yf5pPDBYC9qMKUDoG8vhwcTZvJ96ufzi7sjCggd3mkSOdwJwWT/Xog XULFsjbimk31blaek2pNg734NXewZJOlGq5/CMGp4y6Pkj2GZDoJS3SXb orvxZoY76vIRt3l4oAgCpJbOwgd+WJE7RAVn+hlnUdZsVYbz1vTgLdf3V HJDpH93NG36g4REjOIatPhSxwnDZVVdvydoqEx4jIRzmQyiwVPk8dmWKF g==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="354474563" X-IronPort-AV: E=Sophos;i="6.00,174,1681196400"; d="scan'208";a="354474563" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 10:28:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="702214993" X-IronPort-AV: E=Sophos;i="6.00,174,1681196400"; d="scan'208";a="702214993" Received: from nroy-mobl1.amr.corp.intel.com (HELO [10.209.81.123]) ([10.209.81.123]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 10:28:58 -0700 Message-ID: Date: Thu, 18 May 2023 10:28:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 10/20] x86: xen: add missing prototypes Content-Language: en-US To: Arnd Bergmann , x86@kernel.org Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Juergen Gross , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , Peter Zijlstra , Darren Hart , Andy Shevchenko , Boris Ostrovsky , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-mm@kvack.org References: <20230516193549.544673-1-arnd@kernel.org> <20230516193549.544673-11-arnd@kernel.org> From: Dave Hansen In-Reply-To: <20230516193549.544673-11-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: gg597jypinsxy354c69r1msmy11erpdk X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 131478000C X-HE-Tag: 1684430940-772222 X-HE-Meta: U2FsdGVkX1+FgoyCRgwv2Nc66LjhT/7jR8hvJo4SA2Sg71N+AJ+7+KK0dRNL4adzNmimOOoymItPJOjFciUgFuxKhtcWAOCSSSlbcAxJo/l8pjCTJJaA/cdmWKxrLjwLjsR8UO317pfZOIzCSdtmUZHqcJzyyqqrvX1ALsJA/1oz9ZnPAKWF1GomD4HdRSij/cZ3radsdNhY0daZwBtPR67gqgrfRNb3dcd8KZ8A6U2YRy+7bxnhkScOz3X8gT4u7CRtCkH1XslTN8N+ZTyn0FusGMUAuoocxYbQQxnJErljwNEUumx5XRuN8Y16NeIlYUZAoNTUQoFqY0R4zClMeB7eyy8nJBn16yHygyQ2JVECjftYE8tD25btOwu1z6L0fUQanrQTFfHDB1LryLDYeQnMCS6emmazIKCIWS7rbyxfFKAzm2wZmpPGz+NjtuLhPuv69qPTdyrG5SjvZZ6Gp2FPK8Nlomx2osEbZrPloO1uFomQmM7/1KRv5nNHHqhxkZs2yRhbwU6Z836zjBGOZKWYbhWPLAPu3eyiq/EH8c2WEM9DEOUW2NyXWjco3QIKP9LeiHfS9QdjMleWAb8WQpbsL/q/iFRbxjYVS4MYJmY406ttOtLE1L5HwBJbv+Djrnr1L+YSQaBN3H8V9dQ8V3cUTH3w1XOjG350mccBkQq5efCL1BgNhWztMs54jrO9xrF9pa3jqC6hjCY4v/NQDKHCNqTz4r5AGBg4s2iywOQWh6x/K9ER8O7kbQzSxy0cwuuH0NwOkVqX9mkl5GTc/7qMuCRCrp5ixomcQIv1wQF4ZiqfUDBswq3F8Tchx5H/r2SZJ57Nv3GvumQoYvS5RYhj4hlwQ8pY2JyzKSMimI2WMCg3mkEhdpd8BfggxdvgomDN2uWCn4A9Ji5u9FxE8IKgm/GCz4GJw7Xk/KDGUJxz+/sySLw+nw50hDq+NRrRIsi2bu1eA8MjG6E/Rb0 O7YhZraH DEnyu3qtoc8T1km7kDK+fTeMv7NtMJeynvowkJGSGXAmgoi1kg3VgtKiv3RyxR3N4SpbDX5ylLAe1h18MYVLrdH66D9pn5TWtJgRUPk6nG/8St5XLhN+6Xzt8dsvIgnZ/6c5JYNdulLMRpG4RwJ1eFVO5qQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/16/23 12:35, Arnd Bergmann wrote: > From: Arnd Bergmann > > arch/x86/xen/enlighten_pv.c:1233:34: error: no previous prototype for 'xen_start_kernel' [-Werror=missing-prototypes] > arch/x86/xen/irq.c:22:14: error: no previous prototype for 'xen_force_evtchn_callback' [-Werror=missing-prototypes] > arch/x86/xen/mmu_pv.c:358:20: error: no previous prototype for 'xen_pte_val' [-Werror=missing-prototypes] > arch/x86/xen/mmu_pv.c:366:20: error: no previous prototype for 'xen_pgd_val' [-Werror=missing-prototypes] What's the deal with this one? The patch is doing a bunch functions on top of the ones from the commit message. Were you just showing a snippet of what the actual set of warnings is? Also, fwiw, it would be nice to have actual words in the changelog, even for these maddeningly repetitive series. Even something like: Xen has a bunch of these because of how the paravirt code uses inline assembly.