From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B705FC369C2 for ; Fri, 25 Apr 2025 16:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40A5E6B0005; Fri, 25 Apr 2025 12:17:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DDBB6B0007; Fri, 25 Apr 2025 12:17:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 258B16B0008; Fri, 25 Apr 2025 12:17:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 081F76B0005 for ; Fri, 25 Apr 2025 12:17:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B61B3813CD for ; Fri, 25 Apr 2025 16:17:33 +0000 (UTC) X-FDA: 83373071586.28.C83D57A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 31DA2A0012 for ; Fri, 25 Apr 2025 16:17:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C5NA4jM4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745597851; a=rsa-sha256; cv=none; b=OBBXOXEiJzIgeHr4gnCPPyQ2AsWzAnG01t1zsBdUbpm8uGrIaFvjjy7qEQP16f1wQZenCE gDOjhYDwWu9JhbYjMa4vihdqkgeqFPN8m41uyq8mRh4c2Ch7zQkjZoVpHxg1+55ciBu/jT 094WhEIwRxQzVUSJGHuuV8YUE4uY6Mg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=C5NA4jM4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745597851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b29eryv/5AAWJSs47U1xXSbFp20tCYH/BD5vHiB/9Ko=; b=Z5737AGZcpPSyk8teVC9FAPVFTdMPaDTdCyUpmFn94DkjOMGuHY41l600Ghh4p2DdcQtX+ w+AdQnJ/JmpoCL8bP6VQYusLpfXGul3CbuOiNkotm6Y0AScxHqZ/h7HHCrnUeq4jfj4+A5 qSdJpqoYVudyj7bbsDBCxtroN/ppkHU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745597850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b29eryv/5AAWJSs47U1xXSbFp20tCYH/BD5vHiB/9Ko=; b=C5NA4jM4j3Iho/kG80Cy/682WHArTrhxF9z1gcT1ofUHTztYnHgru88qYZf4y/2YZgKNx7 ctgOrJhVzzORAK/XBWi0JZyVXN/9gI6DHM+MrZeWytgpwuntJvlVSSYGN0E4k5jXvzg1ws LLTM+rfbs5doAIzKu0Djs+1x/xqf2G0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-3E8RKfbmMaWPNErfFmVxsw-1; Fri, 25 Apr 2025 12:17:28 -0400 X-MC-Unique: 3E8RKfbmMaWPNErfFmVxsw-1 X-Mimecast-MFC-AGG-ID: 3E8RKfbmMaWPNErfFmVxsw_1745597847 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43ea256f039so18031615e9.0 for ; Fri, 25 Apr 2025 09:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745597847; x=1746202647; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=b29eryv/5AAWJSs47U1xXSbFp20tCYH/BD5vHiB/9Ko=; b=oEykIEeFrO83HnEEGCjIE7IvRgQdSYGSu4jnVocwtiu+oZcq/ARql2oW+OXU8ObfLU EEhvtltnNyUMZYUR91d4MMotmSWZ//TdoMc7Dkn9qfX/tOiTaONvJZSZxoCyuxVci8Ph waY3G9ilGn3g4tWcdTpNvDzCN3sJZteAHeqa4ac1oFQ+eRf4n7x5zje340UHE3f0NXCX 9/8ixSTBE9BfitNX5qDBzVxKoat0NE4VmBIS6HGdanRiDk3ijWxK4GjLiM4ZT5DLtDbW Gnytt7nkQDyTr8f8aCTpPFHo4FANfKDuuc4c4+ie0pGxY137wto9Tzr4BjBxMuDud7do 3y4Q== X-Forwarded-Encrypted: i=1; AJvYcCXR4XYI0AzLSLKVli0gxZ4Rdh7M4jt+BZhHva/6JDfAiWlLsQzupxBg+8GNM3bFxwe3lhsnvdMpjA==@kvack.org X-Gm-Message-State: AOJu0YyUWiqpn1bJY3XiKJvIlSrmnNAZA4Su9nSGAOJWYJmzmswrBPQe lVd/+TOrqBMk0FOuI968y7yhbmGgD+C+cDqrV3hMl4BAlKh5rphZj1+jSsU1h3fPKwU6UpoMbUn h7x7jBFwfy3FawXA7zMU27eM8P5HZSk0J5ES1nGd8l+kYDHTQ X-Gm-Gg: ASbGncuRitf9J1C77AnqIyevGjyJH8UhTHlVfrOFBS9ga86WT0kCcxS1O8+PMYd0yox 5TwPhsVzfMs93fLHwHqak/m5c9WWxIKDc7/BLn6JJDBKEPO5V5isp19U4HeB+kXyN6BmFf8LYQX HuzlUmiY0p4TjF8H/LB1Tc7TvgRGHCj91ngdnXO/SxKUbnrE0R5dbQwoHmLmN7wL2VG9YmIWmuG ddg0gu1Jwnuy013OKT1ITbtUjBpyJRgDA/r99tP2aREaa5VrnKM95/gXNUatWHJ531h2k3mQrcj 9LihdksTXRTGQs9iJK4m6BdXQvNUYbgcBOePMfitDEjK6lfxkQFs2CxzulTYbILTEld373BRFPa N5c1oTLg6jeoasIkiDgHwqDXL4RxFOagQ31b7 X-Received: by 2002:a05:600c:1c0a:b0:43c:f6b0:e807 with SMTP id 5b1f17b1804b1-440a66aba2emr31976885e9.31.1745597847124; Fri, 25 Apr 2025 09:17:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUpSeFkaLb/Bim7f0WUY/4VwJzME7Xo2p8Q6+jlFDBeIyS8dvjIoW4jh0ONrBl6RD4okp4iA== X-Received: by 2002:a05:600c:1c0a:b0:43c:f6b0:e807 with SMTP id 5b1f17b1804b1-440a66aba2emr31976615e9.31.1745597846752; Fri, 25 Apr 2025 09:17:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c70f:6900:6c56:80f8:c14:6d2a? (p200300cbc70f69006c5680f80c146d2a.dip0.t-ipconnect.de. [2003:cb:c70f:6900:6c56:80f8:c14:6d2a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5da4dsm2788208f8f.99.2025.04.25.09.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 09:17:26 -0700 (PDT) Message-ID: Date: Fri, 25 Apr 2025 18:17:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-8-dwmw2@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250423133821.789413-8-dwmw2@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: --FP6INXnx4ZS-7MGOjJZ-udfR83ikWBqcsECl-yllQ_1745597847 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 31DA2A0012 X-Rspamd-Server: rspam04 X-Stat-Signature: xd59it1rrqcmwuq67a5s8c677iwsrftz X-HE-Tag: 1745597851-196413 X-HE-Meta: U2FsdGVkX18DtAylDJjDB4jpBwZ/eOtr9Px+JPhG+Wr8zzoS9L8OXC1mhtS7XkK1W1xXayh9Iz4jAwfl2lVDJQzJeYckDQd2G4aEhmjfIp9ijKgkGoriOcbJ+ia/B+Q1vfP93xee5kzVNL3rhtFp3C/Shn3M4eZIW6WwPTi4pHtA/lTfN1p3PkViSNq2NOZWT0Vj6zel3DjVbnOZ2a6eSSaofbyvIQHMMPlL3Dty/wcV0SPp8SWYa+drBW9RMrKP0On7Vc/ESn5Qrp5DFrWvk5uV+qsrpwlOHeVc5EaXVLsvHg9QUETC2KElF0DGvB0VEQa5u9wOaNNf8YSdrUXDn0Tgj+I/a/TmXZaAAx+Quf7BMZfL9RHvpb/GvzvjwTkYqVyAzYNbIUQ7AgaJYyp20Xt9K73H2u945qEBJctqFJh7IuiCJO1PWU/5HjEUlXtoQ1F0fW1tV3iS9x1O+q82Jl28Hr/l9zejubV+BBo4uyEx2O1BFvyy8lncILSj/MyKagqyPSynEVQmDOQZov8PRrLN/HewOwG4zmalTG90E+uyst3a8f8R52kukF5kBccn6MpM3v1NAWbKAjH+khIDRaQy/SGlvGBJlhX1Iax7QMFAJDKAI3RVykWCqoO/B7ulYVNdNt3R9lfXIjy+Sqg3S7kf/lCnehXX+2V50SB2SMNdiojYY8bER3TE0WgkfjPS5rcs69aOpVqJEr/Z4j7j7+QFi8JEW6htZELXfvpaxG/ttR4CU1lHY/VVMeiE/+AU2YC3HIM+XTs/CWaPoeCiKT7I4df2rUxqPGemAd9gm/kz7MJHTlT/T4qVZbIB0QrVReGMRFbvvsiNQ5MqTvNgh4JbYwytfJD7OFJvX5lBvfELcS5y6uE4OQHQKyMcD9QYVYzIzbByMQzIfXq9RpSswXvs8muZzQAL+ww/Bw8Dq50AqpXnygN0yArmmACPdrrMpoPPe6CUdEebppYRGO5 XsnncDdD 5UZvikYiH6WQ795Sqa4dpweeEOuAQy/AN8yYeICgIzZ+n24JqC8hCn3nzS8tcq/XPCpr2umdnzFmiaZwLpCWOFBS9espaDizLg7EQ9Ys0LGoH8ucEsgmFl1sKjNwvzNki8vuGivtywYOG6vd72WgjY2/EePyKAFb6G+RKjCukvWwzTEKXJIyYMyZJkHInqes4iChqGMbP1ia2iDWf5noSdd/NQtji16sfeNeSxNVRq+x0PlWZILezgXHRih35a/EaOaieYfeR9QhCjJwoki4PrTcphDKK6I9BUiGpxlPCcPs5wxqL/ncPOwoDmSR6F1KwbFIBE623pwCzX1g9LY0/CKPOAA5Aw62pYRdYhKd1I6SU/N+BriRA425glLsrZ8c3iY4zzwz83YwfYFWHF7SsIXC2Bi5lienpeNuVxoBNIZfn3tEA92E+3FvQcaKK5+irESrVK2kJEyFBoyLLOwCEbaYUdOiAWHUv97zaLaZYSaCVco3EN2mK7uizYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.25 15:33, David Woodhouse wrote: > From: David Woodhouse > > Currently, memmap_init initializes pfn_hole with 0 instead of > ARCH_PFN_OFFSET. Then init_unavailable_range will start iterating each > page from the page at address zero to the first available page, but it > won't do anything for pages below ARCH_PFN_OFFSET because pfn_valid > won't pass. > > If ARCH_PFN_OFFSET is very large (e.g., something like 2^64-2GiB if the > kernel is used as a library and loaded at a very high address), the > pointless iteration for pages below ARCH_PFN_OFFSET will take a very > long time, and the kernel will look stuck at boot time. > > Use for_each_valid_pfn() to skip the pointless iterations. > > Reported-by: Ruihan Li > Suggested-by: Mike Rapoport > Signed-off-by: David Woodhouse > Reviewed-by: Mike Rapoport (Microsoft) > Tested-by: Ruihan Li > --- > mm/mm_init.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 41884f2155c4..0d1a4546825c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -845,11 +845,7 @@ static void __init init_unavailable_range(unsigned long spfn, > unsigned long pfn; > u64 pgcnt = 0; > > - for (pfn = spfn; pfn < epfn; pfn++) { > - if (!pfn_valid(pageblock_start_pfn(pfn))) { > - pfn = pageblock_end_pfn(pfn) - 1; > - continue; > - } So, if the first pfn in a pageblock is not valid, we skip the whole pageblock ... > + for_each_valid_pfn(pfn, spfn, epfn) { > __init_single_page(pfn_to_page(pfn), pfn, zone, node); > __SetPageReserved(pfn_to_page(pfn)); > pgcnt++; but here, we would process further pfns inside such a pageblock? -- Cheers, David / dhildenb