From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 174FFC77B75 for ; Tue, 18 Apr 2023 12:36:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D0E56B0071; Tue, 18 Apr 2023 08:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 559978E0002; Tue, 18 Apr 2023 08:36:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 423628E0001; Tue, 18 Apr 2023 08:36:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 338B06B0071 for ; Tue, 18 Apr 2023 08:36:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EB37D160275 for ; Tue, 18 Apr 2023 12:36:57 +0000 (UTC) X-FDA: 80694461274.06.DEFAE20 Received: from andre.telenet-ops.be (andre.telenet-ops.be [195.130.132.53]) by imf19.hostedemail.com (Postfix) with ESMTP id 3FAC41A0024 for ; Tue, 18 Apr 2023 12:36:55 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=none (imf19.hostedemail.com: domain of geert@linux-m68k.org has no SPF policy when checking 195.130.132.53) smtp.mailfrom=geert@linux-m68k.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681821415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4MoW8VfVZjn0jq5dVdA4m5w1c3mJQHG4dN+YvjNpMqc=; b=sAVJ1vjG7mgB/JCCWHQ7/a5MN3i4xB7oh5B3HDiwt23kkNhbNfGu4h/BnX4gy8OzDKAeUs 6NZy2K07e8q90u+TbIz9/SdmLKk5m5EmPheVxhk729yj9mG0LzzFOXTVjBPLiYdzbyjhuI eQmuGUZvAdgFRSuwQiQydcpM7vYP9P0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=none (imf19.hostedemail.com: domain of geert@linux-m68k.org has no SPF policy when checking 195.130.132.53) smtp.mailfrom=geert@linux-m68k.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681821415; a=rsa-sha256; cv=none; b=Y4uKM3r0qnqTp5Xj2C1VmO9eHqO11SIH+roBnGgckEePrQwrtwWmVKvVLOF/bfwfJl+VHd BueZM0ZbQG4r5WZ4aNHaaq08C6/CNaEiqABb/PliSG5Qn3EbmpXQtaOYjjr635OjfBH6cn ZVeJWR70TLPm1j3wXhA3Ne2Ybjo5y0I= Received: from ramsan.of.borg ([84.195.187.55]) by andre.telenet-ops.be with bizsmtp id mCci290131C8whw01CciYR; Tue, 18 Apr 2023 14:36:53 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.95) (envelope-from ) id 1pokZe-00H56B-Ey; Tue, 18 Apr 2023 14:36:42 +0200 Date: Tue, 18 Apr 2023 14:36:42 +0200 (CEST) From: Geert Uytterhoeven To: Arnd Bergmann cc: Andrew Morton , Arnd Bergmann , llvm@lists.linux.dev, Vineet Gupta , Mike Rapoport , Nathan Chancellor , Nick Desaulniers , Tom Rix , David Hildenbrand , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Suren Baghdasaryan , Naoya Horiguchi , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Biju Das , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] [v2] mm: make arch_has_descending_max_zone_pfns() static In-Reply-To: <20230415081904.969049-1-arnd@kernel.org> Message-ID: References: <20230415081904.969049-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 3FAC41A0024 X-Stat-Signature: fdxgm7is4ct9sqykbtfemi46psboucfc X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681821415-701446 X-HE-Meta: U2FsdGVkX18cdBvuz39kkA2Oc17zMl1uKlCHJSKmkyy8vUmXv8uZoAUu/I8g/zjySJFo8JsYifTxWok6NMlxvVY4lNZyzgZRT83JjxgSrwgpJtfNFPiJ0taswTmADGqLpja6DzCqgYNKG/eBrfL6MXcJnKvBxKsDhwIqasVFDpDJQ9MV/EhyTyEYWXxEv5q7r6ysOC5R5qO+lMiGtHgRyE35Xm6L0rcwZXRnbeOqCrVAB3YLwB9I/VvVh5gaXVDOpSvBFRzUgyj/r2eO3tqxGCITFJLS8yHig5jx1ayeU+KMJtvpOP827afx8Bp8Z6LTCOdFEjCez4vTS56W5g08DSUQNRTaFRFzlGJgjuIPnUu3Gi4D+vN09ibQAKdRGk08jZYKo1k35PZRAf+FTULr5KE9MoFfgmBmGS1bT94FoUx2EV6IQ3+YLeamJjddb13KOrKRXyjkzHzHl2xXKzySqji6jEdV5aPTi3MTf9+uC9XYQGoFw1EELbqfCOeYXJBjXwd9tecaJAVQkntYnMNdou5H2LW+rH65a1BCC09+ZtONSI04LAdeW8DQQyoF6Ut03E6BbQDbyeOy9Y+A0yAeD3649IsFyyPNeDaXyd/n764VjiItRg4zWINodyzjrNy0M0igmkhfTfmUO17JgQSqTdrhYi8HGOntajLu6p0396y64801adsDb7c/nbpJgZwpqrC1nQV8CwmdPihgh1DYq8PkZPxVkyHfN2ylXyWOcv1mN7TORV2S8Nkg91x0cgKcUNSk4QkZZq307VxEd0kPylhyQQ5bJzMlrOpIzlhEjswWl3TL6DQ5vCt+KvFNEBggMuoZTh3HjIeUDVtVxhN/F8xsT/prNEennFp8VgyQcDQrL0iLpL4oZEnd4ajlQh97d8wEoFx+n+3aU7I3DH5oQPejmShlDuogsLKd9q/HD6DeCO4Tyr+6t9kbYQuOJ//DWXhPTYQ+2pTxccwArUT 0qSKYPoH mkJ3cmHuD9Zrrk4Pb6IL0gyNM/bUKoWLxs61VGZ6L3s/LqRAGYJg2eSC292PHHw/IeesV/kpID+ABHGUyvAt49tP9MQS1UMqGLu7Hzvqpyvs4M6wDMlLQGRY3GnWan/WsaMo581eKUd/G1/+1t6jEaS3BAtV77L93LWv+xcB+PGIXudFStPgT/6g5EUPOFsKnFhcteDIwN6TrrEemUBgV6x/n96vs6aCEdPmJK1ifiv6K8J4kVlBc4MTsnhp16IKudpjOT0w4YwPC3aB8Ao+el/VDJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Arnd, On Sat, 15 Apr 2023, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang produces a build failure on x86 for some randconfig builds > after a change that moves around code to mm/mm_init.c: > > Cannot find symbol for section 2: .text. > mm/mm_init.o: failed > > I have not been able to figure out why this happens, but the __weak > annotation on arch_has_descending_max_zone_pfns() is the trigger here. > > Removing the weak function in favor of an open-coded Kconfig option > check avoids the problem and becomes clearer as well as better to > optimize by the compiler. > > Fixes: 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c") > Cc: llvm@lists.linux.dev > Signed-off-by: Arnd Bergmann > --- > v2: fix logic bug reported-by: kernel test robot , > see https://lore.kernel.org/oe-lkp/202304151422.5e4d380b-oliver.sang@intel.com Thanks, reverting commit 413d478d3b366d09 ("mm: make arch_has_descending_max_zone_pfns() static") in next-20230417 and applying your v2 makes Salvator-XS regain its DMA memory zone. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds