From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86E8C46CD2 for ; Tue, 9 Jan 2024 13:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13AD6B007E; Tue, 9 Jan 2024 08:03:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC21B6B0080; Tue, 9 Jan 2024 08:03:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8A2B6B0081; Tue, 9 Jan 2024 08:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C664D6B007E for ; Tue, 9 Jan 2024 08:03:53 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 950CE1C1217 for ; Tue, 9 Jan 2024 13:03:53 +0000 (UTC) X-FDA: 81659789946.10.B95AF24 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf27.hostedemail.com (Postfix) with ESMTP id 5A6E44000A for ; Tue, 9 Jan 2024 13:03:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf27.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704805432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/svxzZmIh8j0CHFFINhIgyBxdrk96PaZOTl+A6ApJOM=; b=8NwDu3HWd7gbAEDFM0kIoYdw75DgRGPEUyFCnRLLKrzLeKCnURmdMhnYR9RfTsiKLYGtn+ lNU50yZAv5ELOd3tu/GVnVTEbwTLr81KAXcGsRVm0IWVk1ZEJjji8E4c2s49RLKURJRWmv 6NAmG/ay30tNCMxJhKCyJEpRzcQ1Jf0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf27.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704805432; a=rsa-sha256; cv=none; b=eq/+wT8pb6rGNNadIqYOZoNzQLrjXJmQQdjBs95wuHsuwvjtkyOGIHRMj5jHDnJfhzHagp Nk/hA6BqXune9DeU1dj0jiBk7MCNZ6WGEBhMFI7LOM8Z2SNgfF+29Ienb/SwY+yUselhU3 QPiiFpKPYti4wjV6bJfEde2NzDFGX7A= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=27;SR=0;TI=SMTPD_---0W-IeJTb_1704805422; Received: from 192.168.33.9(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0W-IeJTb_1704805422) by smtp.aliyun-inc.com; Tue, 09 Jan 2024 21:03:44 +0800 Message-ID: Date: Tue, 9 Jan 2024 21:03:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] cachefiles: Fix signed/unsigned mixup To: David Howells , Christian Brauner , Jeff Layton , Dominique Martinet Cc: Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman , kernel test robot , Yiqun Leng , Jia Zhu References: <20240109112029.1572463-1-dhowells@redhat.com> <20240109112029.1572463-6-dhowells@redhat.com> From: Gao Xiang In-Reply-To: <20240109112029.1572463-6-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5A6E44000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qux4n4gyj5mmbtt4bct5u439shm9etd3 X-HE-Tag: 1704805429-73052 X-HE-Meta: U2FsdGVkX18kLJqhYrUUI1KYxVBedveS7BWNFCTcK81E6c5bi/eFPyacz6YHer71UAn8rLmSGk22ZIdJKqUzyXW52Y6GQTlWtXduSA3cLCjzqFQCWrEO3o25HMqeWiMSxO7witaB3JAGVofmW0Dty3ZrbJzczgAQLV+qNDVxyRrjYtQdfLfE4GjnRdpLw3L5VaXeiGyD+xqaEON8TgHh8Hcx8GyqAfDBX18hkBXLHQk5CKXbtbJ/fYebq8cI6UOESw4jXt7Af9MkzuLDtXCnAh74vcrVKNWn+tAn7LfsrG++p/QnAW865Y84ftEpooQShqBEINOQR8gPxQYpm5rSD0go9dpsnEK3Jjjqf28hauMfHlaPdUhPphj6hvF2TM4p6wWwZVEIoyj6iSSBvLX/uNuplMi4nJYbJUHEql1IDnt0BGafJ1PWnmubwaOGI52BRO+HAZw5Z/qAXcji8sLh1bdg9vHPlqJSwE6wDs8XgBUON29VFA2rtm7dps4GmOHKoH3PLre8qutMz06O4w4qeMPSOcxc009hVN6UKTo6P4lNkN3iuM5IBeY8uAr6RyMk3LQmv5CCSO/B9wMdRWyeXO9+4832p+UvtGkIUZGwOoYJoNGQwt+Xq14u5blyQ/PnBEcpGrqk8HsLY57g/3awN3BoqcFEZaF5edyMju6eUkXYXsS+5oCItax4Rb4dv0pD6JRTeyTp+QBavkIICqgr0yp+YbaoFQfQZT8ryS1BrU1wY0pDzjOzZdJ9+KELedD5xWt/0c7rUwzlwrKnEkqUP63LogY4siY1aWdPY8BGOm0Ss8Iv3MlQVCFfkzfp0w4F/bJVsFNokkn8j8kEvKDYz+4mu0L5ba9cX/hzL+k+Us/XPVpdsTL9ncSRpOx6iG+w7WHoaAJv2Q0Z14p5MfezOrO91P+pne6sZGuYItHvYqvBMBaGC90GRWFYGMt3qk4652fCyvKRC22nWkNY4ca GJUt99rN Z1C+sUqbUJyCY3ZMuGxcGgycgs6dL61yR3ZBAeWoFZfhtcO1oWjojNEx3LDyDKR7UBGS8POICBNWREUtXTh33TgeUAX3blzZ5se8v4q9K53zN+HKUmjNoQqlSeBNNWMtqpmlVhcVm0W7hKHvaobTAB5kbbIscbB689ZEFjm9QnduoDwDAN5ATSODHnnXZxcz+B73sSs41vmfY9TOlcx7lPJaVLlRq1BR7JMgtZMyZanfOT+rPqk4kIVF5jNVjE1ZDQcwbIqy1payl/hlDvCrlgoQmTdQ70x6EEpYePYvGu406lGWP40IVnx83Y30/5fItl2bJi2bwqSYJMTKF7AdomAno56W5WIdLMcVYDNKlZLwvauP9gIBFF5SzXUsfXsRaNpAAUBlg5uDO5qwGiGwCZmv/z0ig+m5ZQr0zYiJ0WVYZ+JWDdm18xY/JCc6Ty1T0p+Ql20h/5oBXIDY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/9 19:20, David Howells wrote: > In __cachefiles_prepare_write(), the start and pos variables were made > unsigned 64-bit so that the casts in the checking could be got rid of - > which should be fine since absolute file offsets can't be negative, except > that an error code may be obtained from vfs_llseek(), which *would* be > negative. This breaks the error check. > > Fix this for now by reverting pos and start to be signed and putting back > the casts. Unfortunately, the error value checks cannot be replaced with > IS_ERR_VALUE() as long might be 32-bits. > > Fixes: 7097c96411d2 ("cachefiles: Fix __cachefiles_prepare_write()") > Reported-by: Simon Horman > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202401071152.DbKqMQMu-lkp@intel.com/ > Signed-off-by: David Howells > Reviewed-by: Simon Horman > cc: Gao Xiang > cc: Yiqun Leng > cc: Jia Zhu > cc: Jeff Layton > cc: linux-cachefs@redhat.com > cc: linux-erofs@lists.ozlabs.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org It looks good to me, Reviewed-by: Gao Xiang Thanks, Gao Xiang