From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2068C282EC for ; Tue, 11 Mar 2025 19:48:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E50C0280002; Tue, 11 Mar 2025 15:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E00D8280001; Tue, 11 Mar 2025 15:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7A2B280002; Tue, 11 Mar 2025 15:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ADE8F280001 for ; Tue, 11 Mar 2025 15:48:24 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 605B3A7E02 for ; Tue, 11 Mar 2025 19:48:25 +0000 (UTC) X-FDA: 83210306970.05.F8BF237 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id CC73F180008 for ; Tue, 11 Mar 2025 19:48:22 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TZNQizkN; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741722503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bq/Cwq4gBqnqnmgfvCPLaJV5Ooqfni9+hYzA5Bx/ZoM=; b=piutgA6Jf5PuLHxaGpMYUzftN0O4qWECVED3H2/P1Nr6I8ut4e+ioZE4bLyeNiBoYhp3CB d7VJnrqyb55KDknv6QIA6EMjwWvacDSZ59iPeGnTg3HeACYEqptWtuXorj3H1q78pRnq1A L23OUlPzY6ajw/6kA/9o7wz7tZ/VLUE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TZNQizkN; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741722503; a=rsa-sha256; cv=none; b=QAmDLrn5zm2e2rYPnwW1PuC22e7v/lky7LQhSuaO4NxsiR3sfgTN2mGNpGZjvfy3bwgd7v KygbTunbU8Xxvv1vU0F55aWHeteWSZjV1p50JbazcBuYBb7Ubj3C0gf4nr4xynyxDPxB2y XyRhEUItpeNdUPhwzAqN8PUVjlFxcKk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741722502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bq/Cwq4gBqnqnmgfvCPLaJV5Ooqfni9+hYzA5Bx/ZoM=; b=TZNQizkNHIuGiKJsL0mvICmPu7wTSAw9r9SOS8wrUrkfdJADKOfsTToqGDG2J18fO5nns+ +YTePAPwRLHpkUXk/9A3N6gUAfOSkUxJahWIf7+3v/exjlSxjeG3y39OUjT7cl8SeaxVcK 1AYGkSN/Ww44qzI+fVwdEc5FyN3XkUk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-baPZcU_iOjGdYegR24Wy2Q-1; Tue, 11 Mar 2025 15:48:20 -0400 X-MC-Unique: baPZcU_iOjGdYegR24Wy2Q-1 X-Mimecast-MFC-AGG-ID: baPZcU_iOjGdYegR24Wy2Q_1741722499 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3912fc9861cso2399353f8f.1 for ; Tue, 11 Mar 2025 12:48:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741722499; x=1742327299; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bq/Cwq4gBqnqnmgfvCPLaJV5Ooqfni9+hYzA5Bx/ZoM=; b=T32lCQ8dUW8H2tQFFMOFABvya14PgSx8sKBa/koVI1XUlSsE6/+DxNKFmN8Eas56CE /4g2KQW/RindM7zXVmK3q/Nht+3AeTkXh5ONcgz6x9ZymwDZx6MDVvNk6lK3FioKTFLE QnQmoOyCiCSv+ZZq+akTMM4ztt6HnQaI/2/bbnlD3qqcjUgrU8iWgSjFULUVVbnsEgpz htAYHihOXwmBn5kmPzVzoztoBYV0lu21SXXTmnQtzGU4sV2NmMf4pvNE2CArK5Cita/g OXvOBKoTPV12VHUIvusSLtNBdtd6dUikhQ7KvD6gFIpy47xihQ42e4KbVk2qniDt8urf AWkg== X-Forwarded-Encrypted: i=1; AJvYcCWRGWBjs2CDlN/Whl26Ox3a7SHr4AR1iLpSZ4AJg+cCRNESe6o5AE37HDp6qvrF21g/gdrJJn27qw==@kvack.org X-Gm-Message-State: AOJu0YwpPv4JCTP72WvOfXDJm/kkv/4IXxwzTSJtFk/32z40xmCIckNF MnB0uc1Q2LSFyL+ZNx1RZiTswt/L4ZZQVUqwZN5DP+TbMbgHk9Pp53zXY+R1WM/XSlGFdfger/h SxptTnPAxh6i8SdrrLXxWaz79+kag9Y2DchVEMTkMHgSQG7Td X-Gm-Gg: ASbGncuaw/4wC7zxr2c3Ug/3o0lrCaYJYD0xtXzGHLiUFu3Yr9E3e2dOTd23k1hpCid t32ywk22keAgcOo9hn2TBqp9t4i7xVIFgVFShzQje87cHRxVgIMIr4UP3xxR1eAj7QXfncvsYIn c8I845PQsTO1SKIC4/HmlQHBNbodvt6rb9Kd9WQbhlSpVGGcvnlUaOwt6+dDbq1GN5ywPLbELS0 8lR3NzOv4UxrEQ+Gsi5jCs8IJr/xPKeAZjEpRSbmz0ycbPT5/OgyvXm/gNJZy6BTwOrHtKtl9Sr 6RrseCEqx0DVA4M9saMyas0s2/R/sYlOpoJjj+XIC34T X-Received: by 2002:a05:6000:4718:b0:390:e8d4:6517 with SMTP id ffacd0b85a97d-39132d29464mr18979171f8f.21.1741722499287; Tue, 11 Mar 2025 12:48:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXbw7q00lvP1bt0vHZTQDKUmkfV+45HTfk6x4dlKMXo5cKKnUnNZxgtX90v/yy4e+O8qbDeQ== X-Received: by 2002:a05:6000:4718:b0:390:e8d4:6517 with SMTP id ffacd0b85a97d-39132d29464mr18979163f8f.21.1741722498927; Tue, 11 Mar 2025 12:48:18 -0700 (PDT) Received: from [192.168.3.141] (p4ff23d1d.dip0.t-ipconnect.de. [79.242.61.29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c01ebddsm19391570f8f.60.2025.03.11.12.48.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 12:48:18 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 20:48:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm/cow: Fix the incorrect error handling To: Cyan Yang Cc: akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311023730.56658-1-cyan.yang@sifive.com> <4a068856-328f-48ae-9b1c-0ec7d65dde6b@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UtrAL11aAn7ifn4hefinRfO1wBas-sI-i6d3ZM4j4VU_1741722499 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CC73F180008 X-Stat-Signature: icwjremkn3fe4rnpwst3pbs8pzr6yq1b X-Rspamd-Server: rspam09 X-HE-Tag: 1741722502-469939 X-HE-Meta: U2FsdGVkX19T0VO5w12GoB3CWHQfsNbQCq3DqsH7I+90PHvyrkRkyukTEkam2VeZ6SQZdYZgT26klhkSU2u+Obn8Iq3QlGuPS1D2/33cZMJ4Y4UwN8YQkow6csKJHN7+nxFTOEHfGnBp3Wmr+mV95oIfLrysWfzjZFUBGWAtdzH2FdluTm8zWiTfOTP+k18+NsqSswjVwZYMI08vMa9wHzH2eXX6KaLk0PcdYyY/6QD+uqrY47uYoW0lDpmhn4KkDOSNLE5+y3OQYrpWgRLxyG4u6Pl33yNHRP+6QO3do5GSztZQDdpk1aDjwBju+khpyJi74P8M//2hIBis5Id+TL2/RwhqhHRwjDU1LFHSL0LmsmKkbv5wH8g/haQTcPVvWSeIqpcr10SNIzHzOBQKLZJPWFSV5eW8dXzEX+0fmzwF1yk8fOs0MDXHcDbs4gisilHlDDCosV9TQK1nyvC7CgINI1520m2crKuPrx0tPc4Qs6SghKv5AUHlUHf8KJoMBXTBlZ//Z2BG+dWdtmwg0ybq4mLHVZYm+/D+TutnlZSnwmglj9NKo+4jNwNL5dsUA4b/70hKJupQmKpoEvdYYck9DpN3hhTZUG4tYtKPdpNvtA5Sgy8y78Ko0PSytlknZmvLlWUVcoQBUSifGPxif94HvJyL0Gr8/wgNaNu9jRxMZGrJU2o5jA80v22SCOeiwUekMGI/+1oECeG8gC9dT3/ij0x6d9XVnatNd2uEaLJ8dh3h0hny6Q0BSk/cBWA/5Ci89fu4FL+3P47suvubm6SUAmpg3hhFOkYtKYYTAMo7xI5K6c5RYP78CJgNrUrT1Jcc2blhq0Me9B98+Mo3JAZ1EupXw9iKBPHVIvFt6N/M7byAoxwPTFWXr1eg3aCk/wu/48CmsSwS2G6Pq9H3MEmPtz7JytrzzaQ8PCTyT+CKFp9GBkrK4vQuZz9oCexwL7RdhXrISj/XWszDgIw 6rve61cR KqLE9L6g9veurlFPKbfhhL5KhayHFYzml2DEyNDOPsODOg42yHu5TDQXcrATvMVfXbu0sAlyPJZrw0f4/6bQKE63KZ04uAGHxj2519BtwAi/TlCnMAywjmAw28ps/DfywQ4FZzZvF0y+R+C2UavUeoxNQS15TpI8FxX1q2phGiw/+j7eIkd7WyN+gpeycbisN2Ml5/ltcX76OBv2mWvOOSBYHP1tJywb8Q9Gdp57H4uh/9no6PXMfjDqOGrNVw9dWXI2DPas41VNWzS/t1U/JoAoa1MPcPKCDlJag8E1aJNOEVu4dtYhhuh7iwcKDVzt1G9U9sH11vR9cxFSf7psdl582ChV7v6Z/yyMCFHs/ochSVuawaoKpDft1nlFIjvSmGxb5Yt3S8R27dA8GzF4nuuAmWokkhK5g8bH3bA9Brse/L+ku20b2eK2gl/fcqRxHSijRLtTtPT+ZWErRwE5Gtk4smQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.03.25 11:38, Cyan Yang wrote: > On Tue, Mar 11, 2025 at 10:19:32AM +0100, David Hildenbrand wrote: >> On 11.03.25 03:37, Cyan Yang wrote: >>> There are two error handlings did not check the correct return value. >>> This patch will fix them. >>> >>> Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") >>> Signed-off-by: Cyan Yang >>> --- >>> tools/testing/selftests/mm/cow.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c >>> index 9446673645eb..16fcadc090a4 100644 >>> --- a/tools/testing/selftests/mm/cow.c >>> +++ b/tools/testing/selftests/mm/cow.c >>> @@ -876,13 +876,13 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) >>> mremap_size = thpsize / 2; >>> mremap_mem = mmap(NULL, mremap_size, PROT_NONE, >>> MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); >>> - if (mem == MAP_FAILED) { >>> + if (mremap_mem == MAP_FAILED) { >>> ksft_test_result_fail("mmap() failed\n"); >>> goto munmap; >>> } >> >> Yes, that check is wrong. >> >>> tmp = mremap(mem + mremap_size, mremap_size, mremap_size, >>> MREMAP_MAYMOVE | MREMAP_FIXED, mremap_mem); >>> - if (tmp != mremap_mem) { >>> + if (tmp == MAP_FAILED) { >>> ksft_test_result_fail("mremap() failed\n"); >>> goto munmap; >>> } >> >> As Dev says, this one is just fine. Leave it as it is. >> > > Thank you for the review. > > I agree with you and Dev this is just fine. The reason I prefer to modify it is > - usually caller checks the return value directly and "tmp == mremap_mem" > should be determined by "mremap". > > If you still prefer to leave it as it is, I will send out the v2 to remove it. Yes, leave it as is. This does not belong in this fix for a real error checking problem. Thanks! -- Cheers, David / dhildenb