From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B511C28B28 for ; Tue, 18 Mar 2025 07:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A87A1280002; Tue, 18 Mar 2025 03:50:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0FB5280001; Tue, 18 Mar 2025 03:50:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 888DA280002; Tue, 18 Mar 2025 03:50:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67BE7280001 for ; Tue, 18 Mar 2025 03:50:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9E95680E36 for ; Tue, 18 Mar 2025 07:50:16 +0000 (UTC) X-FDA: 83233898832.21.AE38427 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 45AB81C0003 for ; Tue, 18 Mar 2025 07:50:14 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t97zL5pA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=55dCasU8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t97zL5pA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=55dCasU8; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742284214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cUJjNqEaROXfP0ip7X2uVuOzSRfoFZxySuFvEV2R3Js=; b=WVw1qeH/Ucd9bZzMNGWqTk96MPj5Q4YnsIX6g0wq2/A++m9Np/Il++tHSZK3wP8wiA3FSP GF8NPzg/m62FkZITVqxqQSJcGCCYEvj4QalX8eIVWG4u92BiWMwo/aZKEn23HUL1LeG/K7 2rVJbGTNkAmshx04b4fHTv/reKwXWzE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t97zL5pA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=55dCasU8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=t97zL5pA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=55dCasU8; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742284214; a=rsa-sha256; cv=none; b=NvK6BD4F/wr7cLhsFx361w1SrOSGF4EeqNrf6RisrqAtAbekQiUDzhEQdVVJ6Jx+JNwx5F xJv8ZXrvC0yXqyphT9iteVW4uKpopKapCI82DnCnWWX+05zMa/EdkL6YTk4jTtb6imqBzQ ozn4elTZvNDggk3gkakiU5+M1GR8UdQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 32A6421A20; Tue, 18 Mar 2025 07:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1742284211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUJjNqEaROXfP0ip7X2uVuOzSRfoFZxySuFvEV2R3Js=; b=t97zL5pAnIvdIyrMSRmLPam1bF6XxvYFbxJjwpjrTj5/9DVwvwfQnCO60MEUtjgmrhAuAG hkmcEn9AaukzuM+DaOQKZcwk+BSBfMd4OQmTH3dvKCsgJjokP56mrys02V2GzLbgpTLicE cRlgkLbuh6BReQd6wUBOoy8TUwoQQBA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1742284211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUJjNqEaROXfP0ip7X2uVuOzSRfoFZxySuFvEV2R3Js=; b=55dCasU8IGX/wNW1Ck7pc2PYmfzlOpeDbzhB0+G1HUiabkgChdKDZSvnagLnIN7vl6uu2+ awg2IKRrhF5JVWBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1742284211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUJjNqEaROXfP0ip7X2uVuOzSRfoFZxySuFvEV2R3Js=; b=t97zL5pAnIvdIyrMSRmLPam1bF6XxvYFbxJjwpjrTj5/9DVwvwfQnCO60MEUtjgmrhAuAG hkmcEn9AaukzuM+DaOQKZcwk+BSBfMd4OQmTH3dvKCsgJjokP56mrys02V2GzLbgpTLicE cRlgkLbuh6BReQd6wUBOoy8TUwoQQBA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1742284211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUJjNqEaROXfP0ip7X2uVuOzSRfoFZxySuFvEV2R3Js=; b=55dCasU8IGX/wNW1Ck7pc2PYmfzlOpeDbzhB0+G1HUiabkgChdKDZSvnagLnIN7vl6uu2+ awg2IKRrhF5JVWBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E7DD1379A; Tue, 18 Mar 2025 07:50:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id d6UxA7Ml2WcWAwAAD6G6ig (envelope-from ); Tue, 18 Mar 2025 07:50:11 +0000 Message-ID: Date: Tue, 18 Mar 2025 08:50:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/9] memcg: use __mod_memcg_state in drain_obj_stock To: Roman Gushchin , Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250315174930.1769599-1-shakeel.butt@linux.dev> <20250315174930.1769599-8-shakeel.butt@linux.dev> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 45AB81C0003 X-Rspamd-Server: rspam08 X-Stat-Signature: w9ukj3yr9qhpdadxed9myoewfrffgsnq X-HE-Tag: 1742284214-446540 X-HE-Meta: U2FsdGVkX18bJpNGnKvrSdHfol6CXOt834X2e0iJYeBM0GhDZE5xXpt6X+s1JqEXgbfBMZqj4Ogmqhg6dZuV4vtVBOSmCtUxgEBjqBEyfkIYZ5kyXvpgPhtyf/M0wQifR/UbZ3evqi1X5CQuheRCBqG+cxtgsbsTq0veh3k38igkohMa+GBuWIEYndFplDMJ3Y0u814oBsT8/R6WaRxchek8hM+HSL/VQkMiL1GP51F7JngWRX/HgSidvzzNMH8FY2Ei/h/EViGw2zub3iVU6IHz5CMvsbVBrggovYk8NBi9gUX0YkIHifracUgYW3M7gBhJdGf9KDR9r20+dMW+VgtsRNUed4G0m+Khp0NL0LqB1PJg/1PZQ1qTtsAM6Q2ECL62b6TQ/zTPacxktsnx/ZIrSdmRFchnzl7eKTdZwQYr0gSwHGxvompTcIBLEGJfPM2bZInf7So0h2+ecnuBbmUknKwBBbhUSl8d5GT8YYwcD+qnCFac+qNlopMjjMG/qdhdhoR26dXGsfd/f6gevOFzCWGxlibh2kdZXLrddAtXhAM0CAQEydh+Mz+5Lsrs+dVXdsm77ojH/T94VgHrhI3SQJaGpXo0U7qU2IgpJ10XCnm5N09Y/TkLQqN0mTfUs88de8aeF+aZaajtxCN6t+5CtCpAmzGEtRYTF/8IJzk6UNHpXfrV8VOCcmaZfPCEp+xo0IaaBVsi9/zOPHE5amN472T8O2+eBL9uE9bUlPO8sG/O3bwd35augU4N4KpzT8CdOzV+MKFK5w6X6JNnaCjO1bHjXWXfwNyvax0taGKMvu5Up3SqUJlxPYehUVVcSSXvJGSq7K8kvDTklUUVac1BFCS20hbouR22IxnjBwWxbBrvF8zcOxQi8au3iWy2tZkQJDXVewzxn9/DDJ8eNWjkYC6MLqSPX7DHH6/gCKRufkDC8H+ilVNsWRXHARVFFaMC+oqlyBkf6ka8HKw e/a3C4Zn g+JrR+SkyLyu5mXhkiNAp2yDWJbHrsmO33kVKI3Md23Gavs8kj4MNriPDYcWNKY13sTU+yXx+jDdV5iqyEx9FlL384C4llOwvef12FwWPVRq60djsgLw62DsnsV+bQms1+1aEUkxBxIf1zJk8UlGvJJ1nb5Vztcr4YcVVcP/Re+nlUBrqsilJb+1vqm4DT9nGsAjNJue6tRgxDiSwt65WSZ9EjQElq3MAmC1Qke2opmJAvj1Wq4HjO7mly7xR4X14V27+yCm+ipsD5a8Sr9xDzTYLFpC/VGTgYZSNddxJoJkHsbi7Rh/y+P2sHI0pg0tzrN+TbRt7hyW08M8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/18/25 02:13, Roman Gushchin wrote: > On Sat, Mar 15, 2025 at 10:49:28AM -0700, Shakeel Butt wrote: >> For non-PREEMPT_RT kernels, drain_obj_stock() is always called with irq >> disabled, so we can use __mod_memcg_state() instead of >> mod_memcg_state(). For PREEMPT_RT, we need to add memcg_stats_[un]lock >> in __mod_memcg_state(). >> >> Signed-off-by: Shakeel Butt >> Reviewed-by: Sebastian Andrzej Siewior >> --- >> mm/memcontrol.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 3c4de384b5a0..dfe9c2eb7816 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -707,10 +707,12 @@ void __mod_memcg_state(struct mem_cgroup *memcg, enum memcg_stat_item idx, >> if (WARN_ONCE(BAD_STAT_IDX(i), "%s: missing stat item %d\n", __func__, idx)) >> return; >> >> + memcg_stats_lock(); >> __this_cpu_add(memcg->vmstats_percpu->state[i], val); >> val = memcg_state_val_in_pages(idx, val); >> memcg_rstat_updated(memcg, val); >> trace_mod_memcg_state(memcg, idx, val); >> + memcg_stats_unlock(); >> } >> >> #ifdef CONFIG_MEMCG_V1 >> @@ -2845,7 +2847,7 @@ static void drain_obj_stock(struct memcg_stock_pcp *stock) > > VM_WARN_ON_IRQS_ENABLED() ? It's part of memcg_stats_lock() > Reviewed-by: Roman Gushchin