From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EB3C021AA for ; Tue, 18 Feb 2025 04:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ADEC2800E3; Mon, 17 Feb 2025 23:55:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00F6A2800E2; Mon, 17 Feb 2025 23:55:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF0C32800E3; Mon, 17 Feb 2025 23:55:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB8802800E2 for ; Mon, 17 Feb 2025 23:55:07 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 66E841C6BA7 for ; Tue, 18 Feb 2025 04:55:07 +0000 (UTC) X-FDA: 83131851054.25.C9C1AEC Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by imf24.hostedemail.com (Postfix) with ESMTP id 759BA180009 for ; Tue, 18 Feb 2025 04:55:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.198 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739854505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aZtYINbEvnxNIMfumNwayjL+y65QQ2qcfJrVEgqAbz4=; b=4mqXzbkBQoZ9NRqKSCEcVy8tZqg5mDt1ZuXYB/zU+4JOwXhRzRamMTo9mFd0fM0czXoOcC ed8tzXQGdQrT7fFXnynjl7jNc4QBYVQMCBFCw3hz0kM+kolGTvdET3oEKqSxG1KWhhF9gT /T/kSTyfsK6CF4DxInIjGUjz5JtUNc4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.198 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739854505; a=rsa-sha256; cv=none; b=cU8OTUQ1euwJZkT8f5YlyW2DaeX/zD0DFKu96lNFnMZ6Xb6QgKr3d1VTKiiNS/8QuR7yi6 D5iTD3RZZGKIaVxZcqVU4xpOTYtJF1eput51icWoPUFuL7Lss65o6LwlM6K+53CakS6kqs fTokdyaD2eKOX6hKhPLPgg2DFyirD3U= Received: by mail.gandi.net (Postfix) with ESMTPSA id 135F544291; Tue, 18 Feb 2025 04:55:01 +0000 (UTC) Message-ID: Date: Tue, 18 Feb 2025 05:55:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: mm/workingset.c:621 workingset_update_node() warn: unsigned '_x' is never less than zero. Content-Language: en-US To: Andrew Morton , kernel test robot Cc: Shakeel Butt , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Linux Memory Management List , Roman Gushchin , "T.J. Mercier" , linux-riscv@lists.infradead.org References: <202502160323.ZLUfooA0-lkp@intel.com> <20250217202127.cf92afe2c0a89d5865e1811b@linux-foundation.org> From: Alexandre Ghiti In-Reply-To: <20250217202127.cf92afe2c0a89d5865e1811b@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeitdeflecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeetlhgvgigrnhgurhgvucfihhhithhiuceorghlvgigsehghhhithhirdhfrheqnecuggftrfgrthhtvghrnhepkeefkeetveejgfelheefvefhvedvfefhieegiedtkefgjeetffejueekgefggfeunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghdptddurdhorhhgpdhinhhfrhgruggvrggurdhorhhgnecukfhppedvtddtudemkeeiudemfeefkedvmegvfheltdemugeifeejmegrhehfieemrgefhedtmeejvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvddttddumeekiedumeeffeekvdemvghfledtmeguieefjeemrgehfheimegrfeehtdemjedviedphhgvlhhopeglkffrggeimedvtddtudemkeeiudemfeefkedvmegvfheltdemugeifeejmegrhehfieemrgefhedtmeejvdeingdpmhgrihhlfhhrohhmpegrlhgvgiesghhhihhtihdrfhhrpdhnsggprhgtphhtthhopeelpdhrtghpthhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdprhgtphhtthhopehlkhhpsehin hhtvghlr dgtohhmpdhrtghpthhtohepshhhrghkvggvlhdrsghuthhtsehlihhnuhigrdguvghvpdhrtghpthhtohepohgvqdhksghuihhlugdqrghllheslhhishhtshdrlhhinhhugidruggvvhdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhmmheskhhvrggtkhdrohhrghdprhgtphhtthhopehrohhmrghnrdhguhhshhgthhhinheslhhinhhugidruggvvhdprhgtphhtthhopehtjhhmvghrtghivghrsehgohhoghhlvgdrtghomh X-GND-Sasl: alex@ghiti.fr X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 759BA180009 X-Stat-Signature: zman3r6dudj64fue9rbjxai7ba31f9ai X-HE-Tag: 1739854505-569417 X-HE-Meta: U2FsdGVkX19+ECBv9R2n3dkJ+fo/aUHdwW2Rj7f4l2II4UumWqXw8uR8GmdeBgICfs/PWx4atS6CbtmlD9PCvHAO4XY5lUIHFJ+zuKffoKQ1BbC2vNGmrPnTe8/PNv+yVqY+aK+94ezJZToPlmNqZWTMz8+FPGegS56mrYAUuYfXADYAnN7LIO7XH2VLM74O48gAcW9wXRdeHaUQG9UX/BTNdglQ7HiwrMIuWiko+YoCi07hehZUAlSCV79D2XtKwExuLrE3+UinZ2Yo96aV14yk1+cOhjPhEyyy8iLUFUaMghy+nX6+IRZDzNc742yMFJ6PXvPB9UAabF65rdCCwCkv4HxepAKB6gDV8JHmFIqRGVmANWd80LVJf3+YTGkcB69fuoXW+JXz/6K6gRaiz31kJJSTFTP4Bzt+nrIo9u/eKOp0xvkIFKc6j9UgGuFNso5mIRXDoa2tlZzzX6UfLDx3x6Brbfmte6WX9o0rUoLOfUZUCpv4egQFQ1NTDvtlShZoBiR65CuqzqEz+k1Fp/XJMYn1Cr9TBG6nlkb0AXvr+sI8+1apfH93s2Vig7Ab8WaPTxRmZAtD7xVftBqJ8ofAKIxdzfmotAtcgSo8oYMIlCY8kcI2SHnYsvlBqY0pdOSWvQhBhlvq1xnFmr8Lfhbv1ir5NgVzfy+G7ORTtpVkYjfBPjP8ahjR+acoPTuXzvZPUhx0iPmzuK1W3L0tnvkh8i+EagBTx4YMY5OoiE6u4oolyeSswkUiH3cfa6uIwALoSWfIDO2D4dssaAJCBJqFjbMVcyT21dBbRNc/LUOnllcBVtj+F+tTvTogCg9O5lUc913iOU9rZUfMunpcbkbSNqRGZoUGqNQzoqgG8feS4jy+qh+cuZLPbB7YLRp6VR/8/+lYi1yP2Nx7F4fnM1sUnoOaJjDCUPGhlx//j0A1hRWExLzccxr4BAgO5IgeGsYI+uSal0tHSYVHQ7q Itw9QBdi II34ozYsf+CEH5tGlyNboix5rfS5DGjPctlI66Nr8+1/I/nks7uRWXzUFnjOT+1n40lssZKZF1HhZ0VBAH0//utm1oRc+szTX2j0eUrNMqVgQsrnIaeYNenQ4rwVksEzq8GB1af39pJ9RCQoszA1S+283ou0TPf5DbNE83mQhu3jWfnKbaTBZ7APi+cCVxev4G70pbx29swZtGZqtu9nYfSlyhifCuE0C0tJhWTO3J48Nem2LMH3+a3sf/qMlfePDI+LpEq8MO+BVo9/CLNjFKNXo338uYq0TjUVD/sl/OkipmiM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, On 18/02/2025 05:21, Andrew Morton wrote: > On Sun, 16 Feb 2025 03:56:06 +0800 kernel test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 7ff71e6d923969d933e1ba7e0db857782d36cd19 >> commit: 4715c6a753dccd15fd3a8928168f57e349205bd4 mm: cleanup WORKINGSET_NODES in workingset >> date: 9 months ago >> config: riscv-randconfig-r073-20250213 (https://download.01.org/0day-ci/archive/20250216/202502160323.ZLUfooA0-lkp@intel.com/config) >> compiler: riscv32-linux-gcc (GCC) 14.2.0 >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202502160323.ZLUfooA0-lkp@intel.com/ >> >> New smatch warnings: >> mm/workingset.c:621 workingset_update_node() warn: unsigned '_x' is never less than zero. >> mm/workingset.c:746 shadow_lru_isolate() warn: unsigned '_x' is never less than zero. >> >> Old smatch warnings: >> include/linux/mm.h:1306 virt_to_head_page() warn: unsigned '_x' is never less than zero. >> >> vim +/_x +621 mm/workingset.c >> >> 617 >> 618 void workingset_update_node(struct xa_node *node) >> 619 { >> 620 struct address_space *mapping; >> > 621 struct page *page = virt_to_page(node); > We're seeing several reports like this. It looks like the RISC-V > virt_to_page() (actualy __pa) implementation needs some attention. Yes, Christoph reported the same warning yesterday, we are discussing it since it is probably a false-positive https://lore.kernel.org/linux-riscv/Z7PWuSA4jtZnxp5J@rli9-mobl/T/#t. Thanks, Alex > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv