From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F15C4332F for ; Sat, 19 Nov 2022 02:55:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFEA46B0072; Fri, 18 Nov 2022 21:55:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAE148E0001; Fri, 18 Nov 2022 21:55:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4F016B0074; Fri, 18 Nov 2022 21:55:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B4F676B0072 for ; Fri, 18 Nov 2022 21:55:31 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7BBA9A01E6 for ; Sat, 19 Nov 2022 02:55:31 +0000 (UTC) X-FDA: 80148676062.23.10C8AD4 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2083.outbound.protection.outlook.com [40.107.243.83]) by imf04.hostedemail.com (Postfix) with ESMTP id 7086E40003 for ; Sat, 19 Nov 2022 02:55:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=On3IJK/pwcrQJDEEkDMxr981b04KtwnhyDZuxn5PjHw6+cnwf0uvh4K1x3dvResVpJjYvRL+1tIsuwJdAKTXwkDCwCnbueuPXKF08JjtBz+ggDtvJ6KisCXGySxa/hDRDERMSpjiwPpXdVWkQME7iJ7f2+zJgGTpodXc26YROt6JKGW+fzckXPxhNa8c6wLaJevn3FVk/szLxT4GLGVuorDJTyCedATSFBcDmcSMs4LQfcYOINadSM8fyB6GUILalMdaACqC1PoiLZlEAY2OiFDnsRDvdYF6KDyfCWIT0fc/73r2J9jAOFSi5PTcFB1WUk/2AP2PUxuArso3ftm/CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7i2ilkC3We2B04ERdLFqxE2SpnhdFiGuN+uVeuVF5Bw=; b=lK4PKmTTFfQUEjMWOjHJaY5BLz9zZBnoJLfefGLYJZO67LNfQhRq6WjOF1/6ts036NrzvPCi54BHS9ojv/P/okKXUiIF6xD+GUSY1eS6iHVl6+0or3jnHZZVV/yAN9e1rmtJt+Ukit+EMITzuZm09QICtgJ+4W6sUIvBWdKgQbnhB6cKVW4ktgYCBZ85FGFxaTyhseWPw61khKNkPRbNrRbqHcNeWlNQyMOLcb/xwoM+DOGmWKsD9/2j/R5cb5HGQuGKjZJ+eU4doWi0emgsG8VDcD1L3xrpu3tHO8OZtIP5fUxBAaEOB9uK4tpvHQ0u7c5yF9qVE6ohodDs+Slu+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7i2ilkC3We2B04ERdLFqxE2SpnhdFiGuN+uVeuVF5Bw=; b=lRcSFE0IIZqan/9LtyYWkgOOrJ5C/7BsqELwf8xJBJtAmfBmvXUxkHoN3WTsd/nwUJ1ptfFOLZceYlULRZjx51faT5nh21JLojWUt17Ioj62qtkXW8HmJ32O2GXffDO66CkwfQbv0yOt/PgKnV2c1PZlB+sY/ngtQVQtgr5l4FQTrPT2bigUaO1csim6fg5z4GWSCnRcVz8rBZp7E+fqmNlsqdSBM2+sU7FmyXVqdnaRhgPVyl/XKm2izMzh3/5Z7bEXGcbeaEheM+AR1vjXIEAV7cygIlXYfRnEdIQwMcf5HyYVlNTzxD22D1bfK+wUS8l9sPg4gvyOBFfPbxRqNA== Received: from DM6PR02CA0040.namprd02.prod.outlook.com (2603:10b6:5:177::17) by CY8PR12MB7657.namprd12.prod.outlook.com (2603:10b6:930:9d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Sat, 19 Nov 2022 02:55:27 +0000 Received: from DM6NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:5:177:cafe::da) by DM6PR02CA0040.outlook.office365.com (2603:10b6:5:177::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9 via Frontend Transport; Sat, 19 Nov 2022 02:55:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT042.mail.protection.outlook.com (10.13.173.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Sat, 19 Nov 2022 02:55:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 18 Nov 2022 18:55:26 -0800 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Fri, 18 Nov 2022 18:55:25 -0800 Message-ID: Date: Fri, 18 Nov 2022 18:55:24 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] mm/gup: Remove the restriction on locked with FOLL_LONGTERM Content-Language: en-US To: Jason Gunthorpe CC: Andrew Morton , , "Alistair Popple" References: <0-v1-b9ae39aa8884+14dbb-gup_longterm_locked_jgg@nvidia.com> <5c5f2c34-05d7-7e64-e368-0f240ef15eeb@nvidia.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT042:EE_|CY8PR12MB7657:EE_ X-MS-Office365-Filtering-Correlation-Id: ad1a0eeb-0d0c-49a4-92e0-08dac9d982fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rnV0Wvupvh5ZIGwTLEUDIbjWBRvx20iF+oddPEIBwJJKDyIDA0u17UthKBsnFl8s3pRkSeoon7JcEpBi7W+aylkAsGzdwtsMOmtaH6MUUJ6FqDQYxJMVumlO7rp2i0qLdjhhoXlaYFqIFfrnomecjTJfB72g8F4e3xx8qHvMNQK13MNXEZItDMybBMHMkSKN/uOnycvvNeejNNoelAOAHXM+PtT0wpJO9QX0NcHnK7/Mxkfz5n0kBwg34C1Ffs9MeaVYpmswK9zRJiVgEeGsAJJehrocy0HDh+04wNSHgVynYgxNH2bivy1DKBqs8xkTzEFssyuj7gj4WI+RJVrshSAPpdRHah+LHuR1OQw/EFdz8gQfMjYKP5aSdPg5kl2firkqbHJqgLiAjv9mtHxdDseZKrw6FL1uu2wwRJ6lYH63xd9btH5H/Mi46Vscz9YP5/DV+c/aOMTqfPgsj3P/Uf8WnkvxjL6MDdDBerrZbQhVMTDJkrweP2i3xTdt8S0uviu245NLgw4pagcxABSrqqlRjG/J54oxsRsNoYIU5vwOFxMZBNF1bLQT3oSmTeY4Bo1RFFfeiguq5nB/qt5RGr+UAV+pz+EYN86u6FSygPY0LFRqk+zub3O+T1dub5uqLG4TNVN6WfvoA6Dxwn7V39NdhulSl2uMtUz/7XjaqwCCm2VwFOxig/QUBM1GRgYDVhFUrSKCf2JwxSYC4HlNx4Wn8C5z/13Va6e1uENwmbZlDPZ30Xt35k9gEVbZV8elytfK4tOdk2+AmzRofLzEtO9qX2Q+ysVlDq1kMeAcqvxu4ase6Eq3lxgaUQ7VduhP X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(36840700001)(40470700004)(107886003)(478600001)(966005)(31686004)(26005)(6862004)(2616005)(40460700003)(4326008)(8936002)(36756003)(8676002)(70206006)(70586007)(4744005)(5660300002)(186003)(336012)(53546011)(16526019)(37006003)(316002)(54906003)(6636002)(16576012)(2906002)(83380400001)(86362001)(82740400003)(40480700001)(31696002)(426003)(47076005)(82310400005)(36860700001)(41300700001)(356005)(7636003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2022 02:55:26.7395 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad1a0eeb-0d0c-49a4-92e0-08dac9d982fb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7657 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1668826531; a=rsa-sha256; cv=pass; b=q0S5KRdHWuBIeqnjtMFYGbERNZHp/zjkz1tZsmP7qbMhLLF0rKGKv4n5Y11p/3dc9zJPF5 /6iGy7IGc+9bpD56C2pBhWS9Oa8QuHhZZfRMN7jWzeg8tdq8wtK7FCt4DdFoKjjxnkvue+ hXO6qdhMJWtxeSmoNUYq/YiruG2nW+Q= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=lRcSFE0I; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf04.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.243.83 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668826531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7i2ilkC3We2B04ERdLFqxE2SpnhdFiGuN+uVeuVF5Bw=; b=cN7KRJZPGKPH0C59YcOFSUDsGiVc47pVzrQ8nTXLbryY6zgP3BwFAw/KBnqJhl5RZbmncA 5rvA7PBVbWwqMKbfLH3XDdsnOk2z8rpyw0hNKiuh63SFvMUdWRrplwej8bpGQlVEDsqxCJ DGWYaR2aD2eioN9yv25CNViVGYToLtQ= X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7086E40003 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=lRcSFE0I; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf04.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.243.83 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Stat-Signature: fu3pfwkkio3cw7batwdb3qt1tnqg38iw X-HE-Tag: 1668826529-764889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/18/22 12:00, Jason Gunthorpe wrote: ... >> Even after this cleanup, gup.c is still a bit of a ball of string, what >> with things like __gup_longterm_locked() actually handling >> !FOLL_LONGTERM, and a bunch of other vestigial stuff, but this takes us >> in the right direction. > > What do you think of this: > > https://github.com/jgunthorpe/linux/commits/gup > I like it--this cleans things up a lot! A couple of tweaks I'd suggest would be: 1) Add an enum for "1" to the new enum, and use it. That will clarify the call sites in the same way that GUP_GET_LOCK helps. 2) Don't change the name of the is_valid_gup_flags(). Or at least, leave some for is "is_" in there. Because that makes the call sites very nice: if (!is_valid_gup_flags()) ...bail out, etc thanks, -- John Hubbard NVIDIA