From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 557ACC83F2C for ; Tue, 5 Sep 2023 09:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B315594000B; Tue, 5 Sep 2023 05:34:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADFC28E001A; Tue, 5 Sep 2023 05:34:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A7F994000B; Tue, 5 Sep 2023 05:34:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 882B08E001A for ; Tue, 5 Sep 2023 05:34:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 57BA2A0BAC for ; Tue, 5 Sep 2023 09:34:39 +0000 (UTC) X-FDA: 81202033878.14.54E9078 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf29.hostedemail.com (Postfix) with ESMTP id B7DDF12000B for ; Tue, 5 Sep 2023 09:34:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693906477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Glu/d+YHYytc96WOVrKbipxSvLvvjirw8JSYq+hClqE=; b=Ci3tga35G3vDpSery5IjkCrzI/lWrUIk1sejfPkJXqWDwDqJLQCQoCDaZZZXuF447gc82d 7iGFJXWsLVqK6V8xP++hjg2Fzeu91dv9EHtMFsLi0CJ7fXqMSgfg+KKF8OyhUnunXHNt/E QsJ9ZxPGv2VCT8RRnsNTpO3nujKQ2jQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693906477; a=rsa-sha256; cv=none; b=mP97XmTZ69S6owiEvS8yxWMQShHS7CEB+TcJzZAG2LUrNJyGhhaRo0WoRW7s/5P1LlQRps 8l88srOwOjblbZldux6gid1sKWolOkzekBvTcbvrAL4bF0NixSV8c7gzt2h9cx/PxVum7A RjpMfBUJmjkosNvLluBtZeKdQpJHlgU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Rg0br0ZthztSLM; Tue, 5 Sep 2023 17:30:32 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 5 Sep 2023 17:34:28 +0800 Message-ID: Date: Tue, 5 Sep 2023 17:34:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: hugetlb_vmemmap: use bulk allocator in alloc_vmemmap_page_list() Content-Language: en-US To: Muchun Song CC: Andrew Morton , Mike Kravetz , Linux-MM , Yuan Can References: <20230905071016.2818810-1-wangkefeng.wang@huawei.com> <877C4C7F-C946-4B55-A4C5-A493EA21B6AC@linux.dev> From: Kefeng Wang In-Reply-To: <877C4C7F-C946-4B55-A4C5-A493EA21B6AC@linux.dev> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B7DDF12000B X-Rspam-User: X-Stat-Signature: 711iweseqshun8s8e73tgrrgdpgxcuog X-Rspamd-Server: rspam03 X-HE-Tag: 1693906475-66040 X-HE-Meta: U2FsdGVkX18NGDkEDpUsLpyYYwpaYNfameVwMihF2EB6CHHp4GZAoJsovqRUdVinMCesFng/mzRAmmTLVy3W2D1xVPV7c0Xc3a9+RvFcPtaHHrFunfd3koBPwq9ekuhZsKjo4c8pzWcgv7Ld1SnUYPLHDMSjSOwdLJNCfpUDgQ7dDLVHr+rArGQdXtYzIcZ3LCB86oDTgj5FTCIcb8yD7CGYDl+tXFRAxj6R3vEmSYgOK6gtSF7yAr6r8ZtUnlGUTFbCgk0hDrke50TrNoPJbgSEUGtC+k55fEP9rnkdxaNQoLcvbu2yTpm4KG/PwUDkXhaMddssDmZLHEZ3D3cG6EZ+HWMCUwsxx7StwFOzJW3g/JYcM4DLYqryK09K6nc6yg8U/RoDBdhNdwWanWPzIUpL/JaPNmiAuFU/9ctxaXauSXIEVMevla0Zy4dyzpHkiMBueW9MgSjLziVK5AzAaUX90HippSN9G0q+vgnWCMSXYyLKkMqP9lC/g9jbYOcfkbl1ol7sChABiar6meEXVxtTgpv+KaqGxAbSt+sa+syylfmddU9pQM6eeMfh1sckYqGI/HBWDKjd3mKVmdMEpsxX95e51uA8GH/sVc4HvlUo0atmEeFxj1XzG4NXA4clxsiO97babcTvptnfT7yMmvJVzOlRw/NN900Zt6Up2rCAieuX8aQmDiqmprdPU5kG8j2Mqx4ABqu9gC2YDuMMj203fyE9/vrBrpMXkanJOgP0t3StKStG/VzSiUjDOtoru483xMnq0i1udhWbFfY5zDg5lyoqLb4kpBv8StoRCyZHyqMQo5hrfkYbnfQ9RbyUIS9CEV+F1FIdz1kc0mi8ZX00TwZ0mc/carL0qtmQwtF/HKRATYxhnegS/OclGkGLBPSMB4legHT0UMCdDHkSKkJW+ITz9Mc+CG6UIFaJcxJMEVrHGfsHfz5n1PuJ02p5HHmDdCkfXcBdGFlkTwy ZNd2Fohl 3+/gY8Pb7G4vvyM7BymM9A0WPXIicXneodjfx3gpX+upj+LChbe4EGfuMtue/ICozdrN7z79sCTToJ6uJa9iMVmNUO1vvX4hveg9PwLBSlW44Y95aNpnGGkKLrJOaJfcLL4/F7o+GQxlVDFk///0JnHkIMb0bYFYT5akwqEKQyjPVOnZoclmrws8lXXz6qTAPsApNvfkPwJUgnsFgn12mC81S3bpKWnBTlkEFWpdymQNmssnW6gtBjecj4RF/t+5x+171M3fLFHo5AR5Gs3e4fMWkZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/5 17:23, Muchun Song wrote: > > >> On Sep 5, 2023, at 15:32, Kefeng Wang wrote: >> On 2023/9/5 15:10, Kefeng Wang wrote: >>> It is needed 4095 pages(1G) or 7 pages(2M) to be allocated once in >>> alloc_vmemmap_page_list(), so let's add a bulk allocator varietas >>> alloc_pages_bulk_list_node() and switch alloc_vmemmap_page_list() >>> to use it to accelerate page allocation. >>> Simple test on arm64's qemu with 1G Hugetlb, 870,842ns vs 3,845,252ns >>> despite the fluctuations, it is still a nice improvement. >>> Tested-by: Yuan Can >>> Signed-off-by: Kefeng Wang >>> --- >>> include/linux/gfp.h | 9 +++++++++ >>> mm/hugetlb_vmemmap.c | 7 ++++++- >>> 2 files changed, 15 insertions(+), 1 deletion(-) >>> diff --git a/include/linux/gfp.h b/include/linux/gfp.h >>> index 665f06675c83..d6e82f15b61f 100644 >>> --- a/include/linux/gfp.h >>> +++ b/include/linux/gfp.h >>> @@ -195,6 +195,15 @@ alloc_pages_bulk_list(gfp_t gfp, unsigned long nr_pages, struct list_head *list) >>> return __alloc_pages_bulk(gfp, numa_mem_id(), NULL, nr_pages, list, NULL); >>> } >>> +static inline unsigned long >>> +alloc_pages_bulk_list_node(gfp_t gfp, int nid, unsigned long nr_pages, struct list_head *list) >>> +{ >>> + if (nid == NUMA_NO_NODE) >>> + nid = numa_mem_id(); >>> + >>> + return __alloc_pages_bulk(gfp, nid, NULL, nr_pages, list, NULL); >>> +} >>> + >>> static inline unsigned long >>> alloc_pages_bulk_array(gfp_t gfp, unsigned long nr_pages, struct page **page_array) >>> { >>> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >>> index 4b9734777f69..699c4fea6b9f 100644 >>> --- a/mm/hugetlb_vmemmap.c >>> +++ b/mm/hugetlb_vmemmap.c >>> @@ -384,8 +384,13 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, >>> unsigned long nr_pages = (end - start) >> PAGE_SHIFT; >>> int nid = page_to_nid((struct page *)start); >>> struct page *page, *next; >>> + unsigned long nr_alloced; >>> - while (nr_pages--) { >>> + nr_alloced = alloc_pages_bulk_list_node(gfp_mask, nid, nr_pages, list); >>> + if (!nr_alloced) >>> + return -ENOMEM; >>> + >> >> eh， forget to inc nr_allocated in the fallback patch， will resend > > Do not change the judgement, "nr_pages -= nr_alloced;" is enough > and simple. sure, thanks. > >>> + while (nr_alloced < nr_pages) { >>> page = alloc_pages_node(nid, gfp_mask, 0); >>> if (!page) >>> goto out; > >