From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A680DD1AD2B for ; Wed, 16 Oct 2024 08:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37CF16B007B; Wed, 16 Oct 2024 04:31:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32BBA6B0082; Wed, 16 Oct 2024 04:31:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CCED6B0083; Wed, 16 Oct 2024 04:31:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 014EF6B007B for ; Wed, 16 Oct 2024 04:31:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 378581A1AC2 for ; Wed, 16 Oct 2024 08:31:20 +0000 (UTC) X-FDA: 82678796424.15.1D6DF1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 57B7680006 for ; Wed, 16 Oct 2024 08:31:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IHBiKC5J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729067462; a=rsa-sha256; cv=none; b=ORNf87Isvc3wy1syFSyf63JCtmZdsufWyx1Qep8oaY5KLgLb5bmPtG1FEfulSAHW5MMMv+ BuTlBquiYWri1jm7AUdrmM4h+YtFwSnAkMvSoyLkPy/CmdU+Ouo0FQLQA4BZY5Wt3f6Dcm C4SWLp4xQIZSRncyS05W9zAtiRERMT8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IHBiKC5J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729067462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nxJAESLDCyGs6G7Q1PYYxxCmB1EZ5PkkRq59RpUu3oA=; b=fnpLyPOPfoZCvb1+NabDN+b8FeEAbsFdStUgoSpff2HXmJi7uuaHbX0mwcNMEZRVvbRix5 8eA6rB0/01YDDbNCF7LSEaS4ruSymH71LnZd11wmgkzy7yc2jzZV0LBA84S5ohqQYjcHz8 JKEioK1dB3vpteCK/4426njdYkwA8uk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729067494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nxJAESLDCyGs6G7Q1PYYxxCmB1EZ5PkkRq59RpUu3oA=; b=IHBiKC5JJKZMAGr1NnFk4zYVNOURjf74Y5e9yTkKB/X6FLhRnHn3YdCJ6fuhVEI7+c1n4H gdl2J6HljZ/ug4Zl854y6eUHTbDfnciFjs702eupt9IuxaC3pQC8ABc3Ex3899nNz15EtR uSNNizVwZMoZvDfWqT9PfSInsCsgHok= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-xo-2tUosODWypewONU7Y6g-1; Wed, 16 Oct 2024 04:31:31 -0400 X-MC-Unique: xo-2tUosODWypewONU7Y6g-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539e13b8143so3631013e87.0 for ; Wed, 16 Oct 2024 01:31:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729067490; x=1729672290; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nxJAESLDCyGs6G7Q1PYYxxCmB1EZ5PkkRq59RpUu3oA=; b=l9HlaTi5KbWbuGaQHwlaNBRQxJdJv+jh7llHBGb7AvKK3+6gk7my44fkTxxckr9/5V K4FCyTNnzQVyESMB2EfnTaMW9hFqhh6Zy1jtzYgZt4sOsois1NsAtAMDMIwe7rbimgcT F8wUrQ09N7BVYS4Q1sP6r8VukSuTwnJc2X2NnsRqdd2uSVYIjy4mYgGVRhZrbirvqmSO biJ4kfnrspvjq51a18xUaUL1jx+hz6cal3OAlxtFl1IDcsROJiWoQaNoI9ZkfYOVzdgR 0GCAhJckwby9yWtSePTA8KumpdLsjS0Ge2P9+2XReoLxrgrVT8isOUL/tLlgGQ6GXoa0 Fpxg== X-Gm-Message-State: AOJu0YxQLE8uH5NMhulaQ6JJ/QZGBidoZ9bIHNUAyolKSiVlmrkoWV1u eeHB0pPyDH066EMCJpL7eNzdS6m38baVt5tj4MaJ7S/ozzwxBqjeM7y+SFNJg4iTLN08XCJBdG7 DPkuQnzxRvWL4xFeVnQA0Ib4tioNNterSXonoiuUhps5BD/p1 X-Received: by 2002:a05:6512:3351:b0:53a:40e:d53d with SMTP id 2adb3069b0e04-53a040ed6demr1230429e87.13.1729067489659; Wed, 16 Oct 2024 01:31:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhlUjLz+Z5x8H1s+KOjW+omWy8l3iv8HfRIL4Tv8iqCoGTTUWh+h2d8eVtiPJ/72N1r4azpw== X-Received: by 2002:a05:6512:3351:b0:53a:40e:d53d with SMTP id 2adb3069b0e04-53a040ed6demr1230412e87.13.1729067489152; Wed, 16 Oct 2024 01:31:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:a200:af8e:d144:6284:4f93? (p200300cbc742a200af8ed14462844f93.dip0.t-ipconnect.de. [2003:cb:c742:a200:af8e:d144:6284:4f93]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43151dfbef4sm9990855e9.17.2024.10.16.01.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 01:31:28 -0700 (PDT) Message-ID: Date: Wed, 16 Oct 2024 10:31:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -v2] resource: Remove dependency on SPARSEMEM from GET_FREE_REGION To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Guenter Roeck , Nathan Chancellor , Arnd Bergmann , Jonathan Cameron References: <20241016014730.339369-1-ying.huang@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241016014730.339369-1-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: s3hij8uyxdfynoozzx743hny4wxega6i X-Rspamd-Queue-Id: 57B7680006 X-Rspamd-Server: rspam02 X-HE-Tag: 1729067479-888623 X-HE-Meta: U2FsdGVkX1/ifwhBOF184V45XvCN4AARcEmZn4CoQx0VcHDWx7xWnan6/KAuvVqE5I2K8kb3Ex4KvgefSa5uhQwwhQ4Dt3weSpGDKgW3Q4jch4esbfItdJgljhPovEUrWQNVRq9qvgeUTF11ayZZNrOXGkzPvPYOXksG1ops3FTAkiIstHeFbFFLqZsn1/VjKunsBp+fqbv13itw9DB/REoqkT8mwr0SozgxGCNL36FgZXC8NOMQnIgw1zYi33sAgggdH1c/36yQ2plPvHXZHruMskZFpFBXlegeSpEsLdxX81i/miXHDe1DpJRDaS1OsBC61xF4V6E84pQOxnSO30BZ/R8fs6CwcofhMVp7DpqC7j1TeA5zSMvz6nwhFB6S+1z2PgNsf4z4J1XpAiF3avXc3Luf2RpvMRI88hIuJB9134c1K0QV5q9XzhYzk3oENefqsEokPw7d3dOW3czTeyA5eTDqZksSwbOAhvbfPs9q9TdiHiqWAM5QopnRTC39ltrgnMKKnITPk9cOI5JwBmylr/K7NobWb7AaHowC6ZWujK8ah89EynVQLbHltMW7lYkNleWWCWrDAqV5iPLno8SgsfLZBE6YEu4Dgvu253Nbbgawpb5dBVE/wYiKd8Rn83jaEqloqhC/+bEGzkKy6kaDLPFX8F2tH81o4LoBxE0gRASxtGgTXjEfude9bePl+isHGGVv3OaPaA9kSDOfTj/DZoSOc7HKl2wfO5MgYRJsSZwKDhdzNjWaCAuwHC0nIkvqhUJbSqiiI/8Mve4OwjUmzpOOtMBsu7/B9Ebjo6eGUbaJNeqzmfEGnSMNjetCD4/W/iwpie11kqc4vr5HzjsZoeykg9CkeBFwe7f4JUHsJOydCqVVy4YlvTie8brtJYtV8H1n/+Mrji2k35Pkd3fVk14iBvx9k5QS2PTg5sk4gcG/iIDCeb+QzvhvMjTT4lICk/hKzcMSh8HbhN5 gvz8I/iI xSO3TC3PLfOlGDbUagP1+2denFoX0W3Gseyow+maJ7z6iy7akp/aa+KsBQbRfhJh/bhl1fAL/IkBqoi6uHfESUxx7hFkLE8G9tL8faX7sY5L24T0EaJnjDjdlgLX5AOFTchoBDqmA1zzZQxKL7oQo8tHMpC9SFReuhMaiQSUMWsuCV7Ftq15GaTqS37y3ekeoddcJocFqBFLRSqBqXLALfO11b2SlHuUKmdpRRlL0lc0kCL0tyeQcWz7TNYytANd6/KaIoCHTNSalBFFTIh569V331OFd7oPcsw+UHC4eG6UsYqwpg1ON4bzuDeWMdPO6Ut8SweaeqUyTS/bp/pwfrzAEiSrSI9vvQHOZx8+xVict3Q2YkYexAuVS50PfY7IUF1nYP1+WmTHfOEqeoNsOz+1mxf/s1qIGH4CKCyEa7iabMPZQv9qXe2WWJH5hOYrflQIoHW3It/FVYMO44rslBuHspA1SE5+C6HfaSRRn8a4+YiaYpF/R2sDfeewqhtHcHh4RASwAovRg3ufybukFUetislEqnx0kzz1ZFngaEE5ZWI6/dQMXjcOx9kyg3Xt5mMwpQAaD6guJlqEKMKP/TKxQeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.10.24 03:47, Huang Ying wrote: > We want to use the functions (get_free_mem_region()) configured via > GET_FREE_REGION in resource kunit tests. However, GET_FREE_REGION > depends on SPARSEMEM now. This makes resource kunit tests cannot be > built on some architectures lacking SPARSEMEM, or causes config > warning as follows, > > WARNING: unmet direct dependencies detected for GET_FREE_REGION > Depends on [n]: SPARSEMEM [=n] > Selected by [y]: > - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y] > > When get_free_mem_region() was introduced the only consumers were > those looking to pass the address range to memremap_pages(). That > address range needed to be mindful of the maximum addressable platform > physical address which at the time only SPARSMEM defined via > MAX_PHYSMEM_BITS. > > Given that memremap_pages() also depended on SPARSEMEM via > ZONE_DEVICE, it was easier to just depend on that definition than > invent a general MAX_PHYSMEM_BITS concept outside of SPARSEMEM. > > Turns out that decision was buggy and did not account for KASAN > consumption of physical address space. That problem was resolved > recently with commit ea72ce5da228 ("x86/kaslr: Expose and use the end > of the physical memory address space"), and GET_FREE_REGION dropped > its MAX_PHYSMEM_BITS dependency. > > Then commit 99185c10d5d9 ("resource, kunit: add test case for > region_intersects()"), went ahead and fixed up the only remaining > dependency on SPARSEMEM which was usage of the PA_SECTION_SHIFT macro > for setting the default alignment. A PAGE_SIZE fallback is fine in the > SPARSEMEM=n case. > > With those build dependencies gone GET_FREE_REGION no longer depends > on SPARSEMEM. So, the patch removes dependency on SPARSEMEM from > GET_FREE_REGION to fix the build issues. > > Link: https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/ > Fixes: 99185c10d5d9 ("resource, kunit: add test case for region_intersects()") > Signed-off-by: "Huang, Ying" > Co-developed-by: Dan Williams > Signed-off-by: Dan Williams > Tested-by: Guenter Roeck > Cc: Nathan Chancellor > Cc: Arnd Bergmann > Cc: David Hildenbrand > Cc: Jonathan Cameron > --- > mm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 4c9f5ea13271..33fa51d608dc 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1085,7 +1085,6 @@ config HMM_MIRROR > depends on MMU > > config GET_FREE_REGION > - depends on SPARSEMEM > bool > > config DEVICE_PRIVATE Acked-by: David Hildenbrand -- Cheers, David / dhildenb