From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1D1C433F5 for ; Wed, 9 Mar 2022 11:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4E318D0003; Wed, 9 Mar 2022 06:31:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD67C8D0001; Wed, 9 Mar 2022 06:31:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B785E8D0003; Wed, 9 Mar 2022 06:31:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id A82138D0001 for ; Wed, 9 Mar 2022 06:31:32 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 64C1A9D66D for ; Wed, 9 Mar 2022 11:31:32 +0000 (UTC) X-FDA: 79224632424.28.0A3FB2C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id B276B140008 for ; Wed, 9 Mar 2022 11:31:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 44F721F381; Wed, 9 Mar 2022 11:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646825490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/mG7FVN+CfQanteTVX950RtdIdYr+omod/t3Qb0PBc=; b=UDZWYsThQjgNLTF389lYj6DmeqinJ2jJTtkXo/kBraeF8tEff7NCD6eqyBDchRx2qYdQwe 2hIHXE8F9jt41cG8a8MG5/xL3wyniKIJTONsRHH9wsyG272mwkfULohQJXDayOnPtNLtsR Mk5xluBuFZ8MuN4eO3FgOhEgItizdZw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646825490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c/mG7FVN+CfQanteTVX950RtdIdYr+omod/t3Qb0PBc=; b=21LSMdrFKMcgWskLwwMjMSqkRf6bIc2kbP2t97CmWVX6tisFvZH6Fpw1pvVIoNuXSpE+ep zt1OvQdGs5zsU4BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1EDA013B71; Wed, 9 Mar 2022 11:31:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bT/rBhKQKGJmZgAAMHmgww (envelope-from ); Wed, 09 Mar 2022 11:31:30 +0000 Message-ID: Date: Wed, 9 Mar 2022 12:31:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/slub: remove forced_order parameter in calculate_sizes Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Miaohe Lin Cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220309092036.50844-1-linmiaohe@huawei.com> <20220309095522.GA1091946@odroid> From: Vlastimil Babka In-Reply-To: <20220309095522.GA1091946@odroid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B276B140008 X-Stat-Signature: 79mkxkiujwffa5uerum3rrukeyntekji Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UDZWYsTh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=21LSMdrF; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1646825491-346008 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/9/22 10:55, Hyeonggon Yoo wrote: > On Wed, Mar 09, 2022 at 05:20:36PM +0800, Miaohe Lin wrote: >> Since commit 32a6f409b693 ("mm, slub: remove runtime allocation order >> changes"), forced_order is always -1. Remove this unneeded parameter >> to simplify the code. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/slub.c | 11 ++++------- >> 1 file changed, 4 insertions(+), 7 deletions(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index 180354d7e741..7f09901ae6b2 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -4038,7 +4038,7 @@ static void set_cpu_partial(struct kmem_cache *s) >> * calculate_sizes() determines the order and the distribution of data within >> * a slab object. >> */ >> -static int calculate_sizes(struct kmem_cache *s, int forced_order) >> +static int calculate_sizes(struct kmem_cache *s) >> { >> slab_flags_t flags = s->flags; >> unsigned int size = s->object_size; >> @@ -4142,10 +4142,7 @@ static int calculate_sizes(struct kmem_cache *s, int forced_order) >> size = ALIGN(size, s->align); >> s->size = size; >> s->reciprocal_size = reciprocal_value(size); >> - if (forced_order >= 0) >> - order = forced_order; >> - else >> - order = calculate_order(size); >> + order = calculate_order(size); >> >> if ((int)order < 0) >> return 0; >> @@ -4181,7 +4178,7 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) >> s->random = get_random_long(); >> #endif >> >> - if (!calculate_sizes(s, -1)) >> + if (!calculate_sizes(s)) >> goto error; >> if (disable_higher_order_debug) { >> /* >> @@ -4191,7 +4188,7 @@ static int kmem_cache_open(struct kmem_cache *s, slab_flags_t flags) >> if (get_order(s->size) > get_order(s->object_size)) { >> s->flags &= ~DEBUG_METADATA_FLAGS; >> s->offset = 0; >> - if (!calculate_sizes(s, -1)) >> + if (!calculate_sizes(s)) >> goto error; >> } >> } > > Looks good to me. > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks both, added to slab-next > Thanks! > >> -- >> 2.23.0 > > -- > Thank you, You are awesome! > Hyeonggon :-)