From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24402C83F22 for ; Wed, 16 Jul 2025 10:16:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4E6A8D0002; Wed, 16 Jul 2025 06:16:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FEBA8D0001; Wed, 16 Jul 2025 06:16:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C5F68D0002; Wed, 16 Jul 2025 06:16:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76D8F8D0001 for ; Wed, 16 Jul 2025 06:16:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 192E18030B for ; Wed, 16 Jul 2025 10:16:10 +0000 (UTC) X-FDA: 83669722500.12.19C2EFE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 90DB980007 for ; Wed, 16 Jul 2025 10:16:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RSRzSVyC; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752660967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=flA8nx4B4YOnN5P74oY+zDuUkp95nmtsIwS1BvsmrjQ=; b=S+X4ljvFTmen+SvK1BfQfV8/fOq6B4y+QOCPexbMWFlSkQEf6W5OawSoBVruYN0sJkt/wu /cYMd+mb3ExzL3eqm314TOFp8PEc/bf3kmwmS1Fgwv2WWaOVz+l2z3ZDTjQTgWaySb1jSE nBMi63MnjiU4Q9za6UKK3a0YUzhjGq0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RSRzSVyC; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752660967; a=rsa-sha256; cv=none; b=eeYFSKPPAtCd2zZorzpz0ZVaQmZqQtbCOZUl/14CQjpV/h84SqjIkDwudPP2M8EmNEUEld i5shWinm/L5I2d2aUopwhgzWTJpOslETUoq3UecwkxoeOGJfNxKVciHRwTnHJ+IoxySW+v MNbV7OL1HfkDqY/40bgWB7aDBvhaYVk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752660967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=flA8nx4B4YOnN5P74oY+zDuUkp95nmtsIwS1BvsmrjQ=; b=RSRzSVyCQ0hRgg7q1ZV3Np9P6o8kGL67Io2gw6u+dcCvMEQBa5eYfXkU4/hf57Cw1proch AlVOyb/lES+7PvMYeziiGBaXxWSrEPzhZwVSpytgJ9qAC3t1mQfUK9H5mx09UwZw+6WWY0 vJwz2qfhBxoDHtw4i0P2pFDU7Ym7zzQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-ET6v4W8RP4-MtatmAEmmNg-1; Wed, 16 Jul 2025 06:16:05 -0400 X-MC-Unique: ET6v4W8RP4-MtatmAEmmNg-1 X-Mimecast-MFC-AGG-ID: ET6v4W8RP4-MtatmAEmmNg_1752660964 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d3f03b74so37546155e9.3 for ; Wed, 16 Jul 2025 03:16:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752660964; x=1753265764; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=flA8nx4B4YOnN5P74oY+zDuUkp95nmtsIwS1BvsmrjQ=; b=Hflpp7Tag+vaNSPJkq0F23yIYZXXcVTOa4niQcityVZWQTQRWoeoyy0oTmcTKyjJ+D WqfFA0TrimF0XO27bzpMa3GiPKOhGu5mPU7Ke6uDXBG3OqdffjXBslj5NNSSQ2Iafdyc h7fxJbBU7POeJkclQvmwmNTcHU0jbeVSfHDVXqZKBN/Yin1YC7UlrsBsBkCWbtrEr2vT mIGhIliL0WZxDvksV1XzJO9fG0gxYptj9keyIw9fw9SK50t5Espj/RRfwQQrKpFfcUDf ahKCHpLA4mWXrrRWxgVJe3KziTE3KzOcPhZhuZPOopGT7EX9ariLJpZhRYFR3FeBpYnJ qHzQ== X-Forwarded-Encrypted: i=1; AJvYcCX1mWzVq6NLkwBqNewGA80lCl/0FNCJrpe01MVR02O+bfgRV15HSr2piN53T8sJZLyiyg4rOBRCPg==@kvack.org X-Gm-Message-State: AOJu0Yzrl15La9XPtJNT41piCC2vFm/vSERlr6TpsRZJXZyH1xMnvJWK xBXhQ3JcVH/yoa4LHRYd3XUCtuFxdfBB8JMtGpkcl+utpRSgN0H9k7OximtG5Kzy+Bxiyl3Tixf yvNckpWLrZzsgGhZ3abUSzp1L5Ozlc6Z8NmjVj7fnt4ygjOPIYac0 X-Gm-Gg: ASbGncu2T9kw5fggskPWp1mcp89DWxJFlvCBzvpvVIeHN6849vR6rt0JUMcJsM4fErW fD5iaiELPfH7Hjd97fR+0MD4l39C3RpSE4ckBmZFaliet2fAkrlo1f3xJYyHfkM5smRfspXWCJq M1qUthuqg8MIbNCfMSbmTdKPpHr0NF6QM4XF0cEOTh0Yy4eKnLym43owG55P8YwBMaiq6JTIVEi 4JFPOWhbLWy5wHdeHLaL275fbJDXmYt+3EBPp+y/G7Im6p441NMxVXf11D2ou+MLZ797e6nd6V7 QBwhkxH4kgG1cglqHVpOANLocXU8OC/pdNmdCBmo+9DL3bmIRDM1vq2F/IQeJpGAE48zaCuAoIq mJCskQmP1PHpICw3I4VVFEnPrlI+ogDspi+1kNS117CW1S85yP0VgkId3mCME4jf0PGU= X-Received: by 2002:a05:600c:46ca:b0:450:6b55:cf91 with SMTP id 5b1f17b1804b1-4562dfd72admr23028775e9.6.1752660964318; Wed, 16 Jul 2025 03:16:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPu49QZciwGvdobBdNGHoaNlj2yAUibyYfxl6yDGr/NB9XNFV1l6HtcPoXfaR9qKs3coPWuA== X-Received: by 2002:a05:600c:46ca:b0:450:6b55:cf91 with SMTP id 5b1f17b1804b1-4562dfd72admr23028315e9.6.1752660963819; Wed, 16 Jul 2025 03:16:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc201asm17251054f8f.22.2025.07.16.03.16.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 03:16:03 -0700 (PDT) Message-ID: Date: Wed, 16 Jul 2025 12:16:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm/util: introduce snapshot_page() To: Luiz Capitulino , willy@infradead.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, shivankg@amd.com, sj@kernel.org, harry.yoo@oracle.com References: <637a03a05cb2e3df88f84ff9e9f9642374ef813a.1752499009.git.luizcap@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <637a03a05cb2e3df88f84ff9e9f9642374ef813a.1752499009.git.luizcap@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UIFslRjrxbh58kG9njDPJi8hR0lUOXXhp6Jg36oe1es_1752660964 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: qanm7bc6he99b847kzn6zf1yb1z3n8wa X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 90DB980007 X-Rspam-User: X-HE-Tag: 1752660967-984526 X-HE-Meta: U2FsdGVkX1/ceSpi9GEMf85jNlclqpbJFIqYFF+tuynLDG3G5TOFUPLgSYOLM2WmtFPodvrzfNTocHeWpbMT0nVxmg6Wl7Jcs/BktACG7PXAc7USvox4i1ugJG8l9w046q8ovY3SJtfq408L2vSu0ibmHCCoBS1NMrrZDhxjDl0ALidQ6Mrq64jQLWitUMW8IjRELcHM2QDHVMltDZ0K3DB65AVMMMhGNlGhKy/aFH+Y2yTQDymum1f4GzEkm16kNhqLMgu77/UnthQdsXo4/RhPCQsrLPNVqeyYOORjos9C6CXWgR79+9WSBchH85t9IRwpRtsa5z54poPmC35GhwC5CQ23v4HFFkEfDy7/rmfsnAUwKAZ4Ly9Rag6wy/JYluZHkUweJgz7M+z7YVPK/cgk+5gXffhV4HjojVrnfB56916BGGQenvhVWs/3JuE41NwHYnPBevw2Bxm3rUcoqAviKaxobkzN59vJuJgQKwEKPNWGUfpNF/PsUpmNvBPa6N9y0SoA++eR/lJlPz0Yu0ErY7yYNa3boyBP5zEcrO8VhtEEUc8DQ+IRypALJ/vunQTPTG2ixCv5ULeFpiGsAsUVmeJhQqQp4LKuVNKPu9ruvXcZIZ1HHU8Yan0cvcfSKLCzWX1zcaZn4ydO77BwZC78wjllLXImrWaJRjgA948tL//bb4/cY+FHILtWPdzH9Xm8MPtqx2K9I6rBpZvDLRzv+iMShWd/F86PFMkVNgLUTiTgu9jBN6SsQoDP5ABkCm++/3+gziWdEdLUMGsjO7tMBScJLbav2pOfXEAh6ZJMx+nMhuy8wYbVl+dH+yopd2lD3Xt0kd0vuMFsMFRMQ/bUGch/RyUnHVeoawBlD9FKvTtGME8xH5Fts4gkzSacBJ8385q0RuxQVkEqmEMgEK/R2wIDPnWQw2pyJROxyja1wngwBtxej64Tq1u/H2DiEsYpw1BEsg+CkEnRSp0 TprQmeb4 OAlz76Hd1JZiQV6gOaiJ0JeBtBVTHrN6GbcdWZCv+6lrtD+063y4WYLPfz7DETxwgRBTGS7TDQ4HYYFlw+7iF2T1R3Dddcj5nFk66dMQ0Tbzzx8R/CAQsdo91KJWCYOgLU09ZXyxKWk3lXsA7YJ7tUC/7LLIkbtGpcnqaG06LZvmGWJC/8rc0Y3y7IkDPHRkzwe06ZWZnV+dqx+x5PuWTgOXlUzl4Pm1UTMR2yTpZOLiWGCXde/xCQmQbtb7rWZjnKMtTyZY5SeqeOTnPIdxM/Q/tSVfjwuyZmVIkAOROrg5oOaPGoqbZt1ZJHcrsVbkVkupIA60ZGPN3cVTu6eRxfC6xJRVTtAQdqflHwEBrFlfqjw7GKGLiGDJyJwQvGXefgcgziV5gE56IaKhmlIpIt/KBoB8cfQi88GmrQCzlbJUTIFXeuHfO79BFyRSh2bRLnzT46gJ22I1CyJG+mryG68wLkjXIS1++RwLu4Zs3UuQkWdtOHXUMoAZZLesSF34uudcZa17V9MekygHYiR5LbE41FA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [...] > > -dump: > - __dump_folio(foliop, &precise, pfn, idx); > + __dump_folio(&ps.folio_snapshot, &ps.page_snapshot, ps.pfn, ps.idx); Nit that can be cleaned up later on top: We should probably call this __dump_page_snapshot() and then just pass ... the page_snapshot. > } > > void dump_page(const struct page *page, const char *reason) > diff --git a/mm/util.c b/mm/util.c > index 0b270c43d7d1..f270bf42465b 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > > @@ -1171,3 +1172,81 @@ int compat_vma_mmap_prepare(struct file *file, struct vm_area_struct *vma) > return 0; > } > EXPORT_SYMBOL(compat_vma_mmap_prepare); > + > +static void set_ps_flags(struct page_snapshot *ps, const struct folio *folio, > + const struct page *page) > +{ > + /* > + * Only the first page of a high-order buddy page has PageBuddy() set. > + * So we have to check manually whether this page is part of a high- > + * order buddy page. > + */ > + if (PageBuddy(page)) > + ps->flags |= PAGE_SNAPSHOT_PG_BUDDY; > + else if (page_count(page) == 0 && is_free_buddy_page(page)) > + ps->flags |= PAGE_SNAPSHOT_PG_BUDDY; > + > + if (folio_test_idle(folio)) > + ps->flags |= PAGE_SNAPSHOT_PG_IDLE; > +} > + > +/** > + * snapshot_page() - Create a snapshot of a struct page > + * @ps: Pointer to a struct page_snapshot to store the page snapshot > + * @page: The page to snapshot > + * > + * Create a snapshot of the page and store both its struct page and struct > + * folio representations in @ps. > + * > + * Note that creating a faithful snapshot may fail if the compound Maybe highlight that this is not really expected to happen, ever. > + * state of the page keeps changing (e.g., due to a folio split). In > + * this case, ps->faithful is set to false, and the snapshot assumes There is no ps->faithful. > + * that @page refers to a single page. > + */ > +void snapshot_page(struct page_snapshot *ps, const struct page *page) > +{ > + unsigned long head, nr_pages = 1; > + struct folio *foliop; > + int loops = 5; > + > + ps->pfn = page_to_pfn(page); > + ps->flags = PAGE_SNAPSHOT_FAITHFUL; > + > +again: > + memset(&ps->folio_snapshot, 0, sizeof(struct folio)); > + memcpy(&ps->page_snapshot, page, sizeof(*page)); > + head = ps->page_snapshot.compound_head; > + if ((head & 1) == 0) { > + ps->idx = 0; > + foliop = (struct folio *)&ps->page_snapshot; > + if (!folio_test_large(foliop)) { > + set_ps_flags(ps, page_folio(page), page); > + memcpy(&ps->folio_snapshot, foliop, > + sizeof(struct page)); > + return; > + } > + foliop = (struct folio *)page; > + } else { > + foliop = (struct folio *)(head - 1); > + ps->idx = folio_page_idx(foliop, page); > + } Condition could be cleaned up by reversing both things if (head & 1) { /* Tail page, lookup the actual head. */ foliop = (struct folio *)(head - 1); ps->idx = folio_page_idx(foliop, page); } else ... } But you're just moving that code, so no need to do that now. I think we could improve some of that in the future a bit to make it even more faithful. But for now this should be just fine. Acked-by: David Hildenbrand -- Cheers, David / dhildenb