From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5B96C71133 for ; Fri, 25 Aug 2023 07:31:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 502B528005B; Fri, 25 Aug 2023 03:31:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B3268E0011; Fri, 25 Aug 2023 03:31:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A46F28005B; Fri, 25 Aug 2023 03:31:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 293178E0011 for ; Fri, 25 Aug 2023 03:31:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E8C4F140280 for ; Fri, 25 Aug 2023 07:31:56 +0000 (UTC) X-FDA: 81161807832.12.963F194 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf09.hostedemail.com (Postfix) with ESMTP id 19647140022 for ; Fri, 25 Aug 2023 07:31:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=iRCFZNbE; spf=pass (imf09.hostedemail.com: domain of haoxing990@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=haoxing990@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692948715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IiQOGxXFGUPadpc3ed3CgeK4NAC12/4bCMS3K6h81pM=; b=0+3/7uZvg72kn0xyeTBN4be2u4uSt0OyRdUSw63JycH1RysevZrbBrReCqaUv3ZnH6EJ3x NoQu9Q9YE09MCpSkZegeXpAOParSK0f9YFRkyaMqXN+3NxmADzalLY1XsH9ahutTOx4aVJ MSzoyoPwuRddEWg+sZehw49vGG5ET9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692948715; a=rsa-sha256; cv=none; b=TP8FdEdEzBJDii7ijN5PvfFUWiMrleA//4a8GESHtyvI/a9nBEf2ARD7nXdCvfCmx4+85Y KShKnpq9iPGJgoK+TeB3NGBthJYE9q3MpRnVKEtAN8MuYdvFH2AbkEAMYUkrhxglF5OyIl 9x69iALqPcBokNxGtzOcKUphA0J4ydU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=iRCFZNbE; spf=pass (imf09.hostedemail.com: domain of haoxing990@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=haoxing990@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-68c0d886ea0so90146b3a.2 for ; Fri, 25 Aug 2023 00:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692948714; x=1693553514; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=IiQOGxXFGUPadpc3ed3CgeK4NAC12/4bCMS3K6h81pM=; b=iRCFZNbEWZfFKcMeBQ6pfGwdVRWuL5CPlnpRtNiUzL5g7WqPPM0qTpuBnKjlXyWaxF T3CYV3tm2UevZ2+WJ6DFQ7aNZKte0Kb6jU/Iz8wfY3dEAIEinBKartPB3Sk+T1odMZwQ xJkXuLZtwiZNBglfNDaxVqYnpSLDB3eK49Q8tQH5xvDv6ILDFNd8VriOXn2sQeOz+PzL YEAUWtMwK6sJC/7dwM+kbpHFao786m8skXnJHY5dDUui1FtDyLntUWuTq0MmFGRpvcMY +b7iLlCd/MFZFbGKmxmuP/MAEJx5NRW6dHKUw8x/hVcnJx2d7g+Jp2xNxbnqDJlYNRjz WhMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692948714; x=1693553514; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IiQOGxXFGUPadpc3ed3CgeK4NAC12/4bCMS3K6h81pM=; b=kLtglHFLrAvZ+UKsLRrzdVxnmY0R+gH6rk0c7YquNg4uSXb0MWRpSHhv+mux1zZfL4 xgKvF7qgrqujQV7QzFJK2x3Rz2o2b7CS+BaFL96jGcwGTfr3Vgc8X5MqxaWFHFFPztxB zKM9ksuc8XqfnTk2Hyu1PM3fhPGgiSgidViIGSxBTjpPYKgRf/Q8h/YF8MwPgwUPHJou FO7ztbE4rZKnzlB1a0mMobJYcVpEcRL43QugGVB3WjqbbxDvjYR7Av+WHuebmRJKlk2p jRK9TQl26A014usspYfsMUEVwdCmDZ/hQP3R7Q1GD+EguQbiAXDYEuqPIWnrgKZ42lrg d/9A== X-Gm-Message-State: AOJu0Yw9zqpT/0e5LWnUtuFtIIo2fiiF40So7bQoCPr9ItDbEetANsCT tHx//xcS6OuN0J53PbXSQxo= X-Google-Smtp-Source: AGHT+IEN6mqPdb2qyiiiW9/fUq6WKL1AVoYLzs0KPpHJ76AJPkjxfT/NlaSwPZULQHWlBaVwuxq4cQ== X-Received: by 2002:a05:6a20:7d8b:b0:14c:7020:d614 with SMTP id v11-20020a056a207d8b00b0014c7020d614mr1407892pzj.49.1692948713765; Fri, 25 Aug 2023 00:31:53 -0700 (PDT) Received: from [192.168.255.10] ([103.7.29.31]) by smtp.gmail.com with ESMTPSA id t9-20020a170902e84900b001b5656b0bf9sm931901plg.286.2023.08.25.00.31.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 00:31:53 -0700 (PDT) Message-ID: Date: Fri, 25 Aug 2023 15:31:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() To: David Hildenbrand , akpm@linux-foundation.org Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vern Hao References: <20230825040848.1542-1-user@VERNHAO-MC1> From: Vern Hao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 19647140022 X-Rspam-User: X-Stat-Signature: txx4he9ogtyccm1oq697h3dx3mzkuwgd X-Rspamd-Server: rspam03 X-HE-Tag: 1692948714-554893 X-HE-Meta: U2FsdGVkX19PwENKPTjK8pFxHkJo2N3aAlcTVSubJxQK7ABQYuBQMMDbgA0Os0GBB63OnHBV4KhEarCuiehRnWldlzGjM8b3fyRA0fSFGfpNiFgR2c88TXp+BlhLrszhTXpk0hBA+HKEIm8pwnmNVc3gI73y983poeIvsjK5fG3OReutmAF7hqSlx42dc+Eri2etUz7xQujBHK3e01Xtcfo10hoT/ihECjjfLF0xRmyYCftriP/PhQhQD7m1v5RGaX4UGLRLhbgLVWDmVDCgExmv+9CnJUullL7J1JbT5wyZ07Efk3IsDyr+jTyIYV98rxcp+4i2Pa8wOVKMakJp3O+MunFpMZUQY526l+Fs+fIyfzohwUi6LBkt0b0hJ/8ey8cSH98/gB2C1op/CtikQgs70Ir9bN/WO7o3zfInbnjIxhmW4SWUHK79XWGoKbXAxG5CLWEhpB6MAP/94fUpzXLXM31K7B/bFqKyOWz4k4WMMDRwd+rJY/jmyBepULtugmMs3Otjb8sd17hnlHw9Mc1sQxhqf2N3q9icG+chshMuXcA8k1Wq+blrRSfmMoW6Lg8naT1Jz3yLePvEUPFIayDUIwaLpU5rynL+haU95UuQOiRaVDcDzGp5b/nl9zR+xoqQ4o7LLjrImUlDnQGAMVW/T/z3FJlEoRidtYCJgkHvhgzzd0XMVDOinHEzo/O65xeTC3U0tIhYz7U6nQYuVXVeSA1AHBX2hPY9OCYMOgjs1YOTuSqG64oCO9YbG5gA3RyM09wFML02xmf/0ZoxXse2ignTLPk3ks+HBUiXVpDN/8bL4d51uoZU1sgJ4hQWFq6a4ImpEZa6l+/ai6a/FVBQHpNtd4MlAEDxqGXSISnxNL8M9et/Xof2h9Qg7abnPAMLNkI4B1AWa3WH8E5KlBTAChQqBfOVnn0X+1nl527mBTvjcfu9a493QhOW4q99vgAT6ZUDzLqwlevwcJt tJx6aEFo lGW9KISJukluWehUGCXq160VSgNRg6znMo72OU2uay8clXGVhOze//+LDVeEqKg4nqwYnGjf/a3qKP5A/CT74eqkYUrzA3dql4BYwoGeXnEUnBYyC/H9F2DnV/cmgU7I6oct9W7pA2ZQw99ZwG1v1vdSDgaGyb75sJmOff/IcVDWa6CCaJrWIlkYumN6gkjy+rUdMfO26gil5MOXbaFTIemLaIxa4T5F2YG2/jG0fdqlCyrnz5E5S7k5RMwzLIwBYdNJ9j56VR7SIoGOusrIk16Ek7oAdT0/Su3tMXbRQ+TLnwq2XnV8OPXe/0wrSgdzLlPTPF1l+su/Qmd7C3BXG1lKr93sAqR36T4qkRT4SQZin4Y0e6PFVL8kGxQlk9MxDZ9hJnUlQWxc4hbdiXDAffSwkzKYmG5/ylJAiBo68pTa3/PytQUuHWGHEehX+2Tj7ne+1d1I6mZyXJv4u8CoSsbJTLUWqHGwaCIdz4R+1fY9Cn3zUq/Ex0JZsUDupc63oPS8q4fEwxfq+JYKSyNgufQ4ENrAoBjrWKLVxM9MEQ4/Jzy3Q0WsPNoRa3l6nYyT4tOH6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001376, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/8/25 15:12, David Hildenbrand 写道: > On 25.08.23 06:08, Vern Hao wrote: >> From: Vern Hao >> >> In skip_cma(), we can use folio_migratetype() to replace >> get_pageblock_migratetype(). >> >> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") > > Why did you think "Fixes" was a good idea? > The skip_cma() contains the folio argument, and the folio_migratetype()  is already implemented in the kernel, so I think it's fine to keep it consistent. Thanks!