linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vern Hao <haoxing990@gmail.com>
To: David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org
Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Vern Hao <vernhao@tencent.com>
Subject: Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()
Date: Fri, 25 Aug 2023 15:31:45 +0800	[thread overview]
Message-ID: <ca7199a4-5628-425f-8f0b-8e8123b431b8@gmail.com> (raw)
In-Reply-To: <aa5d199b-ea12-90f3-91fb-468d74a6f934@redhat.com>


在 2023/8/25 15:12, David Hildenbrand 写道:
> On 25.08.23 06:08, Vern Hao wrote:
>> From: Vern Hao <vernhao@tencent.com>
>>
>> In skip_cma(), we can use folio_migratetype() to replace 
>> get_pageblock_migratetype().
>>
>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available")
>
> Why did you think "Fixes" was a good idea?
>
The skip_cma() contains the folio argument, and the folio_migratetype()  
is already implemented in the kernel, so I think it's fine to keep it 
consistent.


Thanks!



  reply	other threads:[~2023-08-25  7:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230825040848.1542-1-user@VERNHAO-MC1>
2023-08-25  7:12 ` David Hildenbrand
2023-08-25  7:31   ` Vern Hao [this message]
2023-08-25  7:34     ` David Hildenbrand
2023-08-25  7:36       ` Vern Hao
2023-08-25  7:37         ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca7199a4-5628-425f-8f0b-8e8123b431b8@gmail.com \
    --to=haoxing990@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vernhao@tencent.com \
    --cc=zhaoyang.huang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox