Re: [linux-next:master 7766/10451] drivers/clk/qcom/camcc-sm8650.c:3573:29: error: incompatible pointer types passing 'struct device *' to parameter of type 'struct platform_device *'

[Jagadeesh Kona <quic_jkona@quicinc.com>]

On 7/18/2024 12:18 PM, Krzysztof Kozlowski wrote:
> On 07/07/2024 17:20, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   0b58e108042b0ed28a71cd7edf5175999955b233
>> commit: 09ea421652a832083ea380a72addf383965f3682 [7766/10451] clk: qcom: camcc-sm8650: Add SM8650 camera clock controller driver
>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/config)
>> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407072331.baglL4Sd-lkp@intel.com/reproduce)
> 
> This and this:
> https://lore.kernel.org/all/202407072212.WptVaUDt-lkp@intel.com/
> 
> are reports on linux-next. They were addressed to you/
> 
> Jagadeesh, how did you respond to public reports that your commit has
> build failures in linux-next?
> 
> It reached now Linus' tree causing huge rant, unfortunately not in the
> direction we would like that rant to go.
> 
> If you receive a report that your code does not even compile, it is YOUR
> DAMN MOST IMPORTANT TASK to address it IMMEDIATELY.
> 
> I don't think such code should be ever accepted if contributors do not
> take responsibility for their commits.
> 
> Krzysztof
> 

I initially submitted my change [1] by passing pdev to 
qcom_cc_really_probe(). Seems like due to [2] which changed the 
qcom_cc_really_probe() parameters from pdev to dev, my change was 
updated from pdev to &pdev->dev while applying.

When this issue was reported by kernel bot, I checked out the linux-next 
tree but I didn't see this failure since the common change [2] was 
already merged into linux-next. I apologize for not reverting the same 
over the email thread.

But change [2] was somehow missed and only my change [1] landed up in 
Linus's tree, which led to this failure as Arnd described in [3].

[1] 
https://lore.kernel.org/all/20240602114439.1611-8-quic_jkona@quicinc.com/
[2] 
https://lore.kernel.org/all/20240507130531.3286999-4-quic_luoj@quicinc.com/#Z31drivers:clk:qcom:common.c
[3] 
https://lore.kernel.org/lkml/ed757bc4-38ba-420a-9da8-d7de1f1123f6@app.fastmail.com/#t

Thanks,
Jagadeesh

>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202407072331.baglL4Sd-lkp@intel.com/
>>
>> Note: the linux-next/master HEAD 0b58e108042b0ed28a71cd7edf5175999955b233 builds fine.
>>        It may have been fixed somewhere.
>>
>> All errors (new ones prefixed by >>):
>>
>>>> drivers/clk/qcom/camcc-sm8650.c:3573:29: error: incompatible pointer types passing 'struct device *' to parameter of type 'struct platform_device *' [-Werror,-Wincompatible-pointer-types]
>>      3573 |         ret = qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8650_desc, regmap);
>>           |                                    ^~~~~~~~~~
>>     drivers/clk/qcom/common.h:63:57: note: passing argument to parameter 'pdev' here
>>        63 | extern int qcom_cc_really_probe(struct platform_device *pdev,
>>           |                                                         ^
>>     1 error generated.
>>