From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16226C4332F for ; Wed, 1 Nov 2023 06:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83FCC6B025F; Wed, 1 Nov 2023 02:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F0D86B0261; Wed, 1 Nov 2023 02:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E0306B026E; Wed, 1 Nov 2023 02:53:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B0BA6B025F for ; Wed, 1 Nov 2023 02:53:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3893F160B8C for ; Wed, 1 Nov 2023 06:53:35 +0000 (UTC) X-FDA: 81408469590.28.FF5BAC1 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf30.hostedemail.com (Postfix) with ESMTP id DEE9A8000F for ; Wed, 1 Nov 2023 06:53:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=QChlah4+; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf30.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698821613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vkUEf9qIvi0SMDctvwk2B4fTr2MBK+8AfABz9dTKu/8=; b=RqLCfYiCMhZ4XgdEU+ED4tvxb9VEzKNaWa8VrB9JEPuPNzNQi+cWmRUOcfQ9P0fSkcBAc2 0V8AE/p7y2xLbBupNoPZkGIKAv62HU3wbSqpb+3nPQNstOoGsvewccTVuTllDwtujayDoz aD25uuLmVCDeLZ4N1Hue/hFW9TZKcfk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=QChlah4+; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf30.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698821613; a=rsa-sha256; cv=none; b=BXlRFPijoGJxFbdt6ho/RkIjA7lOPd8SkDsZCwAJXlRtXMRDS0zPUotB4L7KfGbvH+J/ju Iywr2p7/W3c8rmk9qD1Rdlj/jePmzzc9owqYAPFCtU0/jfa4fbpaKgBQWMWzzESqJ7sza6 vSM309peGRLCgGcIQmVDRS2OHi1eWjk= Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A15TNEC012804; Wed, 1 Nov 2023 06:53:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=vkUEf9qIvi0SMDctvwk2B4fTr2MBK+8AfABz9dTKu/8=; b=QChlah4+6tT+ib6JEADUjJ5yqmpB1MxuS+DqnO7YNxspRxlv1s78I2RX0lGOnSELa3WH YYEC4dEV/pwRXRyMzzT5H2rF08mGXz60Nb9cXhu8EeLJ+0/sF2ztF4PGFZLdwBYRl973 RbO6UKtJBLpfFxxaNGtO8x8wPyQIuWubGIUr7llTZZ7eoiEgY83S/IIUgjmx1oGV5SCL BQartnJiB29h/J83uNwki1bchIdIG1+2Jci26xznwcghdMvuT+uEqod8X1nJnr016S2n sclc92pggOwhpeynCisU1Dtq4FRL5EhH9UEazLv0atLhlOz/HSwIPiz4zYsu5bG5S/6i sw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u3382jdb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Nov 2023 06:53:31 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A16rUW5019280 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 Nov 2023 06:53:30 GMT Received: from [10.214.66.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Tue, 31 Oct 2023 23:53:27 -0700 Message-ID: Date: Wed, 1 Nov 2023 12:23:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm: page_alloc: unreserve highatomic page blocks before oom Content-Language: en-US To: Pavan Kondeti CC: Michal Hocko , , , , , , References: <1698669590-3193-1-git-send-email-quic_charante@quicinc.com> <2a0d2dd8-562c-fec7-e3ac-0bd955643e16@quicinc.com> <37c58833-1953-42c3-98c6-ee0ac75508ce@quicinc.com> From: Charan Teja Kalla In-Reply-To: <37c58833-1953-42c3-98c6-ee0ac75508ce@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: QFFtBJcqKPNIL5bxjw0mLNMw8tK7eo3r X-Proofpoint-ORIG-GUID: QFFtBJcqKPNIL5bxjw0mLNMw8tK7eo3r X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-01_03,2023-10-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 mlxscore=0 adultscore=0 clxscore=1015 mlxlogscore=575 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311010057 X-Rspamd-Queue-Id: DEE9A8000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1cpu7k38pwgbcphmanjmgsrrqmuruxxu X-HE-Tag: 1698821612-766828 X-HE-Meta: U2FsdGVkX18UyL7tFyBzVQ+9wbDDcE/oZa/cGG3UXgGY52PtUClRNwfRJQ1W0tWES9nIABHm+UOh55AUSA09iMpiKz3Ep1iBQoA+yzhxJVmhePxAFQIQz3tgCAM4zbx+ufCS/so6l0Is7VkJhfNgEEJNmrDupY7PpwZNe92JGTV1UojWQ8/VEPZ02I0LJ0vEopwEt9a0ihc+nvwfAwjiqmFdBE1EIE8+iV7HNu2X5Q439b+6lJXRa2T2AKRTQhLOYAJLNP8W2ErAIpRGLphZ5wO/Y6G9/PDyLNlgIvmNqnnfSZZTa5aZVDQNXcATTQ/9AR6f7gjAJf7csnMzvo3rEXx2yAQtUTO2o47HyUkpOkuYK8HGuvcDMdY2QEzosFB/Ze6cgeVQED6dQ2X2Etn/kDNndSmJJHj41EtdWAaNBS52sjkJ4Cfp/5YxkMJ88GPW+qTj3VbFXIXPQ36yMG3rjHk+NiMZg4Ls4QyCepdDN1gVM2EMe5HC7EY5s0+bk4pmEl2Fi694JYAKH/VFTskl7V6KteFZ1rXjN2Ye6nbusY/EBjquLVPLZcFsJ7RLPxHMELHAoFNMku9HKF/vkuExfb5gbDdrw2BHOtOhKdFI9ozzAb8h36rz5+QFfRcitde44PnIt1mxa/v3ft7SH9P0v117HKSKvW+28LsJ+BExaIHiVmZbWw8nND8Xpc+GMYnnOtBz0lXO9ofMwf3aku5nBWdtdDhPeLzxRMfvbygnVR/SqbOJVNZ+3pg1tp7C+9wgAtoXtx+HphgtJ0OSYICxL/4cwMRdI5chsZkZW3249rtqAE1UGpuR+TtQw+F4WolHa+J5jSWf1/7yBI1pxGSuyZhWEGajq1/eOn4gXWnjvHMIOju+c5W0ZLm4XUqVkry7ICs8frokwUFchX1b+BiFSZ45CycgLCk1e9qR57YOqK0l4mzhOcpMqcdkqoHeLocaeekLxB7bWNVvs3bkwdu 71v4CDc9 ZxrwnL5uqu9j2llk5cwdXngB5rNO4MDZC6aZoX1geuP0GV1p+OT76AFtxbLOC49c12OK+pSXruTIYtw4rE/b8jbMG/oQ2YXW072et4ruRX9GNVgw7Xaly7Yp/GtU1Hkq4WcHQd7kI3MG5UvnCyFzGqeS6xSf3tXuSXc3OJHHaAFAKh8qpeBMDY/bzVoRJMahBZAdNGAnyPwDVEkdZRa18LFddARCDBHZNfc7rtPp69l8Bie26kRQQ8ksmvvM51s0xTMgfuX4LOHMfkQ5gd24+0UrnLQrgs4qeijUm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/1/2023 12:16 PM, Pavan Kondeti wrote: >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 2a2536d..41441ced 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -1886,7 +1886,9 @@ static void reserve_highatomic_pageblock(struct >> page *page, struct zone *zone) >> * Limit the number reserved to 1 pageblock or roughly 1% of a zone. >> * Check is race-prone but harmless. >> */ >> - max_managed = (zone_managed_pages(zone) / 100) + pageblock_nr_pages; >> + max_managed = max_t(unsigned long, >> + ALIGN(zone_managed_pages(zone) / 100, >> pageblock_nr_pages), >> + pageblock_nr_pages); >> if (zone->nr_reserved_highatomic >= max_managed) >> return; >> > ALIGN() rounds up the value, so max_t() is not needed here. If you had > used ALIGN_DOWN() then max_t() can be used to keep atleast > pageblock_nr_pages pages. > Yeah, just ALIGN() enough here. > > Also, add below Fixes tag if it makes sense. > > Fixes: 04c8716f7b00 ("mm: try to exhaust highatomic reserve before the OOM") I should be adding this.