From: Tianxianting <tian.xianting@h3c.com>
To: Michal Hocko <mhocko@suse.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()
Date: Fri, 16 Oct 2020 14:33:13 +0000 [thread overview]
Message-ID: <ca5e3e13f00348898bb9205a7eeb4c85@h3c.com> (raw)
In-Reply-To: <20201016134457.GM22589@dhcp22.suse.cz>
Thanks for the explain.
I got it.
-----Original Message-----
From: Michal Hocko [mailto:mhocko@suse.com]
Sent: Friday, October 16, 2020 9:45 PM
To: tianxianting (RD) <tian.xianting@h3c.com>
Cc: akpm@linux-foundation.org; linux-mm@kvack.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()
On Fri 16-10-20 13:20:41, Tianxianting wrote:
> Thanks
> I understood what you said :)
> But whether it is proper to check reschedule in every loop when lock is taken?
I do not see any actual problem TBH. cond_resched is mostly to increase interactivity for non preemptible kernel. It can reduce throughput but this is a memory reclaim path and I do not expect this to contribute to any moderate hot paths. Direct reclaim doesn't really count as a hot path.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2020-10-16 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 3:39 Xianting Tian
2020-10-16 12:07 ` Michal Hocko
2020-10-16 12:48 ` Tianxianting
2020-10-16 13:02 ` Michal Hocko
2020-10-16 13:20 ` Tianxianting
2020-10-16 13:44 ` Michal Hocko
2020-10-16 14:33 ` Tianxianting [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca5e3e13f00348898bb9205a7eeb4c85@h3c.com \
--to=tian.xianting@h3c.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox