From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D685C3DA49 for ; Tue, 16 Jul 2024 10:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB0D26B0085; Tue, 16 Jul 2024 06:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A61226B0088; Tue, 16 Jul 2024 06:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 928196B0089; Tue, 16 Jul 2024 06:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7387D6B0085 for ; Tue, 16 Jul 2024 06:22:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF8D4140488 for ; Tue, 16 Jul 2024 10:22:09 +0000 (UTC) X-FDA: 82345225578.24.596AA92 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 3820140011 for ; Tue, 16 Jul 2024 10:22:07 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721125289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mof2BdF2wgfCJ/YWOkULfKwz54FH4Y2OtCLn5w3iO4A=; b=arkpiMCU5GO5ygtwe+UOjSX8CT0gRfzMUOXhTxHwgzbOysdg+UUb1BGKzdR592csLZhqHG Rj3l3W5Bux5/JXBLLoOa9dDuF4ZsNK9H0jNkD1V3KzXgL3XC60uOATObj71sFyet6R5Wlt 6p3DHmkLCNwMoWrE63sj2FKmTi0PcG4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721125289; a=rsa-sha256; cv=none; b=bXXBwCbAVU4rAfkQb3fWOOQ4LayDuQvXB1cL5a6wOhKiycZBx1yRYtwmXfeNHadbHgKS0Y m3cD73motXnnfbYRxHretaQQ7mtgzeGSkUp6bl7Wt5mT1UhiRVt4afHHU0YAqbovGeeRZ4 ClKhwZm7pXr2xq7TG28W5QZqKDjl8+I= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78BB31063; Tue, 16 Jul 2024 03:22:32 -0700 (PDT) Received: from [10.163.52.225] (unknown [10.163.52.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 012EF3F762; Tue, 16 Jul 2024 03:21:58 -0700 (PDT) Message-ID: Date: Tue, 16 Jul 2024 15:51:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 16/29] arm64: add pte_access_permitted_no_overlay() To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-17-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-17-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: m9s75b6myxwueh4ggj3iq43uri5hxqyx X-Rspamd-Queue-Id: 3820140011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721125327-963021 X-HE-Meta: U2FsdGVkX1+X7dakoXChKmZFwlPJyPjlIFX48teo7FLMUNlXU13uGDvyMdlgKeUfXzWEXIiW4EWedEBGjhu1UZs08CNwmfqPXyDCKR+AIs22ZTF6kzl/5w+PcpX6sdrJJRtVjRDCi26iWnRb26fJjFKkyWPpHoNbobxYSc1Wc/4ZLv9ZCEcstl5PSDoEcXC7ZqjbJxTLisTcM9SDoW/fNI0mvQXc9bpGsVgMCmbuz2xz/jCuMp+7jyemZlXjNzFmmctkXzZkOd5Vo7hJJMRG1llFN288s6UOEc9VqNsGcLEb5Y6376OXbibec5qKiOKJEhUAgM8fux4gq6yA2dOAHgznBdVrw3GJGS7rcnyc0WYRiY69WQS+G+nyMkvMEsNpJ5ko6SNzorxqkW+OD9r3CEQUAymPGPKBsnHLgsBryltQ0IkfE/Ucw8S19LMuSVkttdFjVrZai5ioJHCbsy1AMYZul6n8nzZP62rPUdT1LQXhIsYH31lg7XR5wUulie5Ey6yxef5pOWX/T1OGptjTO4QK2tNEyzYS0Rr7XkwRsAN/Rnw+WnLc/o/0vLIyotEuoCYY8WcPfCujidBykoJDNAQyFRy7ZRM1FHjRwrMbqUz0+r0LlLWrrjsaX1wL0CmBcf6BGDT4AMT6sZWsbMN48YxoG8JOGdg6/kqP/DYzj2whOoqovsioyj+wd0YEhUp5SCz0OGxlMrx1t7NmC+vJ5OaA6SF1oTKTB7qDf9bbehObuyyH4sL1E4bse1OdldJykDK4gsjEdWbZxsPmXKhcrYp/M/ZkXACw9B0l2SBwD5JkWrJgzh18OKdV++ZsJnSbWkEyT/5qyFqH9rDSw667giroNbfHp4LWl9/4l4KZdzM22A4pweyYbSzWJNlYNJHCRdfSdj7S7kkc3zcQkjLIOUEYgmVXf5WaR4x7XJC+gUoYMpWfUVzJoSoZnMBhsv4wOzK82JtME1jCEQcRIIA rKAr5Ti7 WBXoV9ZBGqtJ6OySPP7H9EVVuRJ40v/Qp+StJ6naBEHbRAefLj6kQ/kLoP7OghacBuFFxFjt9sT8DSQ0MqJRotTiSQbA8h+mUU+HZ7AlSxQt/1Bpx33xcG5/mFafsEyUrUh7E8TYy9AvRa/al9eIxUumHREAZt9pNR+jZ+xXzrZeLeaWjcvl8f2UxP6QO4iFijUGIM79M3mUb+lorawby5IfXoATwAETML7Rr7+NnuWecVEATfVHkd91DGR85IiXTnoW7WU9Yi0p6sa80H5vveKyBmrqyKfOralOmADY7RnvCJsTJEvqsF+s3Qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > We do not want take POE into account when clearing the MTE tags. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon Reviewed-by: Anshuman Khandual > --- > arch/arm64/include/asm/pgtable.h | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 5c970a9cca67..2449e4e27ea6 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -160,8 +160,10 @@ static inline pteval_t __phys_to_pte_val(phys_addr_t phys) > * not set) must return false. PROT_NONE mappings do not have the > * PTE_VALID bit set. > */ > -#define pte_access_permitted(pte, write) \ > +#define pte_access_permitted_no_overlay(pte, write) \ > (((pte_val(pte) & (PTE_VALID | PTE_USER)) == (PTE_VALID | PTE_USER)) && (!(write) || pte_write(pte))) > +#define pte_access_permitted(pte, write) \ > + pte_access_permitted_no_overlay(pte, write) > #define pmd_access_permitted(pmd, write) \ > (pte_access_permitted(pmd_pte(pmd), (write))) > #define pud_access_permitted(pud, write) \ > @@ -348,10 +350,11 @@ static inline void __sync_cache_and_tags(pte_t pte, unsigned int nr_pages) > /* > * If the PTE would provide user space access to the tags associated > * with it then ensure that the MTE tags are synchronised. Although > - * pte_access_permitted() returns false for exec only mappings, they > - * don't expose tags (instruction fetches don't check tags). > + * pte_access_permitted_no_overlay() returns false for exec only > + * mappings, they don't expose tags (instruction fetches don't check > + * tags). > */ > - if (system_supports_mte() && pte_access_permitted(pte, false) && > + if (system_supports_mte() && pte_access_permitted_no_overlay(pte, false) && > !pte_special(pte) && pte_tagged(pte)) > mte_sync_tags(pte, nr_pages); > }