From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA9FC83F1B for ; Mon, 14 Jul 2025 08:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F9DE8E0002; Mon, 14 Jul 2025 04:04:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA428E0001; Mon, 14 Jul 2025 04:04:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 270908E0002; Mon, 14 Jul 2025 04:04:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 05C858E0001 for ; Mon, 14 Jul 2025 04:04:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9827412CDB2 for ; Mon, 14 Jul 2025 08:04:53 +0000 (UTC) X-FDA: 83662134066.09.FC7A707 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 4169410000D for ; Mon, 14 Jul 2025 08:04:51 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MiXuW8Cv; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752480291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ixOAhqEqvoxP1PivoSUfdqLVUuvoI4jKQJJfXotpDys=; b=UN5gWajHUPx7wwSDXiRhWiBrFYoi6cEXoR5vXeIkj7GepDJhx+XMK9lY0r0JXzkeI/L1qn 9x0HJtt3BXFxzN1VqfUN3d5ToIkXEjtBZJHz4v1z7BBqyoTCQBv5Ua0G06BWC34lJijjZv qn9S9+rLPt4lwp+j/h0fBxKgzkgnbzo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752480291; a=rsa-sha256; cv=none; b=iMMWPoqsrBqz9Q6ChXVgts8Yg9HpmQU2KrS3MZdBxjVLegS4lua/Gns7Mm5R4rCfx6zefV SFb89qTP7hzllfZypx6QXdn1Zmgs2l2blBs+kQQw76cKslMPbxWyMuLic7IRtmFb1AjIdJ y2geu1ZRwtt0PVfNtOsdYu41XyRe3q0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MiXuW8Cv; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752480290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ixOAhqEqvoxP1PivoSUfdqLVUuvoI4jKQJJfXotpDys=; b=MiXuW8CvSk3G3a+R4B5rn6QUJNKCosNfbkPs+vmxY6CvAXsd+aum5NBwek7QNvb55yMyIN P4USbWDqxEG8djBc8diJ11E+XauFI2CIdd0kWMm+1K/dN+ReAlSuRGHadh5jAOTV0Ubj+J Cfu/9i0AZrh6LiOIw+Lat549r2PflSA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-dzxgprHbMEKm8Y95AehFIg-1; Mon, 14 Jul 2025 04:04:48 -0400 X-MC-Unique: dzxgprHbMEKm8Y95AehFIg-1 X-Mimecast-MFC-AGG-ID: dzxgprHbMEKm8Y95AehFIg_1752480287 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4561a196f70so3750345e9.1 for ; Mon, 14 Jul 2025 01:04:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752480287; x=1753085087; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ixOAhqEqvoxP1PivoSUfdqLVUuvoI4jKQJJfXotpDys=; b=SmyNvrMZ2OV1w/VyeCtJTK8q8kiDUR4lsFYcUI1flotdHQST0BeSH8TVpR63wiQCH2 gya/w+49bnU+avJlDj31X5+JYP3HmzV3qTnxY863W3MsGjHJRqRTLaWPN9YUA/Oe3srB 8UKaQPoB3JAgID+rL8DIXaKOw/lr/Yowfj/XqEBeRvXAjK0urF0wVQy3cTD3qj+bly/3 Ntd1O0M9zGURwyWU8VFbyQqdxVQtuAkUHTkPWaIT8xnFzs9IaU+7fkX5mdceaxwR6OuV XGNdc+1rCHELxHKtBK7o5edIcx3vmomAl74/3jWkijfZCt+VVwvciTattVJ9GZjvsUNY e6dw== X-Forwarded-Encrypted: i=1; AJvYcCW86trL5uMzZbnNOdozJuENTU5gIoEMrwCpp1SxESf9zYFhlumrtiO6S0EqyplwINgbM0F/YJPY5g==@kvack.org X-Gm-Message-State: AOJu0YxQxCPwyWyJgl1cI6C+sWRItDIgTPvZokPxgWIcgqVaum/0nOWb rjhhyQCqcYS1J9I9dn0ILd61vpyb4FiRF7fgPPqQXg3423M/3zCe5pwlvRUT/JccXpT/uwxmTrC 2jCshzlDP/M0q3n/a7fh+mPX+M5bQON8OkI+CXDzBFKXU14ntyRoK X-Gm-Gg: ASbGncvjOSE6GTD/+PiDixjcEEPRIRKg/bCUuWskkCeRE74o8+Dq2/NHN8QRcZ2apZC YNaxzr4XcIxOkDtGYlwBqCyY58EYzmvCB1xt8JGplVH5qCFuR1R8SFhjhukqhcpTjTN0SYb9vaQ VIE4CyUluP6TEtRk6NWR+kfIQOpA8e5raflevlO9s5KXohn5dB9CzhcznyDzWa85H0k5bIATNtF Ogh8hY7cHnVgZJm+YpWobFe8++nroixFediMlIedmAFuM6mEeviscHCi+KLjA9qIWkGjrPV39ak d8+uAPu5xMYCyM+FnG2pwo1UY2i7ZqOrsXngeVGV0W83Eaiel67BEdNqnJvtqFWmU9KX8vSM1AM ZWqscTVkHfeg425eo9fKPUwXWyvUGjYSLowRRk/bo98Yi90FbaKRtc6io3zdIn3ME X-Received: by 2002:a05:600c:4e8c:b0:453:606b:daea with SMTP id 5b1f17b1804b1-45565ed6221mr88009615e9.20.1752480286496; Mon, 14 Jul 2025 01:04:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoByEu1/Uf5RBo5csxuZUO9+jOoSxjseMQn3FmuvY4lczw6M1Y83tcmfv4c33XRFZ1XLrKJA== X-Received: by 2002:a05:600c:4e8c:b0:453:606b:daea with SMTP id 5b1f17b1804b1-45565ed6221mr88009265e9.20.1752480286086; Mon, 14 Jul 2025 01:04:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8bd1997sm11917851f8f.10.2025.07.14.01.04.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 01:04:44 -0700 (PDT) Message-ID: Date: Mon, 14 Jul 2025 10:04:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation To: Andrew Morton , Chi Zhiling Cc: willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling , Ryan Roberts References: <20250710060451.3535957-1-chizhiling@163.com> <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> <661ccfa4-a5ad-4370-a7f5-e17968d8a46e@163.com> <20250712152544.07f236ec277290c70a2a862f@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250712152544.07f236ec277290c70a2a862f@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _JQd2gBogbKkZ8KX11RVGYCq4OBioqdLBwudHRz31fI_1752480287 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4169410000D X-Stat-Signature: g7kw3wioquszjxans5mg83bhdi9ui8us X-Rspam-User: X-HE-Tag: 1752480291-18775 X-HE-Meta: U2FsdGVkX1/ANRrWOzJsX7nPKMZfzMAeFfvJpxdpG06elLEkCQabqsaXyKWBWR4v2wyDVmY4JBGS0bg5H5Ui7boDOF/KCbxIAhYPVXpBCs9Yym7WMRAj5UiE6V/WoJwrutf4pMGsssAIfXdChmy5OhAdiXGBKHwxvt6TfDnCBaxBwxT4l8bTYVwfKF/vnkaQPYb17d12+IfIz60GQvCCR7hoAt/6a6hjCq+lEdlYnQkM418zd9NI27McAffhCSye+EMwv0UyWOC5JVAKgMq4q3Ho/TEUFTShyTA2CLA8EC/LaKr4zfe2p4hdJd5OjQLiJI1sqLOl+dRlhBF+BWr+DkmgDLeHTHqO6uFv+jv6J5N1sLZtGSvlV1vY7VU+9AvL1eC4zTMz8Xw7+fOXV99zP/DYYn6ixOzd3toUg8KlSjJOtbkx2bNve5dXpy9IlZQNqBygtB9NfkUmzg9ZV/6ifEiEpxGb5e3QPcEBXFxVd2IZ5ZqaKcf1L+7sw5bIDE+n/aqrL+GDH3ojEWhqtgWhB1R8LydeDO+bycmctktUp9PsYUyEt9w5EanYs74WqIX18L87F3sEk3JgkGWmTzLW2BBiOetU83UnZg2i+/yEQvY9YpCdJ/Ix6kIcnYb+Uzc1vvwz/WcVbJpKkMv3z3oKy6FjlM3QSCkRWp97h5vIXmDicEHkpIavRNjMkWg6F/jEYZb4gkz2Y1E8QhRHJOYtAc28OZzjY44/5UVTGlgFjwyr2Yx5Et6Ukc0/t6aW5xIm4dLwh7cRU1YR51F8Yz1DZmTuppBIt9ZqprwdJnFYizUh/EkFNy2PJ9rGJwNJ3Mb4fhBuR5viCRzrJYWVhW/CW249JFN/DFuZ19+TWTgwBV1qJuFf71dXGlzidWgYW9DxXgvpax/LNC6j9HJy3xC3W+kI3yJvexDcIoLZKh1NhjSrbHiVhvZlBWwd6UaJ5yqNzDFl+Cm4aYnxZ3KV2/p ur7IKtQO yXEg1OgzGMtsKG1FADB8K1QurvOxiho+hwmkxGhzR80oZqx/INW2aQtgFYValjKBA3QSBLAhavwcfk+fFxJZkkDtF/VilkX/4iGFpzr/Ziw5I4bNxsklmI6hfn7WE/FQl96gbNxVhozBjfNKvDS5FUpKic/4Wb4ld3hwuca5TvCJ4zus= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.07.25 00:25, Andrew Morton wrote: > On Sat, 12 Jul 2025 10:23:32 +0800 Chi Zhiling wrote: > >> On 2025/7/12 00:15, David Hildenbrand wrote: >>> On 10.07.25 08:04, Chi Zhiling wrote: >>>> From: Chi Zhiling >>>> >>>> folio_nr_pages() is faster helper function to get the number of pages >>>> when NR_PAGES_IN_LARGE_FOLIO is enabled. >>>> >>>> Signed-off-by: Chi Zhiling >>>> --- >>>>   mm/readahead.c | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/mm/readahead.c b/mm/readahead.c >>>> index 95a24f12d1e7..406756d34309 100644 >>>> --- a/mm/readahead.c >>>> +++ b/mm/readahead.c >>>> @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control >>>> *ractl, >>>>        * Ramp up sizes, and push forward the readahead window. >>>>        */ >>>>       expected = round_down(ra->start + ra->size - ra->async_size, >>>> -            1UL << folio_order(folio)); >>>> +            folio_nr_pages(folio)); >>>>       if (index == expected) { >>>>           ra->start += ra->size; >>>>           /* >>> >>> This should probably get squashed in Ryans commit? >> >> I have no objection, it's up to Ryan. > > "Ryans commit" is now c4602f9fa77f ("mm/readahead: store folio order in > struct file_ra_state") in mm-stable. I'd prefer not to rebase for this! Yeah, in that case, obviously no rebase :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb