From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F81C27C53 for ; Wed, 12 Jun 2024 18:38:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 569C06B009D; Wed, 12 Jun 2024 14:38:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 518B66B009E; Wed, 12 Jun 2024 14:38:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BA6E6B009F; Wed, 12 Jun 2024 14:38:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D0A26B009D for ; Wed, 12 Jun 2024 14:38:32 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 833BCA24A3 for ; Wed, 12 Jun 2024 18:38:31 +0000 (UTC) X-FDA: 82223097222.08.D6E8A69 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id AB585140016 for ; Wed, 12 Jun 2024 18:38:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ORYCUpDH; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718217507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eHkiYypujAnwSi5QrP8pZu0qQw3cLgJft3y7PW/t9t4=; b=Br6pzyY15KwC8dH80ha7Mn1b/3dAQgh9Pa+jyCAL3zSASd7+ei7qYoZ1FhgA73TLuYaKH+ vQyxFkoFSqJmrweh+bS+Osd0RrIHaUrm7sfWIpDvdw4Bb7nJn2Typz8mewge7W2zt8iTP+ 5rfo/fQaLKJDwujyoxPpojqwffWQisw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ORYCUpDH; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718217507; a=rsa-sha256; cv=none; b=wDAJdVMeMh5kCpjz/2KTmCe0wn4usXqIlTbyQuJXDHMQt1O2zPAHC58Mf/JepT3UP/2ndS 24iM3W20S6CpCY7vgsfIjBKcnVLXAilyMwNI4setebkM1STg8GkPIaTVtV1uaV6ZyTvnls YKOQ/u4446dswl7+dUj2Y9grS/FrfBA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718217507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eHkiYypujAnwSi5QrP8pZu0qQw3cLgJft3y7PW/t9t4=; b=ORYCUpDHd7ycd/UMM0kfT657bEQiHayWHOm9X9/YzGVbZJzjFNtWIpK6Dq7HdV+mpr5U2j XXxZiLH2vk9K5cw5pVdof+2xchKEY6bFWvoPny2KzpIRNJ4lv/FhkdlRInvps6MIPxnoot H4GMilHb5k72hooLgFZlTs7OTsuGXgw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-aNOhBOQ3OVeSBF0oCSO5kQ-1; Wed, 12 Jun 2024 14:38:25 -0400 X-MC-Unique: aNOhBOQ3OVeSBF0oCSO5kQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42183fdd668so1052445e9.2 for ; Wed, 12 Jun 2024 11:38:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718217504; x=1718822304; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eHkiYypujAnwSi5QrP8pZu0qQw3cLgJft3y7PW/t9t4=; b=nrwDj6fpJg5AM8vo+OPH9K63uxZ1Wvt52ChWqCu2Gydd6Sm3DipoL13Akfu0dc7qUC GPl6O6AfSsudCeJh4NuR3Q3T2XQKJXs8DBa9c74etH2bZAXnO6OJ1izNKJY/PdrwhKWd LeMdnfKTL9viqO7VS0yPlInx7d7UETJijor9nMkA61rPpVUzE7rzkkUQOu5xE6OV7Syp z95FffBey5oBIsN4dlJRdLJlGGp4qp2kcErukzHBMQITwz7DDuFzeqZQcr4lh/eDBQWw gDOdyeVGe8k+2WHhFtDxwXbxQyZW9ryyFDAHvrFJg98wxR0+9HFUPp/2QFty72koRPen P/Pg== X-Forwarded-Encrypted: i=1; AJvYcCWi16TPztZwoTJ8VZ3JWwWByOp+2djehSTs3h0mZqRLCMqadXUJlfv0cUV+veuLrydV42v2E6EvhOiPtrCGthj5Bv0= X-Gm-Message-State: AOJu0YwgvK4j6sCD2dNyErJRmP4XjrkFSSoMAWznC90jiW67ADgFq4GE 1y+OdpzaP+hQRRAz+T/d48Qkc0gSPFevXEvfXMVE7AdCkB094vAa5J+QHi4vUY8TP3sGFGunTEz B2Xms5WeD/7rSLQwKXsuoz7oaa0n+VsTv5iC4rAP6JEXwC01i X-Received: by 2002:a05:600c:358b:b0:422:683b:df4d with SMTP id 5b1f17b1804b1-422862aca70mr25635805e9.8.1718217504329; Wed, 12 Jun 2024 11:38:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9c6UnJX0cTtZy9cm2l0blMA61xj4ptfyilK9HIBnbYNBzABHUDtJIhxGr1xkMg1evDFPT+w== X-Received: by 2002:a05:600c:358b:b0:422:683b:df4d with SMTP id 5b1f17b1804b1-422862aca70mr25635525e9.8.1718217503744; Wed, 12 Jun 2024 11:38:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:bf00:abf6:cc3a:24d6:fa55? (p200300cbc702bf00abf6cc3a24d6fa55.dip0.t-ipconnect.de. [2003:cb:c702:bf00:abf6:cc3a:24d6:fa55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422870f760fsm35980815e9.33.2024.06.12.11.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 11:38:23 -0700 (PDT) Message-ID: Date: Wed, 12 Jun 2024 20:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] mm: pass meminit_context to __free_pages_core() To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, kasan-dev@googlegroups.com, Mike Rapoport , Oscar Salvador , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Alexander Potapenko , Marco Elver , Dmitry Vyukov References: <20240607090939.89524-1-david@redhat.com> <20240607090939.89524-2-david@redhat.com> <2ed64218-7f3b-4302-a5dc-27f060654fe2@redhat.com> <20240611121942.050a2215143af0ecb576122f@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240611121942.050a2215143af0ecb576122f@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AB585140016 X-Stat-Signature: peca8puzcwzy7o3g6carhpktszyqbjiq X-HE-Tag: 1718217507-891105 X-HE-Meta: U2FsdGVkX1+ZM4cMvjDEixd/N4Iw9uVQXkq6s33MBM+KhNtIcf6R/UD3WQSqTjS6Ql7CEBb6dhDKROD7GG3oUiBEYMpmU0VyAbxs5e2ykDOywHVh9JvP5pd8aG5WqMyn2uojZ6+ttVkaSj7e0wLAJnOH8acJB9EBtsyzpbt5svk9gEzD3ohxFKr39cGuLUiNbx6MsC4JN2SqMY0CoojtJsImUZ1+1I9W03NKuchmG305Yl2PGPpY1XuQWSVl8r4wYPTjFr4iwuGGfRgvGwLG5GGYeCjArgRt+LVHq448n5K6xWWCyIDLE92nO6oONmU5VPGbRunazrmz08Gln3dR49XKIyCBbpKHowrHcwKKwnd8ztHSWbn/Gwyu5OQorc1Xgb+ypOioohEoEwCua7axrXW8KSjJWDYtdgUU8WCo9wU08enHTzKPRC0dYU2mgGADwPBNQe5F7qdL7WaCZSt6pd6tgmmPFvv0/shMD7CJ3RebJHZgsGHPt2mzstWadYH9Ej+sWEY9OATdZAsTR2pf/73eZDN+T5Nn4TFH9MfldlxxxfMP+EPgRLlluqQqeFnvPiMIxUKfRJ4kN5FcrJRuF6eNWFpby8NJZjxkQj+C9sJGQac6whwBIbBnQWbnYocY8WvCLUwcK+sDkbShZvXe/bFFqyd6BHsB3tUS5XXrS7l/tBOjtrW16Wv5lhyTXyxYtqshCi5Zd64sBcxeEZ9Ue5k36JQ9QcAcZn1YdYw4Szj1tiy4fncUVEJ3oaSM3Q8BH0v/8c6Is3s5IY7+hJitIr5Da0YSpV0x8mx+2WzQYBS47vV0Ujicu9wUe/66V6ciLXNlNdddcq6C0yGO89WlvKXqNKoK/brVkpVowilVd33ajwEeWvDr4HlV/MUXRjNouvgt6MWlxV2kCGOxwcqTKguYX3t+Q1L2FNb+6TmtZbW7nooqywJ8MJKFNkU180+5La2MJ/Be4QJizo6lhs3 4mttSXni mOKmJGOmVEQQiK+8ZEvkt7UEQGRnBUC4sJalDjKReA5Y7D8iCJAAlwz4oOxdPunyU8B/5dc8MiQVFoJgLgjibYW8V0XBVQ7G4MTrp1vKoO7f6exp27t84k+urdoVPro2ir1fFVN50DY4FI7GTD7y5JnT/G6CwuwkfX8wDXq4Ox/DCDR4n0Z09eSOHyrtCDzfZcTxhx2ipt5zTx11KY4Tiv4W4FwyPCAKd0Su6+Y7liMnU8B3X/Ez0ptnHxb3CE1SXYi6fJkuYbFDc9Cr/7JrirID2asX6nzf1+KqbljwzT+U+gN2mtDn+yqv9/hfDuYhgj9yBhIFcj5cs8Q1+IPEe9UnrzAHj4jU4BUQx93L3+D/b33xGv8apZegqbt+uaCQuEjXtRZpgHAhsVviT6Sncsvx2dgXkZEMM3yEsyD4JJ2agBEk/uvUfi7ZXWkjS/1EWIIfBTo3rmEQ0j4lkjVNnpfJnARO3TucwOr8JDkvlzSuKpJXaSTImIP0QVZofibHSHLzoRb9XlcJwTYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.24 21:19, Andrew Morton wrote: > On Tue, 11 Jun 2024 12:06:56 +0200 David Hildenbrand wrote: > >> On 07.06.24 11:09, David Hildenbrand wrote: >>> In preparation for further changes, let's teach __free_pages_core() >>> about the differences of memory hotplug handling. >>> >>> Move the memory hotplug specific handling from generic_online_page() to >>> __free_pages_core(), use adjust_managed_page_count() on the memory >>> hotplug path, and spell out why memory freed via memblock >>> cannot currently use adjust_managed_page_count(). >>> >>> Signed-off-by: David Hildenbrand >>> --- >> >> @Andrew, can you squash the following? > > Sure. > > I queued it against "mm: pass meminit_context to __free_pages_core()", > not against > >> Subject: [PATCH] fixup: mm/highmem: make nr_free_highpages() return "unsigned >> long" > Can you squash the following as well? (hopefully the last fixup, otherwise I might just resend a v2) From 53c8c5834e638b2ae5e2a34fa7d49ce0dcf25192 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Wed, 12 Jun 2024 20:31:07 +0200 Subject: [PATCH] fixup: mm: pass meminit_context to __free_pages_core() Let's add the parameter name also in the declaration. Signed-off-by: David Hildenbrand --- mm/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index 14bab8a41baf6..254dd907bf9a2 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -605,7 +605,7 @@ extern void __putback_isolated_page(struct page *page, unsigned int order, extern void memblock_free_pages(struct page *page, unsigned long pfn, unsigned int order); extern void __free_pages_core(struct page *page, unsigned int order, - enum meminit_context); + enum meminit_context context); /* * This will have no effect, other than possibly generating a warning, if the -- 2.45.2 -- Cheers, David / dhildenb