From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A9BC77B7F for ; Sat, 13 May 2023 21:36:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0821D6B0071; Sat, 13 May 2023 17:36:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 032636B0072; Sat, 13 May 2023 17:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3C876B0074; Sat, 13 May 2023 17:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D3A4C6B0071 for ; Sat, 13 May 2023 17:36:01 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05413A113E for ; Sat, 13 May 2023 21:36:00 +0000 (UTC) X-FDA: 80786539722.19.09AF945 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by imf15.hostedemail.com (Postfix) with ESMTP id DC8C3A0005 for ; Sat, 13 May 2023 21:35:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b=cr8F1CRB; spf=pass (imf15.hostedemail.com: domain of deller@gmx.de designates 212.227.15.18 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684013758; a=rsa-sha256; cv=none; b=LVBxNGHEvuN/RiQpyNvZExiXhMRqCfT+y1tGYniKgT4oc46Cj3l2Dy83r3gUuUHpS3Kkgi Yksj0e720yAM63AtpWigKWubOTQJKh1NG76JxvjYTMN8IVe9QYTCsZnen4UfuJV0brRvpw +52zJSHry9RSeIULJDjo+EU+DIqKKJU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b=cr8F1CRB; spf=pass (imf15.hostedemail.com: domain of deller@gmx.de designates 212.227.15.18 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684013758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YIDPid/AnU51Zv96DM0MdCj9G9rm9XwyBVfAr/CkjAs=; b=7GVMAPyCd9PzIXSE7oH0yjP2JyW55ud7kPE9si+WsZ3M8BJd//chJ6m0xuAzEzAMdujfKb RmdwC42mc21xXyjYg/0R4f9wIGbo9QoUMx9FKhCnElg1iEN2RrwidKJPAUujDiQxgPnG8T vfT9rK5/rD6wZXx9kJDM8/Ioooudec0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1684013732; i=deller@gmx.de; bh=yJRf6LHTP/Tqq0WjA9yc9VAdZA0puqTSbfj+iJUayOI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=cr8F1CRBH8iQkDkEZ/t6guBO/5jXWPHjvHesKUuGbD0L0xJGMcsfDLG0X9/WHN5tf gmoBZcMozWcEmMI1SXgz60UKtLHg89Qkg3K5IkelB8CkMlNz7sHwAxzIMD7I9clgqG 8BBXU1INAL2hkc4jAoXGc9Lj9qQhDT78CQ4DXrxDBdxOVY1Chk3DgfjVKIVZpGXT/D hVsUkekeRL3hC4ZEJXj+51+YVnf9Nvq9nqI08asyhPuJHM5bnDl2bJRO7+pyeEkSzs makkDeysMdDZ+PR6cOIDeDEyBEo1Ufi+QeDWvXHj3Lo1XEgk6NeIJkd9GLiqmybaVK GkXJUictBPxtg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.158.250]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MdvqW-1qYw4r4BZ0-00b73t; Sat, 13 May 2023 23:35:32 +0200 Message-ID: Date: Sat, 13 May 2023 23:35:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 08/23] parisc: add pte_unmap() to balance get_ptep() Content-Language: en-US To: Hugh Dickins , Andrew Morton Cc: Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <77a5d8c-406b-7068-4f17-23b7ac53bc83@google.com> <44ebbf90-5fbb-2815-17c7-fcfe3c87d78e@google.com> From: Helge Deller In-Reply-To: <44ebbf90-5fbb-2815-17c7-fcfe3c87d78e@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:02c5NpapKZ0yND7w0y40kUtQXH+Ybc0bQPzvspvwYlotAB99sF5 zFBBfNW47FR7ppsIv7ORzd5debot/2bSdnSyGIDtWWm1xzh1QppJDewIoqcOMGEOc5o3++E GB7D5SsAuS01JsydFNYGrdMOwh1KtcLiZKmwzv4YnhFPj7aU+qawXM/A52PkJ99vIebL33s O5IbJLN5O6SEa/1rmMz5g== UI-OutboundReport: notjunk:1;M01:P0:bhlTqfzpBjQ=;VggY45HBIIx7XaH/PngpNV8urft cjwTlAoz1j7g24v8vlKLAO3PylYnY/qHL1gAemvPDWFLKb+ZHNP7elgmO7WqCtgoC6KjABob8 DNOyUboPP4EN29IO7mQkp5zAUdfcC9dvuIH6FrtIgv24kY/u0UkP0sFqXCCza311xuhuc0bfI W3a3RTKNdId6dAowl5u63DT6seM8Hm4iphC0SPSPZT9g005M9r8+BQH/XC9MFQyJSO3FX3CWI UokhNrxaQU+aZoAGuy0ZKtyCLBTYWL4F6TSIHPfUdr4DKE8vx3tRYWkx+4y1/bi2ullhSCNlL t6uHP3r9oyZotSEHOmuNGQ7W90zXSNq13A8slhX51+wEbYQI7OjJlN5/6SNi0b3fPn7mCmsak 5u96zCjBgO45UkYwIFVS3h7nF/Mwj8eEQpBbuQa/S0dQzwZzDhm85nk91JGJWzeKBhnpogocH HASt2e1tuCNJHXlJDWO5LuLXb/JVmpy/KwGOxafTz0qWr0u9OGwBJyzr/aekEvaK0vqfAKu9G WWPJ6EPxl3C5tMotM5H57EtsA/8G5fV+FiCfWCTjtjTsMZF7DQvd5ixzVKc8aKHYj3o78J5J9 b1xbN4FsZDbke0QSx0p5QFQq4XQal0qGr9xIMYRqRZ0p56T3GrZgrwad5D5lXnpeTj0OqJ47u LkxrOM39notrGfVPy74SGBIJ6LFZQs2aBXs0Hrdb2Ua2vNs/36VHsvhfxQ4rZu2ljsKr7Tnsd t3WHCudqPse4fRr2srS44fxtRfB3efVVWEMsoe5NnAfdFJZgOwt0WYZyDbB2PZ4mU7ilCEJAJ irVSZYdS00VuNKqtGWxFrZ0rrE5AHHHlC1uGoa5UQz1YYRu63D00hqjC4lOZ81YrXtV0VSuXi PDH9rmGqc28YryLY3ce8ZihMjd1Tkl/vP1QN0EuRgkkWHoKGGQ5LzjYSoYI+w24AaBgVLeyTT dmWbT/BmDshTWbB5y4/6VdjN1LM= X-Rspam-User: X-Stat-Signature: cdpbj63bfwsbkyxcgooetofsfm9n67yo X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DC8C3A0005 X-HE-Tag: 1684013757-54530 X-HE-Meta: U2FsdGVkX19zdHrCKwr9MNhvzFpB6sG6H7cFMJfu7Dt3UEDaiMhrKt7OQZfTR8p935CBZdNVdmcwSy98kLRA2psfZZ4XULWk3aJYf8aphr0ZgZidmIurxyCj6F2Tgd8IrPdevcg56wDmokmtXhQ1QItnNmBp65RPNvg4XV8Lw4xUe2+MYMOUBAlsOfxlGChJHo7zXgQq2SMY4lvKadR1fOzZ5F2+dGrIG8nWoPBZibs+cGGZubWBpIFpBPi1FRCcIVCssrLaR1O2CWXpEnVf/u4yZ50aUZWEmp1hz8ZVR2Xtm6UsJ99MJTE0Nq84b2SMb1q9KwY/bB8ZYq3tvtS61o4c5epkaoXzyJYmvgk1aFMChlmlXKmb/2TjzvuzpvmbYas9+w5msuXW+lR//0HBB/JnZeBuZCPJDanNlvR8AmE3sgL/VF0zwV1PkDCu3Peg8+WX4xzmaGNc8zkQY7QV3N1R6j1Dr7Zz/IrnXHvgNuQrK6LtrFn6LsJ1hJuJ2qOq8i1nEK+rNle46zwq4IDcg8beibQfv6/q7+WsnRozMCUBchNaEt/B6u4Sp/heIvsb6W/mG++NKTWjShOKHn9a2P15VDKDvOhrUNrruU5ThGN9JOB6M3ONVI+D1pVl0h60jh2eCWidzp1s0C+rknbP+/zHR0EPywz/bTVam4PHHcK0XHPOKaEAlFvzvv7mnarqkhXpvw1CjTY+xR1e3he3iz3ZbYhh/JN8tzGhOkIh3UJp960VJZ0BOmFh6FkPsxOy4z2cblbSOo8CUAxWw6IgDcAmL8ww4DKmQCd3VIpABuX8T24iCcfvha7Ti9D8x6DnfV7BvPOo4QUAmqu3uVE1fPBFxkwjyvGcQ5kqk90uEZFNA6be676HMIa0dnpUqZ3BBI1Lm6t1c6UzshXqKi60bjCy2HXnIc9ZjI7pNuBKrbHVLlP5WABtFh9bpzVINrWnTQtqz+ZOdqo2SIxhlkb lLKx+p9M U8MHua8P5jmiEY/CoMFy6RyTeXqrHqhOn6nr3DzXPgztKzbWsDa6tatnv8JT0sSs9oBpWCL6p9/Id5OZ/IKoObMbIOEqlw4Ntd2zgnFSWBYpcFYHbdMckSH3dzlKXyDZ/MBVsENQOgCjgiICRer8IXxIi80MvcYVftgOKQqixAbmKPA3djESD6+ke1vryCcQI8eBpto2u+tq3M9rTlAQQ/J+GKZKV+/9bL+DAr9Mnf02WPWjxakvuBiygmEQWQQc8JYwoWqqrzjAXTPFu2b86AhdDpQjuqrOQqEA3fxx39011q1H5PngqRv2ggZ7oqya7CKm96WwxQu9o7BUVxeM2yjpWdMZCvsyVMH8uU42XkfnajV03ESsAdgBzNmteklzdh/mg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hugh, On 5/10/23 06:52, Hugh Dickins wrote: > To keep balance in future, remember to pte_unmap() after a successful > get_ptep(). And (we might as well) pretend that flush_cache_pages() > really needed a map there, to read the pfn before "unmapping". > > Signed-off-by: Hugh Dickins > --- > arch/parisc/kernel/cache.c | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c > index 1d3b8bc8a623..b0c969b3a300 100644 > --- a/arch/parisc/kernel/cache.c > +++ b/arch/parisc/kernel/cache.c > @@ -425,10 +425,15 @@ void flush_dcache_page(struct page *page) > offset =3D (pgoff - mpnt->vm_pgoff) << PAGE_SHIFT; > addr =3D mpnt->vm_start + offset; > if (parisc_requires_coherency()) { > + bool needs_flush =3D false; > pte_t *ptep; > > ptep =3D get_ptep(mpnt->vm_mm, addr); > - if (ptep && pte_needs_flush(*ptep)) > + if (ptep) { > + needs_flush =3D pte_needs_flush(*ptep); > + pte_unmap(ptep); > + } > + if (needs_flush) > flush_user_cache_page(mpnt, addr); > } else { > /* > @@ -560,14 +565,20 @@ EXPORT_SYMBOL(flush_kernel_dcache_page_addr); > static void flush_cache_page_if_present(struct vm_area_struct *vma, > unsigned long vmaddr, unsigned long pfn) > { > - pte_t *ptep =3D get_ptep(vma->vm_mm, vmaddr); > + bool needs_flush =3D false; > + pte_t *ptep; > > /* > * The pte check is racy and sometimes the flush will trigger > * a non-access TLB miss. Hopefully, the page has already been > * flushed. > */ > - if (ptep && pte_needs_flush(*ptep)) > + ptep =3D get_ptep(vma->vm_mm, vmaddr); > + if (ptep) { > + needs_flush =3D pte_needs_flush(*ptep)) ^^^^^ One ")" too much and lacks a trailing ";" Should be: needs_flush =3D pte_needs_flush(*ptep); With that fixed the kernel compiles and boots sucessfully on parisc. Helge