From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F89E77188 for ; Thu, 9 Jan 2025 02:40:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BA516B00AD; Wed, 8 Jan 2025 21:40:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16AD26B00B4; Wed, 8 Jan 2025 21:40:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFE7E6B00B6; Wed, 8 Jan 2025 21:40:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D33D66B00B4 for ; Wed, 8 Jan 2025 21:40:45 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7D4611C52F2 for ; Thu, 9 Jan 2025 02:40:45 +0000 (UTC) X-FDA: 82986360450.19.3D04C6B Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf18.hostedemail.com (Postfix) with ESMTP id D53941C0006 for ; Thu, 9 Jan 2025 02:40:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736390443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4L8Y6VZpfb3j4/T3LurXqm0oFvGdCkXTzv0qHZu5Ubw=; b=tp5k5/YWdRGxIHv72H1VmtBYEdjnK0KrwFpLM7iMJ6HPeZLVIgyF7/gxScA7wn3HME+Mkw DVn6cA0VIrvEX1BqPh49fA80YvkYJ8AdEdVo0SAwKEWWHyTOwXWQQMqyEPjVktMdgzwh1E 4AEuMju2rgQ4O0dY4P7n/9MzHvoS91g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736390443; a=rsa-sha256; cv=none; b=VLDllJ6hnoIDrlpheXCYxGCzEmrPcMHfh4qifwZxgbq1tPNEWt6YP8axKN2hb7PWBb+Bw9 YZu8dd30S093FuQ5NxyR6PIHN2hGgRo8csDGICkqQvMnAI6ZORozbJIcz2OWww+3b+xt6m UtKVyjnhEH9QooO0izYBGvgpq2IXXKI= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4YT88J4ZTjz1ky2Y; Thu, 9 Jan 2025 10:37:36 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id A27F4140159; Thu, 9 Jan 2025 10:40:38 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 9 Jan 2025 10:40:35 +0800 Subject: Re: [PATCH v4 -next 14/15] sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c To: Joel Granados References: <20241228145746.2783627-1-yukaixiong@huawei.com> <20241228145746.2783627-15-yukaixiong@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: Date: Thu, 9 Jan 2025 10:40:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml500006.china.huawei.com (7.185.36.76) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D53941C0006 X-Rspam-User: X-Stat-Signature: 9wuiu17om8jnso31izk76a8yzesoz6ha X-HE-Tag: 1736390442-106315 X-HE-Meta: U2FsdGVkX1/M4JDdLItN6b6hL+LODoauUcZtqqeN+AFcyLdyNBZYvBX597C/2qH7YNGmFq+hOyYOe0yFVfsv+bHJZ5pFDb6HPXVxJvuQ725u+PB5ByfqlXHHUqFi04yig9cZOtklmTXG2nRLD8fAUzKSZ2lnvJp3IS2H/vzfMPhvjA8QY9NPbKrLJCpCtnlzW+ivILI77k8DOKWBvsfaR1q3kBmICBq+sUBWZo+shKbU2GriUsljBlwyvuB9KPDDp9J7A+m5uCkCvDXnQej1BDjApEo/mchE+Vx+R9S7tXDS20JnPkpXFN1BxcLaz6EKEhYS7tRl652k1UYZOD8MGrE82Zb0b2Ir9yPXulX22J/8Z+U82BNN/bGu3ZK8uS/DSfbv0aWNvL3juDHcefHAIszrbUWgZq+s4mJB8UIURxwDbR3dbOIG2rHyC3tvZ0abnU1ZHkjN/vxU4OYzlBZtR7BIM9/aMsK09sE78CrgvQsLmafxB0/Qxu8RiB9p++ZEvIvJEBgNBURXxryg42GDDv4ve6gFIxK/I3n4w19ti/vJYSE/FG7RS6Qzdh9uUTDwRhCNnwKvW+0qKIbdRV40LYvoIRgPtjz5gDGqWb0pyaBltIvu7kWv6J+HJDmsGRqUFg069XQIGOwqFH7VSgnDWcufv1PWUV8MElmQEy5WxbiFdGIB2wvuVP7jXeTSL/dbwYJ6EvAtO39yDiyfv4HIxfhpQ47cO66ucJt8Rj8/GXIPxVzRT4NRDTSNB/PV7bE1ALCSHLsZMt3kBdi0Nv8j3GR9tk+OP10YpQS4/iF8h3+vMhC8V+qXShHbjzdkyaBobuwOl/XGIUsB5oUX94Mqk70SJnbc1k+HJQuNYWlmfznnyHpKg1l77l4nBSXzL5TC3MAbPt9FPqQ5hNg/gMFEY5D1QHkEKIe/NwPuza79ENgM/3tzxmce8yC9daLd0oLKTCmdhfp188UW+TxfQ80 aD9Cbz0e ylA5gKSBiZ856ooFriXw4y5VLLyuOgmJQVMTL4VlkSbrvuvu3mu5HV4YMfxZBr/4OKuclj4Xf6827W2nnpr7F8q2ILxrjMvFG5fyVazCjiizAS9806+y+qTANsNn8HRk37+Gl1j6qk4FrruGrA0S0D3gZCY+gzK4t5HyHSOIkSt/YPXk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/6 19:59, Joel Granados wrote: > On Sat, Dec 28, 2024 at 10:57:45PM +0800, Kaixiong Yu wrote: >> When CONFIG_SUPERH and CONFIG_VSYSCALL are defined, >> vdso_enabled belongs to arch/sh/kernel/vsyscall/vsyscall.c. >> So, move it into its own file. After this patch is applied, >> all sysctls of vm_table would be moved. So, delete vm_table. >> >> Signed-off-by: Kaixiong Yu >> Reviewed-by: Kees Cook >> --- >> v4: >> - const qualify struct ctl_table vdso_table >> v3: >> - change the title >> --- >> --- >> arch/sh/kernel/vsyscall/vsyscall.c | 14 ++++++++++++++ >> kernel/sysctl.c | 14 -------------- >> 2 files changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/arch/sh/kernel/vsyscall/vsyscall.c b/arch/sh/kernel/vsyscall/vsyscall.c >> index add35c51e017..898132f34e6a 100644 >> --- a/arch/sh/kernel/vsyscall/vsyscall.c >> +++ b/arch/sh/kernel/vsyscall/vsyscall.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> /* >> @@ -30,6 +31,17 @@ static int __init vdso_setup(char *s) >> } >> __setup("vdso=", vdso_setup); >> >> +static const struct ctl_table vdso_table[] = { >> + { >> + .procname = "vdso_enabled", >> + .data = &vdso_enabled, >> + .maxlen = sizeof(vdso_enabled), >> + .mode = 0644, >> + .proc_handler = proc_dointvec, >> + .extra1 = SYSCTL_ZERO, >> + }, >> +}; >> + >> /* >> * These symbols are defined by vsyscall.o to mark the bounds >> * of the ELF DSO images included therein. >> @@ -55,6 +67,8 @@ int __init vsyscall_init(void) >> &vsyscall_trapa_start, >> &vsyscall_trapa_end - &vsyscall_trapa_start); >> >> + register_sysctl_init("vm", vdso_table); >> + >> return 0; >> } >> >> diff --git a/kernel/sysctl.c b/kernel/sysctl.c >> index 7ff07b7560b4..cebd0ef5d19d 100644 >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -2012,23 +2012,9 @@ static struct ctl_table kern_table[] = { >> #endif >> }; >> > As you mentioned in the commit message, this patch has two objectives. > 1. It moves the vdso_enabled table and 2. It removes the vm_table. > Please separate these two in such a way that the second (removal of > vm_table) can be done at the end and is not related to any particular > table under vm_table. I prefer it that way so that the removal of > vm_table does not block the upstreaming of a move that is already > reviewed and ready. > Thank you for your advice ! I will modify it in series patches v5. >> -static struct ctl_table vm_table[] = { >> -#if defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL) >> - { >> - .procname = "vdso_enabled", >> - .data = &vdso_enabled, >> - .maxlen = sizeof(vdso_enabled), >> - .mode = 0644, >> - .proc_handler = proc_dointvec, >> - .extra1 = SYSCTL_ZERO, >> - }, >> -#endif >> -}; >> - >> int __init sysctl_init_bases(void) >> { >> register_sysctl_init("kernel", kern_table); >> - register_sysctl_init("vm", vm_table); >> >> return 0; >> } >> -- >> 2.34.1 >>