From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4B1EB64D9 for ; Thu, 29 Jun 2023 11:25:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741078D0005; Thu, 29 Jun 2023 07:25:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0908D0001; Thu, 29 Jun 2023 07:25:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B8F58D0005; Thu, 29 Jun 2023 07:25:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C6E28D0001 for ; Thu, 29 Jun 2023 07:25:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1BF3BB08FC for ; Thu, 29 Jun 2023 11:25:37 +0000 (UTC) X-FDA: 80955555114.10.BA95803 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E67F7A0009 for ; Thu, 29 Jun 2023 11:25:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BbAtRvjq; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688037935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MLZjhPSDs2jbUkWMScvhL09+fVbydjxBxx9PxiM4n5E=; b=CRC8gQWNuIKU2R+sL160RxFOaqLlHVNiRIpCsRRkMtrqRrGoDiQlOFWnquG+WYrrWO0EmK PEbag6aha1dssRnoxZcxvBx4sdarP9P2FM366TqIcGpIjPIeiZLeQoMUoohKLQXK+DqWgS qmzwAMUXZUS5kOgpOVhxQIBPm8Lg9GU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688037935; a=rsa-sha256; cv=none; b=FDSt7WBc3aXpIp10QPW/v4dLqV+UmNt7OMU8NGj9GRPI9MgHyJNS3WgRDTn93lasKPXvpe D7hrIAMZi1bU55USuK4MB/yLMPEJhlFg9/mAU0+y0zBoIyi2HUDZQ4BeLPpayr7fw2m+VG M3Mj13+tdXRFqPzjpiWnpeov/jxvAaA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BbAtRvjq; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688037934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MLZjhPSDs2jbUkWMScvhL09+fVbydjxBxx9PxiM4n5E=; b=BbAtRvjqM7PcRvsILZeZRMSnBzCuJlV05/FrsKCgXYhWTMcgdV/nEGyxlbQESJSvXWLYt1 FUcM/QdVvuBNLmYLSswDMPYj36f82EVsbJ+kWqMlbmWfuCSkDhDt/ST+fPbs7dRhQZ4n0V /XZD/4bqE2JDADHzkS9r76GOj7/1G+8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-VDryOMnGP3GoG5JKjFkDSg-1; Thu, 29 Jun 2023 07:25:32 -0400 X-MC-Unique: VDryOMnGP3GoG5JKjFkDSg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fb8284465aso3230395e9.2 for ; Thu, 29 Jun 2023 04:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688037932; x=1690629932; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MLZjhPSDs2jbUkWMScvhL09+fVbydjxBxx9PxiM4n5E=; b=YYfv687d+lLmsekR9Go3zmZqwq+XhxNKOQiMY2mFKZeXBDcepdaDwetQaPgXD/BLyP MwVXsfPAqi12Twm3jTixCFtMSkib+n9FWs+UfrhaAQ/s5ud6xzvDgJVzMsgDnnfPOw+y 8pQqcKVEl9GyGRbOnXpBMfWh98MfCk8tl1L6jp4hAXr8Ww1alwmwfk/9thAf47H23zL1 DMcoteASbnKgdEr+nJBmwMhbiCQhdOHIO8LOaSQbf1LoNZQp9XWzwOcZSOnYYgNs0YMt xEL6vNy6Po/uybyUswUZt20kjpnG57AjwGzvn8nwpfX/je031N+NJ7aMZ/HHKGNZuQX/ aPVA== X-Gm-Message-State: AC+VfDyfoQO8h4dZaRamZyXFuahbnDCvTFBZF50GzS1p14ABA8JEUaaO ptId0tKRkTrRfJjlMwlnDbvlnOFqmrZ5TS+h5lqTewK/1J6WyeIFFpQtIHIPh3Pirvkczd9WhFs 9BFhCmrMxveU= X-Received: by 2002:a7b:c459:0:b0:3fa:9538:963e with SMTP id l25-20020a7bc459000000b003fa9538963emr10234799wmi.36.1688037931807; Thu, 29 Jun 2023 04:25:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ628Q4gxMxKyLmVOvyUnZ4boNo/9yvt5+6bcsHZz9c7sCmO6cfmesV2vUoXvwer0wrC4vP+Ww== X-Received: by 2002:a7b:c459:0:b0:3fa:9538:963e with SMTP id l25-20020a7bc459000000b003fa9538963emr10234783wmi.36.1688037931438; Thu, 29 Jun 2023 04:25:31 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id r10-20020a05600c284a00b003fbac7b52dfsm5338520wmb.3.2023.06.29.04.25.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 04:25:30 -0700 (PDT) Message-ID: Date: Thu, 29 Jun 2023 13:25:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure To: "Huang, Kai" , "Gao, Chao" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "kirill.shutemov@linux.intel.com" , "Chatre, Reinette" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , "x86@kernel.org" References: <7c4b54cbbb887a3b7e468819a2cf11f7434674cc.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <7c4b54cbbb887a3b7e468819a2cf11f7434674cc.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E67F7A0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ancexpn6oc356cmw177f783r6f4bybia X-HE-Tag: 1688037934-359905 X-HE-Meta: U2FsdGVkX1+vWrXG+XqPx9iGhVw7m7f3rjG8vUqD5gByy4mQqdTLmgSxnWC0g1V7rAjgKj66EHzgX8h1jIOQU5jqWR2yzMTmvTvKeAFACvenvyLo2eeg5xfkxjxjD32+eOXYK/2wP7kV9d+HYb0+YD7tSDyarhMasRphDGAlglcRTu6hCbQIs5mPn2uATJ9ztJZ38k1rNiKZMJTlBfSvAd1ZNt64zcBqxlTqXgXRsgWNiucCOitmZ2WsWHM3sEdwiop/bweG6xrBhtJmZDHhhCTVRQU36FLW4he/0gp4EQ9sp9ToPOp13R6E8JyIQPaXR0zujABkKFeGj5l6VHFzjjO7oeSSPUfoW2TzAHbHKAoBoB+XHsTRdo3kdwbDzwGSWd/9PjIqRFXFvyrxMeDGsKAzHCSvhFOh1+gUMRVGqGp06oppzS5j2PPzw5G/AXemI+im99qmxZMxtA9Qf7yJImVnNbktmDCPT1be5zX60spS52W0ZBYDgjn0g4ze/Qs1CIBXu9fNY/Qm42/isYG20wlbR0SoMkGi+pJvZLIrAPSUWzt6VmXgpwVbm8Gu9SHrt1PyO4b/GwlG7qYq1AVK0gRD7YoqltrJSAY30uhMR7rrQ3Evqlnsht5Ij1KPK9telb3c0irFQXPvqgVRyrUIe0CGB0Vjusun6oGNtZR7ZGyKcR5qpNCy0IQaDpYY7rfDtg4ZNuXqIGRN+iTnAXVEJnBAz79XnFZRmIVQlQ0i11UJ39YYwzf1rPFLjLtXMDivLa4iwCeY/dfLEUUtXwT8kk0yPAGUSfrTv3CbQaoLfwsg63cOHzGtJ/7C+HohQ4oVtMl3+nnj+2di92i6M48UKVc1QxTJNnMeQUdl0bUIAYx0HWpfRvTZksJ0iBQiShI1RayVqIjEETQufM/TpCEiYsUKnW16P7YYI33B/g3I8GD3iwU/V0di+454v9kAqYjee23hJKRtt3pSb4i6Q+m rHjgZdIc dMHkE5E4zojdFlPtYTfZ6hDJg97k5MPiD7sJktGjBNeXrrRrHneBgVECY/ZA4f5DUrTzUcNvKknd/zacXCYLfHnbrBLnEXLKNmWtPOPKkusLIdiVv4/d4C74eepMmFqEzqZdUzYGpICGJBkPx5CU+yBU0nAbkMDHOEBi3MldbDhaMqUNnBSNJ7EnRLTUsdjHUTj4t5aZ+4f6pO2mHPhpT5q7J9LsX8aiva2vXDZnPTvCksTms7Pf9gX4d8Gpv5uet31JmhGWg2XxoR1AUkd4dA7Wyw/1jTB7WPI0h4rYUM8P73rQdzu90eMtDs9xuF/y+9rFAQD1r7+QyYW8I7botFySRqhXXdYIB+gigWaKOQIIUDOoEQhmjr9QabHhRA5ahreYVqKkah07MSSLS73j6SgeUDa/8cjo17zjGnT6kA8LsEZ4F+ZkWrs8+JPTOs0PWFaYHuN8rLdjMfq4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> then the code becomes self-explanatory. i.e., you can drop the comment. > > If using this, I ended up with below: > > --- a/arch/x86/include/asm/tdx.h > +++ b/arch/x86/include/asm/tdx.h > @@ -23,6 +23,8 @@ > #define TDX_SEAMCALL_GP (TDX_SW_ERROR | X86_TRAP_GP) > #define TDX_SEAMCALL_UD (TDX_SW_ERROR | X86_TRAP_UD) > > +#define TDX_SUCCESS 0 > + > > Hi Kirill/Dave/David, > > Are you happy with this? Yes, all sounds good to me! -- Cheers, David / dhildenb