From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88DAD64079 for ; Fri, 8 Nov 2024 19:23:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46EC66B00C2; Fri, 8 Nov 2024 14:23:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41E636B00C3; Fri, 8 Nov 2024 14:23:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BF3B8D0001; Fri, 8 Nov 2024 14:23:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0BC516B00C2 for ; Fri, 8 Nov 2024 14:23:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B18F81C6C38 for ; Fri, 8 Nov 2024 19:23:03 +0000 (UTC) X-FDA: 82763900310.14.EB49F4E Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf13.hostedemail.com (Postfix) with ESMTP id 900B620021 for ; Fri, 8 Nov 2024 19:22:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=LPZL+vRs; dmarc=none; spf=pass (imf13.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.173 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731093721; a=rsa-sha256; cv=none; b=ilNutUdhCBhX13cO/ldk4WRLymRhjk3KkeId6V4pZlkrpkyPTK0mOIdeq2kCWJ7YPiRmyP RYblaBxKbF8wEvzJrW75mvAITMWKxtO+7y/yB4ZED5PxT4MpDwyktluvUcR3DJVo9qGDsy vqhHC+GCeaxhXTPC8o4mqx8xoa1E4D4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=LPZL+vRs; dmarc=none; spf=pass (imf13.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.173 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731093721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0WHvEPzIuaCnloxy5m0FklyFacTs1MbmOXmxDfeZH5M=; b=XQr+uyHiXHxy2FsCKGw+EclWQBNLVnZTKdcOabCdTA8EbaFLVHXPnd0jwtK7B85MbQkkCk xe943qLxQMB1DSqUcqEeIU2gpHj00TLbddBpm6GCYMb0vNVAF/CMsmt21OdonqhoeGCuhO mod6dgNy0przLSR4Rvw1PaG0eqtM2a4= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20c803787abso22103495ad.0 for ; Fri, 08 Nov 2024 11:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731093780; x=1731698580; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0WHvEPzIuaCnloxy5m0FklyFacTs1MbmOXmxDfeZH5M=; b=LPZL+vRsCIntMlt4xcHQmoLc9Vxko6HukF5NJaZkrK1PJ8hB8g5/QLmpG7It2p9i5p qmhyVsqqGj4k2fD6FgTYpoY+0AZM8casdrpjtdNi73OazOpRY99e9S4d0s+Fg+pnVO1i Q0xqexktrFI9mm1qFp0MpLMaCzgjgCsEjZP1B0C1hmv0wg1uO93ynzVwVf8NPGboUveP YxlQuFSKS1laccn0o+RO+GhbORLH0/P+WbJKLSJd0+KTqhQ61gvpAe4VmnQb5KHpaR/0 VXDqYRAkLsvQ1VL9VLpXqHdnQa84Y+fRHMzPy4saOXpVLaZFjfgn4cpk0J1LBzv0snXy hd6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731093780; x=1731698580; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0WHvEPzIuaCnloxy5m0FklyFacTs1MbmOXmxDfeZH5M=; b=i9HpCCnOC9sZadQYeQKD2JvaopNq4XxGrwq7FL4u0Ei1LAfq5I1GvH8DBx+d5dnCO1 tN4z2H80Nutyq9jL8iBhqsPs1gtav7kqxz5tJ/uhszG1khFlzwu68G3028fkAgIRqjFW rlNcsJnKB2J7A9uZ+dEmDj2tMRfr2l5ao4lNqlZTyeu7RSEIHbeJc+6wBQMKDTyhTQxr /etIrz9q7yU5wz4N204PmJH9RLiHykvLqtP6hlvtJNXsYUnHbg9SWZM3flMTh5VQr8LP Wrg1ZXRNQcjvHkd6b58y9UajMJxokxarmKicVc1wT4O0hZ3qzZX04/1Ho/Sz1X1bVfbh mywA== X-Gm-Message-State: AOJu0YzgH7mrxgc35odZbNSb3rfBOi3HKi379bRqWdklswwa22xV57IC qH4srySTWmUyVSWfoiPoz1pUYwq3RGfTkR5a3aM0po88O70ZbZq5sCL2N1QYgFs= X-Google-Smtp-Source: AGHT+IH5C0D4ueeoqV9ISt39iXPf8LxCV5vetd5L0Cqq3YdVf2ODnHsEYmqvjt7hO0+vEYelcHAarQ== X-Received: by 2002:a17:903:945:b0:20b:a9b2:b558 with SMTP id d9443c01a7336-2118223b6b4mr62359465ad.28.1731093780491; Fri, 08 Nov 2024 11:23:00 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177ddf2b8sm34454365ad.91.2024.11.08.11.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 11:22:59 -0800 (PST) Message-ID: Date: Fri, 8 Nov 2024 12:22:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/13] mm/readahead: add readahead_control->uncached member To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org References: <20241108174505.1214230-1-axboe@kernel.dk> <20241108174505.1214230-5-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 900B620021 X-Rspamd-Server: rspam11 X-Stat-Signature: e315zkig9r46xqipw7aghpxpbf11byuk X-HE-Tag: 1731093743-178947 X-HE-Meta: U2FsdGVkX19k3vdAhTleKYsQElI7dKx64qPRIohdZwoQ+vLWRD4G4L7WPdPS30SptF+PuKrTv//IWhuD9qPPQ3XORjmbwgmP81gdGffRZ4M3jSdVTYvNK64JDVyGqp1U+n7Mrh+pdkl7npTzVFwEHW/n9zl5Z8dAF7QkDp1veMvhmTJ7HyCNB0eYl9HcyfsrgIPyaJho2XEeWJBFNP21YNzsPFXw7xQ6d2XUHyX1MAcMEryeBsbXC4cWBcaEGhl2YcrHD1XV01TxLsysosl+2VboJ+FOCqgq4yupbGLy94HIQximozsZm5lQa0e2vbbaQLkNBxuHzA8dV6HH3yUDfJ3A0V5qJjTgve7wWKcgfSZ7dAhtiI1UzLgx0yt6RiIToIGQn+m4IiuAK8Pg+y4Wp/k0/mypLD9my0c/G4Ajds4Rishw0/zr+voXnRdIiTxaoGH9BJlpLO7RT6qq7M7FAFS/ltZeBkX9f207vUy8mGhZP+1yH7WNVEcx7FENFOlM4erahf9xEN76v8By+8ADy/Fqcb9oy8rEbT321W6tpsYZmQPMWK0MaABiwxCIv32zMR8vs1Xufbf9YXPdpuUSpL/C9OPFf1Wu+ILG+2GTkCtbwLpe+1MBb2TdTH5eHVRkXcu4v8utNxa9KnEM8PngXjqOa1zJqMLdw34BnNqghmiGmzNoJu1ssfeD1aySl9RwGnpRaWccpEXJtbN6nidANHEmrkjwvxLDjZg5RVWrjZIKcSxXhVhp0wF7wCMs0aDGqoLR3/EoZZ47YTEFwdpqtMlMZ/3GMwPYlTLSRoCxp51LQ60kvr81Iit3NHzMYT4aaFPJARACBcgwS18LCvz/ZU7cW7ikJz40a6zl2DNpp/o4JZjHyX9y2kCvvlzGysDDRq14+XUSSTHdHMox7FLVtkLXo3SgjT+4ISKB8bcbvCfjwTKHqfsPG61WA+cQMADnLlal95TVrSDb7/8VO2Z g7bLBOuH Vta7fV7lhUwcksTyjko4OK7r57AiEHpVuQ4cb0TgYXYAc1oyD+aHuJ4DN3CRNwTqjPbFV5RmiI6dmXYItA+zfxevsNeZwOxnDXYL8AmGn1YpUCtq+q1hfPdTGaeWpHIiJHdnbEt9JE9vJa4SQx5uDgI6n7tHO29Q9/hVGmzDGb1zDnbOnGXWt4OtvKP+HJCrIe8R0QY/D/ID0rgUyHtjjoDH/GgAucEPXIk8yh3KM95xeZgcWQ1u3ilRDuqIZl8GWu61eDK8ZWqPdrs/WstMklguR8vX3tU3egeKToYSn/U/8CFnPCkZZls7+/4rL7aVBQx5ig7MyAKQjQtvJsWGeAaogbDiQpV/J7gmzV6RjtOAH8AN2641bgVyi3sbJiWaGPpW5hHowKwHyoAt4o4UqGWhRtA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/8/24 11:21 AM, Matthew Wilcox wrote: > On Fri, Nov 08, 2024 at 10:43:27AM -0700, Jens Axboe wrote: >> +++ b/mm/readahead.c >> @@ -191,7 +191,13 @@ static void read_pages(struct readahead_control *rac) >> static struct folio *ractl_alloc_folio(struct readahead_control *ractl, >> gfp_t gfp_mask, unsigned int order) >> { >> - return filemap_alloc_folio(gfp_mask, order); >> + struct folio *folio; >> + >> + folio = filemap_alloc_folio(gfp_mask, order); >> + if (folio && ractl->uncached) >> + folio_set_uncached(folio); > > If we've just allocated it, it should be safe to use > __folio_set_uncached() here, no? Indeed, we can use __folio_set_uncached() here. I'll make that change. > Not that I'm keen on using a folio flag here, but I'm reserving judgement > on that unti I've got further through this series and see how it's used. > I can see that it might be necessary. I knew that'd be one of the more contentious items here... On the read side, we can get by without the flag. But for writeback we do need it. I just kept it consistent and used folio_*_uncached() throughout because of that. -- Jens Axboe