From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F59C54E49 for ; Mon, 26 Feb 2024 12:25:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2532C44014C; Mon, 26 Feb 2024 07:25:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 203DB440147; Mon, 26 Feb 2024 07:25:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07D9344014C; Mon, 26 Feb 2024 07:25:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EAFD8440147 for ; Mon, 26 Feb 2024 07:25:43 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 10D78A05C0 for ; Mon, 26 Feb 2024 12:25:43 +0000 (UTC) X-FDA: 81833876166.10.D80C3F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id F11E380005 for ; Mon, 26 Feb 2024 12:25:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N7KW9Whk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708950340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tXZ4/4DyitC4cbf8BiH5neNQ1PVB2r33RhJlhPvfLaU=; b=4ao23hPf+ASL6IPaU7t0+CLPmuaS4yQQ2DPzrIPWmYA++JzsZFAf6GQCjZaPLaUy8qU2Wa CmdOtkioP1YdaOaKnhp+P25kq8i11DuLAqkwH6y+zqb4Y2dG4sF0HqwyqJqlIZzOZiHav0 VGncCDRT/A9mL0uKxHpBTX+iyJpOrgo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N7KW9Whk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708950340; a=rsa-sha256; cv=none; b=0i+myEvocwG9uIP3WCUEHQ5L9T9vrd1RS5HVDQhpuRz6hiN9k1g8oOYdQWqpk60ev/tCOn znv2ZBWyElgjvLZQ3Mz+jOGooMp9RJiOFU6vjC7GizUJFTFQwVkp3LJ1fDvGesp8/+XjaB E6mn87ef1fgSyaVpvIB1UW0uZ5XSd1s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708950338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tXZ4/4DyitC4cbf8BiH5neNQ1PVB2r33RhJlhPvfLaU=; b=N7KW9Whk7+LgLN+HTQZ14cPS+1k4unuiW4wAPFcWP45gE7O/x4pX5pEeE8m3gazmKhUCwE AORmRfqSuFgbLGR8IH/Rel+/YOyC4rDyWQeylDviiIdzO6mz7/LLEXuU+1bBxQ5ADV5QX4 AzMiLRyHx/9oAkNeppKDxQMzGmzllx8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-gHkm_Q4LN7q4BHYPtwGhoQ-1; Mon, 26 Feb 2024 07:25:37 -0500 X-MC-Unique: gHkm_Q4LN7q4BHYPtwGhoQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-33dadb50731so1630940f8f.1 for ; Mon, 26 Feb 2024 04:25:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708950336; x=1709555136; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tXZ4/4DyitC4cbf8BiH5neNQ1PVB2r33RhJlhPvfLaU=; b=hTLE7W87JA8rGmbD1VfFOdxVg8S351GtT/zYcHfyPAZb/rX3mptW42h98CleGQPfXA J9ubgHp5k/6k1uMhbjvNNfNka3giqZCtrq5z0zPMLDt+++bFcbNc2Z5v6F1prjUrTDO/ 8LhR8oaSmIXewKP51UPpd5OvX73JS4Pyb6CX6K8r9dQUxDFeAWCf3Qx7s6OEXN4huFmq 2hxOoOKaqzRE8XX/UCMjY87bGf5bRarLzfRXMnz/aJx9+OibShYoBIFMpblw23gmyvLq ZLOyvOCceLOB6j0JzvyHuIXvofPHBWRxQw9LOXOVNgT2doWVsNAKkkF+IoATAvRGYZFq IWkw== X-Forwarded-Encrypted: i=1; AJvYcCVqY7mNGuxlNN2z9aOKMdLQwE8Pupgrf88TKbjAwodmCfo9haAXMomBHGUrCzvWRlCkahEJaHVg4LMyr9/1+cWHdgs= X-Gm-Message-State: AOJu0YwxppdwZMekTl2fSVktcGKbXqgyqtt0xt7Dhyz08j+2XrY6G42O e/3Q0SBi2aQkI8fvKMBPCJRxDgk4cS6WZcVmu2z2StQQtsWUrRC/H3MTzSNn16fjALtML8xI9ym 00mkB4D2D8OqW7GJlHhUhAqbRRLDLrWtdHVva9ZGGP18XXUG6 X-Received: by 2002:a5d:58e6:0:b0:33d:1517:8dd7 with SMTP id f6-20020a5d58e6000000b0033d15178dd7mr5266751wrd.8.1708950336024; Mon, 26 Feb 2024 04:25:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMd13//2i4XzyIwPOMo4B/+30dDfchEJt9kprRDAxOw4649nSjP1kz+fYlgEdK0+aMa1nz3g== X-Received: by 2002:a5d:58e6:0:b0:33d:1517:8dd7 with SMTP id f6-20020a5d58e6000000b0033d15178dd7mr5266734wrd.8.1708950335599; Mon, 26 Feb 2024 04:25:35 -0800 (PST) Received: from ?IPV6:2003:cb:c72f:f700:104b:9184:1b45:1898? (p200300cbc72ff700104b91841b451898.dip0.t-ipconnect.de. [2003:cb:c72f:f700:104b:9184:1b45:1898]) by smtp.gmail.com with ESMTPSA id bp19-20020a5d5a93000000b0033d4c3b0beesm8439737wrb.19.2024.02.26.04.25.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 04:25:35 -0800 (PST) Message-ID: Date: Mon, 26 Feb 2024 13:25:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64/mm: Export contpte symbols only to GPL users To: Ryan Roberts , Andrew Morton , Catalin Marinas , Mark Rutland , John Hubbard Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org References: <20240226120321.1055731-1-ryan.roberts@arm.com> <20240226120321.1055731-2-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240226120321.1055731-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F11E380005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jmrj4kbnrsykxc7q9gri31dpjsdruppb X-HE-Tag: 1708950338-904472 X-HE-Meta: U2FsdGVkX1/m+Hw+2eEBe2SwcMTRFI7ldhE9Xhovm6ynurrqYEHRhWhPlM91P7n7rIg/8/Wup6gw/XFTm1f66GP3GS2IxSWRPWSXgIld5LUdZTWocvJCdSDr2lKoV8Qj+V2k4Ld00wMjOYaXSf3RP7OhZKYDTT5e5GfKPREDJ4vCr5AND+er7rw92IO7OamrPz0jk4VmQ515f2p50o2pzpX+rZ7BfYlfkVrUBx7ZrFothccoDq9T6brpoUDHnRjt/NNFwWsDAeOpUS+m7QbUgFzQ/vhKO6wSqf6OcUovbFjDmz+re/or5fD7YewJloiPzHlFpQC/s7XJMTnDsU36xdNyDXnecCCt/0KAW3BnV1wo7eNT4gmIw4cRiBLEkROIQKpRoIPWy1dbCfC6pRJWbEwL6eCE03QR9jGST31LAi2HU6S3V++hUPi5A13LtkdWGi9V0Fcd6W07N57NERtgSie8HzXx6wWqDvbFzg8l0gnhvyxKV12JeIf6UO+hcOBi0PAk5KA0jjMPMPdmjx3b1U7H6LY3OH5Tsqupm9xkJ8rliQgVgVut39pq2HhyxiqHGGdFiIGPgTPSV2ReAjsOGYrfIHR6Ct0qDFXl+dLnJRUCEDEq4s7djvToAwSUlqwvjarh8iHJSBozqmLq6oKnHmtt9g1yJUDrBNHLAXcVfpOJdcUEAl7rgFzTxl5N1BK300bHH+YwqX8ZAlOD6DKBFjx2++6v3DqEx3BcUPu9twrfV30HZH1p9ryTMMZdm8DVBdwfVbeNXnNCuluwjI12w/tdjLP1dY72YQ7Oo2l5D0crZmTDNQzGePkeU1Gg3mIp/a8gD8zU9aFZBbpoqWOhzrgoUSFooRVFaJ6g4ODVhgacCWTBaCqBwCci+Aj8H+Vtg9gYeqmcUREVJ7h6iVfu5Wwoe/xBWb/YVKcN38yLcELUZo2ZR38LIcd17ibWQDDhiEpR7mSHiiuuUVLhxMt iYrEDwQ/ dyToRXygJhCFVwSmRxHJtQXdpb1mPxzh+c3PhY7t3W6vu8w8TTLrPRdzoXX8Aqo5NNq11xUFuRbBbh8TsSAiEN5R/cEgFXzK9v0ctI8iD+DJIydNGpg9Ppl+Kd40AVO+T1l6tOBkY+3GGtjowfeef6PLJrK2nyE1ZG3FRgMyK0xX59HJoG3mozDDyqY0FV1q6sk56Qka9tmfwAG1Ktt6pSotCYoonCkD5qDtQ1USHLY+e+TwXJb9+bUJbjelW3hd4hBgudcuUxEObAYBa2QZOU5lKwFJCPTGGyQhMMvpDX9n/yI0ZI/TMA/aGh+TtAFWVv+3edAN1792c2hQ3UcfKpSCilcfZtpBeno1h6/n68B1QU3XuC07neztrBXPnWNEwoS4upTIZIFnKSwtuKqYjVowNoMcuSvdzFILoFIbsezHRt55OxDdp4QzwFeCnim+kuGDC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.02.24 13:03, Ryan Roberts wrote: > The contpte symbols must be exported since some of the public inline > ptep_* APIs are called from modules and these inlines now call the > contpte functions. Originally they were exported as EXPORT_SYMBOL() for > fear of breaking out-of-tree modules. But we subsequently concluded that > EXPORT_SYMBOL_GPL() should be safe since these functions are deeply core > mm routines, and any module operating at this level is not going to be > able to survive on EXPORT_SYMBOL alone. > I only looked at __set_ptes() to get a feeling what would currently work. __set_ptes() might already call __sync_icache_dcache() via __sync_cache_and_tags(), that is EXPORT_SYMBOL_GPL. [mte_sync_tags() is not exported at all, so maybe it's safe to assume that some out-of-tree module could not make good use of set_pte_at() in general] Acked-by: David Hildenbrand -- Cheers, David / dhildenb