From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A90CE7CE6 for ; Tue, 1 Oct 2024 07:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FA55280057; Tue, 1 Oct 2024 03:56:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AABD280036; Tue, 1 Oct 2024 03:56:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D4AD280057; Tue, 1 Oct 2024 03:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1DE9F280036 for ; Tue, 1 Oct 2024 03:56:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A518C140E35 for ; Tue, 1 Oct 2024 07:56:37 +0000 (UTC) X-FDA: 82624276434.17.C8D2817 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 5B70B160010 for ; Tue, 1 Oct 2024 07:56:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Qkwl/YS6"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727769302; a=rsa-sha256; cv=none; b=6RJW8inB+OHESyeanlB+tfQ4d9tepBD3Uaby6ZgsaQ0JnxtLrehKq7RcL4EZN/1ivivKck Fi4nzO4W7St2UJIHzLaCezPFt65+u6T8Rd6BcrXsao3M934Hx7dqh99cPVa0I6hgd5nJN8 T22pUxxZB/eUhgUs02ZfMnmFvCl1pXA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Qkwl/YS6"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727769302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cbH8XpzflwSTa9FMVre7AgUkuPu4oSVgTfzk1ypDcwE=; b=3hfi10S+mgyftxH/9fcw05+hNpE1SdkmZiBqzmq0lq46aAi3G8/MdG4w71e40m3sOx1/0I vu1BhRzVrKb/0tY15pK3MU6+pPFCPsrPVMnW+pQDJunYPgP5/mV+gY4ayt5j9rz1G8cFKY jQ1gYMuWqpvFhlW5tWS2VJBIZy8qMIE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727769394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cbH8XpzflwSTa9FMVre7AgUkuPu4oSVgTfzk1ypDcwE=; b=Qkwl/YS6OJAlP+EhVm9lC4e78mHA7VvPveGzfgsfrsErI49CiLFWEDyFi45vIDXXxy/7jf 6oUEFTTvgUqgvad8pmHR9/4/zoEsZuQZBUllqa/tuNGlNJEBqEKn0dR2SdKUg3cAX2dtlo pmQiitOmlJ/TQwdT8QMbSHOSWrr3ows= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-fgseMqiYOryLS7JZkEuHLQ-1; Tue, 01 Oct 2024 03:56:33 -0400 X-MC-Unique: fgseMqiYOryLS7JZkEuHLQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42ac185e26cso40994315e9.3 for ; Tue, 01 Oct 2024 00:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727769392; x=1728374192; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cbH8XpzflwSTa9FMVre7AgUkuPu4oSVgTfzk1ypDcwE=; b=iyWMpLM4c4WZvX4SlMJV3C6H3aPkTDkDvqeEq7ofQOhwCEJU/OLjY2aqTaaeYD5w/q ot9bWtsH9in8F1bBr9xb1kseuh647RgTMT2LOsrRNElQ9P7kEaZ+on3H1Kql3caMzy+l ELAskSX/K8HOqU0FV5jCKk4MmgKxUUVQbMEzuVGCMlUoetCQK3PGloRXd3XtnKJAta7z UVdly5dMg58HX07c/sS0kQagKFQ+79TQzvdUzj3zQByLEYAR6HiS3IDQB/OomCWXrPxx 1ZtE0sOJYx5z5eUxRCHFpwN+GX3mlbePnUYG6lnXUNgeJ+srs9KFOsCxnn1H+wa7eK/S h/6w== X-Forwarded-Encrypted: i=1; AJvYcCVUJQFv2AQ+tqoI8gzyGlmg/xF8GdkwO0ZtrrjS3oMwBAqbZDHav8Jy4gcqgZDLA0K9EUbrUpo8NQ==@kvack.org X-Gm-Message-State: AOJu0YyLtiPfO2xyNM5ozk5kbA2UkWqlxeSiFDzWi5oh7ybtiITV/FFS 2HZDK2RUQq/LR8ZJYaGFRcEx6NDBF8LMEC96+kTWjh8smtF4QX3D0ESJDVEjFV+H7xOpyt5ZX0Q FYFESq8fuOJ44YHWcGm7LiJJLajkD+ytXgXid/8+SFC9HUVLL X-Received: by 2002:a05:600c:5254:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-42f584347a3mr116624755e9.14.1727769392448; Tue, 01 Oct 2024 00:56:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQhqmU2cWYjY+tEC5W3ihB5hcxwnPWrPcZ+Vwc2MHQ3nR+ln898OKJE10BR5q9novtPOP9GQ== X-Received: by 2002:a05:600c:5254:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-42f584347a3mr116624545e9.14.1727769391966; Tue, 01 Oct 2024 00:56:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c733:a800:ea78:e754:1995:5390? (p200300cbc733a800ea78e75419955390.dip0.t-ipconnect.de. [2003:cb:c733:a800:ea78:e754:1995:5390]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969ffb11sm173758395e9.21.2024.10.01.00.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 00:56:30 -0700 (PDT) Message-ID: Date: Tue, 1 Oct 2024 09:56:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tdx, memory hotplug: Check whole hot-adding memory range for TDX To: Dan Williams , Huang Ying , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" Cc: x86@kernel.org, Andrew Morton , Oscar Salvador , linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kai Huang , "H. Peter Anvin" , Andy Lutomirski References: <20240930055112.344206-1-ying.huang@intel.com> <66fb9a89dd814_964fe294ed@dwillia2-xfh.jf.intel.com.notmuch> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <66fb9a89dd814_964fe294ed@dwillia2-xfh.jf.intel.com.notmuch> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5B70B160010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7n8feihz5tge3irxwzybta6r8dcayicm X-HE-Tag: 1727769395-262930 X-HE-Meta: U2FsdGVkX1/cEpabc55B4k46iMFDXy6n6tEKSbFKcGF2sPbQlzWb4xt+NiYA/Uzjx/1oYBygzLPexf4oBidKILtAo5Ud0mqVPQvJcAHKzuFGGNke0xSqLi0GVT15tuqQx5J6rSdlTJbFKcaSz2rRQspMedQeR3WYWktHodFrVcLJK056AwvfVcaTnKKpuIGgmcgJKtzd5A1FXtrtyMI9jPFkeA7UCMVWgRlk1yD4V1crNBAo/hwdrIL3hSVhY9d+Fad/Ww62iw71CRFn1y4+i5kvyHWAZTGAvyMoOs4iLUtxxCey64bAlcG0jq/B9xY3KhnqSvj2wv0WT0MqM8QzPpz+iET/GrjQsW2Uzg288LjOzFtSOtCI9IlrveKPnSuGBfodFUx9vCK1wqVnyf/0zbrahXRs2PuY/bBwfcpO3kHG4unKwPXBeUpYrlRHHzWFNvCvLaHIc3E+I17BGgrhJv1N3mo5VWP6jFtyQ4N2e81dUtJxgTZyg1Ayqynd03Y+QtmFOGAJHqlpsMGhihmIrja6M1MYSXA4GFSOB0pOTUg88qtX8rwGuizEQqKt4noFui9JWQNRWfVyaZtmE1SNPdC0nB3WxwUBtWYIMSBt13OixsFXIHItqkwaVSVGRMcyzJosnOWFsHGwzpf8QSe1pwSHHCvtGBYW5ov6ksVyNRFjzdEGhHTwvTXiJOKH47a1mVinoSIuIksyu37pW3OQEQ5q7/WZptON/xdNDL3cWz1VtV8FDewGEiYYKApn+eSci6E0fz3nCAyONsmkYW7SmpcXUPXqjU8lBO32WGgxssl6ajUvwsoqPg8+Gg0KeBv5cMMi9iqJ8Dx73YeolhbCvF+k5/jvFVtSp8QEq8ZJraw972kI/iUBx41u7+zGmKjL8v1BHVdgwFtz/z2Lmb0nwtqxcpi5su4MRMj8eTh6cbxEHL+ghy95gMNKtHQ0gtYlyQvSl//j3kztFZy9xw3 cuoiZyi3 819MAHWeH7C2PziMrZiPWRLpSybggakZeH04two898y7CK8f6Lpj/0epBP1wWvQZktQC7GFoQgtya8Tpeg1JeUOJx1HXP7EVjzgr7RO7kzJzh3Lzh6fcZRRJjcC7hLEvKGWs5ovB+mXcPYDwtntV2A3JDXrWB/ocnoRhAMHsogBd0SFGuaepT3VoFgM2T69nb91eeVNYi/2MktGe9xw7eqGiRP7wS5pdzFgcelbOqq0SegzR0f3iPtt+qYv7NDnb6z0rfDjfW12gnAnA55ZOS3Y7WAV9mM5vCUhy0ts548M3gfbvU5FL+tLt0m1vychdC2/dL3crW//LjBlpq64aTTHpjyrbX+4d3S0Io55/mCLzpA+Rg1wx2NIOimKkJx0liibGhcITgD1Jqz6zXwpU5w8RV1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.10.24 08:45, Dan Williams wrote: > David Hildenbrand wrote: >> On 30.09.24 07:51, Huang Ying wrote: >>> On systems with TDX (Trust Domain eXtensions) enabled, memory ranges >>> hot-added must be checked for compatibility by TDX. This is currently >>> implemented through memory hotplug notifiers for each memory_block. >>> If a memory range which isn't TDX compatible is hot-added, for >>> example, some CXL memory, the command line as follows, >>> >>> $ echo 1 > /sys/devices/system/node/nodeX/memoryY/online >>> >>> will report something like, >>> >>> bash: echo: write error: Operation not permitted >>> >>> If pr_debug() is enabled, the error message like below will be shown >>> in the kernel log, >>> >>> online_pages [mem 0xXXXXXXXXXX-0xXXXXXXXXXX] failed >>> >>> Both are too general to root cause the problem. This will confuse >>> users. One solution is to print some error messages in the TDX memory >>> hotplug notifier. However, memory hotplug notifiers are called for >>> each memory block, so this may lead to a large volume of messages in >>> the kernel log if a large number of memory blocks are onlined with a >>> script or automatically. For example, the typical size of memory >>> block is 128MB on x86_64, when online 64GB CXL memory, 512 messages >>> will be logged. >> >> ratelimiting would likely help here a lot, but I agree that it is >> suboptimal. >> >>> >>> Therefore, in this patch, the whole hot-adding memory range is checked >>> for TDX compatibility through a newly added architecture specific >>> function (arch_check_hotplug_memory_range()). If rejected, the memory >>> hot-adding will be aborted with a proper kernel log message. Which >>> looks like something as below, >>> >>> virt/tdx: Reject hot-adding memory range: 0xXXXXXXXX-0xXXXXXXXX for TDX compatibility. >> > > The target use case is to support CXL memory on TDX enabled systems. >>> If the CXL memory isn't compatible with TDX, the whole CXL memory >>> range hot-adding will be rejected. While the CXL memory can still be >>> used via devdax interface. >> >> I'm curious, why can that memory be used through devdax but not through >> the buddy? I'm probably missing something important :) > > TDX requires memory that supports integrity and encryption. Until > platforms and expanders with a technology called CXL TSP arrives, CXL > memory is not able to join the TCB. > > The TDX code for simplicity assumes that only memory present at boot > might be capable of TDX and that everything else is not. So is there ever a chance where add_memory() would actually work now with TDX? Or can we just simplify and unconditionally reject add_memory() if TDX is enabled? > > Confidential VMs use guest_mem_fd to allocate memory, and that only > pulls from the page allocator as a backend. > > This ability to use devdax in an offline mode is a hack to not Thanks, I was missing the "hack" of it, and somehow (once again) assumed that we would be hotplugging memory into confidential VMs. -- Cheers, David / dhildenb