From: Alistair Popple <apopple@nvidia.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org
Cc: Alistair Popple <apopple@nvidia.com>,
gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com,
jgg@ziepe.ca, willy@infradead.org, david@redhat.com,
linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de,
zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org,
balbirs@nvidia.com
Subject: [PATCH RFC v2 03/12] mm/pagewalk: Skip dax pages in pagewalk
Date: Wed, 19 Feb 2025 16:04:47 +1100 [thread overview]
Message-ID: <c9da3d2ef9fbff693fdfae0114fcff39378b8c03.1739941374.git-series.apopple@nvidia.com> (raw)
In-Reply-To: <cover.95ff0627bc727f2bae44bea4c00ad7a83fbbcfac.1739941374.git-series.apopple@nvidia.com>
Previously dax pages were skipped by the pagewalk code as pud_special() or
vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are
refcounted normally that is no longer the case, so add explicit checks to
skip them.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
---
include/linux/memremap.h | 11 +++++++++++
mm/pagewalk.c | 12 ++++++++++--
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/include/linux/memremap.h b/include/linux/memremap.h
index 4aa1519..54e8b57 100644
--- a/include/linux/memremap.h
+++ b/include/linux/memremap.h
@@ -198,6 +198,17 @@ static inline bool folio_is_fsdax(const struct folio *folio)
return is_fsdax_page(&folio->page);
}
+static inline bool is_devdax_page(const struct page *page)
+{
+ return is_zone_device_page(page) &&
+ page_pgmap(page)->type == MEMORY_DEVICE_GENERIC;
+}
+
+static inline bool folio_is_devdax(const struct folio *folio)
+{
+ return is_devdax_page(&folio->page);
+}
+
#ifdef CONFIG_ZONE_DEVICE
void zone_device_page_init(struct page *page);
void *memremap_pages(struct dev_pagemap *pgmap, int nid);
diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index e478777..0dfb9c2 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -884,6 +884,12 @@ struct folio *folio_walk_start(struct folio_walk *fw,
* support PUD mappings in VM_PFNMAP|VM_MIXEDMAP VMAs.
*/
page = pud_page(pud);
+
+ if (is_devdax_page(page)) {
+ spin_unlock(ptl);
+ goto not_found;
+ }
+
goto found;
}
@@ -911,7 +917,8 @@ struct folio *folio_walk_start(struct folio_walk *fw,
goto pte_table;
} else if (pmd_present(pmd)) {
page = vm_normal_page_pmd(vma, addr, pmd);
- if (page) {
+ if (page && !is_devdax_page(page) &&
+ !is_fsdax_page(page)) {
goto found;
} else if ((flags & FW_ZEROPAGE) &&
is_huge_zero_pmd(pmd)) {
@@ -945,7 +952,8 @@ struct folio *folio_walk_start(struct folio_walk *fw,
if (pte_present(pte)) {
page = vm_normal_page(vma, addr, pte);
- if (page)
+ if (page && !is_devdax_page(page) &&
+ !is_fsdax_page(page))
goto found;
if ((flags & FW_ZEROPAGE) &&
is_zero_pfn(pte_pfn(pte))) {
--
git-series 0.9.1
next prev parent reply other threads:[~2025-02-19 5:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 5:04 [PATCH RFC v2 00/12] mm: Remove pXX_devmap page table bit and pfn_t type Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 01/12] mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 02/12] mm: Convert pXd_devmap checks to vma_is_dax Alistair Popple
2025-02-19 5:04 ` Alistair Popple [this message]
2025-02-19 5:04 ` [PATCH RFC v2 04/12] mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 05/12] mm: Remove remaining uses of PFN_DEV Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 06/12] mm/gup: Remove pXX_devmap usage from get_user_pages() Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 07/12] mm: Remove redundant pXd_devmap calls Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 08/12] mm/khugepaged: Remove redundant pmd_devmap() check Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 09/12] powerpc: Remove checks for devmap pages and PMDs/PUDs Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 10/12] mm: Remove devmap related functions and page table bits Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 11/12] mm: Remove callers of pfn_t functionality Alistair Popple
2025-02-19 5:04 ` [PATCH RFC v2 12/12] mm/memremap: Remove unused devmap_managed_key Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9da3d2ef9fbff693fdfae0114fcff39378b8c03.1739941374.git-series.apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=balbirs@nvidia.com \
--cc=bjorn@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=debug@rivosinc.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=willy@infradead.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox