From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D4BC52D7B for ; Wed, 14 Aug 2024 16:32:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E35D66B00AC; Wed, 14 Aug 2024 12:32:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE60B6B00AD; Wed, 14 Aug 2024 12:32:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAD716B00B3; Wed, 14 Aug 2024 12:32:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A7D236B00AC for ; Wed, 14 Aug 2024 12:32:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 44B0B1A1059 for ; Wed, 14 Aug 2024 16:32:43 +0000 (UTC) X-FDA: 82451394606.01.2A18EA2 Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 281BD80036 for ; Wed, 14 Aug 2024 16:32:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=Jr+E9Sdp; spf=pass (imf30.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723653089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HzRjnEYxCgd5sweSvuIswq75tHrQWV8FRv4rbaoLB8o=; b=T/51sasOo+JjTn/sC5YUUqMQ+EYQnBL7nD5lbfJyqRFPMCm5P9PoFqJMKwxNumcCZvmq7V UvOLYxJOIHCUuSD1G+MAntMRAiV2JH+XbIJ3F7Eap6z7an4tcVtmxLvvQWihrylzr2QA+l EnNrFjHab3fvdJUI+jiXuuJhxrA9mH4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723653089; a=rsa-sha256; cv=none; b=amdU+7MtypB1PbuQGyHTvG4Il0N5LtywYrV5mZzlxUjEtzFdISS0KlDxHHXSxUtwIs5616 1BKdG49bW82yF9fO0jXfByedxD0eH7sP198CZY5+xwLSb+a3rZcFxAmAJx3O+xbpymtkLS fhnin0yk91Kr7IDSy9fylyzdT9utigY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=Jr+E9Sdp; spf=pass (imf30.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1723653159; x=1723912359; bh=HzRjnEYxCgd5sweSvuIswq75tHrQWV8FRv4rbaoLB8o=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Jr+E9SdpuUvEJBPiSuhavO9knHg4/Jmoz3U6JzWGbxUA0VXUyt09BFa8+h1IKllu/ pqqSKEufaHwz7Oxv2AZXLRY0CrJIwsRcaPWiJUw31Vb/UahypkScE2+y4iMwVH1Egk SK64dQ0qcjzR8S/Gvd3coWeLb9+44yJISQCUsE06HHPiovw9zSrYrhDzLchMeMqeYJ beAn3yGqTbKW7/dzlFFBh4DSusxb1MnerNUaFi1EUPAY1ChenpU4chrskkSbBOFzSY 1Kdy9EC84BUTht6TiUVEySLxpx7umeuJNGFcTKyvF4e1lsa83C1vEa0PRd3QwnnAQZ jvawIdMVHa1lw== Date: Wed, 14 Aug 2024 16:32:34 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 06/26] rust: alloc: implement `Vmalloc` allocator Message-ID: In-Reply-To: <20240812182355.11641-7-dakr@kernel.org> References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-7-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 514667304e528ccd1bc15957b6357b3f74a19a4b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 281BD80036 X-Stat-Signature: 4x63hdtxrr31ddaj94qynsapsugsb55n X-HE-Tag: 1723653160-152701 X-HE-Meta: U2FsdGVkX18lja4VSwtF8wZMahs4YDOnw3WWM0S2TsSpPuK29RWt5UHxkQGygi5sURFHjHK6F26LaZXgw/WoIM+vHdWL4qXplMoNik84n2E+I/1BJ/6H1WJL28FQAtFqOmGGagxFQeaz1jG11bHkWyvYcua1Fx0AatJmCloIA6a904UPKhGyD60X+oeXLoU4o1r0h4WBUnp0/khs71XB0/pVKrNtyAQBxcyxkj4f2TEnZnfMb/wg9ckZpkKGo+q7AhvgO3ZfRFt6KV7RXUk1poIxpn+xwx7yMN+pGcwwL9M4bHIn+ctwLYG8Knfslv1X7bRUYY4yI2LY/XDZEwBNKJ7KbASZLcNo81HZjV/L6I7fCLRYpsgk7Ojl4om/Fj6+uCQdfpjkHnK99Qojixah9wjR2geMKjsGnFOdqqWgYfkAy5Gxzh827PCpEWw0jVD6x6oPuxZ1x+/awcnmGgkuW7E5WCPG7jktDRWe+UOH30vQDyKl3UlYo6GlH6R4FhPlDJJpgOjf+YleHJAkyy0yHONHuAcNJkKrAX46O232r+qDDOndrX2QIpFqyGERuvhQN+VNFLFvuqX/mqsz08ssqWvV3A2/A5JaIBfZgxA15TgjMgJ6pPDpRo8BeoQeG2dekWH6OfSpthzDBVnO8zbEQgR+5nqVhq1leTYhN7kUKz65fLkcGP1VJK4kqieHKKI/Kz/NOI7dboaI2uFMA5H1L22UIp0VKicXSHRtFPB9Afc82GsRQpneWpSgnrkKp9k8rVrcoEGQbV/HRyrilgP51PG7F8di6p0jDACDHOJsb/+lzPl2e0qrDlUjK5LeiUA4SsJBLyg6cGGuZy9oxTRhpEmdHofk6t1W+06Y5DQfl5BFHNQ45VxpZ2mx6X91U3ICvav4L9Sh1pU3RF5JKEMMyIHWfzfP6uDCIoOU78XCxKWrLS0LI17eXnblFIwnbR9xfS7IvXrqMUdmoH8j+PO ibJ21FWf wuorUZQ1oDmKcQ+8uynlAZszn55peoSpyXI4lb2D41fH30DMD++flA5IHmQBoEnZuf+ykAwacqlVIH8TzYtnO3LqLk2b41njX/Xyi+Qlx5UQ/TXsG8oYNk0bCm7eAoy0bqRHSpAde+l+Jz3GLi2FBS18+4gPbP7dylj9d+H0GufPlkuQmU7pRMPsbJ4yQCWf12zFddl/kLn1yOOP6zQybULyZer9CJcBKaQOOH3yJUesMg6Oa/CeLNdtnkPmBIovssLg++Z/zZnoIIOJnd0X1OK5LSfEvE8EUY/bjJF1Hof+i9H7f6y2C+29egmaC9SLMh9LmYzVTprl32uV9QBpI6U0BS8YmQF7Cg1WeUO87AZW3vAf8j4iMa9R0QIlV5p3lezA7CIdfLIoVIBcchS6NUkOq+MWsNfXhTGXK+R11Y/HDuk3k110F0G6cyr7AlzR1mm/n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.08.24 20:22, Danilo Krummrich wrote: > Implement `Allocator` for `Vmalloc`, the kernel's virtually contiguous > allocator, typically used for larger objects, (much) larger than page > size. >=20 > All memory allocations made with `Vmalloc` end up in `vrealloc()`. >=20 > Reviewed-by: Alice Ryhl > Signed-off-by: Danilo Krummrich > --- > rust/helpers.c | 7 +++++++ > rust/kernel/alloc/allocator.rs | 28 ++++++++++++++++++++++++++++ > rust/kernel/alloc/allocator_test.rs | 1 + > 3 files changed, 36 insertions(+) >=20 > diff --git a/rust/helpers.c b/rust/helpers.c > index 9f7275493365..7406943f887d 100644 > --- a/rust/helpers.c > +++ b/rust/helpers.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > #include >=20 > @@ -199,6 +200,12 @@ void *rust_helper_krealloc(const void *objp, size_t = new_size, gfp_t flags) > } > EXPORT_SYMBOL_GPL(rust_helper_krealloc); >=20 > +void *rust_helper_vrealloc(const void *p, size_t size, gfp_t flags) > +{ > +=09return vrealloc(p, size, flags); > +} > +EXPORT_SYMBOL_GPL(rust_helper_vrealloc); > + > /* > * `bindgen` binds the C `size_t` type as the Rust `usize` type, so we c= an > * use it in contexts where Rust expects a `usize` like slice (array) in= dices. > diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator= .rs > index b46883d87715..fdda22c6983f 100644 > --- a/rust/kernel/alloc/allocator.rs > +++ b/rust/kernel/alloc/allocator.rs > @@ -9,6 +9,7 @@ >=20 > use crate::alloc::{AllocError, Allocator}; > use crate::bindings; > +use crate::pr_warn; >=20 > /// The contiguous kernel allocator. > /// > @@ -16,6 +17,12 @@ > /// `bindings::krealloc`. > pub struct Kmalloc; >=20 > +/// The virtually contiguous kernel allocator. > +/// > +/// The vmalloc allocator allocates pages from the page level allocator = and maps them into the > +/// contiguous kernel virtual space. > +pub struct Vmalloc; > + > /// Returns a proper size to alloc a new object aligned to `new_layout`'= s alignment. > fn aligned_size(new_layout: Layout) -> usize { > // Customized layouts from `Layout::from_size_align()` can have size= < align, so pad first. > @@ -55,6 +62,9 @@ impl ReallocFunc { > // INVARIANT: `krealloc` satisfies the type invariants. > const KREALLOC: Self =3D Self(bindings::krealloc); >=20 > + // INVARIANT: `vrealloc` satisfies the type invariants. > + const VREALLOC: Self =3D Self(bindings::vrealloc); > + > /// # Safety > /// > /// This method has the same safety requirements as `Allocator::real= loc`. > @@ -132,6 +142,24 @@ unsafe fn alloc_zeroed(&self, layout: Layout) -> *mu= t u8 { > } > } >=20 > +unsafe impl Allocator for Vmalloc { Missing SAFETY comment. > + unsafe fn realloc( Does this need `#[inline]`? > + ptr: Option>, > + layout: Layout, > + flags: Flags, > + ) -> Result, AllocError> { > + // TODO: Support alignments larger than PAGE_SIZE. > + if layout.align() > bindings::PAGE_SIZE { > + pr_warn!("Vmalloc does not support alignments larger than PA= GE_SIZE yet.\n"); > + return Err(AllocError); I think here we should first try to use `build_error!`, most often the alignment will be specified statically, so it should get optimized away. How difficult will it be to support this? (it is a weird requirement, but I dislike just returning an error...) --- Cheers, Benno > + } > + > + // SAFETY: If not `None`, `ptr` is guaranteed to point to valid = memory, which was previously > + // allocated with this `Allocator`. > + unsafe { ReallocFunc::VREALLOC.call(ptr, layout, flags) } > + } > +} > + > #[global_allocator] > static ALLOCATOR: Kmalloc =3D Kmalloc; >=20 > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allo= cator_test.rs > index 4785efc474a7..e7bf2982f68f 100644 > --- a/rust/kernel/alloc/allocator_test.rs > +++ b/rust/kernel/alloc/allocator_test.rs > @@ -7,6 +7,7 @@ > use core::ptr::NonNull; >=20 > pub struct Kmalloc; > +pub type Vmalloc =3D Kmalloc; >=20 > unsafe impl Allocator for Kmalloc { > unsafe fn realloc( > -- > 2.45.2 >=20