From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6612CC04FFE for ; Wed, 8 May 2024 12:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9F9F6B008A; Wed, 8 May 2024 08:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4E906B008C; Wed, 8 May 2024 08:45:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3DA66B0095; Wed, 8 May 2024 08:45:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4BE86B008A for ; Wed, 8 May 2024 08:45:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 510781606EA for ; Wed, 8 May 2024 12:45:03 +0000 (UTC) X-FDA: 82095198486.12.0DE2826 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 7B847180020 for ; Wed, 8 May 2024 12:45:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715172301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mR2I6dy3QfrKyqoZCkKMLPrOoviuuIa68mEtsCpP+JU=; b=Iky6dPukAS0efe9oRSDk1OxMj7FqmxIZ4d4mIim5dJrWmNYwB8B6R0GOUowWjzEHDSe7bL 0AwSXqSh7oo3ciW45E2XRHLf+xoTkq5crM6bsVENPxcR8wisE5kt7Ez+6OYa/nGHejqC4a pWRbo4jxJsVKiGe2TH/xDFxD80YOEh4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715172301; a=rsa-sha256; cv=none; b=ZoZfwSk0poHvnSmk+99oBtEINiTH1FvM9kpt9JZ63lPQrlbI6h0TtZ7GZe2ddUTa9GMvC2 J8nC7EYdQtFyIsS72+Vdg8Qcw0iF/V+YSECLena5fCh44A5iqs8GYW1bZEez6E95EmRL0B f7jrsFDQWSM9hVPT4nLFLuplVYeCTd0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27F421007; Wed, 8 May 2024 05:45:26 -0700 (PDT) Received: from [10.57.67.194] (unknown [10.57.67.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B61523F587; Wed, 8 May 2024 05:44:58 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 13:44:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] mm: shmem: add multi-size THP sysfs interface for anonymous shmem Content-Language: en-GB From: Ryan Roberts To: David Hildenbrand , Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6b4afed1ef26dbd08ae9ec58449b329564dcef3e.1714978902.git.baolin.wang@linux.alibaba.com> <30329a82-45b9-4e78-8c48-bd56af113786@arm.com> <0b3735bc-2ad7-44f8-808b-37fc90d57199@linux.alibaba.com> <928c73de-76b0-40d6-a0c3-23d72270ac5c@redhat.com> <28f311ec-9b46-4f28-991c-ac74177acf32@redhat.com> <5c2c70fd-a291-4ca4-b229-dc54e92b3471@arm.com> In-Reply-To: <5c2c70fd-a291-4ca4-b229-dc54e92b3471@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7B847180020 X-Stat-Signature: dgj9mgx784hetauazomay5587jtyrz3d X-Rspam-User: X-HE-Tag: 1715172301-104206 X-HE-Meta: U2FsdGVkX1/2XBwgCeooyfRpIWYmPGWG2drt3Q4Eo0XE3gcZn3ynI1KAnBzhrKyIs8bDyz8YggGnzhpeWN/+NV/ztcGK0Z2t8g3BRsaEKI0HG//EyzkAx1E/RcJJ7oIheNrCNN7MMVK8pYn9lpg6hffHurHvgUdj2kii4vhgDF99n4PVfdjj0QbjUx5LavQgqeQ/gcF6g3yuhVyZ2GStJqMlR5ZAVnnaoVRfWXWE1ajMXRbkOt0Fkg7uCL8c6cI82oLsK/5I/3b780KJlyhrG6sxOfbPXDyYUsQMbw40kvqxiTE86hnBIbOMONbW7jnirpTiO9kO9FQ+8asVN9Eyw2z4at7S0VnZLAHW/U8pL/5sIKPoaGJOv0LzHOAaVVKI2v5KCnjbo0XX6JZ4oMRKYvRdIjknclfqLbjKfhkmMzq4ovvxcgtPz8JrcM1Oa6C8syC4+UsTxvKaRhRdi7UiDmbo24qaIijAxoP/LuH0MzOXzEp+5lBeHimulmBxXLsxFd8JtdNBOfVyQq7j+7u3FdqqLnIE4VjGn08IVoIQQzE0DB3jecvTB2xKnqOFATvEaa0yPpittV23XUislFdAIy6yTCQtUXsTounFs7/UcSWdZ0MnBUOuEMWhs+m0K/XMfRUkYCRJXHpOgBA2umYJigM2Cn+rxZ0AhMldAREuX0Q8i873ls+bhSUomwYq5Pc1dBz2JAPNT1i0lMwVRuCImILSH8DOJXIQrvBYhImJw9PlrWw/Jw6UvA1cby0r6uwujFDOZWoDdjrANUGtJ6i4ZnVHwYoOExUA7EyBrCBNqBzcr0PbYQo99jZH7/B1flnIhYW6AUtpEJQIBLlquhkQt+X8pdkIUX8k9QZrRImw/w7WMSB97R1gLV0Rv5WRhR2QMisDoqj90ROoFJG0e+T76aMJAlhgTre/WtTJX9O+AOfZ8EPnz1scgEVpgL2vPzlVryr/W0x2YIhZWsXRQt7 zy9zcZiV /i6byXSyQAVMrOEHoTG8TiawgugKq8jqhFMu/VAmhMyWE2WgGU/pIR3xwvKoaWo/+EbmoEVup5CLoov942fTixKkSB/TAX5cJEBjuXRfwvYOND2sHk1X6ih7UoX5F62UEPk9Gs9NlzSdCPMkR6YVCbgx4viEvWUeJ8etNUte8kfnaM5BDjfJXIGaDpSq7tZjhQlfMEWUgxlZhiAIu08bgpztq/qx7jXA8jkz2XmbKTf6Kes1fCEcJJjXiBuNEvDUk79FZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/05/2024 13:43, Ryan Roberts wrote: > On 08/05/2024 13:10, David Hildenbrand wrote: >> On 08.05.24 14:02, David Hildenbrand wrote: >>> On 08.05.24 11:02, Ryan Roberts wrote: >>>> On 08/05/2024 08:12, David Hildenbrand wrote: >>>>> On 08.05.24 09:08, David Hildenbrand wrote: >>>>>> On 08.05.24 06:45, Baolin Wang wrote: >>>>>>> >>>>>>> >>>>>>> On 2024/5/7 18:52, Ryan Roberts wrote: >>>>>>>> On 06/05/2024 09:46, Baolin Wang wrote: >>>>>>>>> To support the use of mTHP with anonymous shmem, add a new sysfs interface >>>>>>>>> 'shmem_enabled' in the '/sys/kernel/mm/transparent_hugepage/hugepages-kB/' >>>>>>>>> directory for each mTHP to control whether shmem is enabled for that mTHP, >>>>>>>>> with a value similar to the top level 'shmem_enabled', which can be set to: >>>>>>>>> "always", "inherit (to inherit the top level setting)", "within_size", >>>>>>>>> "advise", >>>>>>>>> "never", "deny", "force". These values follow the same semantics as the top >>>>>>>>> level, except the 'deny' is equivalent to 'never', and 'force' is >>>>>>>>> equivalent >>>>>>>>> to 'always' to keep compatibility. >>>>>>>> >>>>>>>> We decided at [1] to not allow 'force' for non-PMD-sizes. >>>>>>>> >>>>>>>> [1] >>>>>>>> https://lore.kernel.org/linux-mm/533f37e9-81bf-4fa2-9b72-12cdcb1edb3f@redhat.com/ >>>>>>>> >>>>>>>> However, thinking about this a bit more, I wonder if the decision we made to >>>>>>>> allow all hugepages-xxkB/enabled controls to take "inherit" was the wrong >>>>>>>> one. >>>>>>>> Perhaps we should have only allowed the PMD-sized enable=inherit (this is >>>>>>>> just >>>>>>>> for legacy back compat after all, I don't think there is any use case where >>>>>>>> changing multiple mTHP size controls atomically is actually useful). >>>>>>>> Applying >>>>>>> >>>>>>> Agree. This is also our usage of 'inherit'. >>>>> >>>>> Missed that one: there might be use cases in the future once we would start >>>>> defaulting to "inherit" for all knobs (a distro might default to that) and >>>>> default-enable THP in the global knob. Then, it would be easy to disable any >>>>> THP >>>>> by disabling the global knob. (I think that's the future we're heading to, >>>>> where >>>>> we'd have an "auto" mode that can be set on the global toggle). >>>>> >>>>> But I am just making up use cases ;) I think it will be valuable and just doing >>>>> it consistently now might be cleaner. >>>> >>>> I agree that consistency between enabled and shmem_enabled is top priority. And >>>> yes, I had forgotten about the glorious "auto" future. So probably continuing >>>> all sizes to select "inherit" is best. >>>> >>>> But for shmem_enabled, that means we need the following error checking: >>>> >>>>    - It is an error to set "force" for any size except PMD-size >>>> >>>>    - It is an error to set "force" for the global control if any size except >>>> PMD- >>>>      size is set to "inherit" >>>> >>>>    - It is an error to set "inherit" for any size except PMD-size if the global >>>>      control is set to "force". >>>> >>>> Certainly not too difficult to code and prove to be correct, but not the nicest >>>> UX from the user's point of view when they start seeing errors. >>>> >>>> I think we previously said this would likely be temporary, and if/when tmpfs >>>> gets mTHP support, we could simplify and allow all sizes to be set to "force". >>>> But I wonder if tmpfs would ever need explicit mTHP control? Maybe it would be >>>> more suited to the approach the page cache takes to transparently ramp up the >>>> folio size as it faults more in. (Just saying there is a chance that this error >>>> checking becomes permanent). >>> >>> Note that with shmem you're inherently facing the same memory waste >>> issues etc as you would with anonymous memory. (sometimes even worse, if >>> you're running shmem that's configured to be unswappable!). >> >> Also noting that memory waste is not really a problem when a write to a shmem >> file allocates a large folio that stays within boundaries of that write; issues >> only pop up if you end up over-allocating, especially, during page faults where >> you have not that much clue about what to do (single address, no real range >> provided). >> >> There is the other issue that wasting large chunks of contiguous memory on stuff >> that barely benefits from it. With memory that maybe never gets evicted, there >> is no automatic "handing back" of that memory to the system to be used by >> something else. With ordinary files, that's a bit different. But I did not look >> closer into that issue yet, it's one of the reasons MADV_HUGEPAGE was added IIRC. > > OK understood. Although, with tmpfs you're not going to mmap it then randomly > extend the file through page faults - mmap doesn't permit that, I don't think? > So presumably the user must explicitly set the size of the file first? Are you > suggesting there are a lot of use cases where a large tmpfs file is created, > mmaped then only accessed sparsely? I know that's often the case for anon memory, but not sure if you would expect the same pattern with an explicit file?