From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD51C4361B for ; Sun, 20 Dec 2020 01:24:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44A2623A84 for ; Sun, 20 Dec 2020 01:24:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44A2623A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B50396B005C; Sat, 19 Dec 2020 20:24:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFEB16B005D; Sat, 19 Dec 2020 20:24:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6D26B0068; Sat, 19 Dec 2020 20:24:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 81E156B005C for ; Sat, 19 Dec 2020 20:24:03 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3A4D74DA1 for ; Sun, 20 Dec 2020 01:24:03 +0000 (UTC) X-FDA: 77611914366.03.nail66_500303f2744a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 19A5128A4E8 for ; Sun, 20 Dec 2020 01:24:03 +0000 (UTC) X-HE-Tag: nail66_500303f2744a X-Filterd-Recvd-Size: 3350 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Sun, 20 Dec 2020 01:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1608427430; bh=Ce9S6zrCQf0NChxGGpooimbJN6N08uPt4ubX6/bcgIQ=; h=X-UI-Sender-Class:Subject:From:To:Cc:Date:In-Reply-To:References; b=DUWpuql0D50N/j4H+x1vvXtsvi3pOU2QL8/5lJEXwnG/ApY4ev8rY//Va/D5ErEU8 RPPR+67WxcU9l6/Ohpp42rGCVCh57HKU9AabFgj7t+uhDM8lFM9fSsLSuy83WA8T67 dCPauCoCyZPDrVbBY+gDXsWwKHttOGfgvJD59MGQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from homer.fritz.box ([185.221.150.14]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mzhj9-1jvp393CJV-00viGb; Sun, 20 Dec 2020 02:23:50 +0100 Message-ID: Subject: Re: [PATCH] zsmalloc: do not use bit_spin_lock From: Mike Galbraith To: Vitaly Wool , LKML , linux-mm Cc: Barry Song , Sebastian Andrzej Siewior , Minchan Kim , NitinGupta Date: Sun, 20 Dec 2020 02:23:49 +0100 In-Reply-To: <20201220002228.38697-1-vitaly.wool@konsulko.com> References: <18669bd607ae9efbf4e00e36532c7aa167d0fa12.camel@gmx.de> <20201220002228.38697-1-vitaly.wool@konsulko.com> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ax83T0xYQBFJVPHbUHlYTrPgRB/Ee2Y7lhC9LgoB66EzLjnZ4S9 WJ8dtz4Va8Rkvg8hhJPRMXpW2n9w2u/bsZFtSBauU1vxrCdciB8rFzMDmShI/ZMSviLut+P kqkR2FzgQhpBzSdo+5jqYZsWkdT7Z/q9e94G/EEKxGD5gZ7UGyYgi+52iK56e3HLCtr2/37 J2GPFeL526alLAJKeqi6Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:suzbf/ZH2+g=:89lWwvuF2Bio+yeNtbWWMp xu+GM4I4dv86q3igfO1Y+JPnvqU3xNSdFGZAplGGzEjBjBBS1ltBOcj//TooCkKvhwYfQ2nCa zd+P6/K7B6DksOZC5beeuWVVSy5NSKZcXr3B76HMMZmhEN0rUgggeSkoj4A2Tcrz5JjKrAy9i 6QucYBA/JUKcHRYkncSz8MalBbBaqISM+WqbNFBnjsSvXMtKQMdq3Ujg7nl/xs2HAYR5e8/kF z/9AkBJkE8v7y0TM+OojO7rDLGVRC+jBe9wW+KDOo+QI+fyeRgi9thKQ4e6wha8+3y5nPkQm0 p0Yvou40VUuwSZlAh/u4FzcCbFw/BlsbD/CCbuE32Alds9zRmmvsDSrGdk38ZR/ag/9230v1z cVVWeyI9ooso0YUVF/OhbansPlJlnwD7n9jQ6AcVglBoW3f/4OlohjhINxZb85nUYaNhzQC5b 2ZVos3Mrxk5Dm5Q6+fAWvy73xmnHkGowtM5ST2m6MRH7+Q6YJtp08spFHF8nz4hoj8p0B3sN9 xFaN8nQCQaX7/mtGBZbS+LUYvh2lymHDKrCx3f/SHJO1eiXhgfpXQRQT4tEL6f1z09P2CL6Ny WumiRIwinIExnzh9D5KdeJyKU9xx0L2EUnM2nU8wtSvMNR05IFxg2CFY1coZjHhAWeQb7BczG PjuwMVNLQHLcnLIEiU2k9dKk+g1Bg25RMY7CLRvaIu/cy6wf+4h4HI+1Q7BWJMkmxSEp0gNNp RweW9OTXEWALp479tFyt7j71JjU1ImHek0bn0vyHam6Ks8qKQir7FMFYD8TuHADoiPffqh8OK khy70wH39+3MClAM4YQ+mSIUzYDbW4oGm+QnmdCRAsYPSvPIr7x96FbRBdtfknBrNMdCmHisY 4cVwld1y8mLTfBVMN/WA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000250, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2020-12-20 at 02:22 +0200, Vitaly Wool wrote: > zsmalloc takes bit spinlock in its _map() callback and releases it > only in unmap() which is unsafe and leads to zswap complaining > about scheduling in atomic context. > > To fix that and to improve RT properties of zsmalloc, remove that > bit spinlock completely and use a bit flag instead. It also does get_cpu_var() in map(), put_cpu_var() in unmap(). -Mike