From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9376DEB64DC for ; Fri, 21 Jul 2023 07:44:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ABD42801A5; Fri, 21 Jul 2023 03:44:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25B912801A0; Fri, 21 Jul 2023 03:44:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14A492801A5; Fri, 21 Jul 2023 03:44:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 074162801A0 for ; Fri, 21 Jul 2023 03:44:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C697B1A0111 for ; Fri, 21 Jul 2023 07:44:28 +0000 (UTC) X-FDA: 81034831416.08.40BDA5C Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 8848740012 for ; Fri, 21 Jul 2023 07:44:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689925466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/mKQKeTE9YI+IB9i0mlYTv7VQu7wQFKlBelvYVRwQnQ=; b=PRr7CeCyQ2bv6wkINS16bEtajDWV/vjT5buE3WZjFf/FIuFbyDhtVqJGA2BQJI8+6l/u9a nbl2mf8qu4VH+fOE1GeHHM/+icGv2wpld/+XAD2Z//ES+pKzRioaSIMhm/6/6xjqgi5F+G +nkYNl0PjZRICtjVlVUo1pFpVrXqZJk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689925466; a=rsa-sha256; cv=none; b=JTvhJwrHdDZMBywK3gm31vOy6ujiV+dBLlIdrS99r9vHyWSEHiACvjKH4fcvWjHcoLXSu7 /ZCOVBaJS+WzXnpwQC32tXkiwwQqjTpt5mIz8Awsq7lWU72pTYKN/qY2hL9Dt5RXHGFkpe RN7jlteyynr03kfK0TYHEP07Ed17qps= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R6hQT2NjXz4f400T for ; Fri, 21 Jul 2023 15:44:17 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP2 (Coremail) with SMTP id Syh0CgBnDetMN7pktBOOOQ--.2147S2; Fri, 21 Jul 2023 15:44:14 +0800 (CST) Subject: Re: [PATCH 1/2] mm/compaction: correct comment of candidate pfn in fast_isolate_freepages To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang References: <20230720115351.2039431-1-shikemeng@huaweicloud.com> <20230720115351.2039431-2-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: Date: Fri, 21 Jul 2023 15:44:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230720115351.2039431-2-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgBnDetMN7pktBOOOQ--.2147S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Aw4rur1kZr18Ar15Gw4kJFb_yoW8JF4kpF 4DAa1UXwnrJa48Ca47Aa17ua47Xws3tF18Grs3G3yrAanag3s7u3s2qF45ur92vr9Yk3y2 vrZ2gF1Ut3yUZ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1CPfJUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 8848740012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: r8f19my8rfz6ibaw6qjnmhzesk48g8ou X-HE-Tag: 1689925465-502151 X-HE-Meta: U2FsdGVkX19kVxIvM+DWNyg3fqrnutynSCfWUXDG18a2BhlDizsj1LiInUTzimKj3HzUHLol3Q5sU54hUR2wf4/O9cLsLjcEL0gzg8VcpoVuOlON8a2+Z/BM38e4HCnnzW2eeNWsRFfps+bNT6wGdApSwiB9je+jflMVgti28obj2whCOdrE+MPcXSi1i1fdGOaLkyAuv9fhSVvd8mg18b5j5HikGSNYirRDWb+RJaaTcjqaEzNrBwRHgzH7XXcLmn8JZbrMKXqg2LXU+G2R5WmTn/CTZfR7H2MWm3+GRAZsa+LzHB1v58LHqC+Vqsigpk4gDj3RGdBFcKcAxoRiABtxG/h+4SLltqF2ESHnZkXPkUmdrvTO9rX5x31lreLnvrOO3I4JnIlKYC+kSMOglQMK5pFdIvm3dfWSfKJ7q7rpckiP+g4VAzbKZoqB3hQRJvm5nWxSzsKEEiNTDK5JQywsKeXLMTW6zJ5TiWUMqmsIN9QdURtm0yYJjXop7bx966OGwF0MnZZROjGb2JpY/8YW64P+GAXKjr11lx2J3h9B97W4NB3XPpbzM/CfB0FNQfE5BrJvO1yKCGxesxygw0tC3XcQIb40tQtCSmUBu0osQbeJbdOMQSjQuj+PyZigc/uxfExP/nHTif8QjfHiS5Gg7y4HxIlOaSLytU5UFfbAbz1r3CUXVLgGGiLVxzudCBMDSPkCtjVsEWNp988Q5NK83rOWuVD4VgcQ0zhZZPTUmXzrHk85UD4vp0/eqMRX5AM4zK9zl/0K+7qNLghLqb95U3VCzkgw8ea/Dhg7WBq3LJseFw6FSPfk+Yc4zzmzAwzihQQovaLIcpiP2Ikz3UB11NdgABKk/Lmcfbe7VpwXHZFXy9OUT/d0OLoeynmjFCy80ks0hSaRk+oRYTFeYSwyk0DuHVlk8+Fff6Sp3Qhv502au1zdLMEeRPmVtxNbrMhDFJht2TYT2aghCIs 0lQkFMzp y4Iyg3QM0aCornqEQBj3lHpPdvWXodr/HK0z1f2gsAs8lXF9IsXvWU2a6US5fNa19FBRYSwvJC0FrVC7J3+/Tc59UBmgKOU2+h7ZwSb9n+QnAX5xzPa+Vvs1ZLe6m4MZThTe/Ve3WXyDrO0WAvRIpoQ9AAmMztC16xcV4XuUlXEmT7BMEVj2ltbY+X3W9XxHsP7ao00meHI+axeIXU1jglojpboi38/+haZuXgmyo9MCOJKiIvKQjlpIDCEc4isnX/h7Z4MoNdUSK8/sus2yFFPpBR0bExXA2Y5xrcNPq49b2Ebw7rzGVGwQ0u3rlsmWHm5kcVx7TOcNtQOMfXyKmW9g7vqQLGRjkgjbXCwzYpTx1w5NCv5YHZYlouaagVXq4uDosAhYHSJ8X9/xgsvJi1oNd2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baolin, I try to resend a new v2 patchset, the patch 1 is still missing. Here is the patch 1 in old version and I find it in lore archive of lore.kernel.org with link [1]. It's likely that patch 1 is denied by linux-mm.kvack.org but accepted by linux-kernel@vger.kernel.org. Is anyone know how to submit issue of linux-mm.kvack.org, please let know. Thanks! [1] https://lore.kernel.org/all/20230720115351.2039431-2-shikemeng@huaweicloud.com/ on 7/20/2023 7:53 PM, Kemeng Shi wrote: > If no preferred one was not found, we will use candidate page with maximum > pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum > candidate" in comment. > > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index eb1d3d9a422c..c0d8d08fc163 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc) > break; > } > > - /* Use a minimum pfn if a preferred one was not found */ > + /* Use a maximum candidate pfn if a preferred one was not found */ > if (!page && high_pfn) { > page = pfn_to_page(high_pfn); > > -- Best wishes Kemeng Shi