From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D012C47088 for ; Wed, 26 May 2021 14:06:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0CA2361026 for ; Wed, 26 May 2021 14:06:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CA2361026 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83D536B006E; Wed, 26 May 2021 10:06:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8132B6B0070; Wed, 26 May 2021 10:06:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CA886B0071; Wed, 26 May 2021 10:06:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 153FA6B006E for ; Wed, 26 May 2021 10:06:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0C3758E68 for ; Wed, 26 May 2021 14:06:41 +0000 (UTC) X-FDA: 78183557802.10.B5BAE3C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id 2C58A90009ED for ; Wed, 26 May 2021 14:06:32 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) by smtp-out2.suse.de (Postfix) with ESMTP id 828A41FD29; Wed, 26 May 2021 14:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1622037999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+fWJ89PhgnhS/Yf0anDjWgbu8PDm6n5TN+P7qd4Wr8U=; b=RDbd3fdHF45PozgvzgXadaMAZxMTQxUQmwVQHJvnnc4S3H6ZtYg0gUDI1CgoRvs7XGAa4j J5qqMNGwn+m0/oABtqzrxcdiuttGnWEvVZxePlyeVlIfEr4Ln+ZI3jIDLcCbI2jeJOU3/Z tBXmfYg6pVymi3IatniocPvzWYGAkrc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1622037999; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+fWJ89PhgnhS/Yf0anDjWgbu8PDm6n5TN+P7qd4Wr8U=; b=bprVp6ntthqke5j8weOXe3bT25Blzuf6OkkbkDDU5JiA9ypm+J6GeQNVPqgHf991axpd47 pFpUdVianUHVevCg== Received: from director2.suse.de (director2.suse-dmz.suse.de [192.168.254.72]) by imap.suse.de (Postfix) with ESMTPSA id 6249D11A98; Wed, 26 May 2021 14:06:39 +0000 (UTC) Subject: Re: [RFC 2/3] mm/slub: sort objects in cache by frequency of stack trace To: glittao@gmail.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, faiyazm@codeaurora.org References: <20210521121127.24653-1-glittao@gmail.com> <20210521121127.24653-2-glittao@gmail.com> From: Vlastimil Babka Message-ID: Date: Wed, 26 May 2021 16:06:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210521121127.24653-2-glittao@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RDbd3fdH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bprVp6nt; dmarc=none; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: yc85x6a613jixyfbiqomhewjyep65wqi X-Rspamd-Queue-Id: 2C58A90009ED X-Rspamd-Server: rspam02 X-HE-Tag: 1622037992-421699 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/21/21 2:11 PM, glittao@gmail.com wrote: > From: Oliver Glitta > > Sort objects in slub cache by the frequency of stack trace used > in object location in alloc_calls and free_calls implementation > in debugfs. Most frequently used stack traces will be the first. That will make it much more convenient. > Signed-off-by: Oliver Glitta Reviewed-by: Vlastimil Babka > --- > mm/slub.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index d5ed6ed7d68b..247983d647cd 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -5893,6 +5894,17 @@ static void *slab_debugfs_next(struct seq_file *seq, void *v, loff_t *ppos) > return NULL; > } > > +static int cmp_loc_by_count(const void *a, const void *b, const void *data) > +{ > + struct location *loc1 = (struct location *)a; > + struct location *loc2 = (struct location *)b; > + > + if (loc1->count > loc2->count) > + return -1; > + else > + return 1; > +} > + > static void *slab_debugfs_start(struct seq_file *seq, loff_t *ppos) > { > struct kmem_cache_node *n; > @@ -5944,6 +5956,11 @@ static void *slab_debugfs_start(struct seq_file *seq, loff_t *ppos) > process_slab(&t, s, page, alloc); > spin_unlock_irqrestore(&n->list_lock, flags); > } > + > + /* Sort locations by count */ > + sort_r(t.loc, t.count, sizeof(struct location), > + cmp_loc_by_count, NULL, NULL); > + > } > > if (*ppos < t.count) { >