From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25B2C47258 for ; Thu, 25 Jan 2024 08:18:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6087F280004; Thu, 25 Jan 2024 03:18:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8CC8D000C; Thu, 25 Jan 2024 03:18:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45A3D280004; Thu, 25 Jan 2024 03:18:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2FF488D000C for ; Thu, 25 Jan 2024 03:18:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C2569120DB8 for ; Thu, 25 Jan 2024 08:18:02 +0000 (UTC) X-FDA: 81717130404.20.52469B3 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf06.hostedemail.com (Postfix) with ESMTP id 32788180007 for ; Thu, 25 Jan 2024 08:17:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XICrETiL; spf=pass (imf06.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706170681; a=rsa-sha256; cv=none; b=qSTGQZqZRDsMgQlhFoIe2TSRdJIN+mT60bWeQvbVLZDQjWXTBABRwKF864qPI7HGT8ERQ4 S77avXH8YzyQu7vPvm4/E5I7ocKt/7BImcLcuIFa1rMkc0u299y50uqFfD3++BqoGP1kWJ 32NOOI6dV6+99QKo8ZFRS1+Zju+TguE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XICrETiL; spf=pass (imf06.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706170681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SBTHq4bMG1gDrvHUu2w4lSj2h0O+hUHl7UPziFU1CFQ=; b=g47pR1Tteo4aEK5QxGFM+y4qe/jD8Z81x8YwLAjP1taguVyTLEhFP6I4FFUMlc10TnrqA/ m1fe3Hq/SjxwPsSpU96CjWURyo0/znObUWciq+W9/U9zUgmCg92tcddtuXqnpzHmBPNAdA X/OmTeNGrSBJLdlKMOUflgC5dkmmNJM= Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-5d4d15ec7c5so1334111a12.1 for ; Thu, 25 Jan 2024 00:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706170678; x=1706775478; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SBTHq4bMG1gDrvHUu2w4lSj2h0O+hUHl7UPziFU1CFQ=; b=XICrETiLtpcLsVoAn9JYEqo14tfEWn1zogwG50CoRWbA6Sa4Bj1yDF2rxlGovaFF55 vg4SYshD8fkHpaqQJKSmwBj6Ki0iXFdg4L3ed4FQdPDuJZ8BoPBZrN6lNWOWA9QG7SA8 7ZYkFGvYtmvo0zZaGe8ab/+oejDQaEsXMG9AbbukHwPJZxde3gX7IciNiJxabq8TGbSk ZdH/tK+1hR0fbppkfEW0F4CLLlnO00fQ4v/DhulNfjikVOojO0dMj3DWgY/k4sVJmXIb vkvzWVt2/dg71XLMoF836UBrLCGTTmeiRsxUk8BpF72Zcnbds0VeUrnkBKK5lSJVxHqd n6xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706170678; x=1706775478; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SBTHq4bMG1gDrvHUu2w4lSj2h0O+hUHl7UPziFU1CFQ=; b=hQxDR/Yl64xu4NF63MdvRtFS1ffPJ+T22OIwN08jtm3gz3Uvo3KkrrLBjxRONZZoMu yxDKA250OuKHlLOklw9AdLX3awPfGMQKP+sR/ELm9KwvcwRBK8jQM4LhXqI1OdCCTWmB Yb38CiixUjzeaGSNiykTW/mYo6JnEYBy5SD5vwXokFBcRnKhFZ2iqgc0xJ7VYgFOKji+ 2jwIjMDdyYMFZoq0I0vSXg3vxrXbe3g2F95uy2UB3H/BNJXi3ghEoyZckYoYl83v/izn 7FGDZawRpReHpondiRM+FB45Nc/mdDOE9ce6b7HNma1XURfcwnlnIe2UagclGYla0YJy FTFA== X-Gm-Message-State: AOJu0YwuDXRjpdhoOWUzDmwiXhcw8I6DGFXDmwzZKGd0kOvn4R+B8bYC Xzbv/yAKAFCt75FoEwUJCuPrP21Hgmqi1PO65Bqi9pWCBIKZxFdbhbVKOF7rtXQ= X-Google-Smtp-Source: AGHT+IF8qZjF1mquaMxoS+es9e/DvB2FXCF+lh/TuX5XX+zGSS53OXXu7j7PUU022c/Chid+JIqtvA== X-Received: by 2002:a17:902:bc4c:b0:1d7:41b9:9a65 with SMTP id t12-20020a170902bc4c00b001d741b99a65mr681181plz.89.1706170678729; Thu, 25 Jan 2024 00:17:58 -0800 (PST) Received: from [10.4.195.141] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id h9-20020a170902f2c900b001d72b14e98bsm8344576plc.124.2024.01.25.00.17.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 00:17:58 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 16:17:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: zswap: remove unused tree argument in zswap_entry_put() Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Johannes Weiner , Nhat Pham , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240125081423.1200336-1-yosryahmed@google.com> From: Chengming Zhou In-Reply-To: <20240125081423.1200336-1-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 32788180007 X-Stat-Signature: crpgs6ns4npftyrojnthxtrzkibtjey8 X-Rspam-User: X-HE-Tag: 1706170679-225923 X-HE-Meta: U2FsdGVkX19mPMEd0JaGIM0MjrrgTQlk5GaWyrM7UiG/S6lAiTkGxakQ07aqxAYmRcHgaB8uONjPa7JacfCrTWeXa/Q9QE2pGC2Iiki4/rSN0Q3QRnEo8LjWf/AGeyr+5DRYEl7dgQ0FYy1qGzGlNmiRLwWUKlj8G8VGLArcTbIdAZ4/eXNwkXqJ/B+nkJFtSG/kXwRvINJVQn+RayLfCrhokYvRQnj197ycQCN4G4bOjJFphvWG4fdsnaBmW4ersGuLM5GlXIILV5jhfzfx0z8LmNw05wxgJ/MZ0ley1ZKVwWja+vwfyHYppTyjf5YbidLx6rPRJkGRceUsCYFIuecUxO99yH+H4auzQqKuzq8Zk5XLRicaOljjT5FhIb87AzKEr2ITrujDb32/H/g5ADgz2Fq5w8JaVXJ6rS4ROZcWbiT/H7HzawgUaQDo3XIkyEgP97QIEJaEYLtPjWO6r/prRE/UOLs8ISqGneZFopDgfLcq5t0J/DAzJYDVzY2uscdXQrh7BWpbK1Kz+EkKcF0o63rwFNiEshTHn1TnKCAIl29kXHQHC+yo5cPMDxzRsRzUN0fKFW4wugYqv71tJpuTB57kOcbVdIwrjrK0m1rYxpGlRSzNgUINX9IcD12K9ChxFDE8JmXgPzKOi9j+fDfeMCwJ39xYithFs0ALvVXEKh5kPFeOvOtyYHb6KGcWmIZDpiH08pEFVnb+xAnDggPAsLo0g44+Xx2QysWdMo40ypEUMOZm2xbP4/I1XOlcZNt9Qc36FxAb2kUZhJhoyvU6HAaFLNbgctUxL5KMT1wGxG7UMOoaZpmLHw/jyQhOKVgcP1tj0BL1y5KKj/166q/MUJFWHaw/yR5HnVsGEaBCsnR+a1gak2f32WoLrSC29YyqjP2nMXdHBoXACzp+MWhKDbEO5TNMZ2mFPqoyQ15QoXSWdrFeDqJhAE9YDKb4wG1Z2/dfhW0O1usD3SA R7jvnM70 z/GoG6zjRqC/kbDvcd8RjRvLs87l3bpH/J25oEKK0cWPbR9xWmXt1SVOPXEVIsFuvSUav1hRoZZFFJtIfVbT5WNuV+Dx1QpCyyRgEdCmBQ+/GX+pApWCu69ScsW491J8uggOhnZahLOYY6xU1jEEFn/yCRXqLd8XCwdL0F6mWCZk1DGKNpxckhIh9tQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/25 16:14, Yosry Ahmed wrote: > Commit 7310895779624 ("mm: zswap: tighten up entry invalidation") > removed the usage of tree argument, delete it. > > Signed-off-by: Yosry Ahmed LGTM, thanks! Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 78df16d307aa8..8f4a7efc2bdae 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -569,8 +569,7 @@ static void zswap_entry_get(struct zswap_entry *entry) > /* caller must hold the tree lock > * remove from the tree and free it, if nobody reference the entry > */ > -static void zswap_entry_put(struct zswap_tree *tree, > - struct zswap_entry *entry) > +static void zswap_entry_put(struct zswap_entry *entry) > { > int refcount = --entry->refcount; > > @@ -853,7 +852,7 @@ static void zswap_invalidate_entry(struct zswap_tree *tree, > struct zswap_entry *entry) > { > if (zswap_rb_erase(&tree->rbroot, entry)) > - zswap_entry_put(tree, entry); > + zswap_entry_put(entry); > } > > static enum lru_status shrink_memcg_cb(struct list_head *item, struct list_lru_one *l, > @@ -924,7 +923,7 @@ static enum lru_status shrink_memcg_cb(struct list_head *item, struct list_lru_o > > put_unlock: > /* Drop local reference */ > - zswap_entry_put(tree, entry); > + zswap_entry_put(entry); > unlock: > spin_unlock(&tree->lock); > spin_lock(lock); > @@ -1754,7 +1753,7 @@ bool zswap_load(struct folio *folio) > zswap_lru_del(&entry->pool->list_lru, entry); > zswap_lru_add(&entry->pool->list_lru, entry); > } > - zswap_entry_put(tree, entry); > + zswap_entry_put(entry); > spin_unlock(&tree->lock); > > return true;