From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F423EC64EC7 for ; Wed, 15 Feb 2023 12:16:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B3D06B0074; Wed, 15 Feb 2023 07:16:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 663C96B0075; Wed, 15 Feb 2023 07:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 552E16B0078; Wed, 15 Feb 2023 07:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 461406B0074 for ; Wed, 15 Feb 2023 07:16:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 01C18AB63D for ; Wed, 15 Feb 2023 12:16:41 +0000 (UTC) X-FDA: 80469424644.13.2A82EBA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 4FE3040003 for ; Wed, 15 Feb 2023 12:16:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=O24e=6L=linux-m68k.org=gerg@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=O24e=6L=linux-m68k.org=gerg@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676463399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PPy5QcfnsMA2lttAN/Lgd5ZGOauhZ3AQ5rTpENBaURA=; b=QTPJojZ8UTK+TdwUJR+QwD6ZQDPVnP7W0aBVdowBZ//7L65yGmCg6iW4ZPxSGfZMG3iMeG N6kPjs4YtdJIyUdvgKH0zVVyZzCsR+Q3Ia9lNiqAZ7Bf0LK/mWvSv1fe+ndP4prUF9Yng1 iQZNKyaQwTqD4p8Z9NEknRFXM20xAek= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=O24e=6L=linux-m68k.org=gerg@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=O24e=6L=linux-m68k.org=gerg@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676463399; a=rsa-sha256; cv=none; b=GCFwX0mPmjPi7e6smAvtsXKqHMnSVUWKGXSdKEGrOrE7VvUu7Xxl68qzdCQktCmmkbT5As AJpIjdkwu4MkYFPDy6Y6O0ioHpzwsg7L8t9dcUnw7VKMtpHPxo6MpTlLw+kkywdPlDNZDK wP1nbv8cC1AtcvnFforDddOgGb3Cnac= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 367AA61B8A; Wed, 15 Feb 2023 12:16:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E81DC433D2; Wed, 15 Feb 2023 12:16:35 +0000 (UTC) Message-ID: Date: Wed, 15 Feb 2023 22:16:32 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] m68k/nommu: add missing definition of ARCH_PFN_OFFSET Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Geert Uytterhoeven , Guenter Roeck , Rich Felker , Yoshinori Sato , linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org References: <20230214140729.1649961-1-rppt@kernel.org> <20230214140729.1649961-2-rppt@kernel.org> From: Greg Ungerer In-Reply-To: <20230214140729.1649961-2-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wz4wj1rkgtkuqchqdx6gz5pgtp66mxrn X-Rspamd-Queue-Id: 4FE3040003 X-HE-Tag: 1676463399-347814 X-HE-Meta: U2FsdGVkX19E0VjW/25z7ydO61qce1HNGdZCBuvWai/NFbPpKJAF+M1710HsWeNboQJAZv735bZih5+sqTbGZ2bPZp9v1UiAam1K77LwftDLvHQjpMahUW6Xh2f//WrJj1OPBym8BUXrPhQHVUQdsJL5Z1Hf4u7vHHlBvIuNiEjKmuIiwZ8rCvhN0lgpU+gzPdXBjImEJF1aSUWPj8zRlot5B2RpUTtvwkhTBhS/T8mWQOHe2HOp0GTIj56CsLxZeIvicldAUvVaP5qVeFRe2qdLnDdF+cdzU1cHP5Nkl6SnySHQ8yQnTgAXaGwjYNLpbmjrGCWb3gjPqrOY46KqVYRUlxQmA0/aBVUmf78hadauuHYf/rj7i3INdRwS8cC+FcSxjXXFISLCI1cV/lyUn6o69/vhonxmVsVlp3NfpHqCLWQZntqBPDAbbnHq/GKMcw4bKw0W81A3HM6WZcXzpjWX3ZylnHDwGtR4fDG7DGdPONi3Givz+8zbti0IEBu7v2hc35TkCEfl5F8IKPlVHyXKZemyurVBBGlZCGeP3MDEVhKImnVeHUWxQMxd3+TMbgF7aMo7Xx1DTLbrYHken8kAS3ACwGTBQqHsfLwNtJkqiyfWfcUKWB1Nt2R0jsjw7bldOCHcJr3UMEOrqcAKiikdJ/Y2e6wCR7mQOyUiqWxZA77ZqRnywjQni87IzRoH+p5qZ4fsqwI4Vi3bKRDtrO9ufM9ns0BMon2E9Hcawy0vS1BNkyXhzUbs0D02/6G8paD5SC5oHeMsH+QbEIEZRJqHd+h+ftyURT0XU3JEz4ExVJHP2iDflC7qQG6Hf5H+gpxbtWUrT3RZ5V3UjRIVxEr7xp0jf9y/N4+KNdUkXvW9WByTZCloEzAv7K/FHyt7bzSu0jjwjbgP6yjQq9fz5uVDid6uj6aw3IU28yuqWUn5dQOLbaJab3WiRqQ4n/gTNe3F68tlVQuc7zAYhK6 fXvRrIJS fgTgOg9CQPBd/EvzP+ZxtXhkGESG3VHZzcFudMieiSdmy4NtJ6eIH4LoOMTJdctyVk5MgDLWZAjByQLN+KpyL5TO5qKX7VsElBBFsfWqi/qE+iemYpd/N6SlAb9Eu26AB2zwZG1JVEfZxBSIfbdnQVCKTucRp38rHz7sfYlEp5CYymlCBFaibBBqN0UsIIkx4sXDQ5yBu/UZb6GjZL/KYvN5DflkZqk2cuN/Gj5wq56ZzJqeuhCYPGeV9RhmBS1PAeTboB61VtGvIqpA/WmHfBugGgZMFI+I867LNh8t6iHgl8q1BlwbvHss/xw7+e9x+yW/wQenjLXP8YNugiCjexUHpUpU5Q5rO0Vqmcwz1+gcEAl8s3yldhlImPYnAkbU2CPMfxT4TyamRN5deh7WoPPgdJ7oDIZHsgTmLqA/tOlqjOUkgUHw59FSNOv7NLlAJKiQ1t6D9rn/dN9l7fy0EfJsj/3v4sqSRAcqSbM2C520InCBEDtcukfeApxsw18FlYE89z4c8QYM623lqjOyLh4W5W6XHypq2thpSQWZB0kTFulc8rRIhEeGovnR6lNh9e8FSN+ffiHxWjEjyeNJLd1s6HaoXEr20CmIV9moueAtizvwCdMY27e+T+QPwUnVLmn2neT4DaHfqdsM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15/2/23 00:07, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > On m68k/nommu RAM does not necessarily start at 0x0 and when it does not > pfn_valid() uses a wrong offset into the memory map which causes silent > boot failures. > > Define ARCH_PFN_OFFSET to make pfn_valid() use the correct offset. > > Reported-by: Guenter Roeck > Fixes: d82f07f06cf8 ("m68k: use asm-generic/memory_model.h for both MMU and !MMU") > Signed-off-by: Mike Rapoport (IBM) Acked-by: Greg Ungerer > --- > arch/m68k/include/asm/page_no.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h > index 43ff6b109ebb..060e4c0e7605 100644 > --- a/arch/m68k/include/asm/page_no.h > +++ b/arch/m68k/include/asm/page_no.h > @@ -28,6 +28,8 @@ extern unsigned long memory_end; > #define virt_addr_valid(kaddr) (((unsigned long)(kaddr) >= PAGE_OFFSET) && \ > ((unsigned long)(kaddr) < memory_end)) > > +#define ARCH_PFN_OFFSET PHYS_PFN(PAGE_OFFSET_RAW) > + > #endif /* __ASSEMBLY__ */ > > #endif /* _M68K_PAGE_NO_H */