From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79AFC001B0 for ; Fri, 11 Aug 2023 05:23:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADF686B0071; Fri, 11 Aug 2023 01:23:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F6E6B0072; Fri, 11 Aug 2023 01:23:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E3356B0074; Fri, 11 Aug 2023 01:23:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7E3BD6B0071 for ; Fri, 11 Aug 2023 01:23:12 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4ACEF4039A for ; Fri, 11 Aug 2023 05:23:12 +0000 (UTC) X-FDA: 81110680224.13.4A68A44 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf21.hostedemail.com (Postfix) with ESMTP id 2152B1C0009 for ; Fri, 11 Aug 2023 05:23:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SaomQFiR; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf21.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691731389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XbYfNqrawAmF7TACyQLGkNqUkZyraENW6qP9KWM7EOk=; b=0NCMsNWy5wQUkYhBpKqOE2WQowVWbyRAksWyPctlunDRot/hc8A84VeUerLrr3xNoTvA4h Xy+rZhiMIWuqOcfi0ckK4SS+HFXi9cfPUy/xqtCKUBU/KGcmyjDji8L4cG5+i0SiOZb748 TgX30Uk1dmgAg3zUMsIwPF5O/nyg2TU= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SaomQFiR; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf21.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691731389; a=rsa-sha256; cv=fail; b=RA86FlsYQAG6PxRDrQxK2hbwooRDWm8z7wHnJUWwUbgjYczvFNpXZ93HiMnxzLrHEwIMPw ClhM2TARXww3FWzGr5RtbRQZv16lfByhZ3UhSCOe5HojTFGlqVD0BfSWdgWJInnoizK41l O1TrmZJFu2z8p1nMdhGm2nVqiRGzqn4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691731388; x=1723267388; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=NIkFCDG82Qd+6gVnwmShdECoC9/dZBwvgLcBxI7qAA0=; b=SaomQFiRT7LZ1JTltwK6Tc6Y9xNpO9YnrwPImD6qrx5c71lucVYKEfLr j9EFEqTPmTVViSwrck3ALRrx2Amh095xumLrB5RZQaj+8vKJL7t4vaJvf qXaRNvqzxEyQyDsp2Hl3yxwUdjp1hH2YT+PfeZRExD399R7ltX6qUHQl/ KRzDKwVIw+dnM77ANgQK48x7pK2s11hvaVv2xfrHOMoWktDRN2S1Iexeg 1jqzSQEBtj3DsmfyJ6X9AeUd10wd5E8/xr4Ug3qPd9oyRLcEyMsVAcw3c quThNQtou7UGi5h3t49lkC12zCmx+VWld4F5Ft6erFKOUCitrftOnDkLS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="361736441" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="361736441" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 22:21:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="846674410" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="846674410" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 10 Aug 2023 22:21:31 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 22:21:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 22:21:30 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 10 Aug 2023 22:21:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LvNisTMFrYP8sUc+s2vvhqZWPjCdQdrAP6u7FdLdEkHIRfidXeHp8w79n8XDE1jBDUBd8FPZ2+EPX/0tH/HD4T7AnUF2xf/+tw0K86BRLzgqJpumwwSUjVTbVDMXFir0PHAtpt+l/H1BXn8SfJdHqQzz7CtcNGE5WTOOLGyovZkysqqVmdcKMSWnlSfelhWgSKeteULPnrVX1RZQriiIh23L5ri5X8tGwA1LjVsLR+YlzBDHqzUwOB2De24FaaC9eu4CIJS4ksVjDFV6aJSlKxz8ereE/L05/WeO+GzvGZJX4bjpEUxJXFwoOa2g8GH9xh1YcfD4EkC8NV8JuY0l/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XbYfNqrawAmF7TACyQLGkNqUkZyraENW6qP9KWM7EOk=; b=d1j6M9I31zePHc0Dcxo7/bo0dgCV61MJcVvq4XOH9x6N5oC+p2a/iAnyNRFYCuPqeMbRPyUuqCG98z8GykxHD+9WR2UQqymh1fZU7N3MOWbzbao9vWzfTi5GOn7GmgdXEi5vD3aYFxLWauMB340cknKsc3L7d3KqJcsgWsuGIXsnsgWMx6PDG7CjjCekWuzet+yUd6uWhwwk3fPIWwELpzv9r0dNIepqEn8fLKImoWfWScGXLh8F0SxhId5fFQdekxEHRQlW7goso8I7lhMhFzexOL4Xq/kmb6B1Yi+5108iVeYybqbvc/grkmqBwBwOsvD5n3bBiiYuYOIH13ZPbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by DS0PR11MB8717.namprd11.prod.outlook.com (2603:10b6:8:1ab::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Fri, 11 Aug 2023 05:21:24 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::221b:d422:710b:c9e6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::221b:d422:710b:c9e6%3]) with mapi id 15.20.6678.020; Fri, 11 Aug 2023 05:21:24 +0000 Message-ID: Date: Fri, 11 Aug 2023 13:21:21 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] zswap: don't warn if none swapcache folio is passed to zswap_load Content-Language: en-US To: Yosry Ahmed , Yu Zhao CC: , , , , References: <20230810095652.3905184-1-fengwei.yin@intel.com> <26949c92-95a0-414f-918a-8b8cc11e3e9c@intel.com> <3732dd16-148d-4ac6-8295-86a12f89365b@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: KU1PR03CA0020.apcprd03.prod.outlook.com (2603:1096:802:18::32) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|DS0PR11MB8717:EE_ X-MS-Office365-Filtering-Correlation-Id: bde818dd-f5a7-4881-8dff-08db9a2acdf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z2lFTg2sbTRFIigrm/Whq77cq8EgOvravElU27L+jLwYBFUmsk7oapMmhR/rC8K6rjn5PKn6tUjDXS4uoQIy/lFZ263xiiu2Za4SM7BxSSfGVqolasO+b5piv0Pw131fC3r/aaoauCPvtMYxXj/rDsdkXwDTxJXiMJacnbQTW9TMIA0ycYYwSRn5QwpV+5FrsqTal7dm8IuB7LAPH9awco3nvZCcYfVC1VGiQNsX8oxykDTYXVDzlyy1lzp4FEznHXxZHPjVIjYKrP7TDqmQQW+uLuLIUsdoX3Z4aWlbpSLq0kzHQF+NFZQlyF9fC4rI5/uI8tdENKDqP8CfefWZQJARc/woRUFssl4s71WbhODGAQiw2WrdqXq3WR+gyjEK9l8UaeCCuck+qgT/jhgNt6gkJDwsZJJQk+zdcMfEb3yabb97qGsr2Nk4cs2TmRT8a/OF+WWctykLg2G/a6liuOQJ/goGxhi1baXNNEScrMnxII1aoX6Osm0B1ItURhdnfC1h2qjTql52YhYHXYIT97oOgNMOKuxDWINfTvcJRFuUDnDzJF5xJ8Syb+7SWSnUVFuuk3WpN1anvUYLazhge/MZGu/OtMAM79rfMsTNfz0tP+qA4U3+9yFuSCuj3A3oy2B5DgUJ9hUGtfyYv3PVIA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(1800799006)(186006)(31686004)(8676002)(66946007)(110136005)(41300700001)(45080400002)(4326008)(316002)(6512007)(66476007)(6486002)(6666004)(5660300002)(66556008)(8936002)(26005)(83380400001)(6506007)(53546011)(478600001)(2616005)(38100700002)(82960400001)(31696002)(86362001)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkUydndidHhMVnRhdk1Vb1Q3YWhVekFqcFJtcFFlVHFVbm1ER2VWb3JlK2ZW?= =?utf-8?B?Q3laRmNSWVRvR0dkNkhveW16eFg2a0RwbEQ2VWVFam93UHQ3Rkp2WUdxOGg3?= =?utf-8?B?VVBJaExCYVRCdk02aXY0Y3l4N2hsekN2MlY3Tk90L2VIU05pbkVuWURnemdC?= =?utf-8?B?cENaSjR6VVJJb1VHYUZLSERkTTB3Q1NyLzFHZVpJWXhUWFNvRUxDRlhhSGNs?= =?utf-8?B?N0ZRaHBYaGRoNldKUlBQRmpZWGJjanEzQ1dPQTl3YUZUZ0VUNnlsYytDQVZ0?= =?utf-8?B?QVVpbkxja1IzVEVsQk0rSGlBY0hUREk0RnM1KzIvVy83TFJ2WThjN0IxVjU2?= =?utf-8?B?eVdsYnRzMmFpcU44Qzl4ZzFpOU9ML0FoMDZDV0d2SjlDZG90R3lkZU5BS3Z4?= =?utf-8?B?b0VwTHVmc1ZSY3I2bjhZRFM5NEVyMkxURk90WEZQbmc0ZytxOVFZV0VRWlIw?= =?utf-8?B?bWNKY3daYzFuQmRoZUVteEptSTNsMHIvcnJCUGVyODhJY1ZyNWsrWGNYWkNX?= =?utf-8?B?NzFEa0V6N2hTdk8vK3B6S0xmTUtENW8zN3p2ckNONWVxYUFPanM3VUFkVlN4?= =?utf-8?B?MVZaMjRKZDQxZEtRUGZNSFV4N1BiRDliUGszRlFTOUhUMkJSZmxtOHJZU1E5?= =?utf-8?B?S1dQR21SUytkbEsxUkRxTm5jYW14b3NNMDFJaGNQSE5XZ2R1S1BqSXVlcWhy?= =?utf-8?B?c0UzeDFJZCtxKzRVYkw5TVhLano2T2ZVS0poUWw1Y05FSlNoWGRlYzJpNDE2?= =?utf-8?B?YnovYVB3TERsVDdQUTZqKzZhWW9QQVc5WWxTYXVFMVNCMFdIOWZBd2RsR3Ex?= =?utf-8?B?L0pBTCtMdGdQS09aUnhiemV0NFhTVXdKN1N5L3RsOUxtVVp0Z0w3eklXaTlV?= =?utf-8?B?TkxzbmIyQTh6KzBjZHFrY1VnYnEwZjhyVFRrd3ZydGduRU1KVVFVeTVGTm1P?= =?utf-8?B?T3g2VHV4N1ZCMVYrNnkzS2o1dXNBWFdKNzJpbFpEdnRMeHFDcWF0eERaOFpW?= =?utf-8?B?V0hkSlBxbkdoVWFhNE9qTUtKdTkxaVhvS3cyeFc4SS9ZTEh5U1p5YjNudDZI?= =?utf-8?B?UnBDa2pkWmpIaVdpQUNvT2JDUjZlSWd6S3lVcXRRcFlNMnBQMjJLZlZzQzU4?= =?utf-8?B?QmFVZDdFTmZkSFZYdlNGdUtWVkpDNUI2TmhuZnZiOFZtV3o4RHpDZCthQ3pG?= =?utf-8?B?enRIM0ZqY2VtS2FpMHd6d01RY3R0MlF0b1d1YWpCK3NURHEyOVl5M2FwTXR6?= =?utf-8?B?RWZoVnJmNi9qZnZJbmRidmtwVHRndzlZalgwRnBaUXpoNSt3bk5rb0J0WVdu?= =?utf-8?B?aGZ3T1htai82UW4zdnh5WlZCMEY1dFRBQ1pWYjRGQktiZ0ZmUkJVZkgxZEhu?= =?utf-8?B?WEkxSUlvOWVCa203am05Zmd4UmFER3Q2SGNhNWVRTlQ2R2Q1MCtCY2wzK1Ji?= =?utf-8?B?R21YcXBoNGp4NmVPNFBMZjhQTkF3Z2tUSWUzazN6eE4wVmcvM0ZuSi82c2dQ?= =?utf-8?B?aXhWUnEweGovZDcxaHRTb2pGVXJBdVVmTEorWXMrZjVkenFxbXpYZFhlWEx4?= =?utf-8?B?dzhabitZMXk0VmJPcU45MDBqWVZ6S1p6eUhVK3BqSXhGRmkvSHRSeWJXTU5T?= =?utf-8?B?SnZBV21DMmExZUJDbCtNK0Q0UzhhR3ZjbWwwZjYwSGVtYndMaXVoYmFQcW9X?= =?utf-8?B?THladXBQOXIxY1pGaWNlU2pncFo1Vkg1VlRsZ250VTA5citzaUNDbHdTQjYy?= =?utf-8?B?Z21ySjdKcmhvdE9tU2tjRURyQkNNNzlsdGRQUzBPU0haVi9tNGRuY1liazN1?= =?utf-8?B?Sk5aTkUyMitZZ1FEZUhNUFJzYmtHV0sxeDBRZkVNZkFGMTJvRzZ4R1AwWUpR?= =?utf-8?B?NjVSZ0ZKRmZWZVp1Uk5JZHdPWEpsbytjTm1kM3RzTk50U1M1akxJWld6WTQ2?= =?utf-8?B?Vm1sQnpEUzU0RlhMbjRiZDZYS3NDLzNWb1BBTFdnY1hSRVFRMjBMakVFNkJF?= =?utf-8?B?aFZvYUk0WVhzZnhpcU9uNG9CdElzbnB5dkNRWUF4enVBVWtaQWdlMS9zTzF6?= =?utf-8?B?MGNrWDNBc3BqZ2JnTEZzMGgwZis4VFN5NWhreGVHNkR6dlZRR0RhdDc2SkVB?= =?utf-8?B?MVpraS9tYTE1YXEvTzVDb0gzcklscVBkSlZ0Z0VsZ1RJL3JWWk94QVdrdDNo?= =?utf-8?B?K0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: bde818dd-f5a7-4881-8dff-08db9a2acdf6 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 05:21:24.0850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ij0DA5BbmfgiihYC7S4sZYf465a7pmhWn3BNDlTqc7su9+JPiZTEL/bE8lpm5GaM+CCdbwuDEPgc/HpyRS5XXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8717 X-OriginatorOrg: intel.com X-Rspam-User: X-Stat-Signature: tmo7zr3pqcea7w9msa3sfczbfcfteqtz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2152B1C0009 X-HE-Tag: 1691731387-838890 X-HE-Meta: U2FsdGVkX18uGdOFM5h3PIHQuN4a+Nf/bUSNfRLihCyQfCccSYMugzRieha/7wVZ2Dkxs5SofUOXVGcbTjwPcvUB3bavocsEzHFxi7slCHM3UeTVZrO+ri+005aa/pCq9Jf8QzNELvSa0CFTWn7AeuCy+m01Hb+19lCxQ/muwfzz2zlM80hqO767ZbDaCvvqa/DYxWZjFl3QvrGulrsr4iJ65wmdb88p7FHZ3lySCocps3rBrcIq9NY0eV/qXgFpjPlPTxcLNcFm+t7hLRumE8RGeR3n1QkQ405aG8XKHyfZDWibyKfGKfawG/hn58tKeWVjJPi5Kp3HVjjdNGwwdNtVQZxx5KGt07jD4EoWNnEs2wZQSNYkzhlukqBsfJ5JK2KtyXFGBRrFWAF/dCnZ2jKVgLhKqu6TZCVefLytat5YkpqzHLrDMr62EVe7X9Xsu6yQ7TDW+tsIZ0f396EApKY8bNiRuyLhpV49QkXPPV9C4k3cztZZOZtHQcweJSyfPsiVkrUlRX2S9yJL7xEbX1G/6buB/8XQIiBvwAWqHHQzT+7qraz++VuvGNTjmssVhMJ5R8zgki8Vb6AeSRXcebCju75QhD/mQBvfnIJm9QBnEdnQuj+vRpNs97uajWqvAyZUkwG2yJbchw6JKGN8xTOIWeMk12fQMhXkRupQAXzd0ijxUzOGvHPIfr2SOStvraRpok5zL14WSnk1PQ3BGt7yqjf4dTErRIYI+L/+5bcN0KJ1pKfJwil9VWeNYLpEKZqPUGIxpZU9S/hrx+nfxqTisN4AqYrcv9M7/G8DeZ81Z2eNRquCha99MeuVdvS2IdRdcui9/GrsNxS92+b0EiWrPcVtKYB4B6au+ev+lgNC8FC8npAH5SeV/3lgD78lvmPRdl+DeT7WzWoSDxi5QwPRbhkrCkL19SWgmX+BGcHeHI8BrI7x10PCPDNyChnDx6JRLx/d1fWopJDwGRw zv+vwMR1 RkvUfhyPXid2RGNgpFrxDFax4SwfpUIuTAMswBI7Nc0qjjOJsx2sGkDnZMOpEPctVqmW4Q2HOMHqb/1a3sRNd2pSrWOlnwIgWEfOhHtVTguudPKRep7MOkAMwBBrlBgnhE09x7qmf0m0EMPPrwuftJ2sQTu+zNzr9A+7+x1wcAGASlc7GvSngF56r2XvNgy2tYI4Vo5jMkKEkdxHcqyHf8xuUIP47VDUMSSr9IYG3SXhzBuUPdNMdM09omzFO1CpFB02z2Kvz8cCvFvDUa8W074d1WwpZhzbqYa0ULf7GB0ai4D1R8kCTv2GdfQvS5h0e8wVJhXHwcOTgsE0oDjsInIIK6G7WMzBQrtppTLSoatzV+2JiBNUWgsH/omwIhtpyJCCKQFylr52tG5alDVQIVMHLZkRuwtx77R1h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/11/2023 11:21 AM, Yosry Ahmed wrote: > On Thu, Aug 10, 2023 at 8:12 PM Yu Zhao wrote: >> >> On Thu, Aug 10, 2023 at 5:46 PM Yosry Ahmed wrote: >>> >>> On Thu, Aug 10, 2023 at 4:44 PM Yu Zhao wrote: >>>> >>>> On Thu, Aug 10, 2023 at 5:31 PM Yin, Fengwei wrote: >>>>> >>>>> >>>>> >>>>> On 8/11/2023 7:15 AM, Yosry Ahmed wrote: >>>>>> On Thu, Aug 10, 2023 at 4:09 PM Yin, Fengwei wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 8/11/2023 2:44 AM, Yu Zhao wrote: >>>>>>>> On Thu, Aug 10, 2023 at 3:58 AM Yin Fengwei wrote: >>>>>>>>> >>>>>>>>> With mm-unstable branch, if trigger swap activity and it's possible >>>>>>>>> see following warning: >>>>>>>>> [ 178.093511][ T651] WARNING: CPU: 2 PID: 651 at mm/zswap.c:1387 zswap_load+0x67/0x570 >>>>>>>>> [ 178.095155][ T651] Modules linked in: >>>>>>>>> [ 178.096103][ T651] CPU: 2 PID: 651 Comm: gmain Not tainted 6.5.0-rc4-00492-gad3232df3e41 #148 >>>>>>>>> [ 178.098372][ T651] Hardware name: QEMU Standard PC (i440FX + PIIX,1996), BIOS 1.14.0-2 04/01/2014 >>>>>>>>> [ 178.101114][ T651] RIP: 0010:zswap_load+0x67/0x570 >>>>>>>>> [ 178.102359][ T651] Code: a0 78 4b 85 e8 ea db ff ff 48 8b 00 a8 01 0f 84 84 04 00 00 48 89 df e8 d7 db ff ff 48 8b 00 a9 00 00 08 00 0f 85 c4 >>>>>>>>> [ 178.106376][ T651] RSP: 0018:ffffc900011b3760 EFLAGS: 00010246 >>>>>>>>> [ 178.107675][ T651] RAX: 0017ffffc0080001 RBX: ffffea0004a991c0 RCX:ffffc900011b37dc >>>>>>>>> [ 178.109242][ T651] RDX: 0000000000000000 RSI: 0000000000000001 RDI:ffffea0004a991c0 >>>>>>>>> [ 178.110916][ T651] RBP: ffffea0004a991c0 R08: 0000000000000243 R09:00000000c9a1aafc >>>>>>>>> [ 178.112377][ T651] R10: 00000000c9657db3 R11: 000000003c9657db R12:0000000000014b9c >>>>>>>>> [ 178.113698][ T651] R13: ffff88813501e710 R14: ffff88810d591000 R15:0000000000000000 >>>>>>>>> [ 178.115008][ T651] FS: 00007fb21a9ff700(0000) GS:ffff88813bc80000(0000) knlGS:0000000000000000 >>>>>>>>> [ 178.116423][ T651] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>>>>>> [ 178.117421][ T651] CR2: 00005632cbfc81f6 CR3: 0000000131450002 CR4:0000000000370ee0 >>>>>>>>> [ 178.118683][ T651] DR0: 0000000000000000 DR1: 0000000000000000 DR2:0000000000000000 >>>>>>>>> [ 178.119894][ T651] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7:0000000000000400 >>>>>>>>> [ 178.121087][ T651] Call Trace: >>>>>>>>> [ 178.121654][ T651] >>>>>>>>> [ 178.122109][ T651] ? zswap_load+0x67/0x570 >>>>>>>>> [ 178.122658][ T651] ? __warn+0x81/0x170 >>>>>>>>> [ 178.123119][ T651] ? zswap_load+0x67/0x570 >>>>>>>>> [ 178.123608][ T651] ? report_bug+0x167/0x190 >>>>>>>>> [ 178.124150][ T651] ? handle_bug+0x3c/0x70 >>>>>>>>> [ 178.124615][ T651] ? exc_invalid_op+0x13/0x60 >>>>>>>>> [ 178.125192][ T651] ? asm_exc_invalid_op+0x16/0x20 >>>>>>>>> [ 178.125753][ T651] ? zswap_load+0x67/0x570 >>>>>>>>> [ 178.126231][ T651] ? lock_acquire+0xbb/0x290 >>>>>>>>> [ 178.126745][ T651] ? folio_add_lru+0x40/0x1c0 >>>>>>>>> [ 178.127261][ T651] ? find_held_lock+0x2b/0x80 >>>>>>>>> [ 178.127776][ T651] swap_readpage+0xc7/0x5c0 >>>>>>>>> [ 178.128273][ T651] do_swap_page+0x86d/0xf50 >>>>>>>>> [ 178.128770][ T651] ? __pte_offset_map+0x3e/0x290 >>>>>>>>> [ 178.129321][ T651] ? __pte_offset_map+0x1c4/0x290 >>>>>>>>> [ 178.129883][ T651] __handle_mm_fault+0x6ad/0xca0 >>>>>>>>> [ 178.130419][ T651] handle_mm_fault+0x18b/0x410 >>>>>>>>> [ 178.130992][ T651] do_user_addr_fault+0x1f1/0x820 >>>>>>>>> [ 178.132076][ T651] exc_page_fault+0x63/0x1a0 >>>>>>>>> [ 178.132599][ T651] asm_exc_page_fault+0x22/0x30 >>>>>>>>> >>>>>>>>> It's possible that swap_readpage() is called with none swapcache folio >>>>>>>>> in do_swap_page() and trigger this warning. So we shouldn't assume >>>>>>>>> zswap_load() always takes swapcache folio. >>>>>>>> >>>>>>>> Did you use a bdev with QUEUE_FLAG_SYNCHRONOUS? Otherwise it sounds >>>>>>>> like a bug to me. >>>>>>> I hit this warning with zram which has QUEUE_FLAG_SYNCHRONOUS set. Thanks. >>>>>> >>>>>> Does it make sense to keep the warning and instead change it to check >>>>>> SWP_SYNCHRONOUS_IO as well? Something like: >>>>>> >>>>>> VM_WARN_ON_ONCE(!folio_test_swapcache(folio) && >>>>>> !swap_type_to_swap_info(type)->flags && SWP_SYNCHRONOUS_IO); >>>>>> >>>>>> Of course this is too ugly, so perhaps we want a helper to check if a >>>>>> swapfile is synchronous. >>>>> My understanding was that the WARN here is zswap_load() doesn't expect >>>>> a folio not in swapcache. With zram, swap_readpage() must accept the >>>>> folio not in swapcache. So this warn should not be there. >>>>> >>>>> But your comment make more sense to me. I will update the patch not >>>>> to remove this WARN. Thanks. >>>> >>>> That can cause another warning. >>>> >>>> Please don't overegineer. >>> >>> How so? >>> >>> Using zswap with zram is a weird combination >> >> Not at all -- it can achieve tiering between different compressors: >> fast but low compression ratio for zswap but the opposite for zram. > > That's definitely an interesting use case, thanks for pointing this out. > > I would prefer creating a helper and using it in both do_swap_fault() > and zswap_load() in the WARN_ON (with data_race()), but I am not > against just removing the WARN_ON either. I will leave it up to you > and Yin :) OK. I will stick to the current patch. Regards Yin, Fengwei > >> >>> if anything I would >>> prefer leaving the warning as-is than removing it to be honest.