From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD9DFC77B73 for ; Mon, 22 May 2023 00:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EEEB900003; Sun, 21 May 2023 20:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 277DD900002; Sun, 21 May 2023 20:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F22A900003; Sun, 21 May 2023 20:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF4B3900002 for ; Sun, 21 May 2023 20:17:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B728F8017E for ; Mon, 22 May 2023 00:17:01 +0000 (UTC) X-FDA: 80815975842.29.B1D9BE9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id E360B40005 for ; Mon, 22 May 2023 00:16:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BXAriNGx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684714620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BI96jBpMNhYORRa/BJuhrUinBsb8UIUmPFVsaftuGrc=; b=bdpd5d1ZvG7ZfAKZCWwwbWTD9/uLRNFELlK7cucvzIlpzm/1DD6bPhK5Ft8wTKwa1hL/BD SpoNSbKnTgJgIx7k2CHKKDr9rKp7884rDAwQqLkr6vkIiuyW3bLMpIUeP5YMWYdykaWv7C s/6jF4tVtiDG/irSgB2TNbTYRFv26uk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BXAriNGx; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684714620; a=rsa-sha256; cv=none; b=5C3d9BkL4JbKHUyiQpOIuowpUqksisgea1EHastUQGAkF2BdlIP9N0RH5YX0c+bpfBSJeD 5pimfN9o8Ee22D/DiLVWUza+Z7i6bc1Pmo4/U5OTMG8XZ3VqOmj3RTTcnCuYeWaOSuweBA PjFUU7xj61wUkIcc7fErqRDQ1DVQUC8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA56060EBD; Mon, 22 May 2023 00:16:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B4DBC433D2; Mon, 22 May 2023 00:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684714618; bh=pynMqTKclwPIt+cST9RZwiWCLVo4HSNzTZHy4TzJIsc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BXAriNGxpa+JuaO2vxwOc9RNJOKNUssZmct2fcZwWAWp3X0h0H6VbL8sSHwWS4Nlz 4FFrrfLZBOK1xbCl0c1T84fG3aCpvtIPLwDvQzrlNxDwJfLv9BoGEpX1hZmWMVH90/ dCZXRY3nh+vkQyvlEnLs3BwteEN+wNZb3bwJHXJ1Wh6zmCmoh60OUOzjMfheU+87DF MtWTLuia8tNf1tD4dLRjHDec5dxMHfNkmfksktoiwmUe4k2hWaELWrz+GqPuNs9Zw5 8kiY+kVYzuuVS7cmiIzONousu4OZfEQyxVy6h9qY1nQPLDSUdpM78qRyPx4NabhlFy D6sDWIqYSxOIw== Message-ID: Date: Mon, 22 May 2023 09:16:54 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 10/13] fs: factor out a direct_write_fallback helper Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-11-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-11-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E360B40005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xgig43bod7udwn547ooyr7asrwiskodr X-HE-Tag: 1684714619-574060 X-HE-Meta: U2FsdGVkX19lWR9csjdlIdJ7gY+YP+1aagW1oe8cwn/kBXWGmJseVuqrhTeHLkyJw2eum2RvgzAR/u1Cx1hEo6k3eVbYw+kkEZXG+smcfYHfHljg8AmHUoX0LRKmAqwpFzYC9EsvjEwiLFE7xkss570FvNNVJrqpza4AL7xJapHYbQ0jDwcNZDdf7HQBFyr/fqoHKcBMm/8Spp2vV90Xsa7kEfsAQKf3WOUpczAezCLvTv53KefKCKw8MB9bRVisGEBpZbrtj8wf0/GzaN/t/QQrE+YOQCDaDtMfqSUzsFxnABUkzQYHImRKY4oOtjhqeeWn3C7fH4en0nTaEhpNkMt6bdBD1XdHnbMqbdICFslpMFKKuyKitybfmLSHyeo16ztI87WZm7LlK21OTxnJlN4mpsUB5XjiBVP3O/ok6G6kM/rzoFeZb9ANtLhvVRjYI+ua88eHNKf1TKkGWSeiLV5bGtYuCnjGuBmZlITRWt+NZa7rXR85WWjQ6HrqaJhCfkwmnYY/TxYNmiZSHmpeTTIeqC+Msv1T9Q6USPW6OFa2uITepFrleCvYx8CUrlBCFU7NHUkVMKee8VTkIqiX6W6JE24JC2YApzDq2hSZMUUWCpxcTLbuwBGPYgD+fyDSRygihQnZdhLbgrjyAzfnQbQGvvb+KX0IUxqHL5EnBnwgjR7QRbng7eNTC38mRclFNENoutEKiQBJCqjv+bg8Ah5JAVw6p7gXb+DM+9T25sWAZYUKsEszBFDot1DE6/il4rrUMk8LO9sbDs7KbFxqkgHAcG57C85Jyb5ci7LBPdlIfjtCRwgCRbK9netnuwjQgAxl/XqxbvwWD+rHgMI5ZWw1fCywqMq8xmDQJktV6AlBxxfAuHX+YO02oboHOWC8DaUppdV8swH2AxufJ8rmZhVJzKiDIgbZmBResUH7Nzi6hO8B6RvXwGnkp1bZf+55tGyeeShdNOPv1J5PZza 9w38ATa/ nPTpxFZiMmX1uvMAlW+1ZR5XiTp+pbFCEWw8Qhz627Haa97vJM/OCktk530Zk0c4Bp6bEWtxd95SZIEkWn6JDk6TGUtqVZnguY6A9Ntdb71hwTyxEeshJiH/EMXgp9jYzXN6zwhFKVCqx4mkZIxJ94+3M6g7B5MhQDQ5VWza/wB6iVmrPxpxrnO02UyyCDIDWHitv0bpG3+PGMHWnf5DKBO1VV+sEsJV2H2xwHwDiMFXCYDv83oeKW9u+tevI423CsvxpOPeQMhuPwCAhmySoTDdCPN3/mO9bhnERUVT4VfDla2BWunY1HR2MA075PI1PCVO4xSoj/m+Ly79H3OSriW29iGecWYGtt2QB6YGZ82t04Bl1IaSD/WUfbZVynZMl/oU/IdBPF90t1FPPvDqo6HAjIuMrG8fknph67WNWnOjwc5p4mvODcs0nWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 18:35, Christoph Hellwig wrote: > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig Looks OK. One comment below. Reviewed-by: Damien Le Moal > + /* > + * We need to ensure that the page cache pages are written to disk and > + * invalidated to preserve the expected O_DIRECT semantics. > + */ > + end = pos + buffered_written - 1; > + err = filemap_write_and_wait_range(mapping, pos, end); > + if (err < 0) { > + /* > + * We don't know how much we wrote, so just return the number of > + * bytes which were direct-written > + */ > + return err; > + } > + invalidate_mapping_pages(mapping, pos >> PAGE_SHIFT, end >> PAGE_SHIFT); > + return direct_written + buffered_written; Why not adding here something like: if (buffered_written != iov_iter_count(from)) return -EIO; return direct_written + buffered_written; to have the same semantic as plain DIO ? -- Damien Le Moal Western Digital Research