From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E5DCC4167B for ; Tue, 5 Dec 2023 08:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 018146B0072; Tue, 5 Dec 2023 03:11:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0A136B0074; Tue, 5 Dec 2023 03:11:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8A56B0075; Tue, 5 Dec 2023 03:11:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D17706B0072 for ; Tue, 5 Dec 2023 03:11:15 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 97A4214020B for ; Tue, 5 Dec 2023 08:11:15 +0000 (UTC) X-FDA: 81532044510.29.5D78333 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf25.hostedemail.com (Postfix) with ESMTP id 82C32A001C for ; Tue, 5 Dec 2023 08:11:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JtHkQHye; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701763873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c7tcXxVB37+e74YIJ/SoIf8Zq3/8qsP6opp7sTACB/E=; b=LgQci3WaVVoO2zrSpTp+w8z/95QYLYvpXm7K8ISt8Du3EmVkLYikCkeGjGYvLwxS2KhA5U OvcjseE5yYmfGiY41RNRMxGGaZnKOEaLOAriE3xaAKhFFb6npTEGgudAxYMmUA/xVb9+Lp muq3wQ35wHzC8bo530I1ggWcdNwbedY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JtHkQHye; spf=pass (imf25.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701763873; a=rsa-sha256; cv=none; b=olfW/1wLL5QLERJLBDw2kPWxqCa3Ee9YItY8/GyFWrNfEgy76Hd/QUN0XwPwstzLgWEO6j T6Dzy1f8QBSDtRz37ue6f+Awnvp9/1tz9JY5fuh4+aAJpgD3oJwUo+aIOeyb0NBDgkGCEh KJcEsNsRGQVNRcLSkV6R9azT24tHv8Q= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701763870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c7tcXxVB37+e74YIJ/SoIf8Zq3/8qsP6opp7sTACB/E=; b=JtHkQHyeKWUXLqCtj1D8woxmlUkmgsj3Um+0N3QTI3d/nMPguMeFOjwjbSAInQkyo3dw0D 7ZF4YwUoaQ7Wm4u+Abva2IoSi7um8PSW/xk+rytL9QW97nhEQrts6YnggQOIkjGr9NtkGO AkrlZet2qEakUYb2N7eODaod68dWZW8= Date: Tue, 5 Dec 2023 16:11:03 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/4] mm/slub: fix bulk alloc and free stats Content-Language: en-US To: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim Cc: Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Alexander Potapenko , Marco Elver , Dmitry Vyukov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com References: <20231204-slub-cleanup-hooks-v1-0-88b65f7cd9d5@suse.cz> <20231204-slub-cleanup-hooks-v1-1-88b65f7cd9d5@suse.cz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20231204-slub-cleanup-hooks-v1-1-88b65f7cd9d5@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 82C32A001C X-Rspam-User: X-Stat-Signature: 44eiag7h8g1nsaz8ny4as5mxyt8xg6gh X-Rspamd-Server: rspam01 X-HE-Tag: 1701763872-960687 X-HE-Meta: U2FsdGVkX1+AJlg52Q3EblxPdatTmvg2bzi9Tm6X96kU8gRGKmMLyOWd/O61r9+ka9QlLfqSRLDAkOGn7PacB+McpvI7LOwS6fTvesqkMLFt/jrzqyesyOo9wxVh+gtjs2M7qY9S4xxJY8190O89kqFUIJKYbuHo8TCpVvh/S+Fag5MG9YZDKWbflmfDI40Xnlu3F5W5w6p4E2mex5SqgVigACtpcbKAYKJe7N10sTgvoZbdoQGwqWFTg9W6RbVYDknqLRCpAfs7bBsOe9+2Oy5DK6Pa8h2I4FshYRTZ66/OQBro8uTpGp1UTUR5vZKOopHPF7R7yC36z9pg4a6+X7ZdPVpJG1o3LZ//B+3GrOm5JUybTuffl5pR9tRglFm48QElfqAlTsxBJqGWsrpnUdBgZqK/ikcOiEKierk2GAD/N2rbs5WzwcK9pSQ0+oZZ01rNpkGgHBFiR05Iy127IibZ91yUz6OUrE5d5UxgqLgsww6nzpeq6KFkRKNMMz4TRfo7O2U8fAKAyypWOXXL4+TdIZTRzc4rSl8AMDToa6QU5s8wqqqiZJL+6arMJlBUWp3Ht5geCWRXNqS/uFrjS1mEwQ9K4XkacaAxMcVM4H8JBHixZ08NA0Hvm/QEY5lRZXXoQg/JLqrkBQwevPaOecaYy0qqjqA3QafJKiKCQgkGamR0anRDkV6MO2Hwzb/A06jHq2KYCrGnviQgG9r1k/XHlOAKTlGa3j3/KLgE/3rHMDWRv7N7x7G6eApZBvqX7ezNQXtRXiR+Ls+aD53z9TfmZvLqRXJl2hBD1mXGxm9IRBOsw7C/FEozPqKJuy3FOZ3VDGfqiazS36Qs7cx6DQkwE9ovIExBWFYBcl8Iwc9wSDkGSdxyW5mqVOsv7H1vH1ezfHwrrH4TzEKBtWNKUCbV2dtdr/7SsOHAISq0kYebnvg5k26pIFOzbqxF4lU2i6JtMSRs61HzisCp3KR TKpGIXW9 KWTb7Yk6SLERDpmetM16c4fuq2Y3+2k8ZJWq31X7c/g1HpxDQgOkjOedvs58Z3RpG825NdiF1XGGjv6Cdq8P17S2zEMsRVCX70ykNptmlqJjazz3s7AP9vm1rU/Qwb3pL9HlAgLTqArDUXBnT5TtWS2ypWqqfcA3jdUMgmBcwFO/jdnV0y0fNY/Vf9A7hyAPAL78XizW/jCwEtzx9f26t7oba+2pVjn16oArd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/5 03:34, Vlastimil Babka wrote: > The SLUB sysfs stats enabled CONFIG_SLUB_STATS have two deficiencies > identified wrt bulk alloc/free operations: > > - Bulk allocations from cpu freelist are not counted. Add the > ALLOC_FASTPATH counter there. > > - Bulk fastpath freeing will count a list of multiple objects with a > single FREE_FASTPATH inc. Add a stat_add() variant to count them all. > > Signed-off-by: Vlastimil Babka Looks good to me! Reviewed-by: Chengming Zhou > --- > mm/slub.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 3f8b95757106..d7b0ca6012e0 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -396,6 +396,14 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si) > #endif > } > > +static inline > +void stat_add(const struct kmem_cache *s, enum stat_item si, int v) > +{ > +#ifdef CONFIG_SLUB_STATS > + raw_cpu_add(s->cpu_slab->stat[si], v); > +#endif > +} > + > /* > * The slab lists for all objects. > */ > @@ -4268,7 +4276,7 @@ static __always_inline void do_slab_free(struct kmem_cache *s, > > local_unlock(&s->cpu_slab->lock); > } > - stat(s, FREE_FASTPATH); > + stat_add(s, FREE_FASTPATH, cnt); > } > #else /* CONFIG_SLUB_TINY */ > static void do_slab_free(struct kmem_cache *s, > @@ -4545,6 +4553,7 @@ static inline int __kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, > c->freelist = get_freepointer(s, object); > p[i] = object; > maybe_wipe_obj_freeptr(s, p[i]); > + stat(s, ALLOC_FASTPATH); > } > c->tid = next_tid(c->tid); > local_unlock_irqrestore(&s->cpu_slab->lock, irqflags); >