From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C40C2D0CD for ; Mon, 19 May 2025 15:42:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 515EC6B00C4; Mon, 19 May 2025 11:42:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49CCB6B00D2; Mon, 19 May 2025 11:42:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 316AA6B00D3; Mon, 19 May 2025 11:42:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0737D6B00C4 for ; Mon, 19 May 2025 11:42:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 790F61A0924 for ; Mon, 19 May 2025 15:42:43 +0000 (UTC) X-FDA: 83460075006.09.D33456D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf21.hostedemail.com (Postfix) with ESMTP id 2D9DB1C000A for ; Mon, 19 May 2025 15:42:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=E3Y4mYxM; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747669361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=50teDOTcQnJ5dM5fV6tb3Q+afVC3CE67gCQ4k0gtot4=; b=dG8tcNOq6c2ad6Hiz4mid9SCQDWVOcLV/RxpKCab99m+rassSCccxHVSVx1Q85bWqnELTY NTw2CcD6hRtMN59ciYldJ+tBmtSg3NXR8yx5K7dfSVmHrC+/4g9yoUoMUyPkcxXOT3sezp YOhu+CId43GcCxBX23PwEfYmAhV6pVg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=E3Y4mYxM; spf=pass (imf21.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747669361; a=rsa-sha256; cv=none; b=Mal4j9JoPe7qEmlrF71fvzQBo3tjuGYIuTmJ6PgXb92ZyWRdODn80A8RBndABXaXRzeNde 0gCFgF72oMblCbOqPb57XS2GMEQxufmP9QMR4vIc0aFYwbIwDTH6oYTcGPMswjM2DzBIqs AJncNbH+6OrO4BgyakZPTXy18t/U5bU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747669360; x=1779205360; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QdRTzsJUcsheUV56Q97XqQVMswM+EgjfCIC/YHAJjjs=; b=E3Y4mYxM670nisVBBrSKrtQsrmVZ2OrQwIRcjNxetbhPjKllGS4uGB4s A/cuuuEA1vjpa6IUf70hThbkSkU/Au7FSDp4wJ0LMYcBNmJLUXyTc95o4 blYrJeqIFMn1/O4N0K1c8gH/sYukWqfinNHPWR4Z3bG/hpa0WrScpAPG0 Hff34zfRtHDgvJJt/tPKKLthVzYJkCPTLW09K8mDP10D8XXk3k+JgiyBc KE2rNIkp69y8CTH9lCiCU2LFZTyOyxLU2V4ymk6y2330J7uiUJFVzyLkm S1SgELiEjHBFdRIdDULOL7hb9Kta+8JIGmO+u4ajsyvOWdtY3Q8SOfgde Q==; X-CSE-ConnectionGUID: qdbFejPJTqGFymZ+a7srng== X-CSE-MsgGUID: 2xeObBj+So2tA442Q2mCIw== X-IronPort-AV: E=McAfee;i="6700,10204,11438"; a="49479041" X-IronPort-AV: E=Sophos;i="6.15,301,1739865600"; d="scan'208";a="49479041" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2025 08:42:38 -0700 X-CSE-ConnectionGUID: 7q7SkIVwRXe1fkPa+ChUgA== X-CSE-MsgGUID: e1WEPBTfSBm16v9mMcUAEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,301,1739865600"; d="scan'208";a="144403683" Received: from puneetse-mobl.amr.corp.intel.com (HELO [10.125.109.70]) ([10.125.109.70]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2025 08:42:38 -0700 Message-ID: Date: Mon, 19 May 2025 08:42:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [BUG] RCU Detected Stall in sys_process_vm_writev To: David Hildenbrand , Guoyu Yin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com References: <14bbdbd4-fa86-4317-a051-8e1defc7192e@redhat.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <14bbdbd4-fa86-4317-a051-8e1defc7192e@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 2D9DB1C000A X-Rspamd-Server: rspam09 X-Stat-Signature: 9tinhnouq5b13ujxnff54x5cz6xx1n78 X-HE-Tag: 1747669359-116955 X-HE-Meta: U2FsdGVkX19+romlBmwPtDfo8jAXBxqzL69HLp+r2Alxqp57hIlEjfk/2EoXFw4s6XKV/uNR7LK0ttEmzTBQjmOamQSwy9TnGTGX46I9kgtxVB7+3L5bz9pNjsKUa7DieMdeoO8cP9e3J7JUFxhhhuwU85CZY9c0I6SW/zVnn2kInanQiFYXE40IDZlqiZLM9XfF1WcctThbikBjNxp7fi56PY/JJXVRIzPS60QsagDJU8kwpCiloJSN+qnd2jjkQA9txs3PcvEonCu23VoKo8v53HomT1Nc2UJMk58kDwdHCvewm2QCcv6T8L9PhWLFGaIArMF6eue6Mlcp0ZVjcpPuta5snesXY65hTD/qMj707QyN2cQj5FEkKdP8YRnj3iNTfK/3KzvUJBUZGK456JaGWAnw6861z/zma2ascnVVS7w0URkgkiHD12urGvDYhxtUcZ6s6O2QAHm+STdXIQQj0/Bl33jQ0nCCBH31lNlLkdRrzajsji5gfdphYrfyXZzSryPb4MY0fk7c2Pgx79EgbtqoCY1EIRfws4Vh3KIwo9DwC5f6OinLlv6dsSr5/qfD04XS6W4ATm6w9HzYhsdKDkE1llhEv4jUd3EoM9m63JQo1tHB53SRSXhcDoyHPxQqaWsNPoOS94tRjwDVl/NFTggxLFuhZxaV+5koyVR7fN4w2usBdz2sOgb6pMZYs4jLgUfezihZN6tlTr7HfMUT73K7Lyux2pvadOFA/NiE1p4oaUYTu7NNtP0L6sx1Jt/qZMLxbZIoX0fFEQLDcpVnEkYiWJDEHN5QdoD4W1oQnOgbuJWtf+xT5EuJmKg/spb78hGmRjTwvq9GjJdPkJ3iOy/WvMsBQtAiYs3o1Lk2S2lOmoAUOuOg2V0Bf/SjJf0hs/vRGfrSOlPuwUgiPp5AYJLa0nZW3dwFlyxOjtcd3WL8pvMaRVMESZdXS+b/YwXvMihfHB1fPUPGOmo enTcWDbd Kb46MRALkGUd7CsF+ILQAmxdO7t8wbFeyzUeQI92NzbsGVwjs3cYdgXLmZ0usqE5VtQHbFw02V8Y5A0SAOpA8SenhgxobM8POAqG9+0Ash1RBdipM1xwLhj0ZKzPKMiUHQjZJr3huvuhwRHi6HJVOe6tUunJTDbGf0vZATkAC3SVp2Dsmod737rbL7zvyumQJLojmyucztw2eS6lDVqgBAR1iM7zKwGtfTCDUWxixnV8LExpqe9Pnggu99s8oyjWtpYZsB34rDcvayQ/RRz8vxj4Wpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/19/25 00:36, David Hildenbrand wrote: >>  From the dmesg log, CPU 3 is stuck trying to acquire a spinlock in the >> pgd_free function (arch/x86/mm/pgtable.c:490), leading to the RCU >> stall. This is likely caused by spinlock contention triggered by the >> page pinning and unpinning logic in sys_process_vm_writev under high >> load or abnormal conditions. > > pgd_free() calls pgd_dtor() where we should be taking the pgd_lock. > Apart from that, only the buddy allocator might be taking locks when > freeing the page. Yeah, it's definitely the pgd_lock. I just did a quick audit of all the sites that use it and I didn't see any places where we could have left it locked. The most likely means it's _another_ lock underneath (like pgt_lock) that's stuck. The other possibility is that the thread holding pgd_lock got in trouble like with a BUG_ON(). Guoyu Yin: Can you try to reproduce this with lockdep enabled, please? It would also be useful to see the state of all the other threads in the system. Are any of them stuck in a path that holds pgd_lock? > As I am sure you wouldn't bother us with AI generated slop, what > makes you think that the pgd_lock is relevant in the context of > GUP? Yeah, I think someone (or some bad AI bot) is looking at the use of 'pgd_lock' in xen_mm_pin/unpin_all() and somehow connecting that to pin_user_pages().