From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E4DC4345F for ; Thu, 18 Apr 2024 11:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DC896B00AB; Thu, 18 Apr 2024 07:49:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0832E6B00AD; Thu, 18 Apr 2024 07:49:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E65766B00AE; Thu, 18 Apr 2024 07:49:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C869D6B00AB for ; Thu, 18 Apr 2024 07:49:54 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 70D9C1A11C0 for ; Thu, 18 Apr 2024 11:49:54 +0000 (UTC) X-FDA: 82022483508.26.05A1F84 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 305324000B for ; Thu, 18 Apr 2024 11:49:52 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UYb5vAg3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713440992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V8/aQld94UzLvlQOPHbYtcJg5juetjrvjETslid99FE=; b=LgCgz87Lm9EQcjnbQAOJdiXtarr4dP4tO3mJG1UT81iTHg3yoWv0jNlS6KjghQAn8Wjj+P I67EwLTzuVkBRRplltdCzsGJO5IPZnvmBAKYxjXW4gMDK256aLz2hf7fkcy39Ox9KBdBsZ Vh5qA7KEGE7Ysz9PuWjn6YDLicLNZ8A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UYb5vAg3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713440992; a=rsa-sha256; cv=none; b=UsMbow3e7mr8x5MEGyA4IoIzH4vanpLe+Ta4nJ55aRfHBVDKk2ET2DDLZ33x1jyimvqbeC 38lyl/23k0reVWhXUIJ7HgdJwWsiwWTt+9SoaGHfrBtCdj/wM0Yf+0lc4AlfYdscll/8lx xIP1rNTQCtErfbtkPQWHdgCqGHSFdyQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713440991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=V8/aQld94UzLvlQOPHbYtcJg5juetjrvjETslid99FE=; b=UYb5vAg3aqvwyywvNlDsWnrCptnqXaqra/OeoP2o71rbstRR7qNpoBpmlIQA2vSBmuBTCX AkCMII1n4Q6G+7diX6oqB/miTsdNSR5PJJGIpEWPlvSNzuAG1LMum/bHUV85fLMVesYRvs nXxSTyiB6tjAe805Fa65kNnDHD56xAs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-jAHduHm_Oe-GrCeeWR0sSw-1; Thu, 18 Apr 2024 07:49:49 -0400 X-MC-Unique: jAHduHm_Oe-GrCeeWR0sSw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41634d6c008so3625165e9.1 for ; Thu, 18 Apr 2024 04:49:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713440988; x=1714045788; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V8/aQld94UzLvlQOPHbYtcJg5juetjrvjETslid99FE=; b=nuCwYq2TKkQnWUaDA/BzcIazpw84YzGMA2nBTsZhByYfILa4c+epGpasLZ5UGBTpVk 9J/0jKBaWvWkBNHkuuLgPookDMcjA5EctCSbnpZNE0yrrxnL5apTOFxlheV5EAb9X8k/ avnmMIzaiHQy7tMN1kSuXV8k0Jeocd5X12iIAG77L+hu5Qrdw8YpFhAICrlmyWF78l7Y xFZPjIZYctM7vgE4yp7VbCorFpEkQe5jnez4Go77oGev7GqCJkorEShD1vjQ9OO8fkfn imWxr0iqKhMuWU6HLBV8q88lDB4rghvNtTL/G8oksLWtIMRyU83Y65pvKYipBj+zmoLO uTIw== X-Forwarded-Encrypted: i=1; AJvYcCU44b1FA6EaDzwoX4ds8xbAalZPg3wisEcRY8eK/OtXq0muFFQ8yy3nThLwcjCc7spkAwZkAJ0eYx/+e7fBbf3iAgE= X-Gm-Message-State: AOJu0YweVWZxCnZoKbEJupi/CFg2JruFTudefdNuyONF24eqwv8ZOLPa kiMloTJNl8kLjI8vtyKkGd9c4cCtrU4U4IRTg8RFv/7j9fjCLpGrgiHlDZ/WtSC0gksmE9iCAbL QymbLA7VCmq3JA9NOl3hFmm+y6uWI1tZE2LiAfS9Vr5pIBssC X-Received: by 2002:a05:600c:1c91:b0:416:34c0:de9 with SMTP id k17-20020a05600c1c9100b0041634c00de9mr2444307wms.29.1713440988671; Thu, 18 Apr 2024 04:49:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqgqQ3za1EXSURtOq9OHiqKrZ6jbAQ3F9YMHY3AB9QOCUv9Rem8Ber/zitOUCR7OWCSrpNwg== X-Received: by 2002:a05:600c:1c91:b0:416:34c0:de9 with SMTP id k17-20020a05600c1c9100b0041634c00de9mr2444293wms.29.1713440988260; Thu, 18 Apr 2024 04:49:48 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id m16-20020a05600c3b1000b0041496734318sm6310440wms.24.2024.04.18.04.49.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 04:49:47 -0700 (PDT) Message-ID: Date: Thu, 18 Apr 2024 13:49:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] virtio_balloon: introduce memory allocation stall counter To: zhenwei pi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org References: <20240418062602.1291391-1-pizhenwei@bytedance.com> <20240418062602.1291391-3-pizhenwei@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240418062602.1291391-3-pizhenwei@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 305324000B X-Stat-Signature: imiqnhmy73m33etx9mqit7q84jq95qnr X-HE-Tag: 1713440992-59381 X-HE-Meta: U2FsdGVkX1/fZBp5CbSpO6BhHyLEmpxaYwPc4YEZtzVeSIQuMDkQVVArpYE0YQn9m52Tw0wJi9cCtuBsZaW2ahLAkig2YplYn5wR2FEr/oMwCHvh+3OdU+5285BbET6EhNR00TQDSzpNCfVAp3ycb/t1ptRqPT1XzRsDtsNygx7G1dl3XkWodEPm4rtqe8uWbvi+id0fdjUiuHsrIsokP0oRD/c86i56/QCVlVJ3PSvPkKlOlF73OdfRxiqd+Eu33RwXspmdiRUV8dL+UBPM7Cbw5SOkJhzKYoH/3eAhgHLJOxL22VsVUAbQ+bmpy7zKfFQ6nQfVadKRkCzW+jbKL3iUDJhipxdsRaC2il/i9g0OV+/sEUscCmWK8HvSYrAgIMIy0rhcrRNtzJaSIF+aRIbbbYeoS0r7dLJxhCU//V6vqzo8CxYOeY/FU5mA0IzHcmrZRmCJRfxIedt8TX7cn0Ll1XtKxbrG6l2BxEZRBETRyq/aEHn9AYP2udDabMzJB5zLDZVnRsusOryB5afCWmmHLhcFdUXZ0nogpfbdzdNDiIoiqvM/Pxk3/j2n6focKqV3ylyYaC6Fye3ktp68Rq0XGj9lb1N7djoh6hClBAWiRG+lsWkYF2qmtOwhkerwvbC6cfqr4aiwnsoCwE6t7MkbSXQmbuCLZcpTW8FgXZzw0MeDwpziTs9lHVG5v0CstYSLmDkI9b0A+UZf/TGh0sE7UikEa8Kv7EjdWDwF/ckYG6OdEiXhPC/S0UjwMgUGSpa/uxI4RWivHD0iu32v5t5f8gBZJqiG/qcayriQdi7pCgP+YcbxiJ7bnkolX/9mYgP/MjV+gUWQ4jIZSsYIrTuDDmd6E48WLN1M/pPC8BHiuFoCrrhdJNS3zStZJBslKdE5egKj9UXOIdw4olPrXK0y4xGfTTjFtVNAa173vPDxqPmvH+EnHVyJHYB6lKwW2qnciGWCE5ZLNuGAkFG 89toEtCc JUkaLB8Te+/Hr0kWMU3gKyNL/AY82j5NcrYjkaNo3mwVvsGcTIS4rmFAJZLhNCIDDeOlScCYHb+QV9iogVimAq1/URkgf6JC0faJTOWChVXV84F1Ucj9/0EVkUu9D4dgyELplXvzES6Vh7hmHK7TDkhvJhGtGu75gcCgDRLp0gPx54IDckH1nLjbAuZPKDmZHCQamfY6U1XJyl/aLp/BcYVKn5MY485lMdq+rmlYLdiygnEV2tmfPY41HTQqfsvhdQjUIUeMYiK7U8i09vSwWGGY2Bo4DUf/reHdExQl1nY5f162OxvkmuqV8SUC7VqNFPqF2IDBNNNjjsfFLVeMvYX4nuMmsqOfyf0kcsc3V2ZiR3b8QPztiloR6k6KPL1DRJDNh4jPpgfcnwnZOuqk1sZdumROUQBD7AjU8qPuAe7gxareLiu5FbAOxKNz5BMkCxhB61Ww/XjoErVMH+7ZPwf/CzTG6rXyW0CBfBHXCBkgfLipFXnQERgLP84WjpBbj8C/0SOhkghou8WVZsI8tNhi4MzppI9HcJJSIZ9lXmZyudOKAaMX7i/9mAgUGwnJd0w+YPRfOXMMnnwpDGAWCJrpaPMMOFvG+XY6oNcbUqav9GUo9aLacGF8aXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.24 08:26, zhenwei pi wrote: > Memory allocation stall counter represents the performance/latency of > memory allocation, expose this counter to the host side by virtio > balloon device via out-of-bound way. > > Signed-off-by: zhenwei pi > --- > drivers/virtio/virtio_balloon.c | 20 +++++++++++++++++++- > include/uapi/linux/virtio_balloon.h | 6 ++++-- > 2 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index fd19934a847f..e88e6573afa5 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -321,7 +321,7 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > unsigned long events[NR_VM_EVENT_ITEMS]; > struct sysinfo i; > unsigned int idx = 0; > - long available; > + long available, stall = 0; > unsigned long caches; > > all_vm_events(events); > @@ -338,6 +338,24 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) > update_stat(vb, idx++, VIRTIO_BALLOON_S_MAJFLT, events[PGMAJFAULT]); > update_stat(vb, idx++, VIRTIO_BALLOON_S_MINFLT, events[PGFAULT]); > update_stat(vb, idx++, VIRTIO_BALLOON_S_OOM_KILL, events[OOM_KILL]); > + > + /* sum all the stall events */ > +#ifdef CONFIG_ZONE_DMA > + stall += events[ALLOCSTALL_DMA]; > +#endif > +#ifdef CONFIG_ZONE_DMA32 > + stall += events[ALLOCSTALL_DMA32]; > +#endif > +#ifdef CONFIG_HIGHMEM > + stall += events[ALLOCSTALL_HIGH]; > +#endif > +#ifdef CONFIG_ZONE_DEVICE > + stall += events[ALLOCSTALL_DEVICE]; > +#endif Naive me would think that ALLOCSTALL_DEVICE is always 0. :) Likely we should just do: for (zid = 0; zid < MAX_NR_ZONES; zid++) stall += events[ALLOCSTALL_NORMAL - ZONE_NORMAL + zid]; (see isolate_lru_folios() -> __count_zid_vm_events(), where we realy on the same ordering) Apart form that, LGTM. -- Cheers, David / dhildenb